20832 Commits

Author SHA1 Message Date
Mike McQuaid
35e487064e
Merge pull request #7537 from MikeMcQuaid/cli_parser_formulae
Replace ARGV#flags_only with Homebrew.args.flags_only
2020-05-11 08:47:12 +01:00
Mike McQuaid
1c656fb584
Merge pull request #7538 from MikeMcQuaid/bottle_arch
Replace ARGV#bottle_arch with Homebrew.args.bottle_arch
2020-05-11 08:46:57 +01:00
Mike McQuaid
380e2daf09
Merge pull request #7539 from MikeMcQuaid/argv_include
Cleanup ARGV.include? usage
2020-05-11 08:46:46 +01:00
Mike McQuaid
1a7cda00d7
Merge pull request #7179 from nandahkrishna/add-livecheck-dsl
Livecheck Formula DSL
2020-05-11 08:46:27 +01:00
Mike McQuaid
a462177142
Merge pull request #7542 from Homebrew/dependabot/bundler/Library/Homebrew/rspec-expectations-3.9.2
build(deps): bump rspec-expectations from 3.9.1 to 3.9.2 in /Library/Homebrew
2020-05-11 08:45:53 +01:00
Mike McQuaid
9d8fb7a0f6
Merge pull request #7505 from sjackman/docker-hub
tests.yml: Deploy the Docker image to Docker Hub
2020-05-11 08:45:42 +01:00
dependabot-preview[bot]
21a3e306ed
build(deps): bump rspec-expectations in /Library/Homebrew
Bumps [rspec-expectations](https://github.com/rspec/rspec-expectations) from 3.9.1 to 3.9.2.
- [Release notes](https://github.com/rspec/rspec-expectations/releases)
- [Changelog](https://github.com/rspec/rspec-expectations/blob/master/Changelog.md)
- [Commits](https://github.com/rspec/rspec-expectations/compare/v3.9.1...v3.9.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-05-11 05:57:30 +00:00
nandahkrishna
77e74e7e69
Adding livecheck Formula DSL 2020-05-11 09:41:13 +05:30
Bo Anderson
c0f5a52d85
Merge pull request #7532 from Bo98/bintray-url-encode
bintray: url encode where needed
2.2.16
2020-05-10 21:53:37 +01:00
Mike McQuaid
952f8eaac5
Merge pull request #7541 from miketheman/miketheman/fix-uninstall-paths
cmd/uninstall: fix Array comparison
2020-05-10 19:50:22 +01:00
Mike McQuaid
a3474e8361
uninstall: tweak paths array logic. 2020-05-10 19:22:54 +01:00
Mike Fiedler
e4823ea6fe
cmd/uninstall: fix Array comparison
In #7526 a comparison for `paths` was introduced, but if `paths` is ever
`nil`, this triggers an error.

Coercing the variable to an Array should alleviate this problem, as
`nil.to_a` produces an empty and comparable Array.

Fixes #7540

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
2020-05-10 11:28:42 -04:00
Mike McQuaid
270fd422dc
Merge pull request #7534 from MikeMcQuaid/outdated-version
Formula#outdated_kegs: check versions aren't identical.
2020-05-10 15:30:45 +01:00
Mike McQuaid
5f721c6986
Cleanup ARGV.include? usage
Remove usage where `Homebrew.args` could be used instead or, due to the
`Homebrew.args` parsing, there was dead code that was never executed
(and no-one complained about not working).
2020-05-10 15:28:31 +01:00
Mike McQuaid
07b19cba09
Replace ARGV#bottle_arch with Homebrew.args.bottle_arch
Part of https://github.com/Homebrew/brew/issues/5730
2020-05-10 15:15:41 +01:00
Mike McQuaid
fa0d454817
Replace ARGV#flags_only with Homebrew.args.flags_only
Take two on https://github.com/Homebrew/brew/pull/7490
2020-05-10 15:12:25 +01:00
Mike McQuaid
af278b15de
cli/parser: add formulae method.
This removes the coupling on args.formulae before it has been parsed.
2020-05-10 15:10:36 +01:00
Mike McQuaid
4cdc2a5c81
docs/How-to-Create-and-Maintain-a-Tap: official vendor taps.
Explain our policies around "Official Vendor Taps" and clarify the
formulae naming section.

Inspired by discussion in
https://discourse.brew.sh/t/maintenance-of-formulas-by-vendor/7649/.
2020-05-10 14:15:27 +01:00
Mike McQuaid
5685f379ef
Formula#outdated_kegs: check versions aren't identical.
Even if the `version_scheme` does not match: we should never try to
`upgrade` (or show `outdated`) for two identical `pkg_version`s.

If this is ever needed: a `revision` bump should be done instead.

Fixes #7507
2020-05-10 13:42:55 +01:00
Mike McQuaid
7bd454746e
Merge pull request #7526 from MikeMcQuaid/uninstall-list-files
cmd/uninstall: note etc files that stay around.
2020-05-10 13:36:10 +01:00
Bo Anderson
65d7036c19 bintray: url encode where needed 2020-05-10 01:48:29 +01:00
Issy Long
b926eeb0d6
Merge pull request #7531 from Takashiidobe/patch-1
grammar fix for How-To-Create-and-Maintain-a-Tap
2020-05-09 16:23:51 +01:00
Takashi Idobe
9cf43a181c
grammar fix for How-To-Create-and-Maintain-a-Tap
changing `with you github username` to `with your github username`.
2020-05-09 09:55:09 -05:00
FX Coudert
7750ae1983
Merge pull request #7530 from Bo98/gcc-10-version
development_tools: fix GCC 10 version detection
2020-05-09 16:41:21 +02:00
Bo Anderson
9f4dbd4008 development_tools: fix GCC 10 version detection 2020-05-09 14:31:34 +01:00
FX Coudert
9023667f8c
Merge pull request #7528 from Bo98/gcc-10-formula
compilers: support GCC 10 as a formula
2020-05-09 12:26:56 +02:00
Bo Anderson
4bca7f0cba compilers: support GCC 10 as a formula 2020-05-09 11:06:02 +01:00
Dawid Dziurla
bc4251d1ed
Merge pull request #7512 from dawidd6/review-approved-ci
pr-automerge: match only approved PRs by default
2020-05-09 10:56:52 +02:00
Mike McQuaid
11f50cf0ec
Merge pull request #7527 from Homebrew/dependabot/bundler/docs/typhoeus-1.4.0
build(deps): bump typhoeus from 1.3.1 to 1.4.0 in /docs
2020-05-08 13:41:38 +01:00
dependabot-preview[bot]
055f7fcc23
build(deps): bump typhoeus from 1.3.1 to 1.4.0 in /docs
Bumps [typhoeus](https://github.com/typhoeus/typhoeus) from 1.3.1 to 1.4.0.
- [Release notes](https://github.com/typhoeus/typhoeus/releases)
- [Changelog](https://github.com/typhoeus/typhoeus/blob/master/CHANGELOG.md)
- [Commits](https://github.com/typhoeus/typhoeus/compare/v1.3.1...v1.4.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-05-08 12:20:27 +00:00
Mike McQuaid
04ae589d5c
cmd/uninstall: note etc files that stay around.
We don't remove `etc` files on uninstall. Now we have `pkgetc`, though,
we have a pretty decent guess at what files in `etc` may belong to a
given package and can warn about them being left around on uninstall.

Thoughts: should we do the same thing for `var`? I don't see it being
used nearly as consistently.
2020-05-08 10:37:51 +01:00
Mike McQuaid
a635db0f26
Merge pull request #7525 from MikeMcQuaid/deprecated_cask_taps
os/mac/diagnostic: check for deprecated cask taps.
2020-05-08 09:53:52 +01:00
Mike McQuaid
2b224a66a5
os/mac/diagnostic: check for deprecated cask taps.
We keep seeing users popping up with these (#7449) so advise an untap.
2020-05-08 09:18:55 +01:00
Mike McQuaid
29abc81f51
Merge pull request #7519 from MikeMcQuaid/cleanup-tweaks
cleanup: tweak missing clean file behaviour.
2020-05-07 11:24:11 +01:00
Mike McQuaid
38bd4e6d10
Merge pull request #7521 from MikeMcQuaid/fix-options
cli: fix options handling.
2020-05-07 11:14:27 +01:00
Mike McQuaid
929a4678c6
Merge pull request #7518 from MikeMcQuaid/shellenv_bash_profile
shellenv: recommend .bash_profile
2020-05-07 11:03:22 +01:00
Mike McQuaid
80ce0c7adc
Merge pull request #7513 from Homebrew/dependabot/bundler/Library/Homebrew/activesupport-6.0.3
build(deps): bump activesupport from 6.0.2.2 to 6.0.3 in /Library/Homebrew
2020-05-07 11:01:22 +01:00
Mike McQuaid
4da5c09c25
cleanup: tweak missing clean file behaviour.
Instead of cleaning every time if the file is missing: don't clean this
time, touch the file and clean when it's next needed.

Now that this feature has been around for longer this makes more sense
for existing installations and stops the first `brew install` run on a
new/test installation without this file always running a `brew cleanup`.

Also, fix up the use of a compat/deprecated method hit by tests by
this change.
2020-05-07 11:01:09 +01:00
Mike McQuaid
426c0ceb18
brew vendor-gems: commit updates. 2020-05-07 10:37:19 +01:00
Mike McQuaid
c05b3a755f
shellenv: recommend .bash_profile
Fixes #7516
2020-05-07 10:34:59 +01:00
Mike McQuaid
7d2f8749ca
Merge pull request #7520 from MikeMcQuaid/cli_args_style
cli/args: cleanup weird style.
2020-05-07 10:33:39 +01:00
Mike McQuaid
c91f397605
cli: fix options handling.
Fix breaking options on taps again (second time in two weeks, sob).

To avoid doing this again: also add a test for this case (that I've
verified would have caught these cases).
2020-05-07 10:33:02 +01:00
Mike McQuaid
85a9fc4abe
cli/args: cleanup weird style.
This got autofixed by RuboCop but looks weird.
2020-05-07 10:02:34 +01:00
dependabot-preview[bot]
5e4e0401b0
build(deps): bump activesupport in /Library/Homebrew
Bumps [activesupport](https://github.com/rails/rails) from 6.0.2.2 to 6.0.3.
- [Release notes](https://github.com/rails/rails/releases)
- [Changelog](https://github.com/rails/rails/blob/v6.0.3/activesupport/CHANGELOG.md)
- [Commits](https://github.com/rails/rails/compare/v6.0.2.2...v6.0.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-05-07 08:19:29 +00:00
Mike McQuaid
954c833de2
Merge pull request #7514 from Homebrew/dependabot/bundler/docs/activesupport-6.0.3
build(deps): bump activesupport from 6.0.2.2 to 6.0.3 in /docs
2020-05-07 09:18:17 +01:00
dependabot-preview[bot]
f3e373cf6f
build(deps): bump activesupport from 6.0.2.2 to 6.0.3 in /docs
Bumps [activesupport](https://github.com/rails/rails) from 6.0.2.2 to 6.0.3.
- [Release notes](https://github.com/rails/rails/releases)
- [Changelog](https://github.com/rails/rails/blob/v6.0.3/activesupport/CHANGELOG.md)
- [Commits](https://github.com/rails/rails/compare/v6.0.2.2...v6.0.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-05-06 18:06:36 +00:00
Dawid Dziurla
6fa09ab0ee
pr-automerge: match only approved PRs by default
Also remove default `--with-label` value and add `--without-approval`
option.

Reviews could be automatically dismissed on new commits pushed (there is
an option for that in repository settings on Github). That is not the
case for labels. They remain attached to a PR, even when new commits are
pushed. This is undesirable and creates security concerns, because
someone could introduce untested code just before the automerge happens.

Co-authored-by: Eric Knibbe <enk3@outlook.com>
2020-05-06 18:32:47 +02:00
Mike McQuaid
61b98a5e2e
Merge pull request #7511 from rwhogg/tap-pin-command-explanation
docs: Update tap-pin and tap-unpin disable explanations
2020-05-06 14:27:00 +01:00
Bob Wombat Hogg
63e6632aa9 docs: Update tap-pin and tap-unpin disable explanations
I interpreted the existing message as meaning "you don't pin
a tap any more, rather you pin a specific formula from that
tap". I.e. the command still worked, but it had to be done
on a per-formula basis (eg. `brew tap-pin linuxbrew/xorg/mesa` instead
of just `brew tap-pin linuxbrew/xorg`)

IMO, this makes it clearer that the command itself is no longer
supported.
2020-05-06 08:54:54 -04:00
Mike McQuaid
c88d587b5b
Merge pull request #7508 from MikeMcQuaid/pkgetc
formula: add pkgetc method.
2020-05-06 11:04:54 +01:00