admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
37,450 Commits 15 Branches 471 Tags
Commit Graph

716 Commits

Author SHA1 Message Date
Gautham Goli
affd9055c2 audit: Port classname and template comments audit rules from line_problems method to rubocop 2017-08-06 02:28:58 +05:30
Gautham Goli
43cec10000 audit: Port patches audit code to a rubocop 2017-08-05 21:51:24 +05:30
Mike McQuaid
f4983ab16b Merge pull request #2975 from GauthamGoli/audit_urls_rubocop_strict 
audit: Port audit_urls strict rules to rubocop, add tests, autocorrect
 2017-08-01 11:39:01 +01:00
Mike McQuaid
43d68b6dda Merge pull request #2980 from GauthamGoli/audit_style_check_bug_fix 
audit: fix bug where `brew audit foo` runs every style check.
 2017-08-01 11:36:18 +01:00
Mike McQuaid
c3c3575b70 Merge pull request #2964 from GauthamGoli/audit_line_rubocop_part_1 
audit: Port dependency rules from line_problems to rubocop and add tests
 2017-08-01 11:29:26 +01:00
Gautham Goli
5e8e705b50 audit: fix bug where brew audit foo runs every style check. 2017-07-30 22:03:43 +05:30
Gautham Goli
c575f34d5f audit: Port audit_urls strict rules to rubocop, add tests and autocorrect 2017-07-30 12:59:37 +05:30
Gautham Goli
e1cb0b43d7 audit: Port dependency rules from line_problems to rubocop and add tests 2017-07-29 16:36:32 +05:30
Gautham Goli
0c04b9041a audit: Check for style violations when --new-formula is passed 2017-07-28 05:05:34 +05:30
Gautham Goli
2639b6c556 audit: Update Urls Cop with more rules of audit_urls and corresponding tests 2017-07-25 19:06:36 +05:30
Gautham Goli
b7ddd271e1 audit: Port audit_urls partially to rubocop and add corresponding tests 2017-07-21 20:50:28 +05:30
Gautham Goli
a8f1b02be9 audit: Port audit_options rules for new formulae to rubocop and add test 2017-07-15 17:35:10 +05:30
Gautham Goli
f3923f23ef audit: Port audit_options strict rules to rubocop and add tests 2017-07-14 21:43:16 +05:30
Gautham Goli
b8adc1a8aa audit: Port audit_options non-strict rules to rubocop and add tests 2017-07-13 12:41:43 +05:30
Mike McQuaid
f1fa475c4f Merge pull request #2843 from GauthamGoli/audit_conflicts_rubocop 
audit: Port audit_conflicts method to rubocop and add tests
 2017-07-08 07:44:16 +01:00
Gautham Goli
4ed34f91c2 audit: Port audit_conflicts method to rubocop and add tests 2017-07-07 20:46:57 +05:30
Mike McQuaid
bddafe4d54 audit: don't suggest non-stable versioned alias. 
Additionally handle the case where a formula has been installed as
devel/HEAD rather than just e.g. `brew audit --devel`.
 2017-07-07 09:30:18 +01:00
Gautham Goli
8c167b23cc audit: Don't run audit methods when --only-cops is passed 2017-06-30 20:25:12 +05:30
Misty De Meo
87fa20076c
audit: ask for full_index patches 2017-06-28 20:49:37 -07:00
Mike McQuaid
f4cdd7a051 Merge pull request #2790 from GauthamGoli/audit_legacy_patches_rubocop 
audit: Port audit_legacy_patches method to rubocop and add tests
 2017-06-25 08:54:59 +01:00
Gautham Goli
2e82754776 audit: Port audit_legacy_patches method to rubocop and add tests 2017-06-24 17:06:26 +05:30
Mike McQuaid
b9e3daac70 audit: don't use Fossies as a primary URL. 
As requested in:
https://github.com/Homebrew/homebrew-core/issues/14486#issuecomment-307753234
 2017-06-23 19:34:25 +01:00
Gautham Goli
4d7a983415 audit: Port audit_checksum method to rubocop and add tests 2017-06-16 19:45:16 +05:30
Mike McQuaid
7a0aff1080 Autocorrect Rubocop Style/PerlBackrefs. 2017-06-10 20:23:20 +03:00
Mike McQuaid
113a7a81d0 Revert "audit: Port audit_checksum method to rubocop and add tests" 2017-06-09 11:16:11 +03:00
Gautham Goli
d09d5ecc55 audit: Port audit_checksum method to rubocop and add tests 2017-06-08 21:53:46 +05:30
Mike McQuaid
cc8bc44286 audit: ensure curl always has an HTTP url. 
This makes using `HOMEBREW_CURL` significantly nicer as then the system
`curl` (that, on old versions, sucks at SSL) can download a version of
`curl` that it can build from source.
 2017-06-08 14:20:04 +03:00
Mike McQuaid
3a08f81470 audit: fix pypi strict audit capture group. 2017-06-03 20:25:12 +01:00
Mike McQuaid
1d034265af Merge pull request #2726 from MikeMcQuaid/audit-pypi-urls 
audit: check pypi URLs
 2017-06-03 10:01:22 +01:00
Mike McQuaid
d6c4dfc783 Merge pull request #2725 from MikeMcQuaid/audit-formulae-options-fix 
audit: fix false negative for formulae options.
 2017-06-03 10:01:10 +01:00
Mike McQuaid
cbfc83309f audit: check pypi URLs 
#373 implemented as a strict check (thanks nijikon)
 2017-06-02 22:28:07 +01:00
Mike McQuaid
6a0086a0a7 audit: fix false negative for formulae options. 
Handle the case where an if/unless is detected and then write off this
line for option handling.
 2017-06-02 22:26:37 +01:00
Markus Reiter
2d6ae61314 Re-revert "Fix operator spacing." 2017-06-02 19:22:05 +02:00
Gautham Goli
cf848a14d2 audit: Port audit_caveats method to rubocop and add tests 2017-05-31 22:59:48 +05:30
Gautham Goli
51f2338dd5 audit: Port audit_text method to rubocop and add tests 2017-05-30 15:28:05 +05:30
Mike McQuaid
7a38bab333 Fixup all RuboCop warnings. 2017-05-29 18:43:18 +01:00
JCount
dd5d4880dc Merge pull request #2658 from JCount/audit-fix-versioned-aliases-homebrew-core 
audit: fix versioned alias errors in homebrew/core introduced in a7c6a57
 2017-05-21 21:54:17 -04:00
Markus Reiter
473bdadbcd Change error messages. 2017-05-22 02:04:02 +02:00
Markus Reiter
330307b01a Use FormulaVersions for checksum check. 2017-05-22 02:01:57 +02:00
Markus Reiter
ade62aa1b1 Add the same check for Formulae. 2017-05-22 02:01:57 +02:00
JCount
aa81f56356 audit: fix versioned alias errors in homebrew/core introduced in a7c6a57 
This fixes #2657 which in turn were caused by an oversight in #2664
 2017-05-21 12:00:56 -04:00
Mike McQuaid
a7c6a57c8e Merge pull request #2644 from JCount/audit-fix-tap-versioned-aliases 
audit: fix full versioned alias name resolution in taps
 2017-05-20 10:57:30 +01:00
Markus Reiter
f0dc1d96c5 Merge pull request #2537 from reitermarkus/pathname-to_str 
Remove `to_s` from some `Pathname`s.
 2017-05-18 09:39:07 +02:00
JCount
cd8d7a8a44 audit: fix full versioned alias name resolution in taps 
This fixes an issue where audit would prompt for the creation
of an already existing versioned alias while at the same time
declaring the existing alias invalid.
 2017-05-17 15:18:59 -04:00
Mike McQuaid
ea8be174f6 Merge pull request #2631 from GauthamGoli/audit_homepage_rubocop 
audit: Port audit_homepage method to rubocop and add tests
 2017-05-15 10:02:47 +01:00
Gautham Goli
91efcb045e Port audit_homepage method to rubocop and add tests 2017-05-14 22:05:46 +05:30
Mike McQuaid
75d230318a Merge pull request #2627 from MikeMcQuaid/audit-fix-option-detection 
audit: fix dependency option detection.
 2017-05-14 15:09:07 +01:00
Mike McQuaid
d5006ef012 audit: fix dependency option detection. 
Instead of trying to do this all with a single regex give up and do a
two stage process. Eventually I'll end up implementing a full ruby
parser here 🧌.
 2017-05-13 13:00:00 +01:00
Mike McQuaid
b14f1572b7 audit: more checks for versioned aliases. 
Check that a required versioned alias has a valid name (rather than
assuming it’s fine based on it’s existence alone) and check for
the presence of invalid version aliases.

This should handle the case where someone bumps a formula but forgets
to rename the alias that’s mentioned in #2596.
 2017-05-09 15:10:29 +01:00
Markus Reiter
5828eefd01 Remove to_s from some Pathnames. 2017-05-08 13:37:28 +02:00