Mike McQuaid
082017e93d
Merge pull request #15402 from Bo98/tab-version-type-fix
...
tab: fix typing of versions
2023-05-11 13:08:25 +01:00
Bo Anderson
289fb5b393
tab: fix typing of versions
2023-05-11 12:33:27 +01:00
BrewTestBot
8d8e6e4eef
sorbet: Update RBI files.
...
Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml ) workflow.
2023-05-11 00:24:17 +00:00
Bo Anderson
fb31c5d5d6
cask/upgrade: improve error backtraces
2023-05-10 14:46:51 +01:00
Mike McQuaid
15244d8a7d
Merge pull request #15394 from Homebrew/sorbet-files-update
...
sorbet: Update RBI files.
2023-05-10 13:20:14 +01:00
Mike McQuaid
04866b6e39
Merge pull request #15392 from reitermarkus/remove-rubocop
...
Remove `NoDslVersion` cop.
2023-05-10 13:13:35 +01:00
Carlo Cabrera
0376c6c5c1
utils/github: use Pulls API to check open pull requests on CI
...
We currently use the search API to check for duplicate pull requests,
but this is not very reliable. Our `autobump.yml` workflow routinely
opens duplicate pull requests [1] because the search API often returns
incorrect results.
We can make this more reliable by using the Pulls API instead.
Unfortunately, querying the Pulls API is very slow (~10s vs less than a
second for the search API), so let's limit its usage to calls made
inside CI, which should help @BrewTestBot avoid opening duplicate PRs.
(Most recent dupes were authored by @BrewTestBot.)
[1] https://github.com/Homebrew/homebrew-core/pulls?q=is%3Apr+author%3ABrewTestBot+is%3Aunmerged+in%3Acomments+Duplicate
2023-05-10 13:08:32 +08:00
Carlo Cabrera
58067727f4
Merge pull request #15391 from carlocab/fetch-refactor
...
fetch: remove use of `args` from CLI parser
2023-05-10 10:26:40 +08:00
BrewTestBot
d5de908486
sorbet: Update RBI files.
...
Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml ) workflow.
2023-05-10 00:23:20 +00:00
Markus Reiter
46b9dba03c
Remove NoDslVersion
cop.
2023-05-10 01:02:42 +02:00
Markus Reiter
f7168bf234
Merge pull request #15336 from reitermarkus/version-head-null
...
Merge `HeadVersion` and `NullVersion` into `Version`.
2023-05-10 01:01:21 +02:00
Carlo Cabrera
69c16739d2
fetch: remove use of args
from CLI parser
...
See discussion at #15382 .
2023-05-09 18:07:32 +08:00
Mike McQuaid
b3f7c6f7a5
Merge pull request #15390 from Bo98/update-report-no-ext-diff
...
cmd/update-report: don't invoke external diff tools
2023-05-09 08:34:35 +01:00
Mike McQuaid
e06475b9c4
Merge pull request #15388 from reitermarkus/rubocop-tests
...
Refactor RuboCop tests.
2023-05-09 08:33:40 +01:00
Markus Reiter
4b787fdee2
Retry curl_headers
on 400 codes.
2023-05-09 07:40:15 +02:00
Markus Reiter
e493d0cb04
Rescue ErrorDuringExecution
instead of changing curl_headers
return type.
2023-05-09 07:25:00 +02:00
Bo Anderson
8e7d4a5bee
cmd/update-report: don't invoke external diff tools
2023-05-09 05:19:55 +01:00
Markus Reiter
8274920217
Rename OS::Mac::Version
to MacOSVersion
.
2023-05-09 05:08:38 +02:00
Sam Ford
16f3a05e45
Strategy#page_headers: Update for #curl_headers
...
`#curl_headers` was recently introduced into `Strategy#page_headers`
but only the call was modified and the method wasn't updated to
correctly work with the new return value, so all `HeaderMatch` checks
immediately started failing with an error.
This commit includes changes that return `#page_headers` to a working
state. I've removed the `result.assert_success!` call because it
prevents a few checks from being retried with `GET` (`firefox-cn`,
`krisp`, `prepros`).
2023-05-08 23:08:05 -04:00
Markus Reiter
02dbeb62fc
Refactor RuboCop tests.
2023-05-09 04:28:25 +02:00
BrewTestBot
77a25eed28
sorbet: Update RBI files.
...
Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml ) workflow.
2023-05-09 00:24:08 +00:00
Markus Reiter
4bbf120630
Add note about Version
constructor.
2023-05-09 01:13:55 +02:00
Markus Reiter
ff71668f0a
Fix type errors.
2023-05-09 01:13:55 +02:00
Markus Reiter
fe19ddc3a7
Remove Version#empty?
.
2023-05-09 01:13:55 +02:00
Markus Reiter
a1efaf1864
Merge HeadVersion
and NullVersion
into Version
.
2023-05-09 01:13:54 +02:00
Markus Reiter
b05de929c6
Merge pull request #15351 from reitermarkus/livecheck-head
...
Use `curl_headers` and `curl_output` for `Livecheck` strategies.
2023-05-09 00:55:34 +02:00
Patrick Linnane
7c7ddd82fe
Revert "Merge pull request #15377 from carlocab/sorbet-runtime-take2"
...
This reverts commit cca98d5637d847548791b5afb16a5c609de2cb58, reversing
changes made to c0f8068573bbf886fdc78d3f9daca54d53e7e49e.
2023-05-08 12:16:11 -07:00
Mike McQuaid
b61d3500aa
Merge pull request #15270 from SMillerDev/feature/livecheck/github_latest_api
...
feat: use API for GitHub latest release strategy
2023-05-08 16:45:41 +01:00
Sam Ford
efccc5d4bb
GithubLatest: Update documentation
2023-05-08 17:21:19 +02:00
Austin Ziegler
74b50ddc89
Fix small errors in brew shellenv
...
These were introduced by typos and an incorrect assumption on the last
update of #15358 . The last commit had been tested with a parameter, but
had not been re-tested *without* parameter.
Apologies for the error.
2023-05-08 11:06:30 -04:00
Carlo Cabrera
975c4e66f7
fetch: fix typecheck error
...
This is a better replacement of #15381 .
2023-05-08 22:07:02 +08:00
Carlo Cabrera
9b369871e6
Revert "utils/bottles: fix typechecking error"
...
This reverts commit 071f6069d2cff272eaa9404f836cb1254c4fb588.
2023-05-08 21:43:12 +08:00
Carlo Cabrera
7d02626bbd
Merge pull request #15381 from carlocab/fix-sorbet-fetch
...
utils/bottles: fix typechecking error
2023-05-08 21:20:49 +08:00
Carlo Cabrera
071f6069d2
utils/bottles: fix typechecking error
...
https://github.com/Homebrew/homebrew-core/actions/runs/4915420737/jobs/8777887066?pr=130438#step:5:27
2023-05-08 21:07:58 +08:00
Mike McQuaid
b942294cf4
Merge pull request #15378 from reitermarkus/short-version-remove-build
...
Always remove build from `short_version`.
2023-05-08 12:47:18 +01:00
Mike McQuaid
63ad10392d
Merge pull request #15230 from reitermarkus/installer-manual-open
...
Make manual installers easier to open.
2023-05-08 12:46:34 +01:00
Mike McQuaid
628626b078
Merge pull request #15363 from halostatue/shellenv-shell-parameter
...
Allow brew shellenv to accept a shell name param
2023-05-08 12:39:05 +01:00
Mike McQuaid
cca98d5637
Merge pull request #15377 from carlocab/sorbet-runtime-take2
...
Revert "Revert "Merge pull request #15369 from carlocab/sorbet-runtime""
2023-05-08 12:11:07 +01:00
Markus Reiter
c0f8068573
Merge pull request #15223 from issyl0/rubocop-cask-stanza-order-in-on-blocks
...
rubocops/cask: Check for correct stanza order within `on_*` blocks
2023-05-08 09:36:30 +02:00
Markus Reiter
df620ad3ba
Make manual installers easier to open.
2023-05-08 08:25:32 +02:00
Markus Reiter
498ce8d18f
Merge pull request #15243 from aacerox/hotfix/cask-auth-redirect
2023-05-08 07:56:02 +02:00
alejandro.alvarez.acero
555ce9a5b0
Merge URL :header
with :headers
.
2023-05-08 07:41:06 +02:00
Markus Reiter
8db7e44ea7
Always remove build from short_version
.
2023-05-08 05:38:13 +02:00
Carlo Cabrera
84cb8a42f7
Revert "Revert "Merge pull request #15369 from carlocab/sorbet-runtime""
...
We need to exclude any command that might read `lsyncd` on Linux while
simulating macOS. This seems like all of them.
This reverts commit bcf94f6e27d26a6844ee1fa7af73333321015987.
2023-05-08 11:37:48 +08:00
Sam Ford
303ac147a9
GithubLatest: Include URL in match_data
...
It's standard for the `match_data` to include the URL (e.g., as in
`PageMatch`). This uses the provided URL by default, switching to the
generated URL when available.
2023-05-07 10:21:48 +02:00
Sam Ford
cfba45fb56
GithubLatest: Use API URL as generated value
...
The generated URL should reflect what we're actually checking, which
is now the `/releases/latest` API URL.
2023-05-07 10:21:48 +02:00
Sam Ford
34e2779150
GithubLatest: Move #generate_input_values
...
`#generate_input_values` is called before `#versions_from_content`
(in `#find_versions`), so it makes sense to move it above the latter.
2023-05-07 10:21:48 +02:00
Sean Molenaar
573d87cdfa
feat: use API for GitHub latest release strategy
2023-05-07 10:21:48 +02:00
Markus Reiter
1df501b0ac
Tweak tests.
2023-05-07 10:04:28 +02:00
Markus Reiter
ce8788e5bc
Fix code style.
2023-05-07 08:34:13 +02:00