910 Commits

Author SHA1 Message Date
nandahkrishna
6d948bf6ab
utils/github: add wrapper for GitHub API method 2021-02-17 23:04:15 +05:30
nandahkrishna
bf60e2da3d
utils/repology: add constants for repository names 2021-02-17 02:12:18 +05:30
nandahkrishna
24bb6040a7
dev-cmd/bump: add cask support 2021-02-17 00:42:07 +05:30
Mike McQuaid
c13d7e6723
Fix brew style 2021-02-16 09:25:34 +00:00
nandahkrishna
56e0c3d9e8
Update GitHub API usage 2021-02-15 22:38:27 +05:30
nandahkrishna
9d8a5827a3
utils/github: split module 2021-02-15 21:08:10 +05:30
Nanda H Krishna
b9cbeb3019
Merge pull request #10608 from nandahkrishna/assignment-condition-parentheses
style: use parentheses for assignment in conditions
2021-02-15 18:43:54 +05:30
Rylan Polster
79e93f54e2
Ignore more parser warnings 2021-02-14 11:58:05 -05:00
nandahkrishna
8e5451df2f
style: use parentheses for assignment in conditions 2021-02-12 18:33:37 +05:30
Rylan Polster
945d757450
utils/rubocop: don't recreate Regexp into new Regexp 2021-02-11 08:41:32 -05:00
Rylan Polster
98e40d1638
Define ignored warnings as Regexp
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2021-02-11 07:56:27 -05:00
Rylan Polster
3595ac1f7f
style: call rubocop directly 2021-02-10 22:36:42 -05:00
nandahkrishna
15f936a22a
dev-cmd/update-maintainers: implement suggestions from code review 2021-02-08 23:33:26 +05:30
nandahkrishna
6026c7c74d
brew update-maintainers: dev-cmd to update maintainers in README 2021-02-08 23:33:25 +05:30
Marcus Maxwell
f1ef1afd21
Add workflow scope to github.rb 2021-02-08 12:30:19 +00:00
Issy Long
f71ea65ee0
utils/github: Say "macOS keychain" in MissingAuthenticationError
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2021-02-05 13:52:32 +00:00
Issy Long
9394fe2b52
utils/github: Use constant everywhere for "create a PAT" message
- This way if we ever change this messaging, we only have to do so once.
2021-02-05 12:45:11 +00:00
Issy Long
ccb6d5e834
utils/github: Handle users not having any GitHub credentials
- When running `brew request-bottle`, users who don't have credentials
  in the macOS keychain (ie, Linux users) or `HOMEBREW_GITHUB_API_TOKEN`
  receive "Error: Not Found" from the GitHub API returning a 404.
- This is cryptic and confusing for newcomers to Linux maintenance, and
  potentially confusing to other folks using `open_api` where
  credentials are expected yet unset.
- This adds a new `MissingAuthenticationError` to handle the case where
  the GitHub API returns 404 and there are no creds yet API scopes are
  required.

Before:

```
issyl0@sky:/home/linuxbrew/.linuxbrew/Homebrew$ brew request-bottle hello
==> Dispatching request to Homebrew/linuxbrew-core for hello
Error: Not Found
```

After:

```
issyl0@sky:/home/linuxbrew/.linuxbrew/Homebrew$ brew request-bottle hello
==> Dispatching request to Homebrew/linuxbrew-core for hello
Error: No GitHub credentials found in Keychain or environment.
Create a GitHub personal access token:
    https://github.com/settings/tokens/new?scopes=gist,public_repo&description=Homebrew
  echo 'export HOMEBREW_GITHUB_API_TOKEN=your_token_here' >> ~/.profile
```
2021-02-05 12:44:46 +00:00
Mike McQuaid
8eeb838440
Merge pull request #10490 from nandahkrishna/fix-api-credentials-error
utils/github: fix false positive API credential error
2021-02-03 08:58:33 +00:00
Mike McQuaid
c5c151d2b3
Merge pull request #10494 from hyuraku/utils/curl_refactor-curl_with_workarounds
utils/curl: refactor curl_with_workarounds
2021-02-03 08:55:34 +00:00
hyuraku
16f8638236 utils/curl: refactor curl_with_workarounds 2021-02-03 09:54:09 +09:00
nandahkrishna
f15681ccd9
utils/github: fix false positive API credential error 2021-02-03 01:37:57 +05:30
Mike McQuaid
240d2c34fb
utils/fork: fix bootsnap handling.
Also, while we're here:

- remove unused block argument
- remove unneeded RuboCop disable comment
2021-02-02 12:34:14 +00:00
Mike McQuaid
d6957a3acb
Homebrew 3.0.0 deprecations/disables 2021-01-29 19:50:24 +00:00
EricFromCanada
6fc116318e fixes for grammar and wording 2021-01-26 16:19:47 -05:00
EricFromCanada
99ad3350ee use single quotes around stanza and parameter names 2021-01-26 16:19:47 -05:00
EricFromCanada
2ed324ebc0 use backticks around suggested input, flags, and binaries 2021-01-26 16:19:47 -05:00
EricFromCanada
cd3cb6928b indent suggested commands on subsequent line
and combine sequential puts calls
2021-01-26 15:36:44 -05:00
EricFromCanada
a427de5bee capitalization fixes
"curl" is the binary, while "cURL" is the umbrella project.
2021-01-26 15:36:44 -05:00
Seeker
e5fca67e0a
Merge pull request #10406 from SeekingMeaning/bump-formula-improvements
bump-formula-pr: improvements
2021-01-25 16:30:49 -08:00
Mike McQuaid
97d56d122e
Merge pull request #10285 from nandahkrishna/refactor-utils-bump
Refactor `brew bump`
2021-01-25 09:59:48 +00:00
Seeker
cded62333e bump-formula-pr: improvements 2021-01-24 11:23:43 -08:00
nandahkrishna
138f7de18f
Refactor brew bump: apply suggestions from code review
Co-authored-by: Sam Ford <1584702+samford@users.noreply.github.com>
2021-01-24 19:10:47 +05:30
nandahkrishna
4fa01fc8b7
utils/repology: use project-by tool to retrieve Formula data 2021-01-24 19:10:47 +05:30
nandahkrishna
e2ddf9894a
Refactor brew bump 2021-01-24 19:10:46 +05:30
Rylan Polster
180d8ca2b2
utils/curl: use specs when checking http content problems 2021-01-23 17:30:59 -05:00
Rylan Polster
2c83ea7339
Merge pull request #10370 from Rylan12/brew-release
Add brew release command
2021-01-23 15:35:53 -05:00
Rylan Polster
be02591cb6
Add brew release command 2021-01-21 18:29:43 -05:00
Seeker
bd25e7da2a utils/git_repository: add ::git_branch and ::git_commit_message 2021-01-20 17:34:54 -08:00
Michka Popoff
1c027f940f
Merge pull request #10186 from iMichka/bottle-cellar
bottle: tag specific cellars
2021-01-19 17:05:36 +01:00
Dustin Rodrigues
3e074419d7
Merge pull request #10356 from dtrodrigues/pypi-extra
pypi: allow packages in global exclude list if explicitly requested
2021-01-19 10:30:35 -05:00
Michka Popoff
3eea1434cc bottle: tag specific cellars 2021-01-19 10:14:25 +01:00
Seeker
fbafaff4fe rubocop: require braces for Sorbet sig 2021-01-18 16:52:45 -08:00
Seeker
20eaf43836
Merge pull request #10346 from SeekingMeaning/git-repository-safe
git_repository: raise error instead of returning nil if `safe`
2021-01-18 16:48:14 -08:00
Dustin Rodrigues
d87844ae8b pypi: allow packages in global exclude list if explicitly requested 2021-01-18 13:36:48 -05:00
Seeker
9bf409111c git_repository: raise error instead of returning nil if safe 2021-01-17 09:01:04 -08:00
Alexander Bayandin
4a5722ba07 utils/pypi: allow pipgrip to resolve conflicts 2021-01-15 16:17:36 +00:00
Seeker
663b972f44
Merge pull request #10306 from SeekingMeaning/git-repo-pwd
utils/git_repository: use `Pathname.pwd` if no `repo` specified
2021-01-13 16:14:27 -08:00
Rylan Polster
701989968d
Merge pull request #10268 from Rylan12/completions-opt-out
completions: make opt-in only
2021-01-13 16:08:30 -05:00
Seeker
4f02c1c8a8 utils/git_repository: use Pathname.pwd if no repo specified 2021-01-13 13:02:37 -08:00