290 Commits

Author SHA1 Message Date
Markus Reiter
196d7badfa Improve RSpec annotations. 2020-09-09 10:24:20 +02:00
Mike McQuaid
8118aee85d
Merge pull request #8651 from Homebrew/imgbot
[ImgBot] Optimize images
2020-09-08 17:14:00 +01:00
ImgBotApp
1a7b3e87ee
[ImgBot] Optimize images
*Total -- 61.65kb -> 43.73kb (29.07%)

/docs/assets/img/docs/managing-pull-requests.drawio.svg -- 61.61kb -> 43.69kb (29.08%)
/Library/Homebrew/test/support/fixtures/test.gif -- 0.04kb -> 0.03kb (18.6%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>
2020-09-08 14:34:34 +00:00
Markus Reiter
4d8dcb1d81 Add RSpec formatter for Github Actions. 2020-09-07 23:50:44 +02:00
rmnull
7863cc6f80
remove {rust,cpp,go}.elf fixutres. 2020-09-02 18:58:36 +05:30
rmnull
f5ca649e1d
new elf fixtures, and basic tests for Pathname#rpath(=), and Pathname#interpreter(=). 2020-09-02 18:58:36 +05:30
Mike McQuaid
667c2b8804
Merge pull request #8382 from Bo98/startup-speedup
Lazily require some heavy files
2020-08-21 17:11:39 +01:00
Dawid Dziurla
c8c2e38bcb
Consistently use HOMEBREW_RUBY_WARNINGS when calling ruby
Adding this in `dev-cmd/ruby.rb` allows us to suppress warnings like:
```
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/language/python.rb:8: warning: Insecure world writable dir /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/shims/scm in PATH, mode 040777
```
2020-08-20 14:59:58 +02:00
Bo Anderson
281632b64e test: ensure require "formula" isn't run on startup 2020-08-20 02:05:17 +01:00
Bo Anderson
e3372e2a14 Lazily require some heavy files 2020-08-20 02:05:17 +01:00
Rylan Polster
90d9454d1e utils/spdx: add support for complex expressions
Co-authored-by: Seeker <meaningseeking@protonmail.com>
2020-08-19 12:47:58 -04:00
William Ma
a7b063efb5 named_args: Warn when cask with same name exists 2020-08-17 13:06:47 -04:00
William Ma
c8016f6c0a named args: add method tests 2020-08-14 14:10:55 -04:00
Markus Reiter
3b2a9c3b55
Merge pull request #8335 from waldyrious/show-cask-descs-in-info-command
Show cask description in `brew cask info` command
2020-08-14 00:52:27 +02:00
Waldir Pimenta
619af6a723 Show cask description in brew cask info command 2020-08-13 22:21:10 +01:00
Waldir Pimenta
efbfb90c42 Use cask with name for basic info command test
Also add non-dummy URL in the test fixture, to match the name, version, etc.
2020-08-13 22:21:10 +01:00
Markus Reiter
b48bc316e0 Use CLI::Parser for cask commands. 2020-08-13 05:15:15 +02:00
Waldir Pimenta
c66fa42efd Add language stanza to cask rubocops
Also fix the corresponding test
2020-08-09 22:07:31 +01:00
Markus Reiter
8a32954940 Move cask/all to just cask. 2020-08-09 01:34:07 +02:00
Markus Reiter
24eff8f81a Pass args in SoftwareSpec instead of using global args. 2020-07-30 03:21:12 +02:00
Mike McQuaid
25db60ebbb
Unify (mostly) Homebrew code style
Make the Homebrew/cask and Homebrew/homebrew-core style more closely
match the rest of Homebrew.

To accomplish this:
- Run `brew cask style` to ensure we don't break style there when
  making changes or upgrading RuboCop in Homebrew/brew.
- Fix the HomepageMatchesUrl cop to better handle weird input.
- Remove the now unneeded `.rubocop_shared.yml`
- Fix the cask fixtures with `brew cask style --fix`.
- Share more style between Homebrew/brew, casks and formulae.
2020-07-27 12:57:40 +01:00
lionellloh
29622c35d1 tests: wrote up more tests for brew install 2020-07-07 21:34:49 +08:00
Mike McQuaid
4e10341277
Merge pull request #7752 from SMillerDev/cask/readall
Support casks in readall
2020-07-01 12:19:30 +01:00
Mike McQuaid
0166211ffd
integration_test: don't error on missing bin. 2020-07-01 11:55:42 +01:00
Bo Anderson
04cebe30dc test/support/fixtures/bottles: add Big Sur fixtures 2020-06-24 16:31:48 +01:00
Adrian Ho
6044bb17ee Fix test cask macOS dependency
This should be updated when the minimum OS requirement changes.
2020-06-23 09:51:56 +08:00
Mike McQuaid
b58fa4ebb1
Drop Mavericks support.
Companion to https://github.com/Homebrew/brew/pull/7698.

Provide better, `odeprecated` messaging for
`depends_on :macos => :mavericks` and otherwise just fix up the code
that relied on `:mavericks`.
2020-06-10 10:06:46 +01:00
Mike McQuaid
11cf77be17
formula_installer: prelude before fetch.
This ensures that dependencies are verified and tapped before they are
fetched. `FormulaInstaller#lock` has been moved into
`FormulaInstaller#install` to avoid locking until necessary.

While we're here, don't compute dependencies before fetching if we're
not going to use them.
2020-05-23 13:40:13 +01:00
Mike McQuaid
08a9f0e1c0
Use FormulaInstaller#fetch before #prelude. 2020-05-11 09:38:26 +01:00
Michelle Nguyen
2264c08cee
Fetch formula resources before unlinking during upgrade.
Fixes #6374.
2020-05-11 09:37:56 +01:00
Claudia
c85df70757
Fix flaw in Cask test helper
This commit fixes a flaw in the Cask test helper, causing the broken `Cask::Config` test to actually fail.

The flaw occurred while patching the `Cask::Config::DEFAULT_DIRS` hash.
While the original hash uses strings as values, the patched one used
`Pathname` values, masking a broken `Cask::Config::from_json` test.

Now the broken test fails like it should.
2020-04-27 15:09:36 +02:00
Mike McQuaid
cddc67b451
rubocops/uses_from_macos: update list.
Also, provide details on how to update this in future and split it into
two.

Fixes #7396
2020-04-20 10:36:42 +01:00
Mike McQuaid
56c02485e0
rubocops: test whitelists. 2020-04-12 14:17:05 +01:00
Dario Vladovic
3a21ca8956
Implement mdimporter cask stanza 2020-04-06 15:24:14 +02:00
Bo Anderson
4265540cc4 load_path: trim entries where possible to fix Ruby crashes 2020-04-01 11:53:54 +01:00
Mike McQuaid
bd076049a0
integration_test: only run on system Ruby.
There appear to be random, seemingly impossible to debug issues with
running integration tests on portable Ruby. Instead of confusing
contributors when these will be run on CI anyway: let's just skip them
by default (like we do with `--online` for online tests anyway).
2020-03-30 20:25:42 +01:00
ImgBotApp
06841497bb [ImgBot] Optimize images
/Library/Homebrew/test/support/fixtures/test.svg -- 0.26kb -> 0.25kb (1.52%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>
2020-02-16 14:17:57 -08:00
Mike McQuaid
6670ae6202
global: require rubygems for activesupport. 2019-11-06 10:36:40 +00:00
Markus Reiter
e6cfb4a3c2
Merge pull request #6629 from timsly/manpage-artifact
Add Manpage artifact
2019-10-24 13:48:52 +02:00
Tim Masliuchenko
22d821323c Feedbacks 2019-10-23 16:28:00 +03:00
Tim Masliuchenko
3ef5e06943 Add Manpage artifact 2019-10-22 15:21:49 +03:00
Cheng XU
163ef284d2
brew test: more fixes for ARM
On ARMv7, the arch name is armv7l instead of armv7. So update the bottle
file name accordingly.
2019-10-19 15:20:35 +08:00
Cheng XU
f0e848b3e0
fixtures: add testball bottle for ARM
Also fix the absolute link used by testball_bottle-0.1.intel_macintosh.bottle.tar.gz
2019-10-18 15:30:24 +08:00
Issy Long
341ea60807
Auto-fix Style/RedundantBegin offenses
- This also required auto-fixes for Layout/EmptyLinesAroundBlockBody and
  Layout/InconsistentIndentation once the auto-fixer had got rid of the
  "redundant begin"s.
2019-10-13 16:04:27 +01:00
Mike McQuaid
8a8fc68264
Ruby 2.6.3 brew tests fixes 2019-10-08 17:39:31 +01:00
Markus Reiter
7f39d333bc Move assert_success to SystemCommand::Result. 2019-10-04 23:39:25 +02:00
Alec Clarke
45806f6a97 Include test casks in the cask style check.
Currently the tests casks found in "/Homebrew/test/support/fixtures/cask/Casks" and "/Homebrew/test/support/fixtures/third-party/Casks" aren't included in the paths checked when running "brew cask style".

This change includes these test cask paths in the checked paths, and also includes the auto style fixes made by running `brew cask style --fix`.
2019-09-23 08:50:24 -04:00
Alec Clarke
af10d13381 Check blacklisted Casks when auditing.
In some cases, certain Casks shouldn't be resubmitted for specific reasons: difficult to maintain, developers maintain their own version, ...

To make sure these cases are restricted - we can add them to a blacklist and have the blacklist checked as part of the `brew cask audit` steps.
2019-09-17 06:29:46 -07:00
Markus Reiter
16d2f8264c Use MacOSRequirement for casks. 2019-08-21 06:57:21 +02:00
Mike McQuaid
c4f72312ce
Fixup brew style failures. 2019-04-30 09:19:18 +01:00