14409 Commits

Author SHA1 Message Date
Mike McQuaid
0e574eb44e
Merge pull request #5138 from MikeMcQuaid/download_strategy_deprecate_naming_update
compat/download_strategy: improve messaging.
2018-10-20 13:01:20 +01:00
commitay
d38c8fb8c5 audit: disallow devel specs in core 2018-10-20 21:43:33 +10:00
Mike McQuaid
57968a29a5
Merge pull request #5106 from MikeMcQuaid/vendor-rubocop-rspec
Vendor rubocop-rspec
2018-10-20 12:43:00 +01:00
Mike McQuaid
556b339c4f
Merge pull request #5137 from amancevice/fix-deprecated-s3-download-strategy
Fix to deprecated S3DownloadStrategy
2018-10-20 12:41:55 +01:00
Mike McQuaid
864be6d82f
Merge pull request #5105 from MikeMcQuaid/brew-info-verbose-analytics-table
info: make verbose analytics use tabular output.
2018-10-20 12:34:40 +01:00
Mike McQuaid
9272579593
compat/download_strategy: improve messaging.
This should make it clearer how you can maintain this yourself (as well
as being a better fit with `odeprecated`'s output).
2018-10-20 12:34:13 +01:00
Mike McQuaid
99749cbe9c
Merge pull request #5101 from MikeMcQuaid/requirements_cleanup
Cleanup Requirements
2018-10-20 12:13:26 +01:00
Mike McQuaid
0617dc1c1d
info: make verbose analytics use tabular output.
This copies (and slightly improves) the current `brew formula-analytics`
output so `brew formula-analytics` can be adjusted to just output JSON.
2018-10-20 12:06:25 +01:00
Mike McQuaid
4231197437
Merge pull request #5119 from javian/fixtodo1
rubocop: fix some rubocop offences
2018-10-20 11:56:52 +01:00
Mike McQuaid
2e4176a57f
Merge pull request #5130 from commitay/versioned-formula
audit: use `versioned_formula` instead of `formula.versioned_formula?`
2018-10-20 11:55:32 +01:00
Mike McQuaid
303f9579d6
Merge pull request #5075 from EricFromCanada/cmd-help-new
docs: conversion & review of Homebrew::CLI::Parser help in dev-cmd/
2018-10-20 11:53:55 +01:00
Jan Viljanen
2b123153de update description 2018-10-20 09:26:40 +02:00
Jan Viljanen
bd3bc09720 restore sh test 2018-10-20 08:53:19 +02:00
commitay
78a21c8bbf audit: use versioned_formula instead of formula.versioned_formula? 2018-10-20 13:43:55 +10:00
commitay
598909577c
Merge pull request #5091 from commitay/versioned-keg-only
audit: check versioned formulae for `keg_only :versioned_formula`
2018-10-20 13:40:37 +10:00
Alexander Mancevice
2e7758b4e9 Fix to deprecated S3DownloadStrategy
Remove references to removed require_aws_sdk method
See commit: 599ecc9b5ad7951b8ddc51490ebe93a976d43b29
2018-10-19 15:40:15 -04:00
EricFromCanada
388781f6a7 dev-cmd/: remove colons from command specs.
These aren't needed when converting Parser-based help text to man page or Markdown formats.
Includes regenerated docs.
2018-10-19 13:12:55 -04:00
EricFromCanada
7fb425a5c6 man.rb: avoid showing comma when an option has no long version.
Specifically, `brew ruby -e "<ruby code>"`.
2018-10-19 13:12:55 -04:00
EricFromCanada
63b3d400e0 dev-cmd/: add Parser-based help text for remaining commands.
`brew ruby` now accepts only `-e`, verbose, and debug arguments.
2018-10-19 13:12:55 -04:00
EricFromCanada
ddf057f3dd dev-cmd/: edit help text and descriptions. 2018-10-19 13:12:11 -04:00
Mike McQuaid
0c0275771d
Cleanup Requirements
- remove unused NonBinaryOsxfuseRequirement
- import CodeSignRequirement from Homebrew/homebrew-core
- remove unused UnsignedKextRequirement
- don’t allow custom name for X11Requirement
2018-10-19 16:38:41 +01:00
Mike McQuaid
599ecc9b5a
Deprecate unused download strategies
Download the unused, private download strategies. These are a better fit
for being declared in the formulae and/or taps that use them rather than
in Homebrew/brew where they are unused by Homebrew maintainers or
official taps/formulae.
2018-10-19 10:48:52 +01:00
EricFromCanada
20167e5f1b Adjust comments to tidy API docs output. 2018-10-18 21:42:43 -04:00
Markus Reiter
de9cb69206
Merge pull request #5123 from reitermarkus/test-locks
Allow access to lock directory inside tests.
2018-10-17 16:47:50 +02:00
commitay
0a3ad268a0 audit: check versioned formulae for keg_only :versioned_formula 2018-10-17 23:52:42 +10:00
Markus Reiter
b7ea9e1830 Allow access to lock directory inside tests. 2018-10-17 14:23:02 +02:00
Markus Reiter
a838b372de Fix brew cask style with relative paths. 2018-10-17 13:51:51 +02:00
Markus Reiter
178db5dca5
Merge pull request #5104 from reitermarkus/create-cache
Ensure cache directory for `CacheStoreDatabase` exists.
2018-10-16 23:54:46 +02:00
Jan Viljanen
96e5b8d9b1 fix rubocop offences 2018-10-16 22:44:07 +02:00
Markus Reiter
dbf5d5b222
Merge pull request #5118 from reitermarkus/brew-cask-style
Run `rubocop` in temporary directory to skip reading parent config.
2018-10-16 22:00:37 +02:00
Markus Reiter
8aab6dc03d Run rubocop in temporary directory to skip reading parent config. 2018-10-16 14:55:00 +02:00
Markus Reiter
afb75a67b1 Ensure cache directory for CacheStoreDatabase exists. 2018-10-16 11:16:17 +02:00
Mike McQuaid
1621eb0b9d
description_cache_store: handle empty database.
Don't perform an incremental update from a report or list of formulae if
the cache is currently empty.

Also, remove some accidentally remaining debugging output.
2018-10-15 22:51:43 -07:00
Mike McQuaid
4def45f499
utils/github_spec: use author that exists. 2018-10-15 14:15:08 -07:00
Mike McQuaid
056dd588b2
utils/github: add ValidationFailedError.
These have specific errors returned so would be more useful to output.
2018-10-15 12:03:16 -07:00
Markus Reiter
473155e12c
Merge pull request #5103 from reitermarkus/incomplete-downloads
Fix cleanup of incomplete downloads.
2018-10-15 15:19:56 +02:00
JBallin
2bf0db40b3 Normalize formatting of gist-logs errors 2018-10-14 20:40:24 -07:00
JBallin
2a1b936f76 Clarify HOMEBREW_GITHUB_API_TOKEN in gist-logs err 2018-10-14 20:40:24 -07:00
Mike McQuaid
9bcb1d5b01
Merge pull request #5100 from MikeMcQuaid/or-later-default
bottles: make `or_later` the default.
2018-10-14 20:25:34 -07:00
Mike McQuaid
1cf020a823
Merge pull request #5102 from MikeMcQuaid/analytics-build-error-options
analytics: fix display of build error options.
2018-10-14 12:33:53 -07:00
Mike McQuaid
800853a28d
Vendor rubocop-rspec
We aren't going to vendor its dependencies because we already require
a systemwide installation of `rubocop` to work in your editor. This
avoids requiring users to manually do another
`gem install rubocop-rspec` to have their editor integration behave as
expected.
2018-10-14 12:11:54 -07:00
Mike McQuaid
a2074f01a2
Merge pull request #4922 from MikeMcQuaid/azure-coverage
Generate Cobertura coverage data for Azure Pipelines
2018-10-14 02:19:06 +01:00
Mike McQuaid
100e85dda1
Generate Cobertura coverage data for Azure Pipelines
These can be used and displayed directly in the Azure Pipelines GUI.

It may not end up replacing CodeCov but it's easy enough so: why not.
2018-10-13 17:55:04 -07:00
Mike McQuaid
9a144fe0bd
Merge pull request #5095 from EricFromCanada/cli-parser-help
cli_parser: improve help text formatting
2018-10-14 00:27:38 +01:00
Markus Reiter
1f24c6600c Fix cleanup of incomplete downloads. 2018-10-14 00:15:16 +02:00
Mike McQuaid
c2d23838d0
analytics: fix display of build error options.
Currently these are all like `wget #<Options:0x0000000101171658>`.
2018-10-13 15:09:03 -07:00
Markus Reiter
9b84b2404a
Merge pull request #5087 from amyspark/xattr-fail
Cask: fix quarantine check when xattr is broken
2018-10-13 23:52:41 +02:00
Markus Reiter
6d41f4fa7c
Merge pull request #5061 from amyspark/quarantine-symlinks
Cask: set write permissions on symlinks
2018-10-13 23:49:13 +02:00
Markus Reiter
2cb0050a99
Merge pull request #5099 from alecclarke/fix-style-in-uninstall_zap_shared_examples
Use the `all` matcher to check the existence of each path.
2018-10-13 23:27:43 +02:00
Mike McQuaid
8dd59548ed
bottles: make or_later the default.
When Mojave was in beta we made it so that High Sierra bottles would
automatically be used on Mojave. Let's make this the default in general:
older bottles will be used on newer versions of macOS when a newer
bottle is not available.

This should make it easier for taps to bottle single versions of bottles
which will work more widely and to give us breathing room whenever a new
version of macOS is released.

Currently this only applies to the `wine` formula which will have the
`or_later` removed in a Homebrew/homebrew-core PR.

Question: should we use an `odeprecated` for the use of `or_later`?
2018-10-13 12:39:21 -07:00