2836 Commits

Author SHA1 Message Date
Markus Reiter
d5de9d585b Use normal download strategies for casks. 2018-08-06 18:25:19 +02:00
Markus Reiter
93faf44e48
Merge pull request #4612 from reitermarkus/bottle-double-dash
Use `--` for bottles.
2018-08-06 18:15:04 +02:00
Markus Reiter
d33241bc11 Use -- for bottles. 2018-08-06 17:59:51 +02:00
Markus Reiter
888a7073bc Change migration to loop through formulae. 2018-08-06 17:25:29 +02:00
Reto Kromer
456571b15d fix more insecure protocols 2018-08-06 16:50:42 +02:00
Reto Kromer
d630f0885b more secure protocols 2018-08-06 16:23:07 +02:00
Markus Reiter
4a48297d1c Fix cleanup for files with --. 2018-08-06 15:40:05 +02:00
Markus Reiter
4a9e0511f6
Merge pull request #4603 from reitermarkus/download-strategies-system_command
Use `system_command` for all download strategies.
2018-08-06 15:30:20 +02:00
Reto Kromer
2936a60950
use https:// rather than http:// 2018-08-06 13:18:00 +02:00
Markus Reiter
7449f9cd15 Fix update-report migration. 2018-08-06 12:52:18 +02:00
Markus Reiter
837f56c73b Use system_command for all download strategies. 2018-08-06 12:32:34 +02:00
Markus Reiter
9082886144
Merge pull request #4608 from reitermarkus/merge-cask-download-strategy-specs
Merge download strategy specs.
2018-08-06 12:30:10 +02:00
dependabot[bot]
592cb1cc4b
Bump rspec from 3.7.0 to 3.8.0 in /Library/Homebrew/test
Bumps [rspec](https://github.com/rspec/rspec) from 3.7.0 to 3.8.0.
- [Release notes](https://github.com/rspec/rspec/releases)
- [Commits](https://github.com/rspec/rspec/compare/v3.7.0...v3.8.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-08-06 05:59:31 +00:00
Markus Reiter
ac9cd39a4c Merge download strategy specs. 2018-08-06 00:19:54 +02:00
Markus Reiter
dcf5d8d79b Add test for migrate_cache_entries_to_double_dashes. 2018-08-05 20:38:50 +02:00
Markus Reiter
1003d722bd Use -- to separate download name and version. 2018-08-05 15:57:28 +02:00
Markus Reiter
51fa194966 Move cached_location to #initialize. 2018-08-03 10:51:01 +02:00
Markus Reiter
3a99e64646
Merge pull request #4593 from reitermarkus/curl-options
Merge `curl` options used by casks into download strategies.
2018-08-02 15:58:22 +02:00
Markus Reiter
7f4ea02047 Merge curl options used by casks into download strategies. 2018-08-02 11:18:46 +02:00
Markus Reiter
7c496f7a7e Explicitly pass specs to download strategy. 2018-08-02 10:33:14 +02:00
Markus Reiter
e367e7eea8 Explicitly pass url and mirrors to download strategy. 2018-08-02 10:09:35 +02:00
Markus Reiter
3d27b2aa8d Explicitly pass version to download strategy. 2018-08-01 05:40:15 +02:00
Markus Reiter
8ae284e871 Use SystemCommand for curl. 2018-08-01 01:04:42 +02:00
Markus Reiter
ddbefee44a
Merge pull request #4573 from reitermarkus/subversion-spec
Add spec for SVN directory name containing `@`.
2018-07-30 22:25:42 +02:00
Markus Reiter
88783eae31 Refactor Hbc::URL and rename to URL. 2018-07-30 21:07:42 +02:00
Markus Reiter
54aa412015 Use LazyObject for Hbc::URL. 2018-07-30 21:07:42 +02:00
Markus Reiter
428bc9c7a3 Add LazyObject class. 2018-07-30 21:07:42 +02:00
Markus Reiter
d14f5dae7e Add spec for SVN directory name containing @. 2018-07-30 20:13:29 +02:00
ilovezfs
cd2b85c40f
Revert "Use SystemCommand for curl." 2018-07-29 21:45:04 -07:00
Markus Reiter
3c3b05d457
Merge pull request #4564 from reitermarkus/not-a-cask-file-error
Raise error when file does not contain a cask.
2018-07-29 12:31:49 +02:00
Markus Reiter
785ec4ef57 Add tests for `CaskUnreadableError. 2018-07-29 12:03:42 +02:00
Markus Reiter
355df64d93 Use SystemCommand for curl. 2018-07-29 01:23:33 +02:00
Markus Reiter
aacf603ad2 Fix .codecov.yml. 2018-07-27 01:21:38 +02:00
Mike McQuaid
b74974611c
Merge pull request #4548 from MikeMcQuaid/coverage-tweaks
Tweak code coverage logic
2018-07-26 10:21:46 +01:00
Mike McQuaid
afec4e2988 Tweak code coverage logic
- make OS detection looser to exclude more Linux files on macOS (and
  vice versa)
- Allow slight (0.5%) coverage drops to account for somewhat random
  fluctuations.
2018-07-26 10:09:02 +01:00
Markus Reiter
2912ebfbfe Add test for Tap::from_path. 2018-07-25 11:04:00 +02:00
Markus Reiter
83a1e8dd97 Refactor UnpackStrategy::Dmg. 2018-07-24 16:44:27 +02:00
Markus Reiter
1d167a6b9f Reraise SystemCallError as ErrorDuringExecution. 2018-07-24 16:44:27 +02:00
Markus Reiter
eccd20e276 Merge Hbc::Container classes into UnpackStrategy. 2018-07-24 16:44:27 +02:00
Markus Reiter
b6e54a06e0 Refactor unpack strategies into separate files. 2018-07-23 20:59:28 +02:00
Markus Reiter
e5e8033145 Add system_command helpers. 2018-07-22 23:24:18 +02:00
Markus Reiter
db299035ac
Merge pull request #4517 from reitermarkus/rename-system-command
Rename `Hbc::SystemCommand` to `SystemCommand`.
2018-07-22 22:24:00 +02:00
Markus Reiter
45f6cc5bd0
Merge pull request #4532 from reitermarkus/directory-permissions
Fix directory permissions when unpacking.
2018-07-22 22:23:45 +02:00
Markus Reiter
b675024ce0 Add failing test for DirectoryUnpackStrategy. 2018-07-22 22:02:09 +02:00
Markus Reiter
8f462ddb5d Fix Searchable when collection contains nil. 2018-07-22 21:51:53 +02:00
Markus Reiter
bcf05f1a48 Remove :cask from SystemCommand specs. 2018-07-22 21:11:47 +02:00
Markus Reiter
28384ba518 Rename Hbc::SystemCommand to SystemCommand. 2018-07-22 21:11:47 +02:00
Claudia
8666d8fa18
Increase spec timeout to 30 seconds
I’ve noticed the deadlock test in `cask/system_command_spec.rb` appears to fail spuriously, e. g. in #4529.

Details:

https://travis-ci.org/Homebrew/brew/jobs/406827725#L297-L318

With the spec taking 2 seconds on average on my 2017 MBP, I feel it’s
entirely plausible for the aging test-bot hardware to get knocked by
the 15-second timeout.

Given that the spec will pass early anyway if it passes, I feel it’s
reasonable to bump the timeout to 30 seconds.
2018-07-22 16:27:16 +02:00
Markus Reiter
7ad999f5f8
Merge pull request #4488 from reitermarkus/system-command
Refactor `Hbc::SystemCommand`.
2018-07-20 17:51:10 +02:00
Markus Reiter
fec884d8da Add tests for ErrorDuringExecution. 2018-07-19 16:53:11 +02:00