972 Commits

Author SHA1 Message Date
Mike McQuaid
efc3c0c4c0
Use bundle install in more places.
This provides a more consistent version for `rubocop` than relying on
`Homebrew.install_gem_setup_path!` (and we really want `brew style` to
provide consistent output).
2019-01-08 15:08:21 +00:00
Mike McQuaid
149ded30aa
Merge pull request #5417 from vitorgalvao/cask-malware
Cask: remove malware caveat
2018-12-18 08:13:58 +00:00
Vítor Galvão
55084dd8ab Cask: remove malware caveat 2018-12-18 02:29:27 +00:00
Vítor Galvão
b33d29f49a Cask: use browser UA when checking for homepage HTTPS availability 2018-12-13 15:24:40 +00:00
Vítor Galvão
dff0320f8c Cask: Remove check on sha-only change 2018-12-03 17:13:09 +00:00
L. E. Segovia
3b79b4d079
More styling fixes 2018-11-24 11:21:52 +00:00
L. E. Segovia
62fd4a2e00
Use .blank? 2018-11-24 02:02:53 +00:00
L. E. Segovia
5a2743b50d
Merge branch 'master' into gitjiro-improved 2018-11-24 01:01:40 +00:00
Markus Reiter
04908dcb19 Fix RuboCop for Casks. 2018-11-12 05:01:33 +01:00
Mike McQuaid
109e974c38
Cleanup rubocop-cask references. 2018-11-08 15:54:47 +00:00
Markus Reiter
785ffb1b2c Refactor tests for uninstall stanza. 2018-11-07 18:44:52 +01:00
Markus Reiter
f61b963744 Improve application quitting. 2018-11-07 18:44:52 +01:00
Markus Reiter
79dc58f77f
Merge pull request #5242 from reitermarkus/nested-container-permissions
Always make nested container readable and writable.
2018-11-04 17:05:05 +01:00
Markus Reiter
4e44724835 Always make nested container readable and writable. 2018-11-02 23:56:05 +01:00
Mike McQuaid
737b84b54b
brew style --fix fixes. 2018-11-02 17:29:23 +00:00
Markus Reiter
e7b1feefe8 Don’t remove login items on upgrade. 2018-10-25 01:05:53 +02:00
EricFromCanada
20167e5f1b Adjust comments to tidy API docs output. 2018-10-18 21:42:43 -04:00
Markus Reiter
a838b372de Fix brew cask style with relative paths. 2018-10-17 13:51:51 +02:00
Markus Reiter
8aab6dc03d Run rubocop in temporary directory to skip reading parent config. 2018-10-16 14:55:00 +02:00
Markus Reiter
9b84b2404a
Merge pull request #5087 from amyspark/xattr-fail
Cask: fix quarantine check when xattr is broken
2018-10-13 23:52:41 +02:00
Markus Reiter
6d41f4fa7c
Merge pull request #5061 from amyspark/quarantine-symlinks
Cask: set write permissions on symlinks
2018-10-13 23:49:13 +02:00
L. E. Segovia
1707caf968
Cask: fix quarantine check when xattr is broken 2018-10-13 01:27:36 +00:00
L. E. Segovia
094cab89fe
Cask: remove curl calls, use them with --download 2018-10-10 21:36:06 +00:00
L. E. Segovia
32246dd097
Cask: do not audit non-file URLs 2018-10-10 21:36:06 +00:00
L. E. Segovia
3acebc5b62
Cask: recover Git-Jiro's old audit work 2018-10-10 21:36:02 +00:00
commitay
5024efa506
Merge pull request #5059 from commitay/remove-checkpoint
remove appcast checkpoint audit
2018-10-09 15:21:24 +10:00
L. E. Segovia
2c9b599c0a
Cask: simplify chmod +w passes 2018-10-08 18:23:21 +00:00
Markus Reiter
711bb4977f
Merge pull request #5056 from reitermarkus/accessibility_access
Remove the `accessibility_access` stanza.
2018-10-08 18:24:18 +02:00
Markus Reiter
7b38828fe2
Merge pull request #5057 from reitermarkus/unused-verify
Remove unused `include`.
2018-10-08 15:18:11 +02:00
Markus Reiter
7cb1ceb756
Merge pull request #4920 from reitermarkus/days
Use ActiveSupport’s `#days`.
2018-10-08 15:14:36 +02:00
L. E. Segovia
59fcaa3674
Cask: set write permissions on symlinks 2018-10-08 01:39:52 +00:00
commitay
da7d46aa14 remove appcast checkpoint audit 2018-10-08 10:54:30 +10:00
commitay
f2caa9b02f cask/audit: remove cask specific sourceforge URL audits 2018-10-08 09:24:00 +10:00
Markus Reiter
16618d0fc7 Use ActiveSupport’s #pluralize and #to_sentence. 2018-10-07 23:10:56 +02:00
Markus Reiter
c4d418e126 Use ActiveSupport’s #second. 2018-10-07 23:10:56 +02:00
Markus Reiter
b74c3b120d Remove unused include. 2018-10-07 23:09:21 +02:00
Markus Reiter
b7cf925da8 Remove unused methods in Staged module. 2018-10-07 22:00:07 +02:00
Markus Reiter
59e3a532ff Remove the accessibility_access stanza. 2018-10-07 21:53:31 +02:00
Viktor Szakats
a0d971a0d0 secure/fix URLs 2018-10-03 21:21:05 +00:00
Markus Reiter
2308f0c571 Skip quitting applications when not logged into GUI. 2018-10-02 16:27:45 +02:00
L. E. Segovia
6d7e49b02b
Cask: check if xattr works before quarantining
Fixes Homebrew/homebrew-cask#52128.
2018-09-26 20:55:54 +00:00
commitay
1243183294
Merge pull request #4876 from commitay/jdk11
java_requirement, cask dsl caveats: JDK 11
2018-09-26 08:35:03 +10:00
Markus Reiter
e9b9ea49a1 Update to RuboCop 0.59.1. 2018-09-17 03:45:59 +02:00
Markus Reiter
dfb6ada805
Merge pull request #4902 from MikeMcQuaid/active-support-blank
Use ActiveSupport Object#blank? and #present?
2018-09-16 20:02:00 +02:00
Mike McQuaid
955214abc0
Use ActiveSupport Object#blank? and #present? 2018-09-14 17:02:19 +01:00
L. E. Segovia
123dda09f0
Cask: constrain quarantine support status
Quarantine is available ONLY if the script exits with '2'.
It is definitely NOT available if Swift doesn't exist or if
it exits with '5' (incompatible SDK). All other cases are
from now on treated as unsupported.

Also print to standard error only when explictly required (via an
exception).
2018-09-14 15:48:16 +00:00
Mike McQuaid
d7eca0b57c
Use Bundler to manage vendor directory
Rather than having to manually keep track of what version each thing in
here is and copy files around by hand on update let's use Bundler's
standalone mode and careful use of `.gitignore` to help us do it.

This means a `bundle update --standalone` will allow us to update all
gems in vendor.

We could consider vendoring other gems this way in future but I'd
suggest only doing this for gems with no dependencies or at least gems
with no native extensions. The only gem this applies to that we
currently use is `ruby-prof` and I'm not convinced it's widely used
enough to warrant vendoring for everyone. Perhaps that's another
criteria: it should be functionality that's used by non-developer
commands and/or normal Homebrew usage.
2018-09-13 15:24:18 +01:00
commitay
d3fea84387 cask/dsl/caveats: JDK 11 2018-09-12 08:30:35 +10:00
Markus Reiter
5cff91ac75 Don’t add error when changing checksum to :no_check. 2018-09-11 14:02:53 +02:00
Eric Mark Martin
c62d2e6918 Cask: rename block argument f -> cask 2018-09-09 13:37:42 -04:00