28781 Commits

Author SHA1 Message Date
Mike McQuaid
461fc3ec81
Merge pull request #15160 from razvanazamfirei/greedy
Add HOMEBREW_GREEDY option
2023-04-06 08:43:20 +01:00
Mike McQuaid
b9fb7c5dbf
Merge pull request #15162 from Homebrew/dependabot/bundler/Library/Homebrew/addressable-2.8.3
build(deps): bump addressable from 2.8.2 to 2.8.3 in /Library/Homebrew
2023-04-06 08:42:08 +01:00
Mike McQuaid
104434c1d9
Merge pull request #15150 from muzimuzhi/tap-formula-file
Tighten `tap.formula_file?(file)` and `tap.formula_files` to not detect cask file as formula
2023-04-06 08:37:50 +01:00
Razvan Azamfirei
22eb43ca37
syntax fix 2023-04-05 20:07:58 -04:00
Razvan Azamfirei
acc598fdc9
Update env_config.rb
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2023-04-05 19:29:57 -04:00
Razvan Azamfirei
87b4f1f396
Update env_config.rb 2023-04-05 19:26:20 -04:00
Issy Long
d636d2de37
Apply suggestions from review comments
- Rename `strictish` to `strict_only` in `add_error` method.
- Return just `errors`, a Set, not `{ errors: errors }`, a Hash,
  from `Auditor.audit`.
2023-04-06 00:10:28 +01:00
Yukai Chou
0cfc4ab1e8 fixup! avoid duplicating logic 2023-04-06 05:03:56 +08:00
Yukai Chou
16c81d7a55 tighten tap.formula_files similarly 2023-04-06 05:00:21 +08:00
Yukai Chou
1098cb6a7d avoid duplicating logic 2023-04-06 04:59:55 +08:00
Carlo Cabrera
d1b782fd68
github_runner_matrix: simplify 2023-04-06 03:33:34 +08:00
BrewTestBot
e7e80ad8af
Update RBI files for addressable.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
2023-04-05 19:10:42 +00:00
BrewTestBot
60ae89c245
brew vendor-gems: commit updates. 2023-04-05 19:04:35 +00:00
dependabot[bot]
bd94eab349
build(deps): bump addressable from 2.8.2 to 2.8.3 in /Library/Homebrew
Bumps [addressable](https://github.com/sporkmonger/addressable) from 2.8.2 to 2.8.3.
- [Release notes](https://github.com/sporkmonger/addressable/releases)
- [Changelog](https://github.com/sporkmonger/addressable/blob/main/CHANGELOG.md)
- [Commits](https://github.com/sporkmonger/addressable/compare/addressable-2.8.2...addressable-2.8.3)

---
updated-dependencies:
- dependency-name: addressable
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-04-05 18:58:03 +00:00
Carlo Cabrera
87373ff12a
Move more code out of dev-cmd 2023-04-06 02:13:15 +08:00
Douglas Eichelberger
200b5cad6a Minor YARD improvements 2023-04-05 10:06:45 -07:00
Carlo Cabrera
ffcc4cd75f
Merge remote-tracking branch 'origin/master' into test-runners 2023-04-05 23:55:01 +08:00
Mike McQuaid
61efc7076d
Merge pull request #15156 from dduugg/enable-types 2023-04-05 15:43:53 +01:00
Razvan Azamfirei
28490626fd
style fixes 2023-04-05 09:44:32 -04:00
Razvan Azamfirei
183fad82a6
add greedy option 2023-04-05 09:28:15 -04:00
Mike McQuaid
79edc3b5da
Merge pull request #15158 from MikeMcQuaid/coretap_installed 2023-04-05 11:41:11 +01:00
Mike McQuaid
e12ca4cee6
Merge pull request #15152 from dduugg/version-compare 2023-04-05 11:40:03 +01:00
Mike McQuaid
3404767cd0
Merge pull request #15154 from apainintheneck/cop-to-prevent-bin-in-service-blocks 2023-04-05 11:35:33 +01:00
Mike McQuaid
0eb6c63140
Merge pull request #15157 from dduugg/block-types 2023-04-05 11:34:18 +01:00
Mike McQuaid
61eec0002d
tap: remove some CoreTap installed? checks.
We should be using the API unless specifically requested not to.

Fixes #15153.
2023-04-05 09:19:20 +01:00
Mike McQuaid
1c87b8e67a
Merge pull request #15148 from ZhongRuoyu/commands-command_description
commands: explain change in command description splitting
2023-04-05 09:01:42 +01:00
Ruoyu Zhong
c7f3e72e6b
commands: make the description splitting pattern a constant 2023-04-05 15:16:38 +08:00
Douglas Eichelberger
47ffcd5cb7 Add types to block params 2023-04-04 22:42:27 -07:00
Douglas Eichelberger
c5ffec1a11 Enable types in dev-cmd, etc. 2023-04-04 22:23:46 -07:00
apainintheneck
70451ea7b1 Add cop to stop bin in service block
The preferred method is opt_bin because that works
with the API and is more portable (works between versions).

Also removed the last example from the docs of `bin/"name"`
from the service block section
2023-04-04 20:00:30 -07:00
Douglas Eichelberger
ba2d18db36 brew style --fix 2023-04-04 18:14:54 -07:00
Douglas Eichelberger
c0092c2fd2 Move and re-namespace HeadVersion 2023-04-04 18:14:54 -07:00
Douglas Eichelberger
a237a1ff9f Update call sites 2023-04-04 18:14:54 -07:00
Douglas Eichelberger
29f93fb6f2 Add tests 2023-04-04 18:14:54 -07:00
Douglas Eichelberger
0ca4f7eebb Add Version#compare 2023-04-04 18:14:54 -07:00
Carlo Cabrera
0c56540831
Fix --dependents breakage
Without this, we sometimes mistakenly assign runners to dependents jobs
when we don't have to.
2023-04-05 04:25:28 +08:00
Carlo Cabrera
868f9395b6
Extract code to GitHubRunnerMatrix class
The `GitHubRunnerMatrix` takes a list of testing formulae, deleted
formulae, and the available runners and constructs the matrix of active
runners for any given test job.
2023-04-05 03:52:26 +08:00
Yukai Chou
b1b94187af tap: tighten formula_file?(file)
Cask is never a formula.
2023-04-05 03:41:11 +08:00
Mike McQuaid
97d7a5c9b4
Merge pull request #15137 from Homebrew/dependabot/bundler/Library/Homebrew/parser-3.2.2.0
build(deps): bump parser from 3.2.1.1 to 3.2.2.0 in /Library/Homebrew
2023-04-04 18:46:11 +01:00
Carlo Cabrera
49e8d088ae
Move TestRunnerFormula class into a separate file 2023-04-05 01:18:11 +08:00
Carlo Cabrera
26726adc21
determine-test-runners: refactor
This supports extraction into separate modules/files.
2023-04-05 01:09:56 +08:00
Issy Long
53a17b921f
Make --display-failures-only help hidden as it's deprecated
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2023-04-04 17:17:19 +01:00
Issy Long
7cfa544aec
cask/utils: Make more noise when encountering undefined methods
- https://github.com/Homebrew/homebrew-cask/actions/runs/4608585102/jobs/8144571098
  introduced syntax errors for the `mattermost` cask (`autoupdates`
  instead of `auto_updates`), but CI didn't fail so we didn't notice
  until it shipped to users and broke `brew update`.
2023-04-04 17:08:54 +01:00
Carlo Cabrera
5194e5c65e
Check for --eval-all before using HOMEBREW_EVAL_ALL 2023-04-05 00:03:58 +08:00
Mike McQuaid
41e7ee7b51
Merge pull request #15125 from issyl0/rubocops-cask-verified-url-with-path-ending-slash
rubocops/cask: Ensure that "verified" URLs with paths end with "/"
2023-04-04 16:30:09 +01:00
Issy Long
7bb20a3b83
Skip if the URL stanza has only two path components
https://github.com/Homebrew/homebrew-cask-fonts/pull/7336#discussion_r1156325651
2023-04-04 16:11:44 +01:00
Carlo Cabrera
a4ebb96fe6
Remove MacOS definition from generic OS
We don't want to define `MacOS` in the generic OS, so let's make sure we
refer to it as `OS::Mac` in the places we need it.

This reverts commit 575cb0263cb1428c63b9428bbd913ffde83bd317.
2023-04-04 23:10:51 +08:00
Ruoyu Zhong
5c9e073cd5
commands: fix completion descriptions for shell commands too
This was missed in #15146.

Signed-off-by: Ruoyu Zhong <zhongruoyu@outlook.com>
2023-04-04 23:04:13 +08:00
Ruoyu Zhong
4305443c9c
commands: explain change in command description splitting
A comment here would help the reader to understand the need for this
splitting logic, which is not so straightforward.

Addresses review comment in
https://github.com/Homebrew/brew/pull/15146#discussion_r1157361656.

Signed-off-by: Ruoyu Zhong <zhongruoyu@outlook.com>
2023-04-04 22:50:40 +08:00
Mike McQuaid
0048a86673
Merge pull request #15135 from Homebrew/dependabot/bundler/Library/Homebrew/addressable-2.8.2
build(deps): bump addressable from 2.8.1 to 2.8.2 in /Library/Homebrew
2023-04-04 15:37:46 +01:00