4756 Commits

Author SHA1 Message Date
Bo Anderson
32d532fb49
cmd/list: fix Cask listing 2021-03-22 16:21:02 +00:00
Bo Anderson
d14a0bb131
Remove FormulaInstaller.prevent_build_flags 2021-03-22 16:11:27 +00:00
Bo Anderson
25373a18cc
Merge pull request #10880 from Bo98/cli-stronger-types
Stricter handling of CLI args
2021-03-22 14:13:01 +00:00
Carlo Cabrera
a88d65acc7
cmd/list: list casks only if one is installed 2021-03-22 14:12:42 +00:00
Carlo Cabrera
8538970567
cmd/list: delineate formulae and casks
Listing everything without qualifying which is which is confusing for
some users.

Fixes #10897.
2021-03-22 13:13:04 +00:00
Mike McQuaid
5588b6750c
Merge pull request #10885 from dkav/quiet-update
Replace tab with spaces and align indent
2021-03-19 09:38:23 +00:00
Darren Kavanagh
40d09f59b6
Replace tab with spaces and align indent 2021-03-18 11:31:42 -07:00
Bo Anderson
8e98ce69f3
Stricter handling of CLI args 2021-03-18 16:41:57 +00:00
Bo Anderson
20ff68a425
Fix brew style. 2021-03-17 20:45:44 +00:00
Darren Kavanagh
b66b461811
Expand quiet checks in update and update-report 2021-03-13 10:08:06 -08:00
Mike McQuaid
dc1fdc9f8d
Speedup brew --version.
Port `brew --version` to Bash to speed it up.

While we're here:
- remove (now) unused `Tap` Git methods
- use `--quiet` instead of `-q` to be more verbose

Benchmarks:
```
$ hyperfine --min-runs=3 --warmup=2 "git checkout origin/master; brew --version" "git checkout speedup_brew_version; brew --version"
Benchmark #1: git checkout origin/master; brew --version
  Time (mean ± σ):      2.083 s ±  0.004 s    [User: 396.8 ms, System: 597.2 ms]
  Range (min … max):    2.080 s …  2.088 s    3 runs

Benchmark #2: git checkout speedup_brew_version; brew --version
  Time (mean ± σ):     847.9 ms ±  35.2 ms    [User: 100.0 ms, System: 247.9 ms]
  Range (min … max):   824.1 ms … 888.3 ms    3 runs

Summary
  'git checkout speedup_brew_version; brew --version' ran
    2.46 ± 0.10 times faster than 'git checkout origin/master; brew --version'
```
2021-03-04 12:59:42 +00:00
Mike McQuaid
ca47b47f77
Speedup brew --prefix <formula>
This case is _really_ slow even although it's something we encourage
people to run often and build systems often do. The `brew --prefix`
case is really fast because it's just in Bash so: let's pull the
`brew --prefix <formula>` case into Bash too.

This doesn't handle any edge-cases like `--installed` and the formula
detection is pretty simple.

Also, to make this behaviour consistent, never output `Cellar` paths
from the (Ruby) `brew --prefix`; we never want people relying on the
Cellar paths anyway, only output them if the formula wasn't installed
(where, arguably, using a Cellar path is even worse) and the speedup is
worth this deviation in behaviour.
2021-02-25 17:07:28 +00:00
Jonathan Chang
538b6d1a52
Merge pull request #10678 from jonchang/fix-cask-info
cmd/info: fix `brew info --cask` on Linux
2021-02-24 14:06:40 +11:00
Seeker
880a82d21a
uninstall: delete references to unused --binaries flag 2021-02-22 19:48:43 -08:00
Jonathan Chang
90db84242f cmd/info: fix brew info --cask on Linux
We should be able to provide info on casks even if installing
casks isn't supported on Linux.
2021-02-23 13:42:38 +11:00
Dustin Rodrigues
81e3aa899d
update-report: use appropriate pronoun in update message 2021-02-19 11:58:01 -05:00
nandahkrishna
f7c8810214
utils/github/api: remove 'api' from method names 2021-02-17 23:47:05 +05:30
nandahkrishna
56e0c3d9e8
Update GitHub API usage 2021-02-15 22:38:27 +05:30
nandahkrishna
8e5451df2f
style: use parentheses for assignment in conditions 2021-02-12 18:33:37 +05:30
Mike McQuaid
f9b4b69f27
Merge pull request #10575 from nandahkrishna/dependent-cask-check
cmd/uninstall: check for dependent casks
2021-02-12 10:55:38 +00:00
Bo Anderson
0e732d3917 cmd/update-report: report outdated count & suggest brew upgrade 2021-02-10 15:36:38 +00:00
nandahkrishna
7965ad6160
cmd/uninstall: check for dependent casks 2021-02-09 08:47:11 +05:30
Mike McQuaid
72cb6ffd12
utils: import {ohai,puts}_stdout_or_stderr
Fixes #10536
2021-02-05 15:03:31 +00:00
Mike McQuaid
e98a913783
Merge pull request #10501 from MikeMcQuaid/update-stderr
cmd/update-report: output to stderr when not a TTY.
2021-02-05 12:15:30 +00:00
Mike McQuaid
6bf4cf06e7
Merge pull request #10489 from carlocab/unbrewed
cmd/--prefix: ignore shared-mime-info and mactex
2021-02-05 08:54:12 +00:00
Dawid Dziurla
a90fb27adb
untap: add missing --force switch 2021-02-04 18:36:32 +01:00
Mike McQuaid
dbf65770af
cmd/update-report: output to stderr when not a TTY.
Otherwise things like `$(brew bundle list --formula)` become a bit
useless as they can auto-update and then will always fail.
2021-02-03 13:31:24 +00:00
Carlo Cabrera
7dd69d2c94
cmd/--prefix: ignore shared-mime-info and mactex
The shared-mime-info formula and the mactex cask currently install into
locations that are picked up by `brew --prefix --unbrewed`. This leads
to a very large number of files being found.

Before:
```
❯ brew --prefix --unbrewed | wc -l
206735
```

After
```
❯ brew --prefix --unbrewed | wc -l
3
```
2021-02-02 17:33:54 +00:00
Mike McQuaid
cdf8ff9052
Merge pull request #10266 from gromgit/prefix_non_installed
cmd/--prefix: add --installed flag
2021-02-01 09:05:28 +00:00
Adrian Ho
28a8409b6e cmd/--prefix: add --installed flag
This changes the output for uninstalled formulae from Cellar prefix to empty string, so:
```sh
$ brew --prefix abcde python@3.9 tcl-tk
/usr/local/Cellar/abcde/2.9.3_1
/usr/local/opt/python@3.9
/usr/local/Cellar/tcl-tk/8.6.10
$ brew --prefix --installed abcde python@3.9 tcl-tk

/usr/local/opt/python@3.9

$
```
2021-01-31 16:09:43 +08:00
Mike McQuaid
d6957a3acb
Homebrew 3.0.0 deprecations/disables 2021-01-29 19:50:24 +00:00
Rylan Polster
84fc16c1c1
Apply suggestions from code review
Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com>
2021-01-28 09:10:14 -05:00
Rylan Polster
f508f8dc0c
update: show message prompting brew tap --repair
This message is shown when a fetch fails due to a branch rename
2021-01-28 09:10:13 -05:00
Rylan Polster
4bdc11ddc9
tap: fix renamed branches with brew tap --repair 2021-01-28 09:10:13 -05:00
Jonathan Chang
69ecbc3979 cmd/cache: conflict with cask 2021-01-27 14:54:39 +11:00
EricFromCanada
6fc116318e fixes for grammar and wording 2021-01-26 16:19:47 -05:00
EricFromCanada
2ed324ebc0 use backticks around suggested input, flags, and binaries 2021-01-26 16:19:47 -05:00
EricFromCanada
cd3cb6928b indent suggested commands on subsequent line
and combine sequential puts calls
2021-01-26 15:36:44 -05:00
EricFromCanada
2ae4f11963 reorder command flags 2021-01-26 15:36:44 -05:00
EricFromCanada
a427de5bee capitalization fixes
"curl" is the binary, while "cURL" is the umbrella project.
2021-01-26 15:36:44 -05:00
EricFromCanada
2e982cd2a2 use odie when commands encounter errors 2021-01-26 15:36:43 -05:00
EricFromCanada
f5e1557154 use ofail to set Homebrew.failed 2021-01-26 15:36:43 -05:00
EricFromCanada
571179ff0e pass second argument to ohai when applicable 2021-01-26 15:36:43 -05:00
Mike McQuaid
703e34f85c
Merge pull request #10420 from vszakats/patch-1
cmd/update: suppress curl warnings in certain envs
2021-01-26 10:21:23 +00:00
Viktor Szakats
89eecedbbb
cmd/update: suppress curl warning in certain envs
Specifically the warning:
`Failed to set filetime <unixtime> on outfile: Operation not permitted`
when the user's `.curlrc`  contains `--remote-time` and the server 
returned a `Last-Modified:` header, like in case of the GitHub API.
2021-01-25 19:58:41 +01:00
Rylan Polster
67e03a0675
Improve command descriptions
Co-Authored-By: Jonathan Chang <me@jonathanchang.org>
Co-Authored-By: Eric Knibbe <3324775+EricFromCanada@users.noreply.github.com>
2021-01-25 13:46:51 -05:00
Rylan Polster
7f23b55c5e
Cleanup command descriptions
Don't have a period within first full sentence of the description
2021-01-25 13:46:35 -05:00
Seeker
9a99c40e37
Fix remaining broken cask options in upgrade 2021-01-22 13:52:42 -08:00
António Meireles
19f41bddfd Properly allow quarantine in 'upgrade'
issue was raised in #9139 for upgrade/reinstall --cask and was then
closed by #10284. Issue is that #10284 only actually fixed the reinstall
command, leaving behindd the 'upgrade' one which this now fixes.

Signed-off-by: António Meireles <antonio.meireles@reformi.st>
2021-01-22 17:39:19 +00:00
Mike McQuaid
2268e774a4
Merge pull request #10301 from hyuraku/cmd/cleanup_add_desc_about_all_to_prune
cmd/cleanup: add description about all to --prune
2021-01-22 14:57:13 +00:00