38364 Commits

Author SHA1 Message Date
Mike McQuaid
5d8390014f
Merge pull request #15745 from dduugg/formula-attr-types
Add types to Formula attrs
2023-07-25 08:20:40 +01:00
Douglas Eichelberger
a4ca2b9e0b remove unnecessary casts 2023-07-24 22:08:52 -07:00
Douglas Eichelberger
b5c145cfa9 Add init sig as well 2023-07-24 14:12:47 -07:00
Douglas Eichelberger
08e46c18cd Add type to Formula attrs 2023-07-24 14:12:36 -07:00
Mike McQuaid
11b17f80d5
Merge pull request #15743 from Homebrew/macos_signing
Add package signing configuration for GitHub Actions
2023-07-24 17:25:25 +01:00
TETRA2000
051d7ec4f7
Add package signing configuration for GitHub Actions
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
2023-07-24 17:10:31 +01:00
Mike McQuaid
62e54c3387
Merge pull request #15693 from EricFromCanada/assume-untapped
docs: assume core repositories are untapped
2023-07-24 15:20:01 +01:00
Mike McQuaid
4e168a1588
Merge pull request #15744 from dduugg/formula-type-fix
Fix type error when running 'brew doctor'
2023-07-24 15:19:09 +01:00
Douglas Eichelberger
479ca5e314 Fix test 2023-07-24 07:01:57 -07:00
Douglas Eichelberger
a46430a390 Fix type error when running 'brew doctor' 2023-07-24 07:00:26 -07:00
Eric Knibbe
b6c49b7a2d
docs: assume core repositories are untapped 2023-07-24 09:55:56 -04:00
Carlo Cabrera
1ded074734
Merge pull request #15731 from carlocab/better-rpath-handling
extend/os/mac/keg_relocate: improve rpath handling
2023-07-24 21:53:32 +08:00
Mike McQuaid
3b3300546b
Merge pull request #15741 from dduugg/stict-type-string_inreplace_extension 4.1.1 2023-07-24 08:40:46 +01:00
Mike McQuaid
3980bc9c1e
Merge pull request #15736 from Bo98/pr-pull-branch-warn-fix 2023-07-24 08:35:29 +01:00
Douglas Eichelberger
11bb278284 Support Pathname as second arg to gsub! 2023-07-23 21:14:21 -07:00
Douglas Eichelberger
6d53c52d2c Add sigs to Formula boolean methods 2023-07-23 21:05:02 -07:00
Carlo Cabrera
b1169d58a1
Merge pull request #15742 from branchvincent/std_pip_args
formula: fix `std_pip_args` with empty prefix
2023-07-24 11:56:00 +08:00
Branch Vincent
b7775fa007
formula: fix std_pip_args with empty prefix 2023-07-23 20:35:44 -07:00
Douglas Eichelberger
cec3daf6be Fix type regression 2023-07-23 19:48:48 -07:00
apainintheneck
c9dea04bd4 cmd/install: upgrade already installed casks
Previously, the behavior was to warn users that a cask was already
installed and then skip modifying the installed version. This is
different to how we handled things with formulas. For them we would
upgrade any already installed formulas. This just brings casks in line
with what we already do with formulas.

Changes:
- cmd/install: Upgrade already installed casks if HOMEBREW_NO_INSTALL_UPGRADE
  is not set
- env_config: Update wording of HOMEBREW_NO_INSTALL_UPGRADE to include casks
- remove error that was only used to alert about already installed casks

Note:
- The upgrade command for casks defaults to --greedy when you pass named casks
  to the command which means that this will always default to that behavior
  since you must specify the name of the cask when installing.
2023-07-23 18:50:39 -07:00
Douglas Eichelberger
09885cad3a Add sigs to Formula pathname methods 2023-07-23 18:42:06 -07:00
Douglas Eichelberger
c7369b7ea9 Strict type string_inreplace_extension 2023-07-23 15:56:26 -07:00
Eric Knibbe
0e8d1e0bec
Merge pull request #15737 from EricFromCanada/tap-remote-repair
cmd/tap: ensure remote exists before repairing
2023-07-23 14:27:41 -04:00
Carlo Cabrera
bf2b99e770
Merge pull request #15739 from carlocab/inreplace-typecheck
utils/inreplace: fix typechecking error
2023-07-23 18:40:45 +08:00
Carlo Cabrera
fa384b7cc3
utils/inreplace: fix typechecking error
Fixes

        TypeError: Parameter 'before': Expected type T.nilable(T.any(Regexp, String)), got type Pathname with value #<Pathname:/opt/homebrew/Cellar/php@8.1/8.1.21/lib/php>
      Caller: /opt/homebrew/Library/Homebrew/formula.rb:2484
      Definition: /opt/homebrew/Library/Homebrew/utils/inreplace.rb:48

https://github.com/Homebrew/homebrew-core/actions/runs/5635089949/job/15266014851#step:3:1737
2023-07-23 18:23:04 +08:00
Carlo Cabrera
7cc79eaff4
Merge pull request #15738 from carlocab/inreplace-typecheck
formula: fix `inreplace` typechecking error
2023-07-23 15:37:11 +08:00
Carlo Cabrera
a1bf42cc89
formula: fix inreplace typechecking error
Fixes

        TypeError: Parameter 'before': Expected type T.nilable(T.any(Regexp, String)), got type Pathname with value #<Pathname:/opt/homebrew/Cellar/php/8.2.8/lib/php>
      Caller: /opt/homebrew/Library/Taps/homebrew/homebrew-core/Formula/php.rb:207
      Definition: /opt/homebrew/Library/Homebrew/formula.rb:2483

https://github.com/Homebrew/homebrew-core/actions/runs/5635089949/job/15265751616?pr=137335#step:3:1732
2023-07-23 15:23:45 +08:00
EricFromCanada
d47aa103d2
cmd/tap: ensure remote exists before repairing 2023-07-23 00:42:09 -04:00
Eric Knibbe
fe7aa4b614
Merge pull request #15732 from EricFromCanada/create-require-version
formula_creator: require version before creating
2023-07-23 00:20:59 -04:00
EricFromCanada
ca3fe811de
formula_creator: require version before creating 2023-07-23 00:05:43 -04:00
Bo Anderson
9235024131
dev-cmd/pr-pull: fix branch warning conditions 2023-07-22 22:41:51 +01:00
Bo Anderson
3dcf3db07d
Merge pull request #15727 from Homebrew/sorbet-files-update
sorbet: Update RBI files.
2023-07-22 22:32:36 +01:00
Bo Anderson
ccde121c55
sorbet: fix ActiveSupport RBI 2023-07-22 22:00:29 +01:00
Bo Anderson
35865e7976
Merge pull request #15735 from Bo98/ghp-force-oci
github_packages: ensure only OCI format is uploaded
2023-07-22 20:04:00 +01:00
Bo Anderson
d5a780d5b3
github_packages: ensure only OCI format is uploaded 2023-07-22 19:45:18 +01:00
Carlo Cabrera
b5d13ce68d
Merge pull request #15734 from carlocab/cmake-args-typecheck
formula: fix typechecking error in `std_cmake_args`
2023-07-23 02:09:00 +08:00
Carlo Cabrera
d0b0fa5421
formula: fix typechecking error in std_cmake_args
`install_libdir` is sometimes passed a `Pathname`.
2023-07-23 01:52:58 +08:00
Carlo Cabrera
b56e2714cb
Merge pull request #15733 from dduugg/gsub-fix
Gsub fix
2023-07-23 01:37:12 +08:00
Douglas Eichelberger
af5cdd1590 Allow implicit String Pathname in gsub 2023-07-22 10:20:52 -07:00
Carlo Cabrera
4c73942fae
extend/os/mac/keg_relocate: improve rpath handling
This implements the TODO that I left as a comment from #15722.

In order to simplify the handling of deleting an absolute rpath that has
a relative duplicate (or vice-versa, i.e., a relative rpath with an
absolute duplicate), we relocate all rpaths first in one pass and then
delete the duplicates in a separate pass.

We currently rely on some lower-level (but still public) methods from
ruby-macho since the standard `#delete_rpath` method changes the order
in which rpaths are resolved. We can switch back to using
`#delete_rpath` when Homebrew/ruby-macho#555 is merged and released.
2023-07-23 00:22:05 +08:00
Carlo Cabrera
aa74840dc4
Merge pull request #15729 from dduugg/inreplace-sig 2023-07-22 13:01:19 +08:00
Douglas Eichelberger
f55c2a4e8e Fix type error 2023-07-21 20:09:00 -07:00
Douglas Eichelberger
11a9086b89 Fix inreplace sig
Implicit Pathname strings strike again
2023-07-21 20:02:59 -07:00
BrewTestBot
8d9afc8bb0
sorbet: Update RBI files.
Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow.
2023-07-22 00:29:35 +00:00
Bo Anderson
5226cd4344
Merge pull request #15726 from elopez/deparallelize-fix
extend/ENV/super: correct `deparallelize` signature
2023-07-21 21:32:28 +01:00
Emilio López
5b042b8641 extend/ENV/super: correct deparallelize signature
The block is optional, so it should be marked `T.nilable`
2023-07-21 16:46:32 -03:00
Razvan Azamfirei
c64c834d05
bump-cask-pr: add arch-specific version support 2023-07-21 11:45:34 -04:00
Carlo Cabrera
3fee251765
Merge pull request #15724 from carlocab/pr-upload-typecheck
dev-cmd/pr-pull: fix typechecking error
2023-07-21 22:31:56 +08:00
Carlo Cabrera
45171dde8d
dev-cmd/pr-pull: fix typechecking error
Fixes

    Error: uninitialized constant Formulary::Formula

https://github.com/Homebrew/homebrew-core/actions/runs/5622415532/job/15237499429#step:8:132
2023-07-21 22:18:00 +08:00
Mike McQuaid
3a290b21b1
Merge pull request #15705 from Homebrew/revert-15385-revert-sorbet-again
Enable HOMEBREW_SORBET_RUNTIME (sometimes)
2023-07-21 13:24:14 +01:00