30713 Commits

Author SHA1 Message Date
Michael Cho
2b58d9d9a1
formula: allow changing std_configure_args prefix 2023-12-20 10:08:27 -05:00
Mike McQuaid
4d93a50ad6
Merge pull request #16364 from cho-m/pybuild-rubocopy
rubocops/lines: consistency with single non-runtime Python
2023-12-20 11:57:17 +00:00
Ilya Kulakov
907da26e33 sudo: Prioritize sudo_as_root over HOMEBREW_SUDO_THROUGH_SUDO_USER. 2023-12-19 22:39:44 -08:00
Rylan Polster
f61ef4be2f
Merge pull request #16351 from Rylan12/rubocop-for-cask-discontinued
Create rubocop requiring `deprecate!` over `discontinued` for casks
2023-12-19 21:00:58 -05:00
Rylan Polster
841a0623c6
Don't have a comment saying to remove this cop 2023-12-19 20:47:20 -05:00
Michael Cho
326774faee
utils/pypi: use python from formula
Sometimes the Python dependency tree will be impacted by the exact
version of Python being used (most commonly relating to functionality
provided/missing from stdlibs like `importlib-metadata` and `tomllib`)
2023-12-19 20:09:09 -05:00
Issy Long
8cf58e36e6
Add a new RuboCop for alphabetizing zap trash array elements
- Part of issue 16323.
- Previously this was being done manually by Cask maintainers.
- While we're here, enforce that the `zap trash` path is not in `[]` if
  it only contains a single element.
- This is buggy on actual Casks, hence the draft PR.
2023-12-19 23:42:08 +00:00
Michael Cho
61b512c72c
rubocops/lines: consistency with single non-runtime Python 2023-12-19 15:20:45 -05:00
Mike McQuaid
23ce2d5bf8
Merge pull request #16362 from Homebrew/dependabot/bundler/Library/Homebrew/tapioca-0.11.14
build(deps-dev): bump tapioca from 0.11.13 to 0.11.14 in /Library/Homebrew
2023-12-19 18:05:34 +00:00
BrewTestBot
2343f500c1
Update RBI files for rdiscount.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
2023-12-19 17:51:21 +00:00
BrewTestBot
d41dfb328c
Update RBI files for tapioca.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
2023-12-19 17:50:12 +00:00
BrewTestBot
c96e162172
brew vendor-gems: commit updates. 2023-12-19 17:45:51 +00:00
BrewTestBot
4fb44306fd
brew vendor-gems: commit updates. 2023-12-19 17:44:22 +00:00
dependabot[bot]
91b9f6c83d
build(deps-dev): bump rdiscount in /Library/Homebrew
Bumps [rdiscount](https://github.com/davidfstr/rdiscount) from 2.2.7.1 to 2.2.7.2.
- [Changelog](https://github.com/davidfstr/rdiscount/blob/master/CHANGELOG.md)
- [Commits](https://github.com/davidfstr/rdiscount/compare/2.2.7.1...2.2.7.2)

---
updated-dependencies:
- dependency-name: rdiscount
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-12-19 17:41:24 +00:00
dependabot[bot]
c8e89eee2e
build(deps-dev): bump tapioca in /Library/Homebrew
Bumps [tapioca](https://github.com/Shopify/tapioca) from 0.11.13 to 0.11.14.
- [Release notes](https://github.com/Shopify/tapioca/releases)
- [Commits](https://github.com/Shopify/tapioca/compare/v0.11.13...v0.11.14)

---
updated-dependencies:
- dependency-name: tapioca
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-12-19 17:41:15 +00:00
Mike McQuaid
38c5e52a6d
Merge pull request #16358 from Homebrew/dependabot/bundler/Library/Homebrew/rubocop-performance-1.20.0
build(deps-dev): bump rubocop-performance from 1.19.1 to 1.20.0 in /Library/Homebrew
2023-12-19 12:01:48 +00:00
Akihiro Suda
009318dcaf
cleaner: remove *.tbd
For https://github.com/Homebrew/brew/pull/16355#issuecomment-1860642797

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2023-12-19 19:05:28 +09:00
Patrick Linnane
9dee80cb2d
various: fix style errors 2023-12-18 09:34:01 -08:00
BrewTestBot
f04d777c85
Update RBI files for rubocop-performance.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
2023-12-18 17:09:12 +00:00
BrewTestBot
5c01bc34d3
brew vendor-gems: commit updates. 2023-12-18 17:03:04 +00:00
dependabot[bot]
311b268340
build(deps-dev): bump rubocop-performance in /Library/Homebrew
Bumps [rubocop-performance](https://github.com/rubocop/rubocop-performance) from 1.19.1 to 1.20.0.
- [Release notes](https://github.com/rubocop/rubocop-performance/releases)
- [Changelog](https://github.com/rubocop/rubocop-performance/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-performance/compare/v1.19.1...v1.20.0)

---
updated-dependencies:
- dependency-name: rubocop-performance
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-12-18 16:59:59 +00:00
BrewTestBot
5636457248
Update RBI files for rubocop-rails.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
2023-12-18 16:33:14 +00:00
BrewTestBot
7b9b49d11f
brew vendor-gems: commit updates. 2023-12-18 16:29:36 +00:00
dependabot[bot]
aa09726d00
build(deps-dev): bump rubocop-rails in /Library/Homebrew
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails) from 2.22.2 to 2.23.0.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases)
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.22.2...v2.23.0)

---
updated-dependencies:
- dependency-name: rubocop-rails
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-12-18 16:26:45 +00:00
Bo Anderson
b72421e258
Merge pull request #16352 from Rylan12/fix-cask-discontinued-api-generation
Re-add some `discontinued?` checks for casks
2023-12-18 01:42:21 +00:00
Rylan Polster
fe74f5925a
Merge pull request #16353 from Homebrew/sorbet-files-update
sorbet: Update RBI files.
2023-12-17 20:38:03 -05:00
BrewTestBot
1359ebc025
sorbet: Update RBI files.
Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow.
2023-12-18 00:27:17 +00:00
Rylan Polster
25b753fe51
Re-add some discontinued? checks for casks 2023-12-17 19:07:37 -05:00
Eric Knibbe
4259e2ad96
cmd/bump: indicate deprecated or skipped formulae/casks 2023-12-17 16:50:02 -05:00
Rylan Polster
8d8cd23414
Add rubocop to enforce deprecate! over discontinued 2023-12-17 16:49:53 -05:00
Rylan Polster
254fcf7c1f
Update livecheck test fixtures to use deprecate! and disable! 2023-12-17 16:31:04 -05:00
Rylan Polster
4793677123
Merge pull request #16292 from Rylan12/cask-deprecate-disable
Add `deprecate!` and `disable!` to casks
2023-12-17 15:03:39 -05:00
Mike McQuaid
fb7f1a2c4d
Merge pull request #16349 from unshare/homepage-ua
Work around recent Akamai/Microsoft issues
2023-12-17 15:58:01 +00:00
Mike McQuaid
4776c191da
Merge pull request #16345 from razvanazamfirei/update-cask-documentation
create: modify cask template
2023-12-17 15:34:44 +00:00
Issy Long
7e328d8f0a
Merge pull request #16346 from issyl0/dont-forget-about-rubocop-comments
Fix new `Style/MutableConstant` RuboCop offenses for Ruby 3.1
2023-12-17 10:58:33 +00:00
Rylan Polster
c21b8bd68a
Fix deprecation message
Co-authored-by: Bo Anderson <mail@boanderson.me>
2023-12-16 23:10:20 -05:00
Rylan Polster
6431822e7b
Apply feedback 2023-12-16 20:18:35 -05:00
Rylan Polster
472dd95b16
Fix cask loading from the API
Co-authored-by: Kevin <apainintheneck@gmail.com>
2023-12-16 20:08:26 -05:00
Rylan Polster
c5f33aaf99
Load nil reasons from API correctly 2023-12-16 20:01:47 -05:00
Rylan Polster
40d3ab6a5d
Add tests and fix brew typecheck 2023-12-16 20:01:47 -05:00
Rylan Polster
7eb3f1a314
Replace discontinued? with deprecated? 2023-12-16 20:01:47 -05:00
Rylan Polster
53c1e6ecdb
Add deprecate! and disable! to cask stanza order 2023-12-16 20:01:47 -05:00
Rylan Polster
641a80475e
Update cask logic to handle deprecations and disables 2023-12-16 20:01:47 -05:00
Rylan Polster
036723a668
Add deprecate! and disable! methods to the Cask DSL 2023-12-16 20:01:46 -05:00
Valentin Kulesh
06155ff6e0
Work around recent Akamai/Microsoft issues
At the moment, Microsoft Office and related casks fail audit due to
failure to fetch a product homepage from the main Microsoft site
(https://www.microsoft.com/) served by Akamai CDN.
The failure is severe and weird: no status code is received as the
connection is reset.
The analysis revealed the issue is linked to `User-Agent` and
`Accept-Language` headers parsing. Homebrew uses involved user agent
strings and has language hardcoded as `en`.
The simplest workaround is to use a simple user agent string when checking
homepage availability if the cask is in an audit exceptions list.

Merging this would fix Microsoft Office updates (including
https://github.com/Homebrew/homebrew-cask/pull/162671)
2023-12-16 22:20:17 +03:00
Jeroen Ooms
29cf01d442 Fix workflow for duplicate names 2023-12-16 14:36:12 +01:00
Issy Long
149b0e4f31
Fix new Style/MutableConstant RuboCop offenses for Ruby 3.1
- A follow-up to de592af20bbff5bcb548d2474f0722e59ff1129a, resetting the previous disabled comments too.
2023-12-16 11:57:06 +00:00
Sam Ford
4a4f8cb2d2
FormulaAuditor: Add #committed_version_info method
The `#audit_stable_version` check was previously part of
`#audit_revision_and_version_scheme` and duplicates some of the
logic to identify previous version information. To avoid the
duplication, this extracts the logic into a `#committed_version_info`
method that can be called in both audits. The method stores the
information in instance variables, so we don't repeat the collection
process if it has already run.
2023-12-15 17:29:32 -05:00
Sam Ford
ccbde5952d
FormulaAuditor: Separate stable version audit
The "stable version should not decrease" formula audit currently
prevents us from being able to create bottles when downgrading a
formula version. We previously worked around this by bumping
`version_scheme` but this wasn't an intended use case and we now
avoid using it for this purpose.

We can handle simple formula downgrades by reverting changes in a
syntax-only PR but that isn't sufficient when we need new bottles
(i.e., if additional changes have been made to the formula in the
interim time). In the latter case, the only available solution may be
to revert all changes made after the previous version using a
syntax-only PR and then create another PR to reintroduce the other
changes and create new bottles.

To avoid the aforementioned approach, this splits the stable version
audit into a separate method, so we can use `brew audit
--except=stable_version` to selectively skip it.
2023-12-15 17:27:01 -05:00
Razvan Azamfirei
ae1c058f9b
create: modify cask template 2023-12-15 15:34:43 -05:00