4907 Commits

Author SHA1 Message Date
Jack Nagel
26a076eef5 upgrade: tighten installed precondition 2013-05-18 22:09:15 -05:00
Jack Nagel
277f3d3c30 Stop running "prune" as part of "cleanup"
Rationale: "prune" is slow, does not need to be run as often as
"cleanup", and is potentially destructive to things like empty
directories that Homebrew did not create. Thus we should let users run
`brew prune` only when they wish to, while still being able to use `brew
cleanup`.

Closes Homebrew/homebrew#19863.
2013-05-18 20:22:24 -05:00
Jack Nagel
2d8496129c Formula#fetch: always return the cached path
This allows us to remove some type checks that were protecting against
potential nils.
2013-05-16 14:06:26 -05:00
Jack Nagel
daef74aa27 Adjust semantics of Formula#fetch
It doesn't really make logical sense that this method returns both the
fetched path (or sometimes nil!) and the downloader, so just return the
path (again, or nil!) and callers that want the downloader can ask for
it separately.
2013-05-16 14:06:26 -05:00
Jack Nagel
a6f9a1c4a3 fetch: rename 'tarball' to 'download' 2013-05-16 14:06:26 -05:00
Jack Nagel
db0c93dbae fetch: use concat rather than << and flatten 2013-05-16 14:06:25 -05:00
Jack Nagel
903d640d38 Simplify uninstall --force 2013-05-15 22:27:30 -05:00
Jack Nagel
12b63fdd5c uninstall: stop assuming kegs always map to formulae 2013-05-15 22:19:58 -05:00
Jack Nagel
d3a8cb7803 cleanup: enable prune during dry-run mode
Closes Homebrew/homebrew#19826.
2013-05-15 12:57:02 -05:00
Jack Nagel
1197409c36 prune: add dry-run mode 2013-05-15 12:57:01 -05:00
Jack Nagel
f4dcdea64e cleanup: cleanup_all => cleanup_cellar 2013-05-15 12:57:01 -05:00
Jack Nagel
a9fcefda4e cleanup: refactor cleanup_cache 2013-05-15 12:57:01 -05:00
Jack Nagel
5b5bb57865 cleanup: rename variable 2013-05-15 12:57:00 -05:00
Jack Nagel
b26c502f79 cleanup: refactor cleanup_formula 2013-05-15 12:57:00 -05:00
Jack Nagel
87a8f9a6ae cleanup: only map dirs to kegs once 2013-05-15 12:57:00 -05:00
Jack Nagel
daf8c26108 cleanup: use Pathname#rmtree instead of FileUtils 2013-05-15 12:56:59 -05:00
Jack Nagel
b32310c3db cleanup: use subdirs, avoid .directory? checks 2013-05-15 12:56:59 -05:00
Jack Nagel
bf8bf2e1d1 cleanup: remove redundant condition
If f.installed? is true, f.rack.directory? will always be true as well.
2013-05-15 12:56:59 -05:00
Jack Nagel
0c35274bf4 cleanup: rename method for consistency 2013-05-15 12:56:58 -05:00
Jack Nagel
5515d359d5 cleanup: use early return rather than method-spanning conditional 2013-05-15 12:56:58 -05:00
Jack Nagel
8cd331718e cleanup: factor out unqualified cleanup code 2013-05-15 12:56:58 -05:00
Jack Nagel
c48ac0b982 Methods that end in _formula should only accept a formula 2013-05-15 12:56:57 -05:00
Jack Nagel
132e6a3a8e audit: fix version audit for Version subclasses
The version isn't redundant if a subclass of Version is specified.
2013-05-14 20:17:00 -05:00
Jack Nagel
8b763acc2a outdated: always do comparisons with a Formula as the receiver
It is possible for the object returned by Formula#version to be a
subclass of Version with special behavior, so we want to use that for
the comparison.
2013-05-14 20:11:48 -05:00
Jack Nagel
46f8be1d9e Use Hash#each_value rather than discarding key 2013-05-11 16:06:18 -05:00
Jack Nagel
1bf8fbfe9a info: simplify keg listing 2013-05-10 23:45:36 -05:00
Jack Nagel
2517969585 deps: fix --1 output
Fixes Homebrew/homebrew#17550.
Closes Homebrew/homebrew#19668.
2013-05-10 23:45:30 -05:00
Jack Nagel
e02d6f2500 info: improve dependency listing 2013-05-10 23:45:06 -05:00
Jack Nagel
f61a4f8893 doctor: update ruby version check 2013-05-07 19:45:10 -05:00
Jack Nagel
14bc883750 doctor: update git version check 2013-05-07 19:45:10 -05:00
Jack Nagel
66489b70d7 audit: only generate aliases list once 2013-05-07 18:40:14 -05:00
Jack Nagel
fedf9ddae3 audit: only set up the build environment once 2013-05-07 18:39:45 -05:00
Jack Nagel
9dd7672ae7 info: re-raise on blacklist miss 2013-05-02 21:34:48 -05:00
Adam Vandenberg
afd2dde474 --env: show HOMEBREW_CC in superenv
Closes Homebrew/homebrew#18247.
2013-05-02 11:36:30 -07:00
Adam Vandenberg
b163ed03e9 info: try blacklist for unknown formula names
Closes Homebrew/homebrew#17399.
2013-04-29 10:12:40 -07:00
Jack Nagel
9b5cb6cfb6 Allow brew versions to work with underspecified formulae 2013-04-27 14:44:48 -05:00
Jack Nagel
62db042277 audit: fix interpolation check
Fixes Homebrew/homebrew#19363.
2013-04-26 19:18:13 -05:00
Misty De Meo
f4cf04b95e doctor: don't shell out in coreutils check 2013-04-25 18:23:43 -05:00
Misty De Meo
814b969963 doctor: add default-names findutils check
Fixes Homebrew/homebrew#19265.
2013-04-25 18:23:43 -05:00
Jack Nagel
8a74e648e7 audit: warn about top-level methods 2013-04-22 15:19:03 -05:00
Jack Nagel
3a0726406b Add tests for FormulaPin and simplify implementation 2013-04-16 01:58:11 -05:00
Jack Nagel
010a1461f7 Avoid repeated interpolation here too 2013-04-14 23:48:20 -05:00
Adam Vandenberg
4daf0de435 Only prune taps if taps exist.
Closes Homebrew/homebrew#19192.
2013-04-14 09:35:16 -07:00
Jaime Marquínez Ferrándiz
adbd8cee6d New visualization for brew deps --tree
Closes Homebrew/homebrew#18835.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2013-04-13 20:32:45 -05:00
Jack Nagel
291977d823 Run tap --repair as part of prune
And by extension, `cleanup`.

Fixes Homebrew/homebrew#18658.
2013-04-13 17:23:14 -05:00
Jack Nagel
7f9bd7a067 doctor: 'raring' => 'ready'
It was pointed out that 'raring' is a rare word can be confusing to
non-native speakers.

Closes Homebrew/homebrew#18659, see that for details.
2013-04-12 19:32:23 -05:00
Jack Nagel
d25767b354 doctor: consolidate directory access checks
Also include a writability check for lib.

Closes Homebrew/homebrew#18571.
2013-04-12 19:32:02 -05:00
Jiang Xin
f30200890e versions: work for tapped formulae
brew versions is hardcoded to cd to HOMEBREW_REPOSITORY before running
git, and as such fails to report previous versions for any formulae
from a tapped repository.

Add two new private methods repository and entry_name to replace the
hardcoded HOMEBREW_REPOSITORY and formula path, and brew versions
work for both builtin and tapped formulae.

Closes Homebrew/homebrew#12356.
Closes Homebrew/homebrew#19069.

Reported-by: Misty De Meo <mistydemeo@gmail.com>
Suggested-by: Jack Nagel <jacknagel@gmail.com>
Signed-off-by: Jiang Xin <worldhello.net@gmail.com>
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2013-04-11 23:45:15 -05:00
Geoff Petrie
79c745cc76 doctor: suggest brew update in outdated warning
Closes Homebrew/homebrew#19106.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2013-04-11 02:12:59 -05:00
Jack Nagel
951b09b1c5 link: eliminate naked rescue 2013-04-10 12:02:35 -05:00