469 Commits

Author SHA1 Message Date
Dominyk Tiller
c7b0173688 doctor: tweak tmp sticky bit check 2015-11-04 12:53:31 +00:00
Dominyk Tiller
85469b99b1 doctor: fix typo
Fixes Homebrew/homebrew#45623.
2015-11-02 21:04:03 +00:00
Dominyk Tiller
7d0c57cc9e doctor: whitelist Paragon ExtFS dylib 2015-11-02 18:27:13 +00:00
Dominyk Tiller
8acac5aa71 doctor: unify chown messages
Closes Homebrew/homebrew#45398.
2015-10-30 18:42:19 +00:00
Ben White
f7e649831d doctor: Fix typo in uncommitted modifications warning message
Closes Homebrew/homebrew#45443.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
2015-10-29 13:34:36 +01:00
Martin Afanasjew
30cad0608f os: centralize check for pre-release OS X versions
Provide `OS::Mac.prerelease?` for pre-release checks and use it where
appropriate. This should simplify updating the test once a new OS X
release lands.

This also fixes a bug in `BuildError#dump`, where an empty warning
message was printed on El Capitan after a failed from-source build,
because the check there and the one in `check_for_unsupported_osx` were
out of sync.

Closes Homebrew/homebrew#45257.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-10-23 12:34:44 +01:00
Xu Cheng
ee332c4550 handle TapFormulaWithOldnameAmbiguityError
Closes Homebrew/homebrew#44705.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-10-08 16:02:33 +08:00
Dominyk Tiller
bdd27d7cc0 doctor: whitelist Paragon NTFS dylib
Closes Homebrew/homebrew#44542.
2015-10-02 23:43:14 +01:00
Charlie Egan
a90363b605 doctor: minor grammar correction: 'pluralize' breakage
Closes Homebrew/homebrew#44497.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
2015-10-02 19:06:05 +02:00
Xu Cheng
6b3704162f doctor: point Xcode download to App Store for El Capitan 2015-10-01 14:39:25 +08:00
Xu Cheng
6240e896b2 doctor: always print to stderr
This can help to solve the broken layout of doctor.out in brew gist-logs
2015-09-30 16:20:18 +08:00
Xu Cheng
30795ddc29 doctor: temporary add -R flag in chown instruction
Will replace it when we implemented `brew repair-permission`
2015-09-30 13:55:32 +08:00
Xu Cheng
ff132a9ddb doctor: add check_access_homebrew_repository 2015-09-30 13:54:04 +08:00
Xu Cheng
3c54d12cec doctor: official supporting El Capitan 2015-09-30 13:54:04 +08:00
Dominyk Tiller
359cdafb86 doctor: don't false-flag sdk with clt 2015-09-18 15:55:21 +01:00
Dominyk Tiller
722a43aabe doctor: add xcode 7 SDK check 2015-09-18 15:11:48 +01:00
Xu Cheng
c8efb05826 doctor: use Utils.git_available? instead of git? 2015-09-09 12:21:08 +08:00
Xu Cheng
bff03ee5ba doctor: use Homebrew.git_origin 2015-09-09 12:19:17 +08:00
Mike McQuaid
adc077f188 doctor: don't always fail on 10.11.
Do this just for Homebrew developers (and the bot) currently.
2015-09-07 15:06:11 +01:00
Xu Cheng
488aa19d8f doctor: use inject_file_list
Also simplify the condition branch by early return

Closes Homebrew/homebrew#43574.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-09-06 20:02:31 +08:00
Dominyk Tiller
c992749986 doctor: add system curl <10.7 check
Closes Homebrew/homebrew#43283.

Closes Homebrew/homebrew#43298.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
2015-08-26 23:56:10 +01:00
Dominyk Tiller
94bb92b4c1 doctor: add check for SSL_CERT_DIR
Closes Homebrew/homebrew#43154.

Closes Homebrew/homebrew#43277.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
2015-08-26 17:30:36 +01:00
Xu Cheng
a88c40b8c8 core file style update 2015-08-22 13:15:33 +08:00
Misty De Meo
727239e12f Merge bottle install without Xcode branch
Merge branch 'bottle_hooks'
2015-08-21 11:04:22 -07:00
William Woodruff
04a0b2aafe Mark TODO in brew doctor (future PR) 2015-08-21 11:02:33 -07:00
Baptiste Fontaine
8ba0fb9fcf unnecessary calls to .select simplified
These are minor perf optimizations.

Closes Homebrew/homebrew#43028.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
2015-08-18 00:18:22 +02:00
Baptiste Fontaine
3d7c38c736 doctor: suggest to install git if the system one is outdated
Closes Homebrew/homebrew#42934.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
2015-08-14 12:06:57 +02:00
Xu Cheng
ae0e270727 favor flat_map over map...flatten 2015-08-06 22:33:46 +08:00
Xu Cheng
d62095710f More core files style updates 2015-08-03 20:38:20 +08:00
BrewTestBot
13d544e11e Core files style updates.
Closes Homebrew/homebrew#42354.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-08-03 13:22:35 +01:00
Dominyk Tiller
9877b1e7b8 doctor: update xcode links 2015-07-20 17:32:08 +01:00
Dominyk Tiller
52de5aa984 doctor: remove redundant EOS
Closes Homebrew/homebrew#41667
2015-07-13 18:13:45 +01:00
Mike McQuaid
fe68abf987 doctor: don't point to App Store for Xcode on 10.11.
Closes Homebrew/homebrew#41589.

Closes Homebrew/homebrew#41597.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-07-13 08:11:06 -07:00
Jack Nagel
75642e6271 Use Dir.mktmpdir in doctor
This matches how we create temporary directories elsewhere.
2015-06-23 23:20:31 -04:00
Jack Nagel
a1c1c1e3d3 Whitelist ntfs-3g libs
Closes Homebrew/homebrew#40950.
2015-06-23 23:20:31 -04:00
Jack Nagel
72cb403a56 Move 10.11 warning to doctor, pre-install, and post-failure
Fixes Homebrew/homebrew#40778.
2015-06-16 20:02:10 -04:00
Xu Cheng
d9b1fec14f doctor: fix __check_linked_brew
This fixes the case when multiple versions of a formula are installed.

Closes Homebrew/homebrew#40777.
Fixes Homebrew/homebrew#40781.
Fixes Homebrew/homebrew#40797.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2015-06-16 19:06:52 -04:00
Xu Cheng
0e3c11ea07 doctor: use Formula.installed directly
Before
```
brew doctor  9.83s user 0.52s system 76% cpu 13.563 total
```

After
```
brew doctor  0.25s user 0.16s system 9% cpu 4.332 total
```

Closes Homebrew/homebrew#40770.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-06-16 16:08:52 +08:00
Jack Nagel
bd0f179478 Remove obsolete doctor check
We don't support 10.5 anymore, and tigerbrew doesn't have this check
anymore, either.
2015-06-12 22:58:04 -04:00
Jack Nagel
c4dfacaf0c Fix linked keg-only check when only directories are linked 2015-06-12 20:37:20 -04:00
Xu Cheng
d976e43708 doctor: use Formula#full_name 2015-05-29 17:02:22 +08:00
Xu Cheng
04c274f727 doctor: load formula from rack 2015-05-27 13:53:41 +08:00
Dominyk Tiller
e4db0adf54 doctor: add homebrew_temp sticky bit check
Adds a small check to the Doctor command to ensure HOMEBREW_TEMP
has a sticky bit set. This has become a significant issue lately.

Closes Homebrew/homebrew#39735
Original issue: Homebrew/homebrew#39170

Closes Homebrew/homebrew#39739.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-05-14 21:24:49 +01:00
Xu Cheng
453990f1aa add method to detect shell profile file based on users' preference shell
Closes Homebrew/homebrew#38017.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-03-24 21:18:32 +08:00
Xu Cheng
87a35e3580 doctor: $PATH should be insert as it is
Closes Homebrew/homebrew#37500.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-03-08 17:35:54 +08:00
Xu Cheng
b9c002a7cf doctor: export command should use double quotes
Closes Homebrew/homebrew#37496

Closes Homebrew/homebrew#37497.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-03-08 16:01:17 +08:00
Mike McQuaid
fd8bb8776c doctor: accepting the Xcode license requires sudo. 2015-01-15 15:46:35 +00:00
Jack Nagel
d298e54e50 doctor: check access on HOMEBREW_PREFIX/opt 2015-01-12 21:29:22 -05:00
Jack Nagel
d0a1800e37 doctor: check access on all important HOMEBREW_PREFIX subdirs 2015-01-12 21:26:18 -05:00
Jack Nagel
b1514c1c40 doctor: check cellar access 2015-01-12 21:26:18 -05:00