admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
13,950 Commits 15 Branches 471 Tags
Commit Graph

241 Commits

Author SHA1 Message Date
Mike McQuaid
5e073f1f40 Merge pull request #1528 from MikeMcQuaid/audit-devel-revision 
audit: don't check devel version_scheme/revision.
 2016-11-18 13:53:22 +00:00
Mike McQuaid
e4fb108079 audit: check for HOMEBREW_PREFIX test path usage. 
This is also not allowed.

As seen in https://github.com/Homebrew/homebrew-core/pull/6996.
 2016-11-18 09:02:39 +00:00
Mike McQuaid
b7f0edd1fd audit: don't check devel version_scheme/revision. 
These are formulae-wide so doesn't make sense to iterate through these
for specs and get weird results.

As seem in https://github.com/Homebrew/homebrew-core/pull/6952.
 2016-11-17 17:13:52 +00:00
Markus Reiter
e3be9c068b Update .rubocop_todo.yml. 2016-11-16 23:52:37 +01:00
Mike McQuaid
edf042ee97 Merge pull request #1522 from MikeMcQuaid/audit-one-previous-commit 
audit: only check previous formula version.
 2016-11-16 10:25:11 +00:00
Mike McQuaid
31caa8ef93 audit: only check previous formula version. 
For calculating the stable/devel versions this should be sufficient as
it's looking at `origin/master` so for a e.g. unmerged pull request this
will stop complaining about mistakes outside the pull request itself.

This will silence all warnings for historic version mistakes (i.e.
before these audit checks were all enabled) which is normally a bad
thing but as this case would rely on modifying history to complete is a
good one.
 2016-11-16 09:03:20 +00:00
Mike McQuaid
27ea94adb8 audit: check that there are any stable revisions. 
Fixes the exception if `revision_map[formula.stable.version]` is `nil`.
 2016-11-16 08:59:52 +00:00
Mike McQuaid
5e0b3d24e5 audit: fix "version should not decrease" (again). 
- output the max version and current version to make the message more
  obvious.
- Don't compare the development spec version to the formula version and
  then complain the formula version is lower (it should always be!)
 2016-11-15 09:02:50 +00:00
Mike McQuaid
c78aa43386 audit: fix "version should not decrease" check. 
Fix the "version should not decrease" check so it correctly handles
`version_scheme`s.

Fixes #1489.
 2016-11-13 13:35:25 +00:00
Baptiste Fontaine
bfa19b3385 audit: Escape interpolated string in regexp 
This avoids issues with names containing special characters like e.g. [

Fixes #1431
 2016-11-03 18:17:11 +01:00
Mandar Gokhale
0e15ffff62 Correct a few typos 
...and update man pages where applicable
 2016-11-03 12:09:44 +00:00
Mike McQuaid
2a865f085e Merge pull request #1424 from MikeMcQuaid/audit-more-test-system 
audit: check more unscoped test calls.
 2016-11-02 21:50:54 -04:00
Steven Peters
72f889fef0 audit: restore check that was lost in #927 
This audit check ensures that certain build dependencies
are explicitly marked either as `:build` or `:run`.
It seems to have been lost in #927.
It was also adjusted in #1290.
 2016-11-02 16:52:09 -07:00
Mike McQuaid
f35a86ff70 audit: stricter test system calls check. 
Ensure that the name is suffixed with whitespace or quotes.
 2016-11-02 15:57:19 -04:00
Mike McQuaid
7aa26f7817 audit: check more unscoped test calls. 
Also check `def test`, `shell_output`, `pipe_output` and method calls
using parentheses.
 2016-11-02 13:23:38 -04:00
Baptiste Fontaine
127461d879 audit: don't check new formulae revision/versions. 2016-10-30 13:51:23 -04:00
Mike McQuaid
ef58225749 audit: check the version does not decrease. 
This will prevent brew upgrade from working correctly.
 2016-10-30 13:51:21 -04:00
Mike McQuaid
8d5df2ea87 Merge pull request #1402 from MikeMcQuaid/audit-system-test 
audit: check test system calls are fully scoped.
 2016-10-30 13:30:03 -04:00
Mike McQuaid
20c8c5958e Merge pull request #1367 from MikeMcQuaid/audit-check-master-branch 
audit: check for master branch tar/zipballs.
 2016-10-30 13:29:47 -04:00
Mike McQuaid
a093c62b16 Revert "audit: check the version does not decrease." 2016-10-30 07:32:20 -04:00
Mike McQuaid
0bd0fec6a6 audit: check test system calls are fully scoped. 
This doesn't matter for everything but it does for the binaries that
are installed. Have a limited name/alias check when not installed and
a better one that iterates bin/sbin if installed.
 2016-10-29 17:53:05 -04:00
Mike McQuaid
337810bf3e audit: check for master branch tar/zipballs. 
These have unstable checksums and aren't the tagged, stable releases
we require.
 2016-10-29 17:52:13 -04:00
Mike McQuaid
9ab38dd751 Merge pull request #1366 from MikeMcQuaid/audit-check-version-decrease 
audit: check the version does not decrease.
 2016-10-29 17:50:41 -04:00
Mike McQuaid
84d1661b9a Merge pull request #1365 from MikeMcQuaid/audit-stable-url-beta 
audit: check for alpha/beta/rc usage in URLs.
 2016-10-25 08:17:40 -04:00
Markus Reiter
b28b21fd7f Don’t use bare percent literals. 2016-10-24 17:27:20 +02:00
Mike McQuaid
b39f87e710 audit: check for alpha/beta/rc usage in URLs. 
Stable URLs should not use unstable versions.
 2016-10-24 14:54:28 +01:00
Mike McQuaid
762b76e437 audit: check the version does not decrease. 
This will prevent `brew upgrade` from working correctly.
 2016-10-24 10:21:07 +01:00
Mike McQuaid
1f963267b6 Update Rubocop style. 
Another look at the current Rubocop rules and how they fit with our
existing and desired future style. Almost all of these changes were
automatic. Split some rules between formulae/brew where brew doesn't
have millions of cases that need fixed.
 2016-10-22 13:32:46 +01:00
Mike McQuaid
56ae868cf1 audit: don't complain about trailing whitespace. 
This is handled by `brew style` now.
 2016-10-18 08:11:02 +01:00
Max Nordlund
c7fde5ddc9 Fix when clause ordering. 2016-10-15 18:31:06 +02:00
Max Nordlund
d9242c540d Fix wrong ordering on when clauses in audit.rb 
It looks like a rebase/merge conflict remmenet.
 2016-10-14 23:05:34 +02:00
Mike McQuaid
26e4899fde Deprecate apr requirement. 
It's not used on enough configurations now that there's little point in
keeping it around. See e.g. `:autoconf` for prior art.
 2016-10-12 15:37:33 +01:00
Jonathan Chang
5b360c57e3 audit: forbid deprecated_option in new formulae 2016-10-05 15:59:16 -07:00
Markus Reiter
0ab750bf24 Use module_function for commands. 2016-10-02 00:24:47 +02:00
Markus Reiter
573aea0b3d RuboCop: Style/IfUnlessModifier 2016-09-25 19:55:34 +02:00
Markus Reiter
58e36c7319 Fix Style/GuardClause. 2016-09-24 12:24:35 +02:00
Markus Reiter
a5b11a6a5c Fix Style/GuardClause. 2016-09-23 15:30:07 +02:00
Markus Reiter
240e49052c Fix Performance/FixedSize. 2016-09-23 15:30:06 +02:00
Mike McQuaid
3982950e61 rubocop --auto-correct all hash-rocket usage. 2016-09-17 16:14:13 +01:00
Mike McQuaid
264afb67df dev-cmd/audit: fix Rubocop warnings. 2016-09-11 19:14:55 +01:00
Mike McQuaid
af8605ea4b Move developer-focused commands to dev-cmd. 2016-09-08 20:46:37 +01:00