18853 Commits

Author SHA1 Message Date
Mike McQuaid
e68fc530c0
Merge pull request #6040 from claui/endorse-adoptopenjdk
Endorse AdoptOpenJDK instead of Oracle OpenJDK
2019-04-20 13:14:26 +09:00
Mike McQuaid
efa60e499d
Merge pull request #6039 from MikeMcQuaid/freeze-mutable-objects
Freeze more mutable constants.
2019-04-20 08:26:07 +09:00
Claudia
f155ede7fb
Endorse AdoptOpenJDK instead of Oracle OpenJDK
This commit changes the message that appears when Homebrew detects
that a Java requirement is unmet.

The new message will say:

```
Install AdoptOpenJDK with Homebrew Cask:
  brew cask install adoptopenjdk
```

And for Java 8:

```
Install AdoptOpenJDK 8 with Homebrew Cask:
  brew cask install homebrew/cask-versions/adoptopenjdk8
```
2019-04-19 18:00:31 +02:00
Mike McQuaid
d1ea6f38d3
Fix mutable constants violations. 2019-04-19 21:46:20 +09:00
Mike McQuaid
420e63ebcd
Freeze more mutable constants.
This rule adjustment is experimental in RuboCop as it may double-freeze
objects but this isn't an error (and freezing too much is better than
too little).
2019-04-19 18:08:05 +09:00
Mike McQuaid
d42f562d45
Merge pull request #6038 from GauthamGoli/extract-args-fix
extract: Replace ARGV.named with args.remaining
2019-04-19 17:40:55 +09:00
Gautham Goli
8374c3713a extract: Replace ARGV.named with args.remaining 2019-04-19 13:13:43 +05:30
Mike McQuaid
7706e225a9
Merge pull request #6037 from MikeMcQuaid/test-improve-timeout-handling
test: kill all subprocesses on timeout.
2019-04-19 15:43:12 +09:00
Mike McQuaid
4b369962d3
test: kill all subprocesses on timeout.
Fixes #5885.
2019-04-19 14:42:26 +09:00
Mike McQuaid
8f5be03cb8
Merge pull request #6029 from MikeMcQuaid/frozen-string-literal
Enable/fix optional Ruby frozen string literal usage
2019-04-19 13:25:43 +09:00
Mike McQuaid
8fdd278cd3
Merge pull request #6031 from iMichka/sudo3
brew: remove sudo call only in docker context
2019-04-19 10:32:22 +09:00
Mike McQuaid
86f43f79ee
Enable/fix optional Ruby frozen string literal usage
Combined with https://github.com/Homebrew/homebrew-test-bot/pull/247
this will test Homebrew's use of frozen strings in CI. After this we
will then enable it for Homebrew developers and eventually all Homebrew
users.
2019-04-19 10:30:41 +09:00
Mike McQuaid
513dfa20f6
Merge pull request #6032 from MikeMcQuaid/disable-gems
Disable RubyGems by default.
2019-04-19 10:14:07 +09:00
Mike McQuaid
7ab5fef7f2
brew.rb: remove unless ||. 2019-04-19 10:12:03 +09:00
Michka Popoff
49aad7ddb3 brew: remove sudo call only in docker context
Follow up from #6018
2019-04-18 17:16:05 +02:00
Mike McQuaid
892d0ac5fe
style: don’t run shellcheck on specified ruby file. 2019-04-18 21:42:42 +09:00
Mike McQuaid
9e7b98d3e2
Don't check system Ruby is new enough when unnecessary.
We know this is the case in macOS >=10.13.3 so save a Ruby process call.
2019-04-18 21:42:28 +09:00
Mike McQuaid
ef2e297d3b
Disable RubyGems by default.
This speeds up all Ruby invocations where we don't need RubyGems by
around 10%. Where we do need RubyGems: include it manually.
2019-04-18 17:45:03 +09:00
Mike McQuaid
640234caa1
Merge pull request #6030 from MikeMcQuaid/ruby-no-threads
Remove usage of Thread.new
2019-04-18 16:03:18 +09:00
Mike McQuaid
7fbfb02625
Remove usage of Thread.new
I benchmarked these both locally and neither use of `Thread.new`
provides any measurable speedup (and in the `readall` case appears to
slow things down) on my 8 core machine.
2019-04-18 14:46:40 +09:00
Mike McQuaid
1aaffda62f
Merge pull request #6027 from vitorgalvao/remove_to_slashes
hbc: remove all *_to_slashes
2019-04-18 11:59:10 +09:00
Mike McQuaid
4ad8d7608e
Merge pull request #6021 from MikeMcQuaid/argv-cleanup
Update ARGV and CLI parsing
2019-04-17 21:51:27 +01:00
Michka Popoff
f35f17ccf4
Merge pull request #6018 from iMichka/sudo2
brew: remove sudo call
2019-04-17 20:50:06 +02:00
Vítor Galvão
0ee226769a hbc: remove all *_to_slashes 2019-04-17 16:31:35 +01:00
Mike McQuaid
ae63381bd9
cli/parser: use cli/args and tweak freeze behaviour. 2019-04-17 22:16:58 +09:00
Mike McQuaid
e9806b6b55
cli/args: add class to handle arguments. 2019-04-17 22:16:58 +09:00
Mike McQuaid
34a8ab74af
global: provide unpatched ARGV. 2019-04-17 22:16:58 +09:00
Mike McQuaid
e40b171127
Rename cli_parser to cli/parser. 2019-04-17 22:16:50 +09:00
Mike McQuaid
b5b24be48a
Merge pull request #6024 from MikeMcQuaid/no-cleanup-periodic-file
cleanup: don’t cleanup periodic clean file.
2019-04-17 13:48:22 +01:00
Mike McQuaid
18630c7032
extend/ARGV: remove unused methods. 2019-04-17 21:08:26 +09:00
Mike McQuaid
0b272ad26e
cleanup: don’t cleanup periodic clean file.
Cleaning up this file means that cleanup will run again prematurely.
2019-04-17 21:06:47 +09:00
Mike McQuaid
4d6de005d8
Merge pull request #6025 from MikeMcQuaid/release-notes-stderr
release-notes: use stderr for header output.
2019-04-17 13:04:39 +01:00
Mike McQuaid
f6337c543a
Merge pull request #6023 from MikeMcQuaid/config-no-default-logs
system_config: don’t output default HOMEBREW_LOGS.
2019-04-17 13:04:29 +01:00
Mike McQuaid
a4a198a6ec
Merge pull request #6022 from MikeMcQuaid/cask-info-spec-network
cask/cmd/info_spec: needs network connection.
2019-04-17 13:04:16 +01:00
Mike McQuaid
8229e592d7
cask/cmd/info_spec: needs network connection.
Tag it accordingly.
2019-04-17 17:34:33 +09:00
Mike McQuaid
b03558e296
system_config: don’t output default HOMEBREW_LOGS.
This cuts down a bit on noise. While we’re here, optimise the checks too.
2019-04-17 17:02:33 +09:00
Mike McQuaid
888c384801
release-notes: use stderr for header output.
This makes the use of `brew release-notes | pbcopy` a bit easier.
2019-04-17 17:00:24 +09:00
Michka Popoff
1c016ecee7 brew: remove sudo call
except for "brew services" command
2019-04-16 20:35:41 +02:00
Jonathan Chang
b4f73e6164
Merge pull request #6016 from jonchang/update-policy
docs: update Acceptable Formula for options/guis
2.1.1
2019-04-15 20:06:28 +10:00
Claudia Pellegrino
eeecb62568 Update docs/Acceptable-Formulae.md
Co-Authored-By: jonchang <jchang641@gmail.com>
2019-04-15 18:58:18 +10:00
Jonathan Chang
6748b1ee84 docs: update Acceptable Formula for options/guis 2019-04-15 18:22:39 +10:00
Mike McQuaid
356f72dcc6
Merge pull request #6012 from amyspark/hotpatch-fix-atomic_write
atomic_write: repair permissions after writing
2019-04-14 10:02:15 +01:00
Mike McQuaid
1281c4a663
Merge pull request #5983 from zachauten/continue-upgrading-casks-after-failure
'brew cask upgrade' will continue upgrading casks after a failure
2019-04-14 10:01:32 +01:00
Mike McQuaid
0750971870
Merge pull request #5893 from reitermarkus/version-unstable
Add `#unstable?` method for cask versions.
2019-04-14 10:00:57 +01:00
Mike McQuaid
3b842ef41f
Merge pull request #6014 from vitorgalvao/caskroom-home
cask home: update to brew.sh
2019-04-14 10:00:15 +01:00
Mike McQuaid
59682db647
Merge pull request #6013 from EricFromCanada/message-text
update wording and formatting of messages text
2019-04-14 09:59:51 +01:00
EricFromCanada
e0558dc7c7 trim line breaks 2019-04-13 21:37:48 -04:00
EricFromCanada
89f0fcedbe whitespace fixes 2019-04-13 21:32:04 -04:00
EricFromCanada
15c38a2d8b formatting fixes 2019-04-13 21:29:32 -04:00
EricFromCanada
fa6404e0f5 grammar fixes 2019-04-13 21:29:32 -04:00