16125 Commits

Author SHA1 Message Date
Mike McQuaid
0baf8cab5f
brew vendor-gems: commit updates. 2019-04-29 12:52:00 +01:00
dependabot[bot]
5c5ee6e86c
build: bump parser from 2.6.2.1 to 2.6.3.0 in /Library/Homebrew
Bumps [parser](https://github.com/whitequark/parser) from 2.6.2.1 to 2.6.3.0.
- [Release notes](https://github.com/whitequark/parser/releases)
- [Changelog](https://github.com/whitequark/parser/blob/master/CHANGELOG.md)
- [Commits](https://github.com/whitequark/parser/compare/v2.6.2.1...v2.6.3.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-04-29 06:37:27 +00:00
dependabot[bot]
85d5808079
build: bump backports from 3.13.0 to 3.14.0 in /Library/Homebrew
Bumps [backports](https://github.com/marcandre/backports) from 3.13.0 to 3.14.0.
- [Release notes](https://github.com/marcandre/backports/releases)
- [Changelog](https://github.com/marcandre/backports/blob/master/CHANGELOG.rdoc)
- [Commits](https://github.com/marcandre/backports/compare/v3.13.0...v3.14.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-04-29 05:01:07 +00:00
Markus Reiter
ea76a7aaaf Unfreeze string. 2019-04-28 15:24:17 +02:00
Markus Reiter
85c3b55e2b Fix exception in exception. 2019-04-28 15:16:47 +02:00
Mike McQuaid
21bb9f6f5b
Merge pull request #6071 from kiendang/fix-mutable-string
utils/github: fix mutable string syntax
2019-04-26 11:15:56 -07:00
kiendang
5c83729be9 Fix mutable string syntax 2019-04-26 23:03:40 +08:00
Xu Cheng
1dfdc5c2ec
reinstall: don't build bottles unnecessarily.
Apply the same changes from #6066.

Also apply the same logics from `brew upgrade` to preserve
`installed_as_dependency`/`installed_on_request` settings
when reinstalling formulae.
2019-04-26 15:28:57 +08:00
Mike McQuaid
261e2e7926
utils/github: fix frozen string usage.
See https://discourse.brew.sh/t/error-cant-modify-frozen-string/4691/4
2019-04-25 23:28:50 -07:00
Mike McQuaid
193173f470
Merge pull request #6066 from MikeMcQuaid/upgrade-build-bottle-tweaks
upgrade: don't build bottles unnecessarily.
2019-04-25 14:28:25 -07:00
Mike McQuaid
0b685bb890
upgrade: don't build bottles unnecessarily.
Fixes #6063.
2019-04-25 14:01:50 -07:00
Thierry Moisan
c5640acae5
Add bump-revision bump command
bump-revision will increase by one the revision or add "revision 1" if
it doesn't exist.
2019-04-24 22:17:59 -04:00
Mike McQuaid
01ebe9135c
Merge pull request #6058 from lembacon/xcode-10.2.1
xcode: upgrade for Xcode 10.2.1 release
2019-04-24 17:21:07 -07:00
Mike McQuaid
70b07a914f
cmd/info: fix frozen pathname usage.
Fixes #6055.
2019-04-24 14:17:04 -07:00
Chongyu Zhu
aea2804442
xcode: upgrade for Xcode 10.2.1 release 2019-04-24 22:48:00 +08:00
Chongyu Zhu
e3615add8c
python_virtualenv_constants: upgrade virtualenv to 16.5.0 2019-04-24 19:12:00 +08:00
Mike McQuaid
bb2779ecf8
Merge pull request #6054 from follower/patch-1
Fix check_for_unsupported_macos() on outdated releases
2019-04-23 23:23:37 -07:00
Mike McQuaid
bc3a4c1897
diagnostic: tweak frozen string handling. 2019-04-23 23:05:28 -07:00
Mike McQuaid
6325db9e37
utils: fix frozen string usage in odeprecated.
Fixes https://github.com/Homebrew/brew/issues/6053
2019-04-23 22:32:11 -07:00
follower
2064b30fce
Fix check_for_unsupported_macos() on outdated releases
Recent commit 36dbad3922 to default to frozen string literals (via `frozen_string_literal`) broke `check_for_unsupported_macos()` on outdated releases--due to attempted modification of a frozen string literal.

This breaks `install` and `doctor`.

It's like the change wasn't tested on an unsupported outdated release or something... :D

Adding a `+` prefix is apparently one way around this issue according to https://stackoverflow.com/questions/37799296/what-does-the-comment-frozen-string-literal-true-do#37799399. The change worked for me.
2019-04-24 15:02:13 +12:00
Mike McQuaid
47c886117b
compat: add missing frozen string literals.
These weren't added yet due to CI being run at different times to
merges.
2019-04-23 09:42:36 -07:00
Mike McQuaid
6b2dbbc96f
Merge pull request #6042 from MikeMcQuaid/boring_homebrew_display
config: don't show HOMEBREW_DISPLAY.
2019-04-22 13:07:20 -07:00
Mike McQuaid
0d54978ba8
Merge pull request #6036 from MikeMcQuaid/enable-frozen-string-literal
Use FrozenStringLiteralComment instead of flag.
2019-04-22 13:07:08 -07:00
Mike McQuaid
b89589ea29
Merge pull request #6045 from Homebrew/dependabot/bundler/Library/Homebrew/rspec-expectations-3.8.3
Bump rspec-expectations from 3.8.2 to 3.8.3 in /Library/Homebrew
2019-04-22 13:06:46 -07:00
Mike McQuaid
21e07b1ad4
Merge pull request #6046 from Homebrew/dependabot/bundler/Library/Homebrew/unf_ext-0.0.7.6
Bump unf_ext from 0.0.7.5 to 0.0.7.6 in /Library/Homebrew
2019-04-22 13:06:33 -07:00
dependabot[bot]
d23f324acb
[Security] Bump nokogiri from 1.10.2 to 1.10.3 in /Library/Homebrew
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.10.2 to 1.10.3. **This update includes security fixes.**
- [Release notes](https://github.com/sparklemotion/nokogiri/releases)
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.10.2...v1.10.3)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-04-22 18:18:00 +00:00
dependabot[bot]
39d62762eb
Bump unf_ext from 0.0.7.5 to 0.0.7.6 in /Library/Homebrew
Bumps [unf_ext](https://github.com/knu/ruby-unf_ext) from 0.0.7.5 to 0.0.7.6.
- [Release notes](https://github.com/knu/ruby-unf_ext/releases)
- [Changelog](https://github.com/knu/ruby-unf_ext/blob/master/CHANGELOG.md)
- [Commits](https://github.com/knu/ruby-unf_ext/compare/v0.0.7.5...v0.0.7.6)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-04-22 06:36:22 +00:00
dependabot[bot]
3ffc01175f
Bump rspec-expectations from 3.8.2 to 3.8.3 in /Library/Homebrew
Bumps [rspec-expectations](https://github.com/rspec/rspec-expectations) from 3.8.2 to 3.8.3.
- [Release notes](https://github.com/rspec/rspec-expectations/releases)
- [Changelog](https://github.com/rspec/rspec-expectations/blob/master/Changelog.md)
- [Commits](https://github.com/rspec/rspec-expectations/compare/v3.8.2...v3.8.3)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-04-22 06:35:49 +00:00
Markus Reiter
ce15622584 Add *_to_slashes methods to compat. 2019-04-20 23:58:48 +02:00
Mike McQuaid
58e57f2d49
config: don't show HOMEBREW_DISPLAY.
This is set by XQuartz and not needed information for us.
2019-04-20 16:22:10 +09:00
Mike McQuaid
fc6bd2ea1c
Fixup more frozen string handling. 2019-04-20 14:07:29 +09:00
Mike McQuaid
36dbad3922
Add frozen_string_literal to all files. 2019-04-20 13:27:36 +09:00
Mike McQuaid
f76b083b91
Use FrozenStringLiteralComment instead of flag.
Unfortunately we cannot use `--frozen-string-literal` with Ruby 2.3 due
to https://bugs.ruby-lang.org/issues/12031 and our usage of ERB.
2019-04-20 13:25:33 +09:00
Mike McQuaid
e68fc530c0
Merge pull request #6040 from claui/endorse-adoptopenjdk
Endorse AdoptOpenJDK instead of Oracle OpenJDK
2019-04-20 13:14:26 +09:00
Claudia
f155ede7fb
Endorse AdoptOpenJDK instead of Oracle OpenJDK
This commit changes the message that appears when Homebrew detects
that a Java requirement is unmet.

The new message will say:

```
Install AdoptOpenJDK with Homebrew Cask:
  brew cask install adoptopenjdk
```

And for Java 8:

```
Install AdoptOpenJDK 8 with Homebrew Cask:
  brew cask install homebrew/cask-versions/adoptopenjdk8
```
2019-04-19 18:00:31 +02:00
Mike McQuaid
d1ea6f38d3
Fix mutable constants violations. 2019-04-19 21:46:20 +09:00
Mike McQuaid
420e63ebcd
Freeze more mutable constants.
This rule adjustment is experimental in RuboCop as it may double-freeze
objects but this isn't an error (and freezing too much is better than
too little).
2019-04-19 18:08:05 +09:00
Mike McQuaid
d42f562d45
Merge pull request #6038 from GauthamGoli/extract-args-fix
extract: Replace ARGV.named with args.remaining
2019-04-19 17:40:55 +09:00
Gautham Goli
8374c3713a extract: Replace ARGV.named with args.remaining 2019-04-19 13:13:43 +05:30
Mike McQuaid
4b369962d3
test: kill all subprocesses on timeout.
Fixes #5885.
2019-04-19 14:42:26 +09:00
Mike McQuaid
8f5be03cb8
Merge pull request #6029 from MikeMcQuaid/frozen-string-literal
Enable/fix optional Ruby frozen string literal usage
2019-04-19 13:25:43 +09:00
Mike McQuaid
8fdd278cd3
Merge pull request #6031 from iMichka/sudo3
brew: remove sudo call only in docker context
2019-04-19 10:32:22 +09:00
Mike McQuaid
86f43f79ee
Enable/fix optional Ruby frozen string literal usage
Combined with https://github.com/Homebrew/homebrew-test-bot/pull/247
this will test Homebrew's use of frozen strings in CI. After this we
will then enable it for Homebrew developers and eventually all Homebrew
users.
2019-04-19 10:30:41 +09:00
Mike McQuaid
7ab5fef7f2
brew.rb: remove unless ||. 2019-04-19 10:12:03 +09:00
Michka Popoff
49aad7ddb3 brew: remove sudo call only in docker context
Follow up from #6018
2019-04-18 17:16:05 +02:00
Mike McQuaid
892d0ac5fe
style: don’t run shellcheck on specified ruby file. 2019-04-18 21:42:42 +09:00
Mike McQuaid
9e7b98d3e2
Don't check system Ruby is new enough when unnecessary.
We know this is the case in macOS >=10.13.3 so save a Ruby process call.
2019-04-18 21:42:28 +09:00
Mike McQuaid
ef2e297d3b
Disable RubyGems by default.
This speeds up all Ruby invocations where we don't need RubyGems by
around 10%. Where we do need RubyGems: include it manually.
2019-04-18 17:45:03 +09:00
Mike McQuaid
640234caa1
Merge pull request #6030 from MikeMcQuaid/ruby-no-threads
Remove usage of Thread.new
2019-04-18 16:03:18 +09:00
Mike McQuaid
7fbfb02625
Remove usage of Thread.new
I benchmarked these both locally and neither use of `Thread.new`
provides any measurable speedup (and in the `readall` case appears to
slow things down) on my 8 core machine.
2019-04-18 14:46:40 +09:00