42330 Commits

Author SHA1 Message Date
dependabot[bot]
abf98a4743
build(deps-dev): bump thor from 1.3.1 to 1.3.2 in /Library/Homebrew
Bumps [thor](https://github.com/rails/thor) from 1.3.1 to 1.3.2.
- [Release notes](https://github.com/rails/thor/releases)
- [Commits](https://github.com/rails/thor/compare/v1.3.1...v1.3.2)

---
updated-dependencies:
- dependency-name: thor
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-08-29 23:00:53 +00:00
Patrick Linnane
2d247f4642
Merge pull request #18192 from Homebrew/dependabot/bundler/Library/Homebrew/sorbet-0.5.11551 2024-08-29 15:54:35 -07:00
BrewTestBot
16b9b75c6a
brew vendor-gems: commit updates. 2024-08-29 22:42:33 +00:00
Ryan Schumacher
b31a9b922e
Apply suggestions from code review
Co-authored-by: Ruoyu Zhong <zhongruoyu@outlook.com>
2024-08-29 15:55:12 -05:00
Ryan Schumacher
e5a3f0e583
Update docs/How-To-Open-a-Homebrew-Pull-Request.md
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2024-08-29 15:54:32 -05:00
Eric Knibbe
1bf48e25e8
Merge pull request #18191 from Homebrew/dependabot/github_actions/github/codeql-action-3.26.6
build(deps): bump github/codeql-action from 3.26.5 to 3.26.6
2024-08-29 15:09:54 -04:00
xycabcd
147cfa46e4
Deleted the duplicated "PWD check" 2024-08-29 14:45:27 -04:00
dependabot[bot]
61c291fa5e
build(deps-dev): bump sorbet in /Library/Homebrew
Bumps [sorbet](https://github.com/sorbet/sorbet) from 0.5.11549 to 0.5.11551.
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

---
updated-dependencies:
- dependency-name: sorbet
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-08-29 18:30:38 +00:00
dependabot[bot]
c66e5023d3
build(deps): bump github/codeql-action from 3.26.5 to 3.26.6
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.5 to 3.26.6.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](2c779ab0d0...4dd16135b6)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-08-29 18:11:07 +00:00
Ryan Schumacher
72f995599d
Update docs/How-To-Open-a-Homebrew-Pull-Request.md
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2024-08-29 08:48:45 -05:00
Ryan Schumacher
010304a9a1
Update docs/How-To-Open-a-Homebrew-Pull-Request.md
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2024-08-29 08:48:39 -05:00
Ryan Schumacher
f119b4a6d0
Added the block for casks 2024-08-29 08:28:18 -05:00
Ryan Schumacher
ff8b3f21f9
Move to appropriate section and resolve lint error 2024-08-29 08:19:34 -05:00
Ryan Schumacher
5fb6a8b8e3
Add link to Acceptable Formulae and slight wording change for more clarity. 2024-08-29 08:17:22 -05:00
Carlo Cabrera
6cd74705cb
shellenv: silence errors from writing to etc/paths file
Users don't need to see this error. We can just fall back silently
instead.
2024-08-29 19:12:23 +08:00
Ryan Schumacher
8c6aa176f6
Add note about auditor to How-To-Open-a-Homebrew-Pull-Request.md 2024-08-29 05:17:26 -05:00
Carlo Cabrera
04088b3e3c
shellenv: extract paths file to a variable
Let's follow the Rule of Three here.
2024-08-29 17:36:50 +08:00
Carlo Cabrera
6dc90cbf83
cmd/shellenv: improve for newer macOS using /usr/libexec/path_helper
On macOS 14 and newer, `/usr/libexec/path_helper` supports setting a
`PATH_HELPER_ROOT` environment variable.

With this set, `path_helper` checks `$PATH_HELPER_ROOT/etc/paths` and
`$PATH_HELPER_ROOT/etc/paths.d` in the same way it checks `/etc/paths`
and `/etc/paths.d`.

We can use this to simplify management of the user's `PATH` variable
when they do `brew shellenv`. In particular, if their system supports
it, we delegate setting the `PATH` environment variable to `path_helper`
instead of our own code. We also write a default `etc/paths` file if one
is not already present.

This is nicer because it simplifies management of the user's `PATH`
variable. For example, if a user wants a keg-only formula to be in their
`PATH`, they can simply add the necessary path to `/etc/paths` or
`/etc/paths.d` without having to do something like `brew link --force`
or adding to `PATH` themselves.

When `/usr/libexec/path_helper` is not available, we just fall back to
the existing code.
2024-08-29 17:00:43 +08:00
Mike McQuaid
638a3dc3a3
Merge pull request #18167 from Homebrew/fix-cask-formula-file-validation-v2 2024-08-29 08:50:44 +01:00
apainintheneck
60b8878f21 tap: share components of formula and cask file path regexes
The goal here is to make things easier to read by better
describing how different regexes are similar to each other.
2024-08-28 19:12:02 -07:00
Michael Cho
06fc2247c7
Merge pull request #18178 from cho-m/github-tag
utils/shared_audits: GitHub urls can have '.' in repo and '/' in tag
2024-08-28 21:55:29 -04:00
Patrick Linnane
81c4351fb5
Merge pull request #18185 from Homebrew/dependabot/bundler/Library/Homebrew/sorbet-0.5.11549 2024-08-28 08:41:34 -07:00
BrewTestBot
5d1db45b27
brew vendor-gems: commit updates. 2024-08-28 15:24:28 +00:00
dependabot[bot]
8fee9dc845
build(deps-dev): bump sorbet in /Library/Homebrew
Bumps [sorbet](https://github.com/sorbet/sorbet) from 0.5.11547 to 0.5.11549.
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

---
updated-dependencies:
- dependency-name: sorbet
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-08-28 15:21:32 +00:00
Bo Anderson
f5d39c82c3
Merge pull request #18183 from Homebrew/sandbox-fork-fix
Fix misuse of `fork` in sandbox causing crashes
2024-08-28 15:14:59 +01:00
Bo Anderson
6a0db5035f
Fix misuse of fork in sandbox causing crashes 2024-08-28 13:53:01 +01:00
Carlo Cabrera
01287a742a
Merge pull request #18153 from Homebrew/version-cache-handling 2024-08-28 19:37:15 +08:00
Carlo Cabrera
b63ecff52c
brew.sh: use git diff instead of git diff-index 2024-08-28 19:21:50 +08:00
Carlo Cabrera
a597a1eecb
Reverse order of if conditional
Checking for readability is a cheaper operation that `git diff-index`.
2024-08-28 18:58:27 +08:00
Michael Cho
41009cbc92
Merge pull request #18173 from cho-m/github_packages-license
github_packages: use official license annotation
2024-08-28 00:01:08 -04:00
Carlo Cabrera
62d187dd82
Merge pull request #18166 from Homebrew/runner-spec-formulae 2024-08-28 11:44:24 +08:00
Carlo Cabrera
c61492ac91
Fix logic error in active_runner?
We should only activate a runner when there are deleted formulae if it
isn't a dependent matrix.
2024-08-28 10:50:18 +08:00
Carlo Cabrera
45be393f95
Merge pull request #18179 from Homebrew/dependabot/bundler/Library/Homebrew/sorbet-0.5.11547 2024-08-28 02:44:20 +08:00
BrewTestBot
7c4589f516
brew vendor-gems: commit updates. 2024-08-27 18:32:47 +00:00
dependabot[bot]
d3f9db7e84
build(deps-dev): bump sorbet in /Library/Homebrew
Bumps [sorbet](https://github.com/sorbet/sorbet) from 0.5.11545 to 0.5.11547.
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

---
updated-dependencies:
- dependency-name: sorbet
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-08-27 18:21:53 +00:00
Michael Cho
d1dc3b2206
utils/shared_audits: GitHub urls can have '.' in repo and '/' in tag 2024-08-27 11:39:50 -04:00
Michael Cho
bf320eb4bf
github_packages: use official license annotation
For now we ignore the 256 character limit stated by GitHub packages

https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry#labelling-container-images
2024-08-27 10:12:11 -04:00
Ruoyu Zhong
80c04e2528
Merge pull request #18175 from Homebrew/docker-build-push-action
workflows/docker: use `docker/build-push-action` to build images
2024-08-27 22:06:56 +08:00
Ruoyu Zhong
73b8950d87
workflows/docker: use safer delimiters
Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
2024-08-27 18:34:52 +08:00
Ruoyu Zhong
d452cd947d
workflows/docker: consolidate pushes in single step 2024-08-27 18:34:52 +08:00
Ruoyu Zhong
82f97bcf29
workflows/docker: use docker/build-push-action to build images
This allows us to use Docker's build cache across workflow runs.

Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
2024-08-27 18:29:59 +08:00
Ruoyu Zhong
ae2b3bc7d4
workflows/docker: only perform login when necessary 2024-08-27 18:29:59 +08:00
Mike McQuaid
81d26f8059
Merge pull request #18169 from cho-m/spdx-case-sensitive 2024-08-27 09:28:55 +01:00
Mike McQuaid
83645e2917
Merge pull request #18174 from Homebrew/gitlab-urls 2024-08-27 09:09:46 +01:00
Kevin
f31aa91f67
Merge pull request #18176 from Homebrew/speed-up-loading-cask-and-formula-file-names_v4
Simplify globbing for casks and formula in taps
2024-08-27 01:02:58 -07:00
apainintheneck
62a4734c90 tap: add tests for formula_file? and cask_file? 2024-08-27 00:36:23 -07:00
apainintheneck
2d6d080f32 Simplify globbing for casks and formula in taps
This is yet another approach to f3a5a3c449cf004aee662966e6c8dd2ebe122c0f
which got merged in over the weekend. It is much simpler than what we've
got now with almost exactly the same performance characteristics. A great
combination of maintability and performance.

```console
$ hyperfine --parameter-list branch master,speed-up-loading-cask-and-formula-file-names_v4 --warmup 5 --setup 'git switch {branch}' 'brew cat gimp'
Benchmark 1: brew cat gimp (branch = master)
  Time (mean ± σ):      1.459 s ±  0.012 s    [User: 0.892 s, System: 0.536 s]
  Range (min … max):    1.448 s …  1.483 s    10 runs

Benchmark 2: brew cat gimp (branch = speed-up-loading-cask-and-formula-file-names_v4)
  Time (mean ± σ):      1.456 s ±  0.009 s    [User: 0.889 s, System: 0.536 s]
  Range (min … max):    1.445 s …  1.468 s    10 runs

Summary
  brew cat gimp (branch = speed-up-loading-cask-and-formula-file-names_v4) ran
    1.00 ± 0.01 times faster than brew cat gimp (branch = master)
```
2024-08-26 23:22:15 -07:00
Michael Cho
d3d3f502a7
formula_auditor: tag needs to be a String 2024-08-26 23:07:41 -04:00
Michael Cho
cccab0d9a9
utils/shared_audits: allow subgroups in gitlab url 2024-08-26 23:07:31 -04:00
Patrick Linnane
b7b155bf0e
Merge pull request #18170 from Homebrew/dependabot/bundler/Library/Homebrew/ruby-lsp-0.17.16 2024-08-26 16:08:01 -07:00