admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
42,330 Commits 15 Branches 471 Tags
Commit Graph

716 Commits

Author SHA1 Message Date
Jack Nagel
d3daa8a25b Mark deprecated download strategies as such 2014-12-22 00:52:10 -05:00
Jack Nagel
df70d960f8 Assume CVS module name when none is given 2014-12-22 00:43:02 -05:00
Jack Nagel
8a1ed0e748 Allow :module => "name" for CVS URLs 2014-12-22 00:43:02 -05:00
Jack Nagel
d97daa7c1b Fix references to url 2014-12-18 20:09:52 -05:00
Jack Nagel
eec429b9b6 Add :using => :fossil 2014-12-18 13:06:05 -05:00
Jack Nagel
867a87b50a Move url munging to initialize 2014-12-18 13:06:05 -05:00
Jack Nagel
ef4347b898 Start versioning cached git clones 2014-12-18 12:57:37 -05:00
Mike McQuaid
4716ee838e Revert "Start versioning cached git clones" 
This reverts commit f4fe50a0958b7b47b32041e11d4943d6ae7d3972.
 2014-12-18 13:03:32 +00:00
Jack Nagel
1cfeba04a8 Start versioning cached git clones 2014-12-17 23:18:17 -05:00
Jack Nagel
9a2f2aee7e Use Utils.popen_read to avoid shelling out in a few places 2014-12-16 15:51:57 -05:00
Jack Nagel
5201411a6d Provide version reader method 2014-12-10 00:55:26 -05:00
Jack Nagel
0909b12eb9 Prefer cached_location over tarball_path 2014-12-10 00:53:57 -05:00
Jack Nagel
37c636ae18 Reorganize methods in CurlDownloadStrategy 2014-12-10 00:53:57 -05:00
Jack Nagel
00ad37dd84 Add more general support for passing credentials to curl 2014-12-09 22:39:58 -05:00
Jack Nagel
18b8681a7c Pull strategy for downloading from research.att.com into core 2014-12-09 21:18:01 -05:00
Jack Nagel
1dc4fbdb0b Provide access to the specs hash indirectly via a meta attribute 2014-12-09 19:59:16 -05:00
Jack Nagel
3e1cc70fb4 Move tool path methods to AbstractDownloadStrategy 2014-12-09 16:46:28 -05:00
Jack Nagel
bec5e0671f Use quiet_safe_system to silence CVS checkouts 2014-12-09 16:03:14 -05:00
Jack Nagel
e9c368b92e Include FileUtils in AbstractDownloadStrategy 2014-12-09 15:55:28 -05:00
Jack Nagel
ddf6f51776 Prefer cached_location method over @clone ivar 2014-12-09 14:22:44 -05:00
Jack Nagel
90f938dc86 Stop returning a path from CurlDownloadStrategy#fetch 
Download strategies do not consistently return a value from `fetch`, so
our code calls `cached_location` to get the path instead.
 2014-12-09 12:47:10 -05:00
Jack Nagel
8560ad3ad0 Use quiet_safe_system to silence submodule updates 2014-12-06 20:57:23 -05:00
Jack Nagel
04d287e8db Use quiet_safe_system to silence submodule checkouts 2014-12-06 20:57:23 -05:00
Jack Nagel
5d811c519b Use quiet_safe_system to silence bzr updates 2014-12-06 20:57:22 -05:00
Jack Nagel
37c08393db Use quiet_safe_system to silence CVS updates 2014-12-06 17:18:34 -05:00
Jack Nagel
7e844cad1c Simplify fossil checkouts 2014-12-06 16:48:20 -05:00
Jack Nagel
dd2446ab08 Extract part of stage method to VCS strategy superclass 2014-12-06 16:00:20 -05:00
Jack Nagel
5f0feb7e85 Remove years-old TODO 2014-12-06 15:54:04 -05:00
Jack Nagel
df25be78b5 Demote FIXME to a normal comment 2014-12-06 15:53:37 -05:00
Jack Nagel
6081874612 Mark private SubversionDownloadStrategy methods 2014-12-06 15:02:49 -05:00
Jack Nagel
5afa11ecab Move fetch implementation into VCS strategy superclass 2014-12-06 15:02:49 -05:00
Jack Nagel
4026e035ad Use start_with? instead of a regexp 2014-12-06 15:02:49 -05:00
Jack Nagel
01dc112b60 Move SVN URL munging to initialize 2014-12-06 15:02:49 -05:00
Jack Nagel
62c1c61ec2 Remove method that duplicates superclass implementation 2014-12-06 15:02:49 -05:00
Jack Nagel
f189454328 Extract update from fetch in VCS strategies 2014-12-06 15:02:49 -05:00
Jack Nagel
3a20562d6e Add clone_repo to remaining VCS strategies 2014-12-06 15:02:49 -05:00
Jack Nagel
8debc18839 Add repo_valid? to remaining VCS strategies 2014-12-06 15:02:49 -05:00
Jack Nagel
a2dbcfee5b Make repo_valid? private 2014-12-06 15:02:48 -05:00
Jack Nagel
f43fe41423 Make __path methods private 2014-12-06 15:02:48 -05:00
Jack Nagel
54785bb8a0 Make cache_tag private 2014-12-06 15:02:48 -05:00
Jack Nagel
6a56c45fbf Mark private VCSDownloadStrategy methods 2014-12-06 15:02:48 -05:00
Jack Nagel
566d6b3a46 CurlDownloadStrategy: initialize attributes in initializer 
The downloader is instantiated on-demand, so we no longer need the lazy
initialization here.
 2014-12-05 22:11:23 -05:00
Jack Nagel
853399da44 Provide VCSDownloadStrategy#head? 2014-12-05 18:57:28 -05:00
Jack Nagel
ecba7b4e7e Stop supporting hg found in share/python 2014-12-05 17:05:48 -05:00
Jack Nagel
ed842246f7 Make the git download strategy default to :branch => "master" 
Fixes Homebrew/homebrew#33437.
 2014-12-03 17:25:51 -05:00
Jack Nagel
32ab3bb32f Use curl -d to pass query parameters in the bottle download strategy 
Fixes Homebrew/homebrew#33355.
 2014-10-19 23:01:09 -05:00
Jack Nagel
09b7f40b25 Simplify UnsafeSubversionDownloadStrategy 2014-10-07 21:33:15 -05:00
Jack Nagel
5dd1092f5f Remove last usage of StrictSubversionDownloadStrategy 
This strategy is only used in one formula, so we can just replace it
with a dependency. It could be done with a requirement, but since this
is a low-impact change (it only matters for head builds on Leopard), I'm
not sure it's worth the effort.

The constant is retained for compatibility, though I could find only one
other reference to it on GitHub, in a formula that was removed from core
almost two years ago.
 2014-10-05 20:15:18 -05:00
Larry Shaffer
ba8ef6a7ed Add friendlier local file missing error 
Closes Homebrew/homebrew#26481.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2014-08-24 23:26:36 -05:00
Dabrien 'Dabe' Murphy
46ca68de5e Modify "git rev-parse --verify" args in "has_ref?" 
Per the `git-rev-parse(1)` manpage:

  --verify Verify that exactly one parameter is provided, and that it
  can be turned into a raw 20-byte SHA-1 that can be used to access the
  object database. If so, emit it to the standard output; otherwise,
  error out.

  If you want to make sure that the output actually names an object in
  your object database and/or can be used as a specific type of object
  For example, git rev-parse "$VAR^{commit}" will make sure $VAR names
  an existing object that is a commit-ish (i.e. a commit, or an
  annotated tag that points at a commit).

That actually means that:

  git rev-parse --verify af8e768e2bd3b4398bca033998f83b0eb8874914

will _always_ return the SHA-1 hash — regardless of whether or not
that's actually a valid reference!

Thus, when `GitDownloadStragtegy#update_repo` tries to check
`has_ref?`, it mistakenly succeeds, and doesn't actually do a `git fetch
origin`.

The fix is to use:

  git rev-parse --verify "af8e768e2bd3b4398bca033998f83b0eb8874914^{commit}"

Fixes Homebrew/homebrew#31045.
Closes Homebrew/homebrew#31054.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2014-07-23 21:07:02 -05:00