Max Howell
7e1e8efdf4
Fix install names for keg-only brews too
...
Fixes Homebrew/homebrew#6065 . Fixes Homebrew/homebrew#6218 .
2011-07-04 09:31:48 +01:00
Max Howell
870f36769e
Fix install_name massaging for keg-only brews
...
Fixes Homebrew/homebrew#6065 .
My pre-emptive fix that avoided calling Pathname.ensure_writable because I was not convinced it worked broke this function due to incorrect logic.
The lesson is, don’t write pre-emptive fixes. Wait until you've seen the bug first. All code has bugs in, so write less. I'm an idiot sometimes.
2011-06-28 17:28:37 +01:00
Adam Vandenberg
02b09e311f
formula.rb: put bottle attrs on separate line
...
This line is getting long, and having these on a separate line
will help with some rebasing in some work-in-progress branches.
2011-06-22 14:13:44 -07:00
Mike McQuaid
eb7c5fa6d7
Fix missing pourable? reference.
2011-06-22 18:00:45 +01:00
Mike McQuaid
2495cdc544
Build from source when we've options or 10.5.
2011-06-22 17:48:20 +01:00
Mike McQuaid
f2e018d747
Return an array from options.
2011-06-22 17:48:20 +01:00
Mike McQuaid
6d3c488d4a
Renaming pouring method to pourable?.
2011-06-22 17:48:20 +01:00
Mike McQuaid
bd2fa562c3
Add stub options method.
2011-06-21 22:28:54 +01:00
Mike McQuaid
b7dd6f1f7e
Remove redeclared method.
2011-06-21 19:25:39 +01:00
Mike McQuaid
5d7e796617
Only pour bottles when not building from source.
2011-06-21 19:25:39 +01:00
Mike McQuaid
b549ca837f
Fix bad pathname indentation.
2011-06-21 19:24:45 +01:00
Mike McQuaid
939a530ddc
Make bottle path.
2011-06-21 19:04:18 +01:00
Mike McQuaid
23769d62ad
Fix brew bottle versioning.
2011-06-21 19:04:17 +01:00
Adam Vandenberg
c5923168d6
Move -- higher in argument list
...
A spurious "--" argument was being passed to the installer script.
2011-06-21 07:27:13 -07:00
Adam Vandenberg
f409e4f22f
Pathname: remove unused method starts_with?
2011-06-19 21:34:59 -07:00
Adam Vandenberg
cee1003782
brew-doctor: use String.start_with?
2011-06-19 21:32:54 -07:00
Adam Vandenberg
e6bac8a8ea
back-port start_with? from 1.8.7
...
This allows its use in Leopard, which has Ruby 1.8.6.
2011-06-19 21:32:37 -07:00
Les Hill
0d44609dfb
doctor: check /usr/local for writablity
...
- Airfoil during the install of InstantOn changes /usr/local to
root:wheel ownership
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
2011-06-19 09:46:57 -07:00
Max Howell
d661b2be4f
Actually reset the permissions
2011-06-17 09:30:25 +01:00
Max Howell
1d606388b4
Show summary headings when appropriate
2011-06-17 09:30:25 +01:00
Max Howell
1587c70357
Don’t output "nothing" messages
...
This is how we do it in general in Homebrew.
2011-06-17 09:30:25 +01:00
Max Howell
215fcd3292
Fix upgrading libdeps breaking stuff after cleanups
...
Fixes Homebrew/homebrew#2709 .
By forcing dylibs to have an install_name id that is the HOMEBREW_PREFIX path, ie. the symlink’s path. Stuff that links to these dylibs will use this id and thus by immune to upgrades of underlying libraries.
Thus whatever keg is "current" ie. linked, will be the library that is used by the tool.
This fix is not retroactive. So there will still be breakage for existing installations of stuff.
The fix_install step in install is moved after the link step as the symlinking
is required to determine the eventual ids for each dylib.
2011-06-17 09:30:25 +01:00
Max Howell
527c841f1c
Fix make_relative_symlink when names differ
...
Before we would always make the symlink itself have a basename the same as what it pointed to.
I don’t think this breaks any of the other usages as they were working by coincidence.
2011-06-17 09:30:25 +01:00
Adam Vandenberg
be63ae9b14
Inclue HOMEBREW_USE_CLANG in --env output
2011-06-16 20:58:06 -07:00
Adam Vandenberg
3977beb8ed
Make these methods on ENV.
2011-06-16 20:58:05 -07:00
Adam Vandenberg
7a9c72cf62
Allow HOMEBREW_USE_CLANG env var
2011-06-16 20:58:05 -07:00
José Martínez
d1aac6bc03
Allow --use-clang to override fails_with_llvm
...
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
2011-06-16 20:45:56 -07:00
José Martínez
2763fc6f5a
Add clang compiler option
...
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
2011-06-16 20:45:52 -07:00
Adam Vandenberg
ea35d749af
be more ruby-like
2011-06-16 20:35:09 -07:00
Adam Vandenberg
00b7e07f45
audit: check for redundant 'version'
2011-06-16 20:31:55 -07:00
Jack Nagel
4b6de22cf2
Fix brew-info when on branch master and github.user set
...
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
2011-06-16 19:30:19 -07:00
Adam Vandenberg
35e2a5a498
Fix issue checklist link
2011-06-16 15:40:12 -07:00
Adam Vandenberg
8f896f9d2c
Style changes related to bottling.
2011-06-16 08:41:16 -07:00
Adam Vandenberg
b643d105eb
Allow underscore with these suffixes for version detection
2011-06-16 06:47:13 -07:00
Adam Vandenberg
0523f66bec
deps: document -n switch
2011-06-15 09:02:18 -07:00
Max Howell
a656243377
Don’t error out if the Cellar doesn’t yet exist
2011-06-15 13:04:06 +01:00
Max Howell
08f31bc573
Fix first brew update
with Git 1.7.4+; Fixes Homebrew/homebrew#5128
...
Behaviour for git checkout was changed such that the update would fail because it refused to checkout files on to existing files in the working directory.
This was bad behaviour anyway, we should make efforts to keep any local modifications to the Homebrew checkout. Everything is neatly resolved if we just do a --soft reset.
Closes Homebrew/homebrew#6017 .
2011-06-15 13:02:48 +01:00
Mislav Marohnić
8c521ca3d0
refactor update
command to use git diff instead of parsing pull
output
...
This fixes reporting of which formulae changed in git versions where `pull`
output is not compatible.
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
2011-06-14 14:47:39 -07:00
Mislav Marohnić
5fdb145e76
enable updater tests to be run on their own
...
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
2011-06-14 14:47:33 -07:00
Adam Vandenberg
db76c21aee
brew audit: check for git://github.com/ urls and warn
2011-06-13 14:20:55 -07:00
Mike McQuaid
31dea3b800
Add changes to Homebrew internals for bottling.
2011-06-08 22:19:10 +01:00
Adam Vandenberg
760bbb4e36
Remove debugging puts
2011-06-08 11:34:01 -07:00
Adam Vandenberg
5d5a8ed32f
Better support for brew install <url>
...
Brews installed via URL are now checked from the cache when
other commands are run. This allows for instance:
brew install <vim-url>
brew info vim
2011-06-08 11:13:50 -07:00
Dan Loewenherz
6495505f88
Add HOMEBREW_CACHE to let the user specify a cache directory
...
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
2011-06-07 13:38:15 -07:00
Adam Vandenberg
b15be6965d
brew-doctor: do not complain about trailing slashes
2011-06-07 13:18:00 -07:00
Adam Vandenberg
5bc0625fc3
Reformat minimum Xcode check
2011-06-06 08:03:07 -07:00
Adam Vandenberg
fd533881a6
brew audit: also check for spaces in Amazon formulae
2011-06-06 07:25:00 -07:00
Adam Vandenberg
1a5cf082d7
Edit universal_binary comment
2011-06-05 08:07:17 -07:00
Adam Vandenberg
f7c7fae0ed
Also find versions in zipballs
2011-06-04 17:29:21 -07:00
Mislav Marohnić
04b90610a3
the doctor
command exits with status "1" if there are warnings
...
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
2011-06-03 21:16:02 -07:00