Markus Reiter
13e3272e37
Remove Cask’s RuboCop configuration.
2016-10-23 14:13:16 +02:00
Markus Reiter
364adff35c
Bring spec_helper
in line with test_helper
.
2016-10-23 14:13:16 +02:00
Markus Reiter
e51accecfd
Remove test_cask
, fake_fetcher
, and fake_response_for
methods.
2016-10-23 14:13:16 +02:00
Markus Reiter
622cac47ae
Use test/lib/config
for tests.
2016-10-23 14:13:16 +02:00
Martin Schimandl
31fb996800
Remove unncessary semicolon
2016-10-23 09:57:28 +02:00
Josh Hagins
5b421b93c9
Merge pull request #1329 from jawshooah/cask/cleanup-tests
...
cask/test: DRY up tests and remove redundant helper
2016-10-20 14:56:11 -04:00
Martin Schimandl
8f8606b8c8
Fix code coverage issue by introducing shutup blocks
2016-10-20 19:45:18 +02:00
Markus Reiter
2b049006fa
Merge pull request #1330 from reitermarkus/spec-helper
...
Refactor `spec_helper`.
2016-10-20 09:07:03 +02:00
Josh Hagins
fab6cc5b07
cask/test: remove compliance_test
2016-10-19 22:15:18 -04:00
Josh Hagins
cba0d069cc
cask/test: DRY up tests and remove redundant helper
2016-10-19 22:15:18 -04:00
Josh Hagins
3bc2c2d087
hbc/cli/list: don't print empty line if nothing to list
2016-10-19 22:15:03 -04:00
Josh Hagins
32f2231cdf
hbc/cli/list: don't require Caskroom to be initialized
2016-10-19 22:15:03 -04:00
Josh Hagins
f79cb2ba30
Merge pull request #1325 from vin047/numbered-usernames
...
fix 'cask info' for external repos with numbers
2016-10-19 20:44:55 -04:00
Markus Reiter
95c93263e6
Refactor spec_helper
.
2016-10-20 00:01:39 +02:00
Markus Reiter
f04a1b59aa
Require spec_helper
globally.
2016-10-19 22:27:14 +02:00
Markus Reiter
fb29a31c72
Merge pull request #1320 from reitermarkus/which-lsar
...
Also use `which` to find `lsar` in PATH.
2016-10-19 22:01:06 +02:00
Yoshimasa Niwa
60c4328a17
Use Ruby 2.x style for named arguments.
2016-10-19 11:14:30 -07:00
Josh Hagins
de5cadc447
Merge pull request #1328 from jawshooah/cask/fix-tests
...
Unset HOMEBREW_DEVELOPER in cask tests likely to raise deprecation errors
2016-10-19 14:08:27 -04:00
Josh Hagins
c18441e81b
Merge pull request #1315 from jawshooah/cask/load-only-rb
...
hbc/locations: arg is file only if absolute or .rb file
2016-10-19 12:36:42 -04:00
Josh Hagins
eebf535bee
dsl_test: unset HOMEBREW_DEVELOPER to avoid deprecation errors
2016-10-19 12:35:47 -04:00
Josh Hagins
fef8f143e8
compliance_test: unset HOMEBREW_DEVELOPER to avoid deprecation errors
2016-10-19 12:35:47 -04:00
Josh Hagins
e8b6aa4ed1
cask/spec: replace with_env_var with with_environment
2016-10-19 12:35:47 -04:00
Markus Reiter
1e92f997c1
Also use which
to find lsar
in PATH.
2016-10-19 18:20:34 +02:00
Vinoth Ramiah
154237ba8e
fix 'cask info' for external repos with numbers
...
fixes 2 issues: error when username has a number, correct url for repos not on github
2016-10-19 14:59:57 +01:00
Josh Hagins
d08f61a704
Merge pull request #1317 from reitermarkus/refactor-rubocop-cask
...
Refactor `brew cask style` not to require `.rubocop.yml`.
2016-10-18 19:22:12 -04:00
Josh Hagins
b4fc4acc09
hbc/locations: arg is file only if absolute or .rb file
...
Handle the case when an argument passed to `brew cask` is both the name
of a Cask and a non-Cask file in the current working directory.
Fixes https://github.com/caskroom/homebrew-cask/issues/25611 .
2016-10-18 19:19:33 -04:00
Markus Reiter
6e1c132f99
Remove Cask’s which
method.
2016-10-18 17:22:08 +02:00
Markus Reiter
8d83516577
Look for container extraction programs in PATH.
2016-10-18 17:17:19 +02:00
Markus Reiter
9f76e2bbe3
Merge pull request #1318 from reitermarkus/refactor-cask-tests
...
Set `HOMEBREW_NO_EMOJI` and `HOMEBREW_CASK_OPTS` in `cask-tests`.
2016-10-18 17:01:55 +02:00
Markus Reiter
143c3ac5c8
Force the use of rubocop-cask
’s default configuration.
2016-10-18 16:40:25 +02:00
Markus Reiter
3a22aff1b6
Refactor brew cask style
not to require .rubocop.yml
.
2016-10-18 16:39:08 +02:00
Markus Reiter
a92dc724b0
Set HOMEBREW_NO_EMOJI
and HOMEBREW_CASK_OPTS
in cask-tests
.
2016-10-18 16:24:30 +02:00
Naren
5f2929788c
following to follow
2016-10-18 09:52:55 -04:00
Naren
6ac54f297f
remove empty line and concatenate newline to e.message in cli.rb
2016-10-18 09:52:55 -04:00
Naren
29d81fc647
updating DSL test
2016-10-18 09:52:55 -04:00
Naren
8e9720c5b9
updated cmd to point to prebug steps url
2016-10-18 09:52:55 -04:00
Josh Hagins
e9863a71f6
hbc/cli/style: bump RUBOCOP_CASK_VERSION
2016-10-17 16:43:24 -04:00
Yoshimasa Niwa
5d606dd0a2
Use SystemCommand.run instead of custom wrapper.
...
There is an existing `SystemCommand.run` that executes command with
`sudo`. Use that instead of yet another custom wrapper.
2016-10-15 15:19:30 -07:00
Markus Reiter
ef70677e88
Add test for Formatter.columns
.
2016-10-15 17:13:38 +02:00
Markus Reiter
198bf4d3bd
Convert puts_columns
to puts Formatter.columns
.
2016-10-15 17:13:38 +02:00
Markus Reiter
01d87f8107
Don’t use puts_columns
if empty?
or single item.
2016-10-15 17:13:38 +02:00
Martin Schimandl
a4e092a1c4
add cask reinstall command
2016-10-14 19:25:44 +02:00
Markus Reiter
1a01a4d42d
Merge pull request #1264 from reitermarkus/single-language-audit
...
Allow auditing of a single language of a cask.
2016-10-12 08:18:35 +02:00
Markus Reiter
bb3c689371
Fix CaskCommandFailedError.
2016-10-11 18:27:01 +02:00
Markus Reiter
9eaf221885
Allow auditing of a single language of a cask.
2016-10-11 15:10:12 +02:00
Markus Reiter
6be6ce33e0
Merge pull request #1245 from reitermarkus/fix-cask-path-for-query
...
Fix getting cask path for queries.
2016-10-10 23:33:51 +02:00
Yoshimasa Niwa
d51cd15e0c
Create caskroom without sudo in writable parent.
...
In case the parent directory of Caskroom is writable for the user, we
don't need to use `sudo` to execute commands.
Make a generic method to run commands that has an option to switch sudo
so that we can run commands with and without sudo.
2016-10-10 11:17:07 -07:00
Alyssa Ross
6c5b8f0f5e
Update URL in qualified_token comment
...
The homebrew/homebrew wiki no longer exists.
2016-10-10 14:46:00 +01:00
Yoshimasa Niwa
d00f35b8c4
FIX: cask changes /usr/local ownership recursively
...
Relatively old code in Hbc::Caskroom recursively changes the ownership
of the directory where the Caskroom directory exists, that changes
entire files in /usr/local to user:staff if Homebrew setup with default
configuration.
This is really dangerous because it's easy to trigger (just simply type
`brew cask something` by following some installation documentation.)
This patch removes entire `chown` with -R option and make the logic
simply creating Caskroom directory with default Homebrew directories
ownership and permission.
2016-10-09 13:27:31 -07:00
Markus Reiter
8ded5b690f
No need to check if Encoding
is defined.
2016-10-09 15:34:12 +02:00