14331 Commits

Author	SHA1	Message	Date
Markus Reiter	355df64d93	Use SystemCommand for curl.	2018-07-29 01:23:33 +02:00
Markus Reiter	aacf603ad2	Fix .codecov.yml.	2018-07-27 01:21:38 +02:00
Markus Reiter	8a24472e2e	Don’t match MZ for Cab.	2018-07-27 00:54:31 +02:00
Mike McQuaid	19d87bf15f	link: when refusing link display keg only caveats ... These are a bit easier to follow and have been recently improved. Inspired by conversation in #4441.	2018-07-26 10:49:55 +01:00
Mike McQuaid	b89367e6d9	caveats: tweak keg_only_text ... - make it a public method - allow skipping the reason - output how to set the various variables in your current shell	2018-07-26 10:49:07 +01:00
Mike McQuaid	74c77db5bd	shell: tweak export_value parameters. ... Let’s have a default value for shell (considering this isn’t a public API) to make it easier to use.	2018-07-26 10:48:25 +01:00
Mike McQuaid	b74974611c	Merge pull request #4548 from MikeMcQuaid/coverage-tweaks ... Tweak code coverage logic	2018-07-26 10:21:46 +01:00
Mike McQuaid	afec4e2988	Tweak code coverage logic ... - make OS detection looser to exclude more Linux files on macOS (and vice versa) - Allow slight (0.5%) coverage drops to account for somewhat random fluctuations.	2018-07-26 10:09:02 +01:00
Markus Reiter	478f50f589	Merge pull request #4545 from reitermarkus/tap-path-regex ... Make `HOMEBREW_TAP_PATH_REGEX` also match exact path.	2018-07-25 23:54:58 +02:00
Markus Reiter	dfa5bfdf9d	Add Tap#command_file? method.	2018-07-25 11:42:28 +02:00
Markus Reiter	2912ebfbfe	Add test for Tap::from_path.	2018-07-25 11:04:00 +02:00
Markus Reiter	0ab6b957df	Make HOMEBREW_TAP_PATH_REGEX also match exact path.	2018-07-25 11:04:00 +02:00
Markus Reiter	a1f0ff4322	Merge pull request #4547 from reitermarkus/fix-name_error ... Don’t rescue `NameError` for `#run`.	2018-07-25 11:03:44 +02:00
Markus Reiter	802d7de8e8	Don’t rescue NameError for #run.	2018-07-25 10:42:16 +02:00
Markus Reiter	bfd82a3be1	Merge pull request #4546 from reitermarkus/remove-macho-check ... Remove `MachO` check for `Executable`.	2018-07-25 10:28:35 +02:00
Markus Reiter	d8624f5fe7	Remove MachO check for Executable.	2018-07-25 10:03:50 +02:00
commitay	7542c4edb7	utils/github: remove full stop from the "skipping" comment	2018-07-25 15:38:14 +10:00
Markus Reiter	83a1e8dd97	Refactor UnpackStrategy::Dmg.	2018-07-24 16:44:27 +02:00
Markus Reiter	1d167a6b9f	Reraise SystemCallError as ErrorDuringExecution.	2018-07-24 16:44:27 +02:00
Markus Reiter	eccd20e276	Merge Hbc::Container classes into UnpackStrategy.	2018-07-24 16:44:27 +02:00
ilovezfs	6027683d4e	Merge pull request #4542 from MikeMcQuaid/more-mojave-bottle-tweaks ... Change Mojave bottle behaviour	2018-07-24 10:52:46 +02:00
Mike McQuaid	6417332a3a	Change Mojave bottle behaviour ... Rather than relying on a `HOMEBREW_FORCE_BOTTLE` variable (which ends up doing silly things like forcing bottle usage even when options are provided) instead handle this at the `or_later` bottle detection level so on prerelease versions of macOS any bottle looks like an `or_later` bottle (unless various environment variables are set). Fixes issues noted in: https://github.com/Homebrew/brew/pull/4520#issuecomment-407229605	2018-07-24 09:25:32 +01:00
Markus Reiter	8223df081c	Merge pull request #4540 from reitermarkus/unpack-strategies ... Refactor unpack strategies into separate files.	2018-07-23 21:38:34 +02:00
Mike McQuaid	758aefaa27	Merge pull request #4539 from MikeMcQuaid/tab-options-handling ... tab: correctly handle options request.	2018-07-23 20:16:42 +01:00
Markus Reiter	b6e54a06e0	Refactor unpack strategies into separate files.	2018-07-23 20:59:28 +02:00
Markus Reiter	2c9dc62d35	Merge pull request #4534 from reitermarkus/remove-gpg-container ... Remove `Hbc::Container::Gpg`.	2018-07-23 20:59:11 +02:00
Mike McQuaid	ea97da9879	tab: correctly handle options request. ... Because a `Tab` is an `OpenStruct` the existing calls to `any_args_or_options?` would always return `false`. This means that `Formula#declared_runtime_dependencies` would never call `Tab#without?` to check whether a dependency has been brought in by an option. Fixes #4407	2018-07-23 19:58:39 +01:00
Mike McQuaid	0fe1f01e41	audit: output new formula issue comment failure message. ... This should help debug when this fails to be created.	2018-07-23 19:33:59 +01:00
Markus Reiter	b7eb7e48f0	Remove Hbc::Container::Gpg.	2018-07-23 19:35:01 +02:00
Markus Reiter	d6a245c051	Merge pull request #4536 from reitermarkus/container-system-command ... Add `system_command` helpers.	2018-07-23 18:46:56 +02:00
Mike McQuaid	44eeb59774	bottle: add --json and --merge docs. ... Fixes #4519.	2018-07-23 14:51:47 +01:00
Markus Reiter	1ccd1c0017	Don't use CaskError in Hbc::Container::Dmg.	2018-07-23 03:04:11 +02:00
Markus Reiter	e5e8033145	Add system_command helpers.	2018-07-22 23:24:18 +02:00
Markus Reiter	db299035ac	Merge pull request #4517 from reitermarkus/rename-system-command ... Rename `Hbc::SystemCommand` to `SystemCommand`.	2018-07-22 22:24:00 +02:00
Markus Reiter	45f6cc5bd0	Merge pull request #4532 from reitermarkus/directory-permissions ... Fix directory permissions when unpacking.	2018-07-22 22:23:45 +02:00
Markus Reiter	4f3df014cf	Merge pull request #4535 from reitermarkus/searchable-nil ... Fix `Searchable` when collection contains `nil`.	2018-07-22 22:14:16 +02:00
Markus Reiter	c29ab2d707	Fix DirectoryUnpackStrategy permissions.	2018-07-22 22:03:28 +02:00
Markus Reiter	b675024ce0	Add failing test for DirectoryUnpackStrategy.	2018-07-22 22:02:09 +02:00
Markus Reiter	8f462ddb5d	Fix Searchable when collection contains nil.	2018-07-22 21:51:53 +02:00
Markus Reiter	bcf05f1a48	Remove :cask from SystemCommand specs.	2018-07-22 21:11:47 +02:00
Markus Reiter	fd2a333b45	Use grep_v.	2018-07-22 21:11:47 +02:00
Markus Reiter	28384ba518	Rename Hbc::SystemCommand to SystemCommand.	2018-07-22 21:11:47 +02:00
Markus Reiter	4f495a967d	Add verbose to extract_nestedly.	2018-07-22 20:30:28 +02:00
Markus Reiter	891be1ec64	Add verbose to FileUtils calls.	2018-07-22 20:30:28 +02:00
Markus Reiter	9bd2167257	Add quiet flags if not verbose.	2018-07-22 20:30:28 +02:00
Markus Reiter	8278e9e403	Move verbose from #initialize to #extract.	2018-07-22 20:30:28 +02:00
Markus Reiter	de66dad834	Merge pull request #4524 from reitermarkus/missing-super ... Fix missing `super`.	2018-07-22 19:49:28 +02:00
Mike McQuaid	3b5aabf90d	Merge pull request #4531 from claui/spec-increase-timeout ... Increase spec timeout to 30 seconds	2018-07-22 16:30:11 +01:00
Claudia	8666d8fa18	Increase spec timeout to 30 seconds ... I’ve noticed the deadlock test in `cask/system_command_spec.rb` appears to fail spuriously, e. g. in #4529. Details: https://travis-ci.org/Homebrew/brew/jobs/406827725#L297-L318 With the spec taking 2 seconds on average on my 2017 MBP, I feel it’s entirely plausible for the aging test-bot hardware to get knocked by the 15-second timeout. Given that the spec will pass early anyway if it passes, I feel it’s reasonable to bump the timeout to 30 seconds.	2018-07-22 16:27:16 +02:00
Markus Reiter	d0951bdc1d	Remove Hbc::Container::Criteria.	2018-07-21 16:31:24 +02:00