6628 Commits

Author SHA1 Message Date
Mike McQuaid
6dd51ff399 audit: check for setuid in caveats. 2015-02-19 09:29:17 +00:00
Jack Nagel
e92a87179a Use ternary instead of inline rescue 2015-02-18 21:36:48 -05:00
Jack Nagel
4b1028c9e5 Start recording the formula path in the install receipt
Later we can use this information to try and load the formula from the
correct source.
2015-02-18 21:29:17 -05:00
Jack Nagel
1ab384a313 Revert "Start recording the formula path in the install receipt"
This reverts commit f98d1d660c38afe3caf1450b2443a6d5fab8a14b.
2015-02-18 21:08:24 -05:00
Jack Nagel
3158c398af Start recording the formula path in the install receipt
Later we can use this information to try and load the formula from the
correct source.
2015-02-18 20:35:47 -05:00
Xu Cheng
40087e30df ruby 1.8 doesn't have sort_by!
Closes Homebrew/homebrew#36935

Closes Homebrew/homebrew#36936.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-02-19 02:02:43 +08:00
Mike McQuaid
ce956eda8e cleanup-installed: fix brewdle command name 2015-02-18 14:10:27 +00:00
Mike McQuaid
bf76b71fe9 test-bot: don't repeat creating Bintray packages. 2015-02-18 13:19:13 +00:00
Mike McQuaid
579f288bd2 test-bot: construct formula object correctly. 2015-02-18 13:12:54 +00:00
Mike McQuaid
675991eb61 pull: publish bottles on Bintray. 2015-02-18 13:07:22 +00:00
Mike McQuaid
e9e2be9404 test-bot: autopublish existing bottles on Bintray. 2015-02-18 13:07:22 +00:00
Jack Nagel
4f13858fe8 Fix a couple of formatting issues in man page 2015-02-17 21:05:24 -05:00
Mike McQuaid
8f8e40295c test-bot: silent and correct bintray content path. 2015-02-17 19:42:37 +00:00
Mike McQuaid
fcb05efcd5 test-bot: more Bintray fixes. 2015-02-17 19:35:15 +00:00
Mike McQuaid
67828cd015 test-bot: specify bintray username/password. 2015-02-17 19:18:14 +00:00
Mike McQuaid
38f9a78c29 Add initial Bintray upload support. 2015-02-17 18:57:59 +00:00
Dominyk Tiller
51956d343a audit: extend ssl checks
Extends the audit checks to GnuPG, a significant chunk of Freedesktop
domains, and Github Pages. I’ve somewhat hardened my stance towards
Github Pages from the last time we extended this, hence the new
inclusion - I did a pretty thorough check through the Homebrew formulae
that use Github Pages for homepage links and found very few places
where enforcing SSL/TLS would cause issues - I think a wider
enforcement is worthwhile.

I’ve also fixed the capitalisation of the taps, if only because at the
moment it disagrees with what ` puts formula.tap ` outputs (We get
Homebrew/homebrew-head-only rather than homebrew/homebrew-head-only for
example).

Closes Homebrew/homebrew#36719.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-17 12:06:17 +00:00
Xu Cheng
86cd5d2f24 test-bot: fail fast in check_results
Closes Homebrew/homebrew#36893.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-17 10:30:42 +00:00
Xu Cheng
f204e2e608 audit: more information on build deps audit
Closes Homebrew/homebrew#36892.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-17 10:30:32 +00:00
Mike McQuaid
a4f675a0fb cleanup-installed: deprecate command. 2015-02-16 18:49:16 +00:00
Jack Nagel
3f3b7746dd Fix another filesystem leak in updater tests 2015-02-15 12:54:03 -05:00
Jack Nagel
eaf82ba09b Stage entire git repo into build directory
Closes Homebrew/homebrew#27193.
2015-02-14 16:32:24 -05:00
Jack Nagel
6648f976fb Remove unnecessary use of Dir[] 2015-02-14 15:28:40 -05:00
Xu Cheng
d0e2d126a1 audit: catch empty installations
Closes Homebrew/homebrew#36794.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-14 15:10:35 +00:00
Jack Nagel
6d791acf22 Support older git without "submodule sync --recursive"
Fixes Homebrew/homebrew#36774.
2015-02-13 22:16:57 -05:00
Xu Cheng
56f7208f8e info: show correct file origin for formula from path or url
Closes Homebrew/homebrew#36733.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-13 11:33:51 +00:00
Mike McQuaid
e34d9a7b37 outdated: handle HEAD, URL and path installation.
Handles edge cases missed in Homebrew/homebrew#36699.

Closes Homebrew/homebrew#36741.

Closes Homebrew/homebrew#36760.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-13 10:58:43 +00:00
Mike McQuaid
0caa1912d9 Move "path or URL" tap string to global constant. 2015-02-13 10:58:43 +00:00
Jack Nagel
7004d3de0d Extract logging from the command class 2015-02-12 20:20:10 -05:00
Jack Nagel
384c444be8 Drop unnecessary call to compact 2015-02-12 20:09:31 -05:00
Jack Nagel
28b926686b Get the basename and dirname once 2015-02-12 19:13:03 -05:00
Mike McQuaid
988ec8de98 outdated: handle fully qualified tapped formulae.
Previously if I did `brew install boxen/brews/imagemagick` and then `brew
upgrade boxen/brews/imagemagick` and the version of `imagemagick` in
`boxen/brews` was older than the version in `Homebrew/homebrew` then it would
install the correct version from the `boxen/brews` tap and then try to
immediately upgrade it to the version from `Homebrew/homebrew`. I'd argue
fairly strongly that this behaviour is pretty unintuitive; when you fully
specify a formula from a tap then it should be prioritised by `brew upgrade`
and `brew outdated.

This commit makes `brew upgrade boxen/brews/imagemagick` only upgrade the
version of `imagemagick` if the version in the `boxen/brews` tap is newer.
Similarly `brew outdated imagemagick` and `brew outdated
boxen/brews/imagemagick` will show different results if the newer version
differs between `boxen/brews` and `Homebrew/homebrew`.

Closes Homebrew/homebrew#36699.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-11 14:22:48 +00:00
Mike McQuaid
2320c0a6c1 pull: copy new subject when bumping. 2015-02-11 14:22:19 +00:00
Xu Cheng
4d17d4c8db gist-logs: show the formula origin for non core-formula
Closes Homebrew/homebrew#36730.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-11 11:04:37 +00:00
Xu Cheng
f640cbac9e brew uses: parse ARGV properly
`ARGV.flag?` = `ARGV.include?` + `ARGV.switch?`

Closes Homebrew/homebrew#36727.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-11 11:02:46 +00:00
Xu Cheng
105eaf3382 test-bot: only test the runtime dependencies.
Also add support to `brew uses` to ignore build or optional dependencies.

Closes Homebrew/homebrew#36154.
Closes Homebrew/homebrew#36656.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-09 14:12:19 +00:00
Dominyk Tiller
8e12390fc8 Update Example Formula documentation.
I feel like we’re probably fighting a losing battle here, but here’s a
bundle more updates to the example formula to cover some ground not
already covered.

Closes Homebrew/homebrew#36644.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-09 12:40:10 +00:00
Jack Nagel
4b91017894 Make compiler shim robust against missing environment variables
Fixes Homebrew/homebrew#36217.
2015-02-08 20:04:07 -05:00
Jack Nagel
d4e24dce0a Get rid of cccfg? method 2015-02-08 20:04:06 -05:00
Jack Nagel
fd031f256a Add predicate methods for compiler shim configuration 2015-02-08 20:04:06 -05:00
Jack Nagel
60452a526f Quote entire path passed to checkout-index 2015-02-08 19:53:38 -05:00
Jack Nagel
5c758f7852 Revert "download_strategy: escape spaces in git submodule path."
This is causing submodules to be checked out into a path with a literal
"$path" component:

$ find . | grep "\$path$"
./$path
./Carthage/Checkouts/Commandant/$path
./Carthage/Checkouts/Commandant/Carthage/Checkouts/Quick/$path
./Carthage/Checkouts/PrettyColors/$path
./Carthage/Checkouts/Quick/$path
./Carthage/Checkouts/ReactiveCocoa/$path
./Carthage/Checkouts/ReactiveCocoa/Carthage/Checkouts/Quick/$path
./Carthage/Checkouts/ReactiveTask/$path
./Carthage/Checkouts/ReactiveTask/Carthage/Checkouts/Quick/$path
./Carthage/Checkouts/ReactiveTask/Carthage/Checkouts/ReactiveCocoa/$path
./Carthage/Checkouts/ReactiveTask/Carthage/Checkouts/ReactiveCocoa/Carthage.checkout/Quick/$path

This reverts commit 3a5f099297e9ab3b799af5f7a65edd8d64bc7bae.
2015-02-08 19:44:39 -05:00
Xu Cheng
e547438ff4 cmd/info: prevent duplicate dependency display.
Before:

    $ brew info llvm
    ==> Dependencies
    Build: xz ✔, xz ✔, xz ✔, xz ✔, xz ✔, xz ✔

    $ brew info --json=v1 llvm
    ... "dependencies":["xz","xz","xz","xz","xz","xz"], ...

After

    $ brew info llvm
    ==> Dependencies
    Build: xz ✔

    $ brew info --json=v1 llvm
    ... "dependencies":["xz"], ...

Closes Homebrew/homebrew#36653.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-08 15:53:30 +00:00
Kashif Rasul
003d650e88 download_strategy: escape spaces in git submodule path.
for issue Homebrew/homebrew#36646

Closes Homebrew/homebrew#36649.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-08 14:14:34 +00:00
Dominyk Tiller
2abd3298f9 audit: catch more examples from example_formula
See
https://github.com/Homebrew/homebrew/pull/36629#discussion_r24293912
amongst other recent examples. The example formula isn’t as strongly
policed as the ` brew create ` default, this tries to do something
about that.

Closes Homebrew/homebrew#36639.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-08 12:24:17 +00:00
David Christenson
fb246b0f4e Minimize test JPEG and PNG
Losslessly compress with jpegoptim and optipng.

Closes Homebrew/homebrew#36606.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-08 12:23:39 +00:00
David Christenson
46aa40c067 Add test PDF and SVG. 2015-02-08 12:23:31 +00:00
Xu Cheng
f8791da2ec formula: sort installed version in to_hash
https://github.com/Homebrew/homebrew-brewdler/pull/43#discussion_r24248760

Closes Homebrew/homebrew#36611.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-07 20:43:03 +00:00
Jack Nagel
357d0f2796 Use start_with? to simplify path sanity check 2015-02-07 13:54:33 -05:00
Jack Nagel
f438af9915 Don't prune cellar paths when cellar is in /opt
Fixes Homebrew/homebrew#35382.
2015-02-07 13:54:33 -05:00