5820 Commits

Author SHA1 Message Date
Mike McQuaid
167dac74b7 utils: tweak install_gem_setup_path to not warn.
If the `Gem.user_dir/bin` is not already in the PATH it'll complain
unnecessarily (as we add it to the PATH ourselves) so just add it to the
PATH before running the install.
2015-01-02 13:37:06 +00:00
Mike McQuaid
9e8103cf38 Add Homebrew.install_gem_setup_path! function.
This uses the logic from tests.rb in man.rb too so that this can be
shared in a few places.
2015-01-02 12:42:02 +00:00
Baptiste Fontaine
81986ee7a7 audit: system check fixed for multiple arguments
Closes Homebrew/homebrew#35459.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-01-02 10:36:36 +00:00
Mike McQuaid
1e96c6fec4 formula_versions: ignore another exception. 2015-01-02 10:34:36 +00:00
Shaun Jackman
c01e6b81d3 test-bot: do not --cleanup outside CI.
Closes Homebrew/homebrew#35424.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-01-02 09:50:28 +00:00
Mike McQuaid
e87b377add pull: fix tap URL regex for devel/head-only. 2015-01-02 09:24:25 +00:00
Baptiste Fontaine
8fcfa08c43 ID3 tags stripped from MP3 test fixture
Closes Homebrew/homebrew#35427.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-01-01 21:34:12 +00:00
Jack Nagel
26a2e4c4d3 Avoid formula lookup when we know it will fail
Formulary.loader_for cannot raise exceptions, as canonical_name must
work for nonexistent formulae. However, we can skip the constant lookup
and a redundant file existence check by returning a loader that raises
immediately in #get_formula.
2015-01-01 13:21:29 -05:00
Jack Nagel
34fc227f92 Get rid of StandardLoader class 2015-01-01 13:21:29 -05:00
Baptiste Fontaine
b7ca3e33d6 minimal MP3 test file added
Closes Homebrew/homebrew#35417.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-01-01 15:02:08 +00:00
Jack Nagel
648c47e85d Re-raise NameError when it doesn't match our constant 2014-12-31 17:28:21 -05:00
Jack Nagel
5bf92cd7ca Check file existence instead of rescuing LoadError 2014-12-31 17:28:21 -05:00
Jack Nagel
2cb160dc46 Stop rescuing NameError
This clause originated in 4a36c56ac7b36904712aa472b9bd50ef1b0c80d3,
attempting to catch NameErrors raised by const_defined? calls earlier in
the method body. Those const_defined? calls have since been moved out of
the body of the begin block.

Stop rescuing NameError here, which will make true programming errors in
formulae easier to debug.
2014-12-31 17:28:21 -05:00
Jack Nagel
62c0a391b4 Don't attempt to detect version if URL is not set 2014-12-31 10:38:04 -05:00
Jack Nagel
8ebaa9c0a9 Handle newer ruby versions correctly in config output
Since Ruby 2.1, patch releases take the form "2.x.y" rather than
"2.x.y-pnum".
2014-12-31 09:54:44 -05:00
Jack Nagel
1de21b7f00 Use block-form of File.open 2014-12-30 23:52:07 -05:00
Jack Nagel
accd72b290 Log build environment on failure 2014-12-30 23:47:07 -05:00
Jack Nagel
77c0f60434 Always dump full configuration 2014-12-30 23:33:50 -05:00
Xu Cheng
b10c58d6e2 brew-config: always show XCode/CLT state
Closes Homebrew/homebrew#33860.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2014-12-30 23:18:05 -05:00
Jack Nagel
8b51cf019d Move exception text into exception object 2014-12-29 22:57:45 -05:00
Jack Nagel
912a586d15 Preserve backtrace for download errors 2014-12-29 22:51:55 -05:00
Jack Nagel
a955665102 Preserve backtrace from original exception 2014-12-29 15:23:01 -05:00
Jack Nagel
633f29af5d Remove duplicated logic from FromUrlLoader 2014-12-29 14:59:18 -05:00
Jack Nagel
2bf1f93721 Extract method 2014-12-29 14:59:18 -05:00
Mike McQuaid
4d584d37f7 test-bot: don't try to retap TapDependency taps. 2014-12-29 12:28:43 +00:00
Mike McQuaid
95ccf53a49 test-bot: tap TapDependency's tap. 2014-12-29 12:20:30 +00:00
Mike McQuaid
b3d44da9e3 TapDependency: add tap accessor. 2014-12-29 12:20:03 +00:00
Mike McQuaid
eb51f8a5fa test-bot: init added/modified formulae arrays. 2014-12-29 07:55:01 +00:00
Mike McQuaid
bff259330c test-bot: clean up harder on failure (before). 2014-12-29 07:51:50 +00:00
Jack Nagel
e651e7662a Use formula helper in tests 2014-12-28 21:56:06 -05:00
Misty De Meo
d57fe3eded search: add homebrew-x11 to default taps 2014-12-28 18:42:20 -08:00
Mike McQuaid
8c19b2a13e test-bot: clean harder if first clean fails. 2014-12-28 18:17:12 +00:00
Mike McQuaid
af4a156885 test-bot: tweak readability. 2014-12-28 18:17:02 +00:00
Mike McQuaid
b5439b6f7a test-bot: check if dependents are installed.
Before fetching or installing with no args.
2014-12-28 18:16:49 +00:00
Mike McQuaid
515395171c Set cask and download DSL values on requirements.
Closes Homebrew/homebrew#35257.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2014-12-28 12:14:49 +00:00
Mike McQuaid
99ecc9ac34 unsigned_kext_req: use new cask/download DSL. 2014-12-28 12:14:49 +00:00
Mike McQuaid
88208af8e4 requirement: add cask and download attributes.
Print out the message pointing to the Cask and/or download location too.a
2014-12-28 12:14:49 +00:00
Jack Nagel
7f29dc13b8 Drop pointless subclass in test 2014-12-28 00:03:16 -05:00
Jack Nagel
8805f3ae51 Drop unnecessary requires 2014-12-28 00:03:16 -05:00
Jack Nagel
0a16fff0cd Avoid TestBall class in checksum verification tests 2014-12-28 00:03:16 -05:00
Jack Nagel
3c9bee268b Preserve signature of #initialize in tests 2014-12-27 23:11:32 -05:00
Jack Nagel
9e335fa0b8 Revert "audit (strict): check for use double-quotes."
This reverts commit 8fe14451842dea92bca04116ba043421b4f44a6b.

Conflicts:
	Library/Homebrew/cmd/audit.rb
2014-12-27 17:07:30 -05:00
Jack Nagel
1ee1e2ca3c Stop testing accessor type 2014-12-27 16:31:38 -05:00
Jack Nagel
728a7c6259 Remove dead code 2014-12-27 16:31:32 -05:00
Jack Nagel
ba48d8c5b9 Use version attribute directly in cache comparisons
The bug that prompted the two relevant commits has since been addressed.

Squashed commit of the following:

commit ecca17ede8324efd1175a42300ace8e1e2df30fa
Author: Jack Nagel <jacknagel@gmail.com>
Date:   Sat Dec 27 16:16:12 2014 -0500

    Revert "Don't use pkg_version when cleaning the cache"

    This reverts commit 4d511b5169d78a5d44bbf6c36c17f0c28014a614.

commit e8935de08f6440ae1874ce523f93b19da6b68df3
Author: Jack Nagel <jacknagel@gmail.com>
Date:   Sat Dec 27 16:16:12 2014 -0500

    Revert "Fix cleanup for head-only formulae"

    This reverts commit 510267ffd314c296c0b0969dd27d130a249f16e2.
2014-12-27 16:16:16 -05:00
Mike McQuaid
e1c6a4614f Rename HEAD only tap. 2014-12-27 20:55:21 +00:00
Mike McQuaid
8458540afb audit: simplify test defined check. 2014-12-27 20:46:01 +00:00
Mike McQuaid
13239276f0 audit: improve FileUtils check.
Match the parens properly and only interpolate once.

Closes Homebrew/homebrew#35288.
Closes Homebrew/homebrew#35291.
2014-12-27 20:35:26 +00:00
Jack Nagel
77a1c6f166 One less external call to #active_spec 2014-12-27 14:26:56 -05:00
Mike McQuaid
b43876d4a2 create: recommend brew audit --strict. 2014-12-27 16:51:53 +00:00