1701 Commits

Author SHA1 Message Date
Mike McQuaid
2320c0a6c1 pull: copy new subject when bumping. 2015-02-11 14:22:19 +00:00
Xu Cheng
4d17d4c8db gist-logs: show the formula origin for non core-formula
Closes Homebrew/homebrew#36730.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-11 11:04:37 +00:00
Xu Cheng
f640cbac9e brew uses: parse ARGV properly
`ARGV.flag?` = `ARGV.include?` + `ARGV.switch?`

Closes Homebrew/homebrew#36727.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-11 11:02:46 +00:00
Xu Cheng
105eaf3382 test-bot: only test the runtime dependencies.
Also add support to `brew uses` to ignore build or optional dependencies.

Closes Homebrew/homebrew#36154.
Closes Homebrew/homebrew#36656.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-09 14:12:19 +00:00
Xu Cheng
e547438ff4 cmd/info: prevent duplicate dependency display.
Before:

    $ brew info llvm
    ==> Dependencies
    Build: xz ✔, xz ✔, xz ✔, xz ✔, xz ✔, xz ✔

    $ brew info --json=v1 llvm
    ... "dependencies":["xz","xz","xz","xz","xz","xz"], ...

After

    $ brew info llvm
    ==> Dependencies
    Build: xz ✔

    $ brew info --json=v1 llvm
    ... "dependencies":["xz"], ...

Closes Homebrew/homebrew#36653.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-08 15:53:30 +00:00
Dominyk Tiller
2abd3298f9 audit: catch more examples from example_formula
See
https://github.com/Homebrew/homebrew/pull/36629#discussion_r24293912
amongst other recent examples. The example formula isn’t as strongly
policed as the ` brew create ` default, this tries to do something
about that.

Closes Homebrew/homebrew#36639.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-08 12:24:17 +00:00
Jack Nagel
cd522b1719 Always respect build options when invoking post_install
Fixes Homebrew/homebrew#36335.
2015-02-07 11:02:35 -05:00
Mike McQuaid
e8d8c3a486 test-bot: don't try and bottle unstable formulae.
e.g. devel-only or head-only formulae.
2015-02-04 14:20:21 +00:00
Jack Nagel
2bf409d888 brew list foo should always error when foo is not installed
Fixes Homebrew/homebrew#36484.
2015-02-03 20:26:57 -05:00
Mike McQuaid
f2a9b9cbd2 test-bot: optional requirements are satisfied. 2015-02-03 16:46:36 +00:00
chdiza
5e854164a7 untap: Handle multiple arguments
Closes Homebrew/homebrew#36436.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-01 20:12:13 +01:00
Dominyk Tiller
5ac0446fd7 test-bot: support --devel and/or --HEAD install
See discussion in https://github.com/Homebrew/homebrew-devel-only/pull/8

In essence, the test bot currently does this:

```
==> brew install --verbose --build-bottle j2objc			 FAILED
Error: j2objc is a devel-only formula
Install with `brew install --devel j2objc`
```

I’m proposing that we pass that arg to the test-bot automatically to
allow the bot to pass head-only and devel-only formulae without that
failure message. I’ve also trimmed the arguments further down to
prevent it duplicating the —devel install in formulae which define no
stable block.

Closes Homebrew/homebrew#36030.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-01-27 12:40:36 +00:00
Mike McQuaid
c2e0fb0c08 config: be quieter with java_home.
References Homebrew/homebrew#36249.
2015-01-27 12:25:27 +00:00
Dominyk Tiller
40ddea637a audit: stop red-flagging devel-only
Currently the bot is failing certain devel-only formulae because it
thinks having ` devel ` defined with an added ` head ` defined
as well = a head-only formula.

```
==> audit problems
docker-machine:
 * Head-only (no stable download)
```

This is a pretty simple fix for that problem:

```
==> brew style docker-machine
1 file inspected, no offenses detected
```

Closes Homebrew/homebrew#36197.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-01-26 14:39:12 +00:00
Xu Cheng
8fc3c4c8e9 brew-config: check whether java exists in PATH
For OS X, we will call `/usr/libexec/java_home` to exam whehter
java is installed.

Also rename the method to follow the same naming pattern of other
similar methods.

Closes Homebrew/homebrew#36187.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-01-25 10:05:56 +00:00
Mike McQuaid
105fcb5399 pull: allow temporarily editing an empty commit. 2015-01-23 17:35:20 +01:00
Jack Nagel
bf6887bc59 Deprecate GithubGistFormula
Closes Homebrew/homebrew#36094.
2015-01-22 20:34:51 -05:00
Jack Nagel
165b47c0e6 Audit check for gnome unstable as stable 2015-01-22 16:58:54 -05:00
Baptiste Fontaine
aec2f01a55 config: add Java to output.
Closes Homebrew/homebrew#35596.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-01-22 17:16:36 +01:00
Jack Nagel
af1e9a9610 Expose bottle details on the formula object
Fixes Homebrew/homebrew#36032.
2015-01-20 22:27:23 -05:00
Mike McQuaid
6a6b56127c test-bot: handle devel-only formulae. 2015-01-17 19:12:10 +01:00
Xu Cheng
6d786e7dbb brew-config: show realpath for pyenv and rbenv
Closes Homebrew/homebrew#35819.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-01-17 18:48:34 +01:00
Jack Nagel
c6dee041eb install: fix --HEAD for formulae with head and devel but no stable 2015-01-16 00:00:21 -05:00
Dominyk Tiller
3f318b8ed4 install: handle devel-only correctly
See the discussion in
https://github.com/Homebrew/homebrew-devel-only/pull/6

Closes Homebrew/homebrew#35793.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2015-01-15 23:50:45 -05:00
Mike McQuaid
fd8bb8776c doctor: accepting the Xcode license requires sudo. 2015-01-15 15:46:35 +00:00
Mike McQuaid
dac4848661 pull: merge and rebase when pulling bottles.
This seems to be a more robust approach when a PR has multiple commits.
2015-01-15 11:15:13 +00:00
Jack Nagel
7f7742c2b6 Add message to the exception raised when tests return false 2015-01-13 12:35:50 -05:00
Jack Nagel
4bdfb27d9f Move assertion setup into formula_assertions.rb 2015-01-13 12:33:50 -05:00
Jack Nagel
b61528e757 Save and restore ENV around test invocations
This prevents mutations that happen in individual tests from leaking
into other tests.
2015-01-13 12:19:56 -05:00
Jack Nagel
d298e54e50 doctor: check access on HOMEBREW_PREFIX/opt 2015-01-12 21:29:22 -05:00
Jack Nagel
d0a1800e37 doctor: check access on all important HOMEBREW_PREFIX subdirs 2015-01-12 21:26:18 -05:00
Jack Nagel
b1514c1c40 doctor: check cellar access 2015-01-12 21:26:18 -05:00
Jack Nagel
aa4ff175ff doctor: fix grammar 2015-01-12 21:26:18 -05:00
Jack Nagel
9ff211f212 doctor: remove incorrect statement from HOMEBREW_LOGS check 2015-01-12 21:26:18 -05:00
Mike McQuaid
3f08b8881b cleanup-installed: use uninstall --force. 2015-01-11 10:12:44 +00:00
Xu Cheng
1818799634 test-bot: unlink conflict formulae during the test
Closes Homebrew/homebrew#35697.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-01-09 15:37:29 +00:00
Mike McQuaid
26b80ecccc test-bot: improve output of dependent testing. 2015-01-09 11:35:03 +00:00
Mike McQuaid
424ded8fdb test-bot: ignore changed dependents. 2015-01-09 11:35:03 +00:00
Jack Nagel
459f92b065 Remove another use of the direct url writer
masgn is hard to grep for :/
2015-01-08 14:28:43 -05:00
Dominyk Tiller
50d64da1ec audit: improve ssl/tls detection
I don’t know how maintainers are going to feel about this, to be
honest. If it’s too clunky, perhaps we could externalise the entire two
main blocks here and then require that file into the audit instead?

Basically, I’m pushing changes here to better detect a wide-array of
SSL/TLS available links that either have no auto-redirect in place or
is a common linking error in formulae. I haven’t spotted any false
positives yet, but obviously, feel free to try and break the changes
and I’ll fix as necessary ;).

IMO, this would allow us gradual updates without having to mass-update
everything at once and stress the bot and inform users they have
hundreds of updates pending when really it’s just style/basic changes.

Closes Homebrew/homebrew#35551.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-01-06 08:16:25 +00:00
Jack Nagel
dcad08339e Fix syntax error 2015-01-05 15:28:31 -05:00
Jack Nagel
d79a7c0fcf Always use exec_editor to exec the editor 2015-01-05 15:27:07 -05:00
Mike McQuaid
3821c190f9 style: explicitly point to config file.
Closes Homebrew/homebrew#35556.
2015-01-05 08:01:20 +00:00
Mike McQuaid
980cad0717 audit (strict): only run brew style with Ruby 2. 2015-01-05 07:52:47 +00:00
Dominyk Tiller
e871a91958 install: fail on devel where devel doesn't exist
Just equalises a little how we treat HEAD and devel. The former already
fails if there isn’t a head defined, It seemed logical that devel
should fail in the same way.

Closes Homebrew/homebrew#35554.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2015-01-05 00:04:23 -05:00
Jack Nagel
f937e5f920 Forward arguments in IRB formula helpers 2015-01-04 21:37:27 -05:00
Jack Nagel
4398660cdd Checkout outdatedness in brew upgrade <formula>
Fixes Homebrew/homebrew#35523.
2015-01-04 14:03:56 -05:00
Mike McQuaid
c294ce22a7 audit: also run brew style on --strict.
Closes Homebrew/homebrew#35465.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-01-04 11:05:34 +00:00
Mike McQuaid
e0cacd3008 style: run Rubocop on formulae (new command) 2015-01-04 11:05:34 +00:00
Mike McQuaid
1cd0a47067 tests.rb: use Homebrew.failed to send exit code. 2015-01-04 11:05:34 +00:00