373 Commits

Author SHA1 Message Date
Jack Nagel
269405995e Simplify getting the list of doctor checks 2014-09-07 14:20:37 -05:00
Josh Larson
a316a07251 Fix comma splice in outdated brew message
Closes Homebrew/homebrew#32123.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2014-09-06 00:29:16 -05:00
Jack Nagel
6638d08489 doctor: print values of DYLD_* env vars 2014-09-04 17:33:33 -05:00
Jack Nagel
b46f8caa8f Object#methods returns an array of symbols on 1.9+
Fixes Homebrew/homebrew#31926.
2014-08-27 15:47:09 -05:00
xxxajk
1dc384b4c4 Fix mktmp to be generic as-per SUS/BSD.
Closes Homebrew/homebrew#31586.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2014-08-14 10:36:07 +01:00
Jack Nagel
11470e2a1a Don't compare versions against floating point numbers 2014-08-09 22:01:28 -05:00
Misty De Meo
2c9ad45784 doctor: retire Mono warning
We haven't actually had any complaints about this in awhile; it appears
that cmake no longer picks up this specific framework.

Refs Homebrew/homebrew#11030.
2014-08-08 20:17:25 -07:00
Jack Nagel
ba4a4e4103 Limit exposure of the options data structures 2014-07-29 21:54:32 -05:00
Jack Nagel
7078af8218 Pass the string directly to the output method 2014-07-19 23:50:59 -05:00
Jack Nagel
d2aeadb1cd Pass array to puts instead of iterating over it 2014-07-19 23:36:02 -05:00
Jack Nagel
cf8f8dec1f Fix up phrasing of case-sensitive volume warning 2014-07-09 17:04:52 -05:00
Jack Nagel
82ce0be6fd Clean up /bin/df regexp
- remove unnecessary captures
 - '%' is not a metacharacter so it doesn't need to be escaped
 - match using '+' instead of '*'
2014-07-09 17:04:52 -05:00
Jack Nagel
5ab16295e5 Fix getting filesystem mounts 2014-07-09 17:04:52 -05:00
Jack Nagel
2d8a3ac35a Use popen wrapper
Closes Homebrew/homebrew#30678.
2014-07-05 15:41:22 -05:00
Jack Nagel
804872fc94 Use sort_by in missing deps doctor check 2014-07-01 20:11:55 -05:00
Jack Nagel
51326e0b63 Extend with a module instead of aliasing on the singleton class 2014-06-25 11:19:00 -05:00
Jack Nagel
4d9d01893e Move deprecated Formula class methods to compat
These have all been moved to Formulary.
2014-06-22 15:03:17 -05:00
Mike McQuaid
1c176348ca doctor: add caveats to avoid scaring people.
Sporadically people ask to whitelist doctor warnings or file issues when
there's nothing actually wrong. Help reassure such people with a
friendly message.

Closes Homebrew/homebrew#30230.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2014-06-20 11:14:35 +01:00
Jack Nagel
4f8be5bb66 Remove obsolete doctor check
Both build environments remove MACOSX_DEPLOYMENT_TARGET by default.
2014-06-19 19:32:37 -05:00
Jack Nagel
d9c586e201 Remove unnecessary string evals from doctor 2014-06-19 19:32:37 -05:00
Jack Nagel
b87f9b37d6 Pull requires out of methods 2014-06-19 17:55:04 -05:00
Jack Nagel
10a1952d2c Only "extend self" once on the Homebrew module 2014-06-19 13:10:36 -05:00
Jack Nagel
c0e0bd2984 Read df output in binary mode
Fixes Homebrew/homebrew#30046.
2014-06-11 00:42:51 -05:00
Misty De Meo
8cb980f7be doctor: Add check for install_name_tool
Closes Homebrew/homebrew#29593.
2014-06-03 22:50:37 -07:00
Jack Nagel
0e0bee9c50 Update ruby version doctor check 2014-06-03 11:04:07 -05:00
Jack Nagel
c5bcd99eb4 Re-enable Xcode-only support on 10.9
Closes Homebrew/homebrew#29377.
2014-05-19 14:41:03 -05:00
Jack Nagel
4676045bdd Less snark 2014-05-18 17:43:07 -05:00
Jack Nagel
1845b39d41 Separate Xcode and CLT doctor checks by OS X version
Closes Homebrew/homebrew#29206.
2014-05-12 18:59:52 -05:00
Jack Nagel
348d0eb05c doctor: use Xcode.bundle_path 2014-05-02 16:50:25 -05:00
Jack Nagel
273d580550 Apparently quiet_system isn't always quiet
cf. Homebrew/homebrew#28918.
2014-05-02 11:00:29 -05:00
Jack Nagel
cf5ecfc06d doctor: suppress warnings from git wrapper script
Fixes Homebrew/homebrew#28901.
2014-05-02 09:52:14 -05:00
Jack Nagel
86daf90700 Remove bad doctor check 2014-05-01 19:43:42 -05:00
Jack Nagel
aa5a5a526f Rename Xcode.folder to MacOS.active_developer_dir
This reflects what Apple calls it in more recent versions of Xcode/OS X.
2014-05-01 18:36:46 -05:00
Jack Nagel
9d02c39e23 Fix syntax error 2014-04-15 11:37:20 -05:00
Jack Nagel
a55e670a8a Remove yet another xcode-select check 2014-04-15 11:28:01 -05:00
Jack Nagel
a9461dd01b doctor: fix typo
Fixes Homebrew/homebrew#28221.
2014-04-07 10:03:44 -05:00
Jack Nagel
a2a75aca1a Mirror unlink logic when checking for linked keg-only formulae 2014-04-06 13:56:26 -05:00
Jack Nagel
0d3121f781 Batch up mdfind calls when possible 2014-04-01 20:47:26 -05:00
Mike McQuaid
6e86976920 Revert "doctor: use double quotes for setting PATH."
I'm an idiot.

This reverts commit f890e4973840a66a522189c8e5530bff61d17162.
2014-03-25 16:20:53 +00:00
Mike McQuaid
0d898edc37 doctor: use double quotes for setting PATH.
Closes Homebrew/homebrew#27619.
2014-03-25 16:02:19 +00:00
Adam Vandenberg
5c51c85564 Finesse doctor message for /Library Python 2014-03-05 21:29:36 -08:00
Adam Vandenberg
95d7776a90 add check for /Library Python
Closes Homebrew/homebrew#24788.
2014-03-01 23:19:36 -08:00
Mike McQuaid
09330dd83b doctor: tweak XQuartz check.
Sometimes (e.g. Homebrew/homebrew#27014) it may find an installed version but no prefix.

In this case we still want to tell users if it's outdated.
2014-02-26 12:40:25 +00:00
Adam Vandenberg
fab5e1d905 add doctor check for HOMEBREW_KEEP_INFO 2014-02-23 08:31:03 -08:00
Mike McQuaid
268e32e37c doctor: don't complain about unmigrated remote. 2013-12-17 23:40:21 +00:00
Mike McQuaid
4b7f435a00 doctor: fix autocrlf set command.
Fixes Homebrew/homebrew#25282.
2013-12-17 16:34:01 +00:00
Mike McQuaid
5751b9e66c doctor: add instructions for remote migration. 2013-12-17 16:25:51 +00:00
Chris Kampmeier
2635817ca8 doctor: don't let gitconfig break dirty-tree check
`brew doctor` always complains about uncommitted modifications to
Homebrew when you have status.branch=true in your git config, because
the implicit --branch makes `git status -s` always print branch/tracking
info. The --porcelain mode is similar to -s/--short, but ignores most of
the user's config and should remain stable.

The --untracked-files option ensures we'll see untracked files even for
users with status.showUntrackedFiles=no, which is not suppressed by
--porcelain for some reason.

Closes Homebrew/homebrew#25230.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2013-12-15 17:20:45 +00:00
Mike McQuaid
a1728a8174 doctor: check for migrated origin Git remote.
Closes Homebrew/homebrew#25211.
2013-12-14 23:11:16 +00:00
Mike McQuaid
4c2e7b1659 Update docs, comment mxcl/homebrew refs. 2013-12-14 18:18:35 +00:00