4631 Commits

Author SHA1 Message Date
Jack Nagel
344f77e179 Don't load unused compat files for tests 2014-06-16 14:32:24 -05:00
Jack Nagel
3b3c03159a Remove compat/brewkit
Formulae from the "brewkit" era are no longer compatible with the
Formula class.

This file was (unintentionally) removed from the $LOAD_PATH quite
a while ago, and nobody has complained, so remove it.
2014-06-16 13:58:54 -05:00
Jack Nagel
86942aeaee Remove an internal method from compat 2014-06-16 13:53:30 -05:00
Jack Nagel
f3817b58ee install: move requires to top of file 2014-06-16 13:36:17 -05:00
Jack Nagel
e91f359a56 Remove an unnecessary use of ARGV.build_head? 2014-06-15 23:31:58 -05:00
Jack Nagel
5c24876d02 Fix audit suggestion 2014-06-15 23:28:06 -05:00
Jack Nagel
6e1450e974 Handle illegal constant names when fetching remote formulae 2014-06-15 20:23:20 -05:00
Adam Vandenberg
9c4d309a80 readall: fix permissions 2014-06-15 16:21:28 -07:00
Adam Vandenberg
53826bdb0e Migrate readall 2014-06-15 15:48:14 -07:00
Jack Nagel
c8fd1214bd Revert "Only do formula class sanity checks once"
This reverts commit ace78b1f3a59a893c7068e485555acf792470080.

Fixes Homebrew/homebrew#30154.
2014-06-14 16:04:38 -05:00
Ben Hale
014ac21193 Remove cloudfoundry-cli
This change removes the cloudfoundry-cli formula from the repository.
It will now be available from pivotal/tap tap.

Closes Homebrew/homebrew#30105.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2014-06-14 09:35:17 -05:00
Jack Nagel
4b07dbbf78 Only define intel family test on intel CPU 2014-06-13 16:32:26 -05:00
Jack Nagel
1b9aed4025 Always pass path to formula constructor 2014-06-12 23:14:01 -05:00
Jack Nagel
d3ad1212fb Make compiler objects directly 2014-06-12 23:13:17 -05:00
Jack Nagel
718b6f8b0c No need to send, just call the method 2014-06-12 21:47:36 -05:00
Jack Nagel
4c0d2c2bfb Handle failures in temporary_install better 2014-06-12 21:33:55 -05:00
Jack Nagel
1beefdb5d0 Remove repeated test code 2014-06-12 21:31:51 -05:00
Jack Nagel
e9cf30eb2c Support older Minitest constant 2014-06-12 21:28:00 -05:00
Jack Nagel
3f3ba8462e Always expand __FILE__ 2014-06-12 18:14:48 -05:00
Jack Nagel
8c2db70cf8 Always pass a path to formula constructor in tests 2014-06-12 17:58:12 -05:00
Jack Nagel
59981c5b4c Move a test class that is only used once into the test 2014-06-12 17:58:12 -05:00
Jack Nagel
a50f09c343 Remove an extra slash in file:// URLs in tests 2014-06-12 17:58:12 -05:00
Jack Nagel
9a554f5f4b Use example.com as domain in tests 2014-06-12 17:58:12 -05:00
Jack Nagel
4f476d7066 Remove dummy method 2014-06-12 17:58:12 -05:00
Jack Nagel
502078099f Prefer self.class.name to self.class.to_s 2014-06-12 16:13:07 -05:00
Jack Nagel
4651b5214f Remove a const_defined? check 2014-06-12 16:09:03 -05:00
Shaun Jackman
ae3e567daa Linuxbrew: Use xdg-open
Closes Homebrew/homebrew#29817.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2014-06-12 13:11:05 -05:00
Jack Nagel
96195295a3 Deprecate Pathname#cp and Pathname#chmod_R
As far as I can tell these methods have only ever been used in the test
suite.

Since Formula includes FileUtils, it is generally simpler (and in the
case of cp, more readable) to use the FileUtils methods directly.

Closes Homebrew/homebrew#30081.
2014-06-12 09:00:58 -05:00
Jack Nagel
faaa622820 Deprecate Pathname#/ with non-string/non-pathname arguments
Ruby 2.2 will define Pathname#/ as a simple alias of Pathname#+.
In practice, this means that it will raise a TypeError unless the
argument responds to to_path or to_str.

Currently we blindly convert the argument to a string using to_s, so
deprecate this in the interest of matching the upstream behavior. In the
future we can replace this with

  alias_method :/, :+ unless method_defined?(:/)

Closes Homebrew/homebrew#30079.
2014-06-12 09:00:51 -05:00
Jack Nagel
6eb7e0c27f Eliminate an uninitialized ivar warning 2014-06-11 21:34:09 -05:00
Jack Nagel
c319eb1f01 Decouple CompilerSelector from MacOS, clean up tests 2014-06-11 21:23:05 -05:00
Jack Nagel
290db72bd5 Pass the version into the Compiler constructor, eliminate a type check 2014-06-11 21:21:50 -05:00
Jack Nagel
f3e9c5c070 Fix up some assertions 2014-06-11 13:05:10 -05:00
Jack Nagel
ddc615366c Use assert_empty 2014-06-11 12:22:29 -05:00
Jack Nagel
93d8e71641 Use Digest#file if it's available 2014-06-11 12:05:19 -05:00
Jack Nagel
c0e0bd2984 Read df output in binary mode
Fixes Homebrew/homebrew#30046.
2014-06-11 00:42:51 -05:00
Jack Nagel
5ec52ea4da Remove unnecessary require 2014-06-10 22:29:20 -05:00
Jack Nagel
dd1f742854 Remove unnecessary code 2014-06-10 21:50:58 -05:00
Jack Nagel
0505582507 Rename TEST_FOLDER to TEST_DIRECTORY 2014-06-10 21:49:41 -05:00
Jack Nagel
dbe82909a3 Remove ABS__FILE constant from test environment 2014-06-10 21:46:29 -05:00
Jack Nagel
9a0098dbec Scope setup to the tests that need it 2014-06-10 21:21:09 -05:00
Jack Nagel
6e634890e8 Add methods for building test file paths 2014-06-10 21:21:06 -05:00
Jack Nagel
5263f50f74 Trust the fixtures and stop asserting on file(1) output 2014-06-10 20:40:51 -05:00
Jack Nagel
e3472540c1 Pull common code into setup method 2014-06-10 20:40:51 -05:00
Jack Nagel
c7685d2b70 Extract constant strings 2014-06-10 20:24:07 -05:00
Jack Nagel
df7756aeb9 Pull mock initialization code into initialize 2014-06-10 20:04:51 -05:00
Jack Nagel
65673d60c1 Move updater mock into test class namespace 2014-06-10 20:03:37 -05:00
Jack Nagel
d8f86f290b Use external interface in tests 2014-06-10 19:56:42 -05:00
Jack Nagel
cd4b801749 Simplify test setup 2014-06-10 19:44:46 -05:00
Jack Nagel
ba856de06e Remove rcov rake task
rcov is not compatible with Ruby 2.0.
2014-06-10 17:50:33 -05:00