11461 Commits

Author SHA1 Message Date
Alyssa Ross
3702e561d6 uninstall: test should_check_for_dependents? 2016-10-25 23:53:10 +01:00
Alyssa Ross
5a3d6c4c8f uninstall, keg: update style 2016-10-25 23:48:34 +01:00
Alyssa Ross
d0ad097082 uninstall: remove duplicated method
This was moved to Keg, but looks like I forgot to get rid of it here.
2016-10-25 23:48:00 +01:00
Alyssa Ross
aff5f42c58 missing: document --hide 2016-10-25 22:36:13 +01:00
Alyssa Ross
c4c855b9fc ARGV: extract #values from missing 2016-10-25 22:36:13 +01:00
Alyssa Ross
a4dc835ba0 uninstall: call Formula#missing_dependencies directly 2016-10-25 22:36:13 +01:00
Alyssa Ross
422f38b945 missing: call Formula#missing_dependencies directly 2016-10-25 22:36:13 +01:00
Alyssa Ross
0cd983487c missing_deps: extract formula instance method 2016-10-25 22:34:35 +01:00
Alyssa Ross
99a7fb8cb4 uninstall: don't use unless || 2016-10-25 22:34:35 +01:00
Alyssa Ross
ef13f8eaca uninstall: only <=1 Diagnostic.missing_deps call 2016-10-25 22:34:35 +01:00
Alyssa Ross
452691528d Revert "keg: fallback to missing_deps if deps not in tab"
This reverts commit da1caba17c624f03fa8e6fbe59683f57fb7ac17a.
2016-10-25 22:34:35 +01:00
Alyssa Ross
ae3f53a1ec keg: fallback to missing_deps if deps not in tab 2016-10-25 22:34:35 +01:00
Alyssa Ross
c88b67f3a8 missing: simplify code a bit 2016-10-25 22:34:35 +01:00
Alyssa Ross
8e3e8e31c2 missing: add tests for not missing and hide 2016-10-25 22:34:35 +01:00
ilovezfs
7fa4ffe3dc missing: allow hiding specified formulae 2016-10-25 22:34:35 +01:00
Alyssa Ross
ed0fffd931 uninstall: style fixes 2016-10-25 22:34:35 +01:00
Alyssa Ross
7792acda52 uninstall: allow dependent checks to be by-passed
Dependent can be bypassed with `--ignore-dependencies`.
This is now the default for `HOMEBREW_DEVELOPER`s.
2016-10-25 22:34:35 +01:00
Alyssa Ross
13d705c5e7 integration tests: preserve HOMEBREW_DEVELOPER
This means that run_as_not_developer can be used in integration tests
2016-10-25 22:34:34 +01:00
Alyssa Ross
ecb1075390 uninstall: check for dependents even with --force 2016-10-25 22:34:34 +01:00
Alyssa Ross
b42f76939c uninstall: reorganise code
With the way uninstall is set up at the moment, it's pretty difficult to
add functionality to both the --force and normal variants.

Extracting the racks and kegs to be uninstalled before uninstalling them
should make this easier.
2016-10-25 22:34:34 +01:00
Alyssa Ross
888c44b238 uninstall: fix dependent order bug 2016-10-25 22:34:34 +01:00
Alyssa Ross
08c898f280 integration tests: testball install overridable 2016-10-25 22:34:34 +01:00
Alyssa Ross
563b56701b keg: rename #formula to #to_formula
@vladshablinsky pointed out that other Homebrew classes, like Dependency,
use #to_formula.
2016-10-25 22:34:34 +01:00
Alyssa Ross
08f3aecf6b uninstall: consistent spelling of "dependent"
@ilovezfs pointed out that Homebrew generally uses "dependent", rather than
"dependant".
2016-10-25 22:34:34 +01:00
Alyssa Ross
e41c4e5029 uninstall: better message when dependents remain
Suggested by @MikeMcQuaid
2016-10-25 22:34:34 +01:00
Alyssa Ross
6f0aabe707 uninstall: refuse when dependants still installed
Closes #934.
2016-10-25 22:34:34 +01:00
Mike McQuaid
84d1661b9a Merge pull request #1365 from MikeMcQuaid/audit-stable-url-beta
audit: check for alpha/beta/rc usage in URLs.
2016-10-25 08:17:40 -04:00
Josh Hagins
030c3a5016 Merge pull request #1375 from zmwangx/fix-bottle-nonexistent-pyc-bug
bottle: fix nonexistent pyc bug
2016-10-25 04:33:26 -04:00
ilovezfs
a4f654fd3f Merge pull request #1376 from jawshooah/fix-relocate-regression
formula_installer: fix regression in #1253
2016-10-25 01:30:01 -07:00
buo
6a406763f3 Open incomplete download in append mode
Open the incomplete download in append mode instead of write mode.
Opening in write mode truncates the existing file, so curl keeps
restarting downloads instead of resuming the incomplete downloads.
2016-10-25 16:46:59 +09:00
Josh Hagins
652c5bc865 formula_installer: fix regression in #1253
Apparently `cellar :any_skip_relocation` doesn't actually mean we
can skip relocation, at least for text files.
2016-10-25 03:41:37 -04:00
Zhiming Wang
dd527bfcdc
bottle: fix nonexistent pyc bug
We were deleting pyc files *after* replace_locations_with_placeholders
and recording changed_files, meaning that some of the recorded files
were to be deleted. The correct order is the opposite.

A sample failed session: https://bot.brew.sh/job/Homebrew%20Core/10080/version=el_capitan/testReport/junit/brew-test-bot/el_capitan/bottle_buku/.
2016-10-25 01:44:40 -04:00
Josh Hagins
fab2cffe5d keg_relocate: wrap relocation locations in struct 2016-10-24 16:21:08 -04:00
Josh Hagins
adc4b1f0c7 keg_relocate: brew style fixes 2016-10-24 16:21:08 -04:00
Josh Hagins
9c519bbdbc keg_relocate: refactor relocate_text_files
Replace relocate_text_files with three methods that clarify intent:
replace_locations_with_placeholders, replace_placeholders_with_locations
and replace_text_in_files, the first two calling the third.
2016-10-24 16:21:08 -04:00
Josh Hagins
5b64fa6fb1 metafiles: convert Metafiles class to module 2016-10-24 16:21:08 -04:00
Josh Hagins
9628a613cf metafiles: use Set.new instead of Array#to_set 2016-10-24 16:21:08 -04:00
Josh Hagins
ce33f593b4 metafiles: convert EXTENSIONS and BASENAMES from Array to Set 2016-10-24 16:21:08 -04:00
Josh Hagins
c46155aba4 keg_relocate: cache files rewritten during brew bottle
`brew bottle` replaces instances of the Homebrew prefix, cellar, and
repository with placeholders in all text files. Cache these files in
INSTALL_RECEIPT.json so that we don't have to check every single text
file for placeholders on install.
2016-10-24 16:21:08 -04:00
Markus Reiter
e6bce5ec27 Merge pull request #1342 from reitermarkus/fixtures
Move cask's fixtures to `test/fixtures`.
2016-10-24 22:09:45 +02:00
Markus Reiter
b28b21fd7f Don’t use bare percent literals. 2016-10-24 17:27:20 +02:00
Josh Hagins
3f3fa4d0f7 Merge pull request #1334 from jawshooah/cask/fix-tap-regex
hbc/qualified_token: simplify token parsing
2016-10-24 10:38:02 -04:00
Mike McQuaid
b39f87e710 audit: check for alpha/beta/rc usage in URLs.
Stable URLs should not use unstable versions.
2016-10-24 14:54:28 +01:00
Markus Reiter
31ec04704a Move cask fixtures to test/fixtures/cask. 2016-10-24 15:52:41 +02:00
Josh Hagins
b2870c2480 hbc/qualified_token: use regex captures instead of String#split 2016-10-24 09:50:33 -04:00
Mike McQuaid
762b76e437 audit: check the version does not decrease.
This will prevent `brew upgrade` from working correctly.
2016-10-24 10:21:07 +01:00
Josh Hagins
4ed51d8240 hbc/auditor: refactor and fix bug
Use instance methods to DRY things up, and fix a bug discovered in
caskroom/homebrew-cask#26067 where Casks with language blocks would
always fail audit.
2016-10-24 04:27:21 -04:00
Josh Hagins
b481ed73a0 Merge pull request #1252 from niw/fix_cask_command_changes_entire_directory_ownership
FIX: cask changes /usr/local ownership recursively
2016-10-24 01:21:08 -04:00
Josh Hagins
606a762344 Merge pull request #1248 from Git-Jiro/add_reinstall_cmd_to_cask
add cask reinstall command
2016-10-24 01:11:48 -04:00
Martin Schimandl
0b8af5771f Remove duplicate description of <token> 2016-10-24 05:30:49 +02:00