admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
34,710 Commits 15 Branches 471 Tags
Commit Graph

34710 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Douglas Eichelberger
719f1d6c6e Refactor some use of OpenStruct 2023-02-28 13:05:43 -08:00
Sam Ford
7d9e1a50e8
livecheck: Add Xml strategy 
This adds a generic `Xml` strategy to livecheck that requires a
`strategy` block to operate. The XML-parsing code is taken from the
existing approach in the `Sparkle` strategy. As such, `Sparkle` has
been updated to use the `Xml#parse_xml` method instead.

Unlike the `Json` strategy, we don't currently have any `strategy`
blocks in first-party taps that manually parse XML. However, we had a
user request support for something like this and I was already working
on an `Xml` strategy (as a way of extracting the XML-parsing code
from `Sparkle` into something general-purpose), so here we are.

Future strategies that parse simple XML data can potentially use the
`Xml#find_versions` method (similar to how we have strategies that
leverage `PageMatch#find_versions`) instead of having to implement
something bespoke like `Sparkle`.
 2023-02-28 14:58:11 -05:00
Douglas Eichelberger
e6ddf8c958 Enable Style/OpenStructUse cop 2023-02-28 11:12:54 -08:00
Mike McQuaid
2451d017f9
update-report: allow additions/deletions from the API. 
If we're installing from the API: we cannot use Git to check for differences in
packages so instead use `{formula,cask}_names.txt` to do so.

The first time this runs: we won't yet have a base state
(`{formula,cask}_names.before.txt`) to compare against so we don't output
anything and just copy the files for next time.
 2023-02-28 16:46:44 +00:00
Mike McQuaid
7c15dce285
Merge pull request #14798 from MikeMcQuaid/deprecate_shell 
Deprecate `preferred_shell` and `shell_profile`.
 2023-02-28 15:18:00 +00:00
Mike McQuaid
32463227ac
Deprecate preferred_shell and shell_profile. 
I know that we're outside our normal deprecation cycle but: these are
totally broken with the API and it doesn't make sense to support them
only for non-core formulae.
 2023-02-28 15:02:06 +00:00
hyuraku
198c6f6b8c move cask/cmd/info_spec to cask/info_spec 2023-03-01 00:01:28 +09:00
hyuraku
efdef5f26c move cask/cmd/info to cask/info 2023-03-01 00:00:54 +09:00
Mike McQuaid
5dbf95958b
Merge pull request #14838 from Homebrew/sponsors-maintainers-man-completions 
Update manpage and completions.
 2023-02-28 14:22:13 +00:00
BrewTestBot
26e5768bc9
Update manpage and completions. 
Autogenerated by the [sponsors-maintainers-man-completions](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/sponsors-maintainers-man-completions.yml) workflow.
 2023-02-28 14:06:12 +00:00
Carlo Cabrera
1201f18db0
Merge pull request #14667 from carlocab/update-reset-tap-names 
cmd/update-reset: improve arg parsing
 2023-02-28 22:05:10 +08:00
Issy Long
a2b488cd10
Merge pull request #14818 from issyl0/rubocop-documentation 
rubocop: Only enable `Style/Documentation` for `@api public` code
 2023-02-28 13:47:13 +00:00
Carlo Cabrera
e2082f0c53
workflows/tests: avoid resetting homebrew/bundle 
This command was being called with the wrong relative path, so it
silently did nothing. Now that `update-reset` errors out from invalid
arguments, we know that running `update-reset` here is not needed.
 2023-02-28 21:47:08 +08:00
Issy Long
e82869b3ac
ci: Fix working directory for RuboCop filepath step? 2023-02-28 13:30:19 +00:00
Mike McQuaid
70d3417319
Merge pull request #14823 from issyl0/contributions-reviews-approved 
dev-cmd/contributions: Only count approving reviews
 2023-02-28 13:22:52 +00:00
Issy Long
b8b7e6350d
dev-cmd/contributions: Only count approving reviews 
- The `reviewed-by` filter retrieved all reviews for a user, including
  those they'd added to their own PRs. Since it's impossible to click
  the "approve" button on one's own PR, filter this to `review:approved`
  to get "further project goals" kinds of reviews.
- Suggested in https://github.com/Homebrew/brew/pull/14813#discussion_r1118696385.
 2023-02-28 12:58:21 +00:00
Issy Long
f7dd63008e
ci: Include RuboCop filepaths check in syntax workflow 
- The slowest part of the separate workflow was the repo checkout step,
  so include it in here to avoid the overhead.
 2023-02-28 12:52:48 +00:00
Issy Long
267d72a9d0
More comments and TODOs 
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
 2023-02-28 12:50:05 +00:00
Carlo Cabrera
53053e0625
cmd/update-reset: improve arg validation 
This is based on feedback from #14667.
 2023-02-28 20:38:00 +08:00
Carlo Cabrera
12364d70d2
Revert "cmd/update-reset: accept tap names as arguments" 
This reverts commit ac7dbc008284e1a85353548eb8e15c008be902ec.
 2023-02-28 20:30:40 +08:00
Mike McQuaid
eeadcc8ded
Merge pull request #14632 from bevanjkay/cask-sample-languages-audit 
cask/auditor: only audit 10 languages by default on casks with many languages
 2023-02-28 12:16:51 +00:00
Rylan Polster
f6af334397
Merge pull request #14825 from MikeMcQuaid/more_sharding_fixes 
More Formula/Casks sharding fixes
 2023-02-28 07:08:29 -05:00
Bevan Kay
0589ac427d
Update Library/Homebrew/cask/auditor.rb 
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
 2023-02-28 23:00:43 +11:00
Mike McQuaid
4cbc4f64d1
Merge pull request #14834 from reitermarkus/livecheck-skip-latest 
Allow `version :latest` if `livecheck` is `skip`.
 2023-02-28 11:59:29 +00:00
Mike McQuaid
eea6e1777e
Merge pull request #14837 from Homebrew/sponsors-maintainers-man-completions 
Update maintainers.
 2023-02-28 11:54:27 +00:00
Mike McQuaid
0406279ad3
More Formula/Casks sharding fixes 
- Stop `brew style` from complaining
- Fix message reference in `brew edit`
 2023-02-28 11:52:38 +00:00
Mike McQuaid
d0e03fc425
Merge pull request #14820 from apainintheneck/delay-loading-from-cask-source-api 
Delay loading from cask source api
 2023-02-28 11:50:10 +00:00
Mike McQuaid
b339caf744
Merge pull request #14831 from Homebrew/sorbet-files-update 
sorbet: Update RBI files.
 2023-02-28 11:41:53 +00:00
Mike McQuaid
4986a1aa26
Merge pull request #14830 from samford/livecheck/rework-json-match 
Strategy#from_url: Amend conditions for Json
 2023-02-28 11:41:41 +00:00
Issy Long
0f2270e9ef
Merge pull request #14819 from issyl0/signoffs-were-just-a-stepping-stone-to-reviews 
dev-cmd/contributions: Stop counting signoffs now we have "real" reviews
 2023-02-28 11:37:14 +00:00
Mike McQuaid
0a0479ab0e
Remove Markus from former maintainers. 2023-02-28 11:35:32 +00:00
BrewTestBot
a862c598be
Update maintainers. 
Autogenerated by the [sponsors-maintainers-man-completions](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/sponsors-maintainers-man-completions.yml) workflow.
 2023-02-28 11:21:32 +00:00
Mike McQuaid
5ca4ab0260
Merge pull request #14778 from dduugg/inflection-util 
Replace ActiveSupport inflections with Utils methods
 2023-02-28 11:20:46 +00:00
Issy Long
6b76e5e66f
dev-cmd/contributions: Stop counting signoffs now we have "real" reviews 
- Signoffs were just a stopgap until we implemented getting "real"
  reviews for a user via the GitHub API. They were a suboptimal way of getting
  reviews because they only really exist in Homebrew/homebrew-core where
  BrewTestBot adds signoffs for each maintainer who reviewed the PR.
 2023-02-28 11:12:51 +00:00
Markus Reiter
a2a68292ae
Allow version :latest if livecheck is skip. 2023-02-28 10:35:07 +01:00
Bevan Kay
48a7282458
fix style 2023-02-28 19:02:08 +11:00
Bevan Kay
295a3539a5
Update with-many-languages.rb 2023-02-28 18:55:12 +11:00
Bevan Kay
d1b09a90da
cask/auditor: only audit 10 languages by default on casks with many languages 2023-02-28 18:54:27 +11:00
apainintheneck
b91e93cda0 Load cask source with tap info 
This info is used in the installer to
decide whether to report analytics.
 2023-02-27 23:51:43 -08:00
Douglas Eichelberger
2073e70696 brew style --fix 2023-02-27 21:43:10 -08:00
Douglas Eichelberger
f9f73f3ef6 Tidy up 2023-02-27 21:42:47 -08:00
Douglas Eichelberger
1ab278f74c Fix style/type violations 2023-02-27 20:34:07 -08:00
Douglas Eichelberger
82dad857a8 Restore global 2023-02-27 20:31:01 -08:00
Douglas Eichelberger
6ea501b59f Add tests 2023-02-27 20:30:55 -08:00
Douglas Eichelberger
325994a60c Move inflection utils to Utils module 2023-02-27 20:20:56 -08:00
Douglas Eichelberger
0eccc0e987 git grep -l Utils::Inflection | xargs gsed -i 's|Utils::Inflection|Utils|g' 2023-02-27 20:18:27 -08:00
Douglas Eichelberger
86c500fdcc Try removing inflections require 2023-02-27 20:18:10 -08:00
Douglas Eichelberger
8d788ec98c Try removing String monkey-patched types 2023-02-27 20:18:10 -08:00
Douglas Eichelberger
cfdb0c2e4b Fix type error 2023-02-27 20:18:10 -08:00
Douglas Eichelberger
7f3593e12d inline titleize 2023-02-27 20:18:10 -08:00