When fixing references to regular dylibs, it is sufficient to search for
a file with the same base name, e.g., `libpoppler.56.dylib`. However, if
the broken reference is to a framework, we also have to take into
account preceding path components to find a suitable match. Framework
references (according to the `dyld` man page) come in two flavors:
- `XXX.framework/Versions/YYY/XXX` (with version)
- `XXX.framework/XXX` (without version)
The change here is to detect these patterns and to make sure that the
fixed library reference has the same suffix as the broken one.
Prior to this fix, a broken framework reference (if originating in a
sister framework) to `QtXml.framework/Versions/5/QtXml` would have been
rewritten to `<qt5-keg>/lib/QtXml.framework/QtXml`. In practice, this
mostly works, but is technically incorrect and thus creates problems
like in Homebrew/homebrew#42191. With this fix, the framework reference is correctly
rewritten to `<qt5-keg>/lib/QtXml.framework/Versions/5/QtXml`.
ClosesHomebrew/homebrew#45494.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
This matches the version shipped with 10.10.5.
The list of supported features/protocols was obtained
using `curl-config`:
```
features="`curl-config --features`"; echo "${features//$'\n'/ }"
protocols="`curl-config --protocols`"; echo "${protocols//$'\n'/ }"
```
Signed-off-by: Mohammad AlSaleh <CE.Mohammad.AlSaleh@gmail.com>
ClosesHomebrew/homebrew#46073.
Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
* Show pinned and keg-only as attributes, where pinned
version is shown as well.
* Use brackets instead of parentheses to distinguish formula
attributes(e.g. keg-only) with spec attributes(e.g. bottled)
* Don't show blank line for formula without homepage.
* Don't show duplicated keg-only message which will be shown later
in caveats.
* Underline urls.
* Remove unnecessary github_info return value check, which is always
existed.
ClosesHomebrew/homebrew#46037.
Signed-off-by: Xu Cheng <xucheng@me.com>
```
Fast-forward
Library/Formula/ant.rb | 8 ++++----
Library/Formula/nailgun.rb | 10 +++++-----
2 files changed, 9 insertions(+), 9 deletions(-)
Deleted branch pull-bottle-45902 (was 1fdb73d).
==> Publishing on Bintray:
{"files":3}
==> Publishing on Bintray:
Error: Failure while executing
```
In that case, "jetty-runner" is bottle unneeded, but because I've passed the
pull bottle command for the other two formulae, it attempts to publish a bottle
that isn't there.
If this was set at build-time (i.e. by the Ruby 1.8.7 buildsystem) then
`cc` could be passed arguments and fail to run.
ClosesHomebrew/homebrew#45890.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
When fixing references to regular dylibs, it is sufficient to search for
a file with the same base name, e.g., `libpoppler.56.dylib`. However, if
the broken reference is to a framework, we also have to take into
account preceding path components to find a suitable match. Framework
references (according to the `dyld` man page) come in two flavors:
- `XXX.framework/Versions/YYY/XXX` (with version)
- `XXX.framework/XXX` (without version)
The change here is to detect these patterns and to make sure that the
fixed library reference has the same suffix as the broken one.
Prior to this fix, a broken framework reference (if originating in a
sister framework) to `QtXml.framework/Versions/5/QtXml` would have been
rewritten to `<qt5-keg>/lib/QtXml.framework/QtXml`. In practice, this
mostly works, but is technically incorrect and thus creates problems
like in Homebrew/homebrew#42191. With this fix, the framework reference is correctly
rewritten to `<qt5-keg>/lib/QtXml.framework/Versions/5/QtXml`.
ClosesHomebrew/homebrew#45494.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
I find brew switch very helpful to activate a different version of an
installed formula. This seems worth calling out in the documentation to
elevate awareness.
ClosesHomebrew/homebrew#45694.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
