Sam Ford
01cb74e525
livecheck: clarify livecheckable language
...
Formulae, casks, and resources have a `#livecheckable?` method that
indicates whether they contain a `livecheck` block. This is intended
to be read as "has a livecheckable?", not "is livecheckable?" (as
livecheck can find versions for some packages/resources without a
`livecheck` block). Unfortunately, correct understanding of this
method's behavior [outside of documentation] relies on historical
knowledge that few people possess, so this is often confusing to
anyone who hasn't been working on livecheck since 2020.
In the olden days, a "livecheckable" was a Ruby file containing a
`livecheck` block (originally a hash) with a filename that
corresponded to a related formula. The `livecheck` blocks in
livecheckable files were integrated into their respective formulae in
August 2020, so [first-party] livecheckables ceased to exist at that
time. From that point forward, we simply referred to these as
`livecheck` blocks.
With that in mind, this clarifies the situation by replacing
"livecheckable" language. This includes renaming `#livecheckable?` to
`#livecheck_defined?`, replacing usage of "livecheckable" as a noun
with "`livecheck` block", replacing "livecheckable" as a boolean with
"livecheck_defined", and replacing incorrect usage of "livecheckable"
as an adjective with "checkable".
2024-12-02 10:13:03 -05:00
Mike McQuaid
50384591c7
extend/kernel: add sigs to opoo/onoe/ofail
...
Add these and correctly pass through a string to
`GitHub::Actions.puts_annotation_if_env_set`.
Also, fix some call sites to not rely on the `void` return.
2024-05-10 14:12:19 +01:00
Mike McQuaid
222fe8ef0b
Homebrew 4.3.0 deprecation/disable/removals.
...
The usual pass of deprecating/disabling/removing code for the next
minor Homebrew release.
2024-05-07 12:18:04 +01:00
Douglas Eichelberger
c50fb2dbd2
Remove redundant cli/parser requires
2024-03-29 18:53:07 -07:00
Douglas Eichelberger
1db309f024
Fix typo'd class name
2024-03-21 17:41:31 -07:00
Douglas Eichelberger
c70dc040c6
Port Homebrew::DevCmd::BumpUnversionedCask
2024-03-20 10:25:18 -07:00
Douglas Eichelberger
8156c5d140
Audit remaining commands
2024-01-31 20:02:33 -08:00
Bo Anderson
26ea6b7f9e
Pull in REXML gem as it doesn't ship with Ruby 3
2023-10-27 20:24:10 +01:00
Bo Anderson
bb7aef85db
Migrate remaining no-api commands to new scoped system
2023-06-22 17:11:20 +01:00
Douglas Eichelberger
24cf6076e8
brew style --fix
2023-04-24 20:42:39 -07:00
Douglas Eichelberger
0b04b99e68
brew typecheck --suggest-typed --update
2023-03-09 20:32:46 -08:00
Markus Reiter
fbf85b7530
Ignore discontinued casks in bump-unversioned-casks.
2023-02-21 12:43:09 +01:00
Markus Reiter
8c8065746b
Fix duration calculation.
2023-02-12 01:40:19 +01:00
Markus Reiter
c735c63122
Ignore livecheckable casks in bump-unversioned-casks.
2023-02-09 16:06:53 +01:00
Douglas Eichelberger
24e7c2c5bd
Remove active_support Time extensions
2023-02-04 13:51:35 -08:00
Bo Anderson
f5dc7a571f
Fix Style/ObjectThen offences
2022-06-17 19:47:55 +01:00
Bevan Kay
5040ec8142
fix style issues
2021-07-21 16:25:11 +10:00
Bevan Kay
212992a476
fix typecheck, add reference in bump-unversioned-casks
2021-07-21 16:09:09 +10:00
Mike McQuaid
6f071a06f8
Use JSON.pretty_generate
...
It's dramatically more human readable for very little difference in
space.
2021-04-09 15:44:37 +01:00
EricFromCanada
2ae4f11963
reorder command flags
2021-01-26 15:36:44 -05:00
Seeker
50cd836427
Merge pull request #10351 from SeekingMeaning/sig-braces
...
rubocop: require braces for Sorbet `sig`
2021-01-19 03:50:20 -08:00
Rylan Polster
d1f3e39b7b
Update commands to generate usage banner
2021-01-18 21:20:11 -05:00
Seeker
fbafaff4fe
rubocop: require braces for Sorbet sig
2021-01-18 16:52:45 -08:00
Dawid Dziurla
cf654da251
dev-cmd: indicate multiple named args in usage banner
2021-01-15 13:04:07 +01:00
Rylan Polster
da811373d3
Add named_args DSL for commands
2021-01-13 17:09:42 -05:00
Seeker
b9854bd4cf
rubocops: add unless_multiple_conditions
2021-01-08 10:33:54 -08:00
Markus Reiter
01cd373c34
Also cache failed version bump attempts.
2020-12-14 13:02:52 +01:00
Markus Reiter
a428aa6617
Wrap guess_cask_version with timeout.
2020-12-11 02:48:12 +01:00
Markus Reiter
eec1d5e17f
Add timeout in bump-unversioned-casks.
2020-12-09 03:12:21 +01:00
Markus Reiter
1c2a31e224
Allow passing individual casks to bump-unversioned-casks for debugging.
2020-12-08 01:03:39 +01:00
Markus Reiter
73440797ef
Add bump_unversioned_cask helper method.
2020-12-07 23:03:47 +01:00
Markus Reiter
c6876ba65c
Add UnversionedCaskChecker helper class.
2020-12-07 23:03:47 +01:00
Markus Reiter
3b524a04c2
Output PKG contents if no version can be found.
2020-12-07 23:03:47 +01:00
Markus Reiter
d6f30a4bc1
Handle formatted versions ending with build version.
2020-12-07 23:03:47 +01:00
Markus Reiter
96bbf1ac15
Show contained files of PKGs when version detection fails.
2020-12-07 23:03:47 +01:00
Markus Reiter
4f3bfd1d58
Improve handling of short_version starting with version.
2020-12-07 23:03:47 +01:00
Markus Reiter
91ce799fe2
Ignore empty version strings.
2020-12-07 23:03:47 +01:00
Markus Reiter
933499089c
Add test for decide_between_versions.
2020-12-07 23:03:47 +01:00
Markus Reiter
6d21df2c8b
Always choose longer version in correct format.
2020-12-07 23:03:47 +01:00
Markus Reiter
bf46814ddd
Skip casks before extracting.
2020-12-07 23:03:47 +01:00
Markus Reiter
a3182a6386
Extract package into new temporary directory.
2020-12-07 23:03:47 +01:00
Markus Reiter
ef1ea75c08
Add support for single-package casks.
2020-12-07 23:03:47 +01:00
Markus Reiter
2157a71a68
Never exit with failure.
2020-12-07 23:03:47 +01:00
Markus Reiter
ffebf0da5f
Update check_time even if time and file size didn't change.
2020-12-07 23:03:47 +01:00
Markus Reiter
0a54169fa6
Change limit to minutes.
2020-12-07 23:03:47 +01:00
Markus Reiter
b57a448f2a
Add bump-unversioned-casks command.
2020-12-07 23:03:47 +01:00
