Markus Reiter
ebfc3996fd
Allow “which” as context prefix.
2023-02-24 12:28:05 +01:00
Markus Reiter
fa2d917dec
Add test for extracting unwritable files.
2023-02-24 12:28:05 +01:00
Markus Reiter
347bc4535f
Fix permissions for extracted files.
2023-02-24 12:28:04 +01:00
Mike McQuaid
f280ce069b
Support loading formulae/casks from subdirectories
...
Previously, we required all formulae and casks to be in a specific
formula or cask directory but did not check any subdirectories.
This commit allows using subdirectories for official taps, the only
ones likely to be big enough to warrant sharding in this way and to
avoid potentially breaking backwards compatibility for existing taps.
This was inspired by the most recent issues with homebrew-cask.
2023-02-24 10:57:41 +00:00
Mike McQuaid
2d31f80f5c
Merge pull request #14773 from reitermarkus/extract-signatures
...
Add signatures for extraction functions.
2023-02-24 09:50:46 +00:00
Maxim Belkin
d3da5a340d
Bash completions: cache names of 'doctor' checks
2023-02-23 18:36:51 -07:00
BrewTestBot
ff43853c8f
sorbet: Update RBI files.
...
Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml ) workflow.
2023-02-24 00:29:35 +00:00
Issy Long
8d4bdbafc4
dev-cmd/contributions: CSV output of totals per maintainer
...
- Turns out in my head a few days ago I was overcomplicating this. I had a
brainwave while in the shower.
- Some refactoring so that we call `totals` to sum up the hash of hashes less,
since the grand total numbers are now used in multiple places.
2023-02-23 23:35:45 +00:00
DenizUgur
46aefe776f
fix tests
2023-02-23 11:08:39 -08:00
DenizUgur
026709962d
update tests
2023-02-23 11:02:20 -08:00
Sam Ford
a0a366e22d
PageMatch: Tweak documentation comments
2023-02-23 13:41:56 -05:00
BrewTestBot
40f286fc42
Update RBI files for rubocop.
...
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml ) workflow.
2023-02-23 18:26:08 +00:00
BrewTestBot
30a64593f6
brew vendor-gems: commit updates.
2023-02-23 18:18:18 +00:00
Sam Ford
7735036c56
livecheck: Add Json strategy
...
This adds a generic `Json` strategy to livecheck that requires a
`strategy` block to operate. This is primarily intended as a
replacement for existing `strategy` blocks in formulae/casks that
use `JSON#parse`, as it allows us to internalize/standardize that
boilerplate while improving error-handling.
Additionally, future strategies that parse JSON data can use the
`Json#find_versions` method instead of having to reinvent the wheel
(similar to how we currently have a number of strategies that
leverage `PageMatch#find_versions`).
2023-02-23 13:17:35 -05:00
DenizUgur
f4ed502350
run_at_load set to true by default
2023-02-23 10:15:06 -08:00
dependabot[bot]
e91b60ef68
build(deps): bump rubocop from 1.45.1 to 1.46.0 in /Library/Homebrew
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.45.1 to 1.46.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.45.1...v1.46.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-02-23 18:14:31 +00:00
Mike McQuaid
d7029e95cd
Merge pull request #14769 from dduugg/enable-types
...
Enable typing in Cask::Artifact
2023-02-23 18:02:44 +00:00
Mike McQuaid
b3db997e7b
os/mac/extend/ENV/super: handle nil sdk.
...
I'm aware this is not meant to happen but: sometimes it does and the
lack of handling produces a subpar error.
2023-02-23 15:31:04 +00:00
Mike McQuaid
68859ae256
Merge pull request #14782 from MikeMcQuaid/running_as_root_but_not_owned_by_root
...
api: don't download files as root when Homebrew's not owned by root.
2023-02-23 13:34:15 +00:00
Mike McQuaid
57ef4afe57
api: improve root messaging.
...
Co-authored-by: Bo Anderson <mail@boanderson.me>
2023-02-23 12:48:18 +00:00
Mike McQuaid
d1cba00ee3
Merge pull request #14779 from MikeMcQuaid/bye_atom
...
which_editor: remove Atom.
2023-02-23 10:20:10 +00:00
Mike McQuaid
2884b1649b
api: don't download files as root when Homebrew's not owned by root.
...
This was mentioned in a random comment. While we're here, make some
helper functions to query this a bit more nicely elsewhere when we do
it.
2023-02-23 10:04:50 +00:00
Mike McQuaid
2f47403f8c
dev-cmd/generate-*-api: don't use same constant name.
...
Otherwise Ruby warns.
2023-02-23 09:09:54 +00:00
Mike McQuaid
236208ff79
Merge pull request #14756 from apainintheneck/clean-up-extend-os-requires
...
extend/os: clean up requires
2023-02-23 09:07:59 +00:00
Mike McQuaid
f6d1fa62f1
Merge pull request #14762 from MikeMcQuaid/generate_api
...
Add generate-{cask,formula}-api commands
2023-02-23 09:02:15 +00:00
Mike McQuaid
aca3eead71
which_editor: remove Atom.
...
It's been deprecated. Make VSCode first because it's what we recommend.
2023-02-23 08:53:32 +00:00
Mike McQuaid
43209a1af1
Merge pull request #14775 from issyl0/github-api-commits-support-since-until
...
utils/github: Add date filtering to the commit author API query
2023-02-23 08:52:36 +00:00
Mike McQuaid
9c9213aabd
Apply suggestions from code review
...
Co-authored-by: Rylan Polster <rslpolster@gmail.com>
Co-authored-by: Bo Anderson <mail@boanderson.me>
2023-02-23 08:45:56 +00:00
apainintheneck
8de625e0e2
extend/os: clean up requires
...
These need to be after the original module/class definitions
for the monkey-patching to work correctly.
2023-02-22 21:21:24 -08:00
Bo Anderson
336c2c792d
Merge pull request #14733 from Bo98/api-security
...
Security enhancements to API
2023-02-22 23:10:37 +00:00
Bo Anderson
7008771051
Merge pull request #14771 from Homebrew/dependabot/bundler/Library/Homebrew/plist-3.7.0
...
build(deps): bump plist from 3.6.0 to 3.7.0 in /Library/Homebrew
2023-02-22 23:10:08 +00:00
Issy Long
c7b06df72e
dev-cmd/contributions: One --verbose
sentence per user is enough
2023-02-22 23:05:02 +00:00
Issy Long
28a2a6ea43
utils/github: Add date filtering to the commit author API query
...
- I missed this off the original implementation - oops. This gives parity with
the `git log` implementation.
2023-02-22 23:01:38 +00:00
Bo Anderson
5ecf76a611
Harden plist parsing
2023-02-22 22:52:06 +00:00
Bo Anderson
e663f532a6
Checksum Ruby source file downloads
2023-02-22 22:50:24 +00:00
Bevan Kay
7497f805ba
Revert "cask: audit for correct signing of pkg installers"
2023-02-23 09:12:24 +11:00
Bo Anderson
b7d6d00c34
api: use signed endpoint
2023-02-22 21:53:32 +00:00
Markus Reiter
4f04e9e599
Add signatures for extraction functions.
2023-02-22 22:15:53 +01:00
Issy Long
bfff981f1a
Merge pull request #14770 from issyl0/smarter-pagination
2023-02-22 19:35:42 +00:00
Sean Molenaar
2b1fbaa26d
Merge pull request #14748 from SMillerDev/feat/cask/audit_short_version_sparkle
...
cask: audit if sparkle livecheck needs multipart version
2023-02-22 20:23:17 +01:00
Sean Molenaar
c14b7917a2
Update Library/Homebrew/cask/audit.rb
2023-02-22 19:43:02 +01:00
BrewTestBot
f5cd81be7e
Update RBI files for plist.
...
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml ) workflow.
2023-02-22 18:21:36 +00:00
BrewTestBot
be7319bd98
brew vendor-gems: commit updates.
2023-02-22 18:14:20 +00:00
dependabot[bot]
25f604f86f
build(deps): bump plist from 3.6.0 to 3.7.0 in /Library/Homebrew
...
Bumps [plist](https://github.com/patsplat/plist ) from 3.6.0 to 3.7.0.
- [Release notes](https://github.com/patsplat/plist/releases )
- [Changelog](https://github.com/patsplat/plist/blob/master/CHANGELOG.rdoc )
- [Commits](https://github.com/patsplat/plist/compare/v3.6.0...v3.7.0 )
---
updated-dependencies:
- dependency-name: plist
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-02-22 18:10:19 +00:00
Issy Long
dd140ea717
utils/github/api: Smarter pagination in paginate_rest
...
- The `API_MAX_PAGES` value is 50, so for pages 1 to 50, the
`paginate_rest` method was making an API call even if there was no
data past, for example, page 8.
- This made `brew contributions --user=issyl0` take 11 minutes, since we
made 50 API calls _per repo_ even if it was unnecessary, burning down
our API allowance.
- Instead, stop looping if we detect that there's no data in `result`.
- This probably needs more testing for other parts of Homebrew that rely
on `paginate_rest` and the different shapes of data it outputs.
2023-02-22 17:53:46 +00:00
Issy Long
1b3fa0bef7
Merge pull request #14768 from issyl0/contributions-fix-trailers-args
...
dev-cmd/contributions: Correctly order the trailers method args
2023-02-22 17:41:23 +00:00
Issy Long
0d345c4257
dev-cmd/contributions: Correctly order the trailers method args
...
- Was this a bad merge conflict resolution, or me not paying enough
attention another time?
2023-02-22 17:24:13 +00:00
Douglas Eichelberger
29c6baeed1
Enable typing in Cask::Artifact
2023-02-22 09:11:29 -08:00
Issy Long
3d3369c542
dev-cmd/contributions.rb: odie
...
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2023-02-22 17:02:22 +00:00
Issy Long
d40bd0ae3e
dev-cmd/contributions: Fix single-user handling; be more verbose
...
- `brew contributions --user=issyl0` was taking forever because it went
through all maintainers first, because the conditionals were in the
wrong order.
- This was too quiet, far too quiet, for something that takes so long.
- Now verbose mode tells you what repos it's scanning for a user.
2023-02-22 16:48:31 +00:00