4948 Commits

Author SHA1 Message Date
Mike McQuaid
c31ae1ce6a
Merge pull request #14948 from hyuraku/remove-cask/cmd/fetch
remove `cask/cmd/fetch`
2023-03-19 17:21:22 -04:00
Issy Long
b979646c42
Merge pull request #15000 from issyl0/fix-extra-blank-line-in-caveats
caveats: Remove extra blank line between `keg_only` and other caveats
2023-03-19 20:57:15 +00:00
Issy Long
f10b88ca85
caveats: Add a new line if there isn't one from previous conditions 2023-03-19 18:38:09 +00:00
hyuraku
4271d41e51 remove new specs 2023-03-19 22:31:00 +09:00
hyuraku
dfee012f77 change cask spec to formula one 2023-03-19 19:14:46 +09:00
apainintheneck
d42e9b40d5 formulary: add test for loading service blocks from API 2023-03-19 00:09:16 -07:00
apainintheneck
501730df5d Add service serialization specs 2023-03-19 00:09:16 -07:00
Issy Long
865e99c611
test/cask: Rename 'expected_json_ventura' since it's >= Ventura
- Let's actually show in the fixtures JSON filename what's changed
  between the two.
2023-03-18 15:16:23 +00:00
Issy Long
6b4b923b44
test/cask: Fix "System Settings" caveats for (non-)Ventura OSes
- "System Preferences" was updated to be "System Settings" in macOS
  Ventura. This naming was updated in our caveats generator in PR 14997.
- This test was failing for me locally (on Ventura) because it was
  hardcoded to expect `System Preferences => Security & Privacy`, but
  getting `System Settings => Privacy & Security`.
- This is not the most important thing in the world, we can probably
  live with the failing test, but I thought I'd try to fix it anyway.
2023-03-18 13:19:20 +00:00
Mike McQuaid
647d86f3e4
Merge pull request #14998 from stevenlele/locale
Fix locale parsing
2023-03-17 15:36:22 -04:00
Mike McQuaid
b8743d337b
Merge pull request #14991 from issyl0/cask-url-audit-pass-referrer
cask/audit: Pass a URL's `referer` through to cURL
2023-03-17 15:33:38 -04:00
stevenlele
c9e44a0395 Update test 2023-03-17 20:35:17 +08:00
stevenlele
ca22b67dd2 Fix locale parsing 2023-03-17 20:15:42 +08:00
Issy Long
0701ea42fa
cask/audit: Pass a URL's referer through to cURL
- Some casks have URL arguments like "referer" (spelled wrong, that's
  intentional in the HTTP spec).
- The audit for one such cask, `iThoughtsX`, was failing because the
  "referer" wasn't getting passed through to cURL so the access would
  404.

----

Before:

```
❯ brew audit --cask --online --appcast --signing 'ithoughtsx'
[...]
audit for ithoughtsx: failed
 - The binary URL https://cdn.toketaware.com?download=iThoughtsX.zip is not reachable (HTTP status code 404)
 - Version '9.2.0' differs from '9.3.0' retrieved by livecheck.
 - Version '9.2.0' differs from '9.3.0' retrieved by livecheck.
Error: 2 problems in 1 cask detected
```

After:

```
❯ brew audit --cask --online --appcast --signing 'ithoughtsx'
[...]
audit for ithoughtsx: failed
 - Version '9.2.0' differs from '9.3.0' retrieved by livecheck.
 - Version '9.2.0' differs from '9.3.0' retrieved by livecheck.
Error: 1 problem in 1 cask detected
```
2023-03-16 23:28:50 +00:00
Mike McQuaid
6fd54eba5f
Merge pull request #14985 from dduugg/no-compat
Remove compatibility layer
2023-03-15 13:48:00 -04:00
Mike McQuaid
83aea49d8a
Merge pull request #14981 from dduugg/tab-no-ostruct
Remove OpenStruct use in Tab
2023-03-15 12:16:49 -04:00
Markus Reiter
9d415e22da
Simplify SPDX test. 2023-03-15 14:30:47 +01:00
Douglas Eichelberger
4d32699f61 Placate rubocop 2023-03-14 23:01:09 -07:00
Douglas Eichelberger
cc5b013cb9 Remove compatibility layer 2023-03-14 14:49:34 -07:00
Douglas Eichelberger
6238a0779d remove test 2023-03-14 11:46:38 -07:00
Douglas Eichelberger
a1748605ab Minor Kernel cleanup 2023-03-14 10:27:16 -07:00
Douglas Eichelberger
c178986235 Fix tests 2023-03-14 08:50:56 -07:00
hyuraku
7d90e3a2a1 add new spec to cmd/fetch_spec 2023-03-13 22:31:09 +09:00
Mike McQuaid
296c5088aa
Merge pull request #14935 from hyuraku/move-cask/cmd/uninstall
Move cask/cmd/uninstall
2023-03-13 10:19:41 +00:00
hyuraku
da6f48dbd0
Merge branch 'master' into move-cask/cmd/uninstall 2023-03-12 11:49:06 +09:00
Douglas Eichelberger
731a02ee73 rm .brew_irb_history 2023-03-11 17:27:53 -08:00
Douglas Eichelberger
826aca7217 Add tests 2023-03-11 17:27:53 -08:00
Douglas Eichelberger
8a57c37c33 Fix extend/array_spec 2023-03-11 17:27:53 -08:00
Douglas Eichelberger
999594dc07 Remove oxford comma from to_sentence default 2023-03-11 17:27:53 -08:00
Issy Long
8e13a6e1f4
Merge pull request #14944 from issyl0/more-rubocop-naming-method-parameter-name
rubocop: Further trim `Naming/MethodParameterName` allowlist
2023-03-11 22:59:39 +00:00
hyuraku
08560e04ae remove cask/cmd/fetch_spec 2023-03-11 22:13:00 +09:00
hyuraku
e321edabbc remove options and comments 2023-03-11 21:15:24 +09:00
Issy Long
e9d994622e
rubocop: Drop "f" from Naming/MethodParameterName allowlist
- This either stands for "file" but more often than not "formula".
2023-03-11 00:17:27 +00:00
apainintheneck
2baaafba92 Cleanup irb history file in tests
This was caused by the irb spec. Note that
$HOME is set during the test setup so will
always be correct.
2023-03-09 17:07:08 -08:00
hyuraku
cd0686d75b move cask/cmd/uninstall_spec to cask/uninstall_spec 2023-03-09 22:33:45 +09:00
hyuraku
38a62b3a51 repair style 2023-03-09 20:55:33 +09:00
hyuraku
2f870fa670 move cask/cmd/upgrade_spec to cask/upgrade 2023-03-09 20:41:22 +09:00
Issy Long
3a83b5492c
rubocop: Clean up Style/BlockDelimiters excludes and autofix offenses
- The defaults of using "do ... end" for multi-line blocks everywhere is
  good, better than switching everything to braces everywhere.
2023-03-08 23:54:22 +00:00
Mike McQuaid
b1801333cb
Merge pull request #14917 from dduugg/string-inflections
Remove ActiveSupport String inflections
2023-03-08 12:39:54 +00:00
Douglas Eichelberger
6ffda80a8a brew style 2023-03-07 10:14:57 -08:00
Douglas Eichelberger
544960b4fc Replace String#underscore with util 2023-03-07 10:13:38 -08:00
Douglas Eichelberger
1f742727af Move tests 2023-03-07 09:08:54 -08:00
Mike McQuaid
f4e180c40b
brew style --fix 2023-03-07 08:57:57 +00:00
hyuraku
4ab4dcdc82 repair spec style 2023-03-06 22:29:52 +09:00
hyuraku
122b24e9ff repair zap spec 2023-03-06 22:27:54 +09:00
hyuraku
e0416e0f65 add zap option spec to cask_installer spec 2023-03-06 22:27:53 +09:00
hyuraku
7c1bd961c6 remove cask/cmd/zap and cask/cmd/zap_spec 2023-03-06 22:27:53 +09:00
Mike McQuaid
9e370b0a3d
Merge pull request #14847 from dduugg/no-to_sentence
Move Array#to_sentence monkey-patch from ActiveSupport to extend/
2023-03-06 12:37:02 +00:00
Issy Long
7a334070b8
Merge pull request #14893 from issyl0/sorbet-bumps 2023-03-06 12:23:59 +00:00
Issy Long
5a68566097
Merge pull request #14886 from issyl0/rubocop-cask-url-verified-disallow-protocol 2023-03-06 12:22:22 +00:00