Carlo Cabrera
a4ebb96fe6
Remove MacOS
definition from generic OS
...
We don't want to define `MacOS` in the generic OS, so let's make sure we
refer to it as `OS::Mac` in the places we need it.
This reverts commit 575cb0263cb1428c63b9428bbd913ffde83bd317.
2023-04-04 23:10:51 +08:00
Carlo Cabrera
506f6c81a7
Support --dependents
flag on macOS
2023-04-04 16:20:37 +08:00
Carlo Cabrera
c125079d0f
determine-test-runners: allow usage on macOS without --dependents
2023-04-04 13:54:35 +08:00
Carlo Cabrera
3d03d243a4
determine-test-runners: test failure modes (again)
2023-04-04 13:25:44 +08:00
Carlo Cabrera
e191dbfb9e
Improve style
2023-04-04 13:20:03 +08:00
Carlo Cabrera
a2e97fe1ad
Improve type-checking style
...
Co-authored-by: Douglas Eichelberger <dduugg@users.noreply.github.com>
2023-04-04 01:54:12 +08:00
Carlo Cabrera
45fdbbd1c1
determine-test-runners: add type-checking
2023-04-03 22:27:46 +08:00
Carlo Cabrera
dbdff020c0
determine-test-runners: avoid reopening Formula
2023-04-03 21:32:57 +08:00
Carlo Cabrera
89cd55c287
dev-cmd/determine-test-runners: add command to set test runners
...
This is based on feedback from Homebrew/homebrew-core#127236 .
2023-04-03 20:36:45 +08:00
Douglas Eichelberger
4f5fc770f6
rm popen sigs
2023-03-30 17:22:02 -07:00
Douglas Eichelberger
80091b8a58
Fix tests
2023-03-30 16:39:10 -07:00
Douglas Eichelberger
15582dd031
Add Utils popen sigs, enable IO types
2023-03-30 16:39:10 -07:00
apainintheneck
9835d1a681
formula: add missing extend/os require
...
This allows Formula#valid_platform? to work correctly on MacOS.
2023-03-28 11:38:58 -07:00
Mike McQuaid
6024f4aa3f
Merge pull request #15068 from MikeMcQuaid/more_update_tweaks
...
More update tweaks
2023-03-28 09:25:20 +01:00
Mike McQuaid
eef6e9bf05
Merge pull request #15072 from apainintheneck/search-by-platform
...
search: show results by platform
2023-03-28 09:07:46 +01:00
Mike McQuaid
b97db86a26
Merge pull request #15057 from dduugg/enable-types
...
Enable types in Formula files
2023-03-28 08:57:17 +01:00
Carlo Cabrera
f75c56a90d
Merge pull request #14873 from carlocab/no_fixup_chains
...
Pass `-no_fixup_chains` to linker when required
2023-03-28 12:25:48 +08:00
apainintheneck
c073cf901a
search: show results by platform
...
This means that formulas that are only available on one
OS should only show up in the search results for the platform.
2023-03-27 20:04:57 -07:00
Mike McQuaid
9de0b619f3
More update tweaks
...
- Make copying to `*_names.before.txt` the responsibility of `update.sh`
(unless the file doesn't exist at all). This provides the added
benefit of allowing the inspection of the before/after state after
running a `brew update` rather than both files always being identical
at this point.
- State `No changes to formulae or casks.` on macOS.
- Rename and flip `updated_formula_report` to `auto_update`; this naming
was confusing every time.
- Only display the `You can upgrade with...` messaging if we're not
auto-updating as sometimes it will be displayed before the commands it
references (e.g. `upgrade`, `outdated` or an `install` that proceeds
to upgrade these formulae).
Fixes https://github.com/Homebrew/brew/issues/15065
2023-03-27 17:24:32 +01:00
apainintheneck
0048b394d4
readall: fix no simulate
...
This wasn't working with casks because the bottle tag
would be nil here.
It was refactored to not use the bottle tag because
casks don't have bottles.
I also moved the valid_casks? method to extend/os/mac
because casks only run on macOS and the generic OS
tests were failing before.
2023-03-26 10:37:20 -07:00
Douglas Eichelberger
7720485f40
Enable types in Formula files
2023-03-25 08:50:06 -07:00
apainintheneck
6ccf21c2c9
Merge branch 'master' into add-service-block-to-formula-api
2023-03-22 20:06:32 -07:00
Douglas Eichelberger
9ba677f6d4
Update Library/Homebrew/extend/pathname.rb
...
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2023-03-22 10:04:53 -07:00
apainintheneck
38146893c3
api_hashable: Make API path subs generic
...
This turns the ability to replace common paths with placeholders
into a mixin that can be used with both Casks and Formulae.
The idea here is to make formula hash generation more consistent.
2023-03-21 23:20:42 -07:00
Douglas Eichelberger
91afda651a
Update Pathname#magic_number
2023-03-21 17:37:48 -07:00
Douglas Eichelberger
b1f722aed7
Update RBI files
2023-03-21 17:37:48 -07:00
Douglas Eichelberger
f38a672938
brew style --fix
2023-03-21 17:37:48 -07:00
Douglas Eichelberger
82dc57dfea
Enable UnpackStrategy types
2023-03-21 17:37:46 -07:00
Mike McQuaid
bd8341d422
Merge pull request #15020 from dtrodrigues/pluralize-includecount
...
Add include_count parameter to pluralize util
2023-03-20 13:53:31 +00:00
Mike McQuaid
1e4abe2cc9
Merge pull request #15018 from dduugg/rm-hash-refinement
...
Use ActiveSupport Hash#assert_valid_keys instead of refinement
2023-03-20 13:48:47 +00:00
Dustin Rodrigues
b776fb32de
change includecount to include_count for readability
2023-03-20 07:23:17 -04:00
Dustin Rodrigues
e5fba88035
use includecount argument in pluralize
2023-03-19 23:35:47 -04:00
Douglas Eichelberger
92b99b3132
Remove misleading upstream.rbi, enable types in on_system
2023-03-19 19:41:46 -07:00
Douglas Eichelberger
4dcd5ac47f
Remove HashValidator
2023-03-19 17:37:58 -07:00
Mike McQuaid
96eb047121
Merge pull request #15008 from dduugg/enable-types
...
Enable types in Library/Homebrew/cask, etc.
2023-03-19 17:22:18 -04:00
Douglas Eichelberger
4f2ff3819b
Clean up rbi files
2023-03-18 16:03:25 -07:00
Ruiyang Wu
4ac228cc41
Use install-info
from texinfo
if not available in /usr/bin
...
`install-info` is not shipped with macOS Ventura and some Linux
distros. This commit uses `install-info` from `texinfo` formula if it
is not available in `/usr/bin`.
See: https://github.com/Homebrew/discussions/discussions/4306
2023-03-18 18:24:03 -04:00
Mike McQuaid
6fd54eba5f
Merge pull request #14985 from dduugg/no-compat
...
Remove compatibility layer
2023-03-15 13:48:00 -04:00
Douglas Eichelberger
da3e28b026
Fix tests
2023-03-14 23:01:08 -07:00
Douglas Eichelberger
cc5b013cb9
Remove compatibility layer
2023-03-14 14:49:34 -07:00
Douglas Eichelberger
a1748605ab
Minor Kernel cleanup
2023-03-14 10:27:16 -07:00
Douglas Eichelberger
f4c9a96c70
Enable types in dev-cmd
2023-03-14 08:32:03 -07:00
Douglas Eichelberger
04fa6e24d7
Enable more typing
2023-03-13 09:08:56 -07:00
Douglas Eichelberger
999594dc07
Remove oxford comma from to_sentence default
2023-03-11 17:27:53 -08:00
Issy Long
8e13a6e1f4
Merge pull request #14944 from issyl0/more-rubocop-naming-method-parameter-name
...
rubocop: Further trim `Naming/MethodParameterName` allowlist
2023-03-11 22:59:39 +00:00
Issy Long
e9d994622e
rubocop: Drop "f" from Naming/MethodParameterName
allowlist
...
- This either stands for "file" but more often than not "formula".
2023-03-11 00:17:27 +00:00
Douglas Eichelberger
76671ef555
Typecheck ENV extensions
2023-03-09 20:51:01 -08:00
Issy Long
89fb8c78e8
rubocop: Drop "s" from Naming/MethodParameterName
allowlist
...
- Most usages of this were in the `pretty_duration` method, where "s"
is better described as "seconds" since we're calculating a duration.
- I also took the executive decision to do the same to "m" which refers
to "minutes".
2023-03-08 14:42:53 +00:00
Douglas Eichelberger
7aab1c2a38
Remove ActiveSupport String inflections
2023-03-07 10:16:52 -08:00
Carlo Cabrera
4c4e9369b1
Fix brew style
2023-03-07 23:28:59 +08:00