Mike McQuaid
7d0ac4dd4b
style: run actionlint.
...
It feels nice to also be running this as part of `brew style` checks
and, indirectly, `brew test-bot` tap syntax checks.
Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
2024-05-27 15:30:04 +01:00
Mike McQuaid
16901a674f
extend/kernel: make opoo/odie/etc. print GitHub Actions notes.
...
We already do this for deprecations but these may make warnings
and errors from Homebrew easier to spot in GitHub Actions logs.
While we're here, cleanup other cases that should have used
`GitHub::Actions::Annotation` but didn't and provide some helpers and
tweaks there necessary for our use case here.
2024-05-09 14:43:53 +01:00
Markus Reiter
caf87c0336
Warn about undocumented non-private APIs.
2024-05-01 11:35:20 +02:00
Mike McQuaid
aa6ea4be83
Call Homebrew.install_bundler_gems! more consistently.
...
- Call `Homebrew.install_bundler_gems!` as early as possible
- Always call `Homebrew.install_bundler_gems!` in `dev-cmd` rather than
in `Library/Homebrew` helpers method (to ensure we don't accidentally
call this for non-dev-cmd commands)
2024-04-30 10:39:35 +01:00
Markus Reiter
0f0055ede4
Make documentation @api private by default.
2024-04-26 19:04:20 +02:00
Mike McQuaid
ea2892f8ee
brew.rb: handle missing args.
2024-03-07 16:20:20 +00:00
Issy Long
06028c204a
Merge pull request #16518 from issyl0/rubocop-md
...
rubocop: Try out `rubocop-md` for linting the code in our docs
2024-02-02 15:49:46 +00:00
Douglas Eichelberger
eb7c3e52a0
Require SystemInclude only where needed
2024-01-31 11:42:01 -08:00
Issy Long
00b47d1fec
Teach brew style about docs/.rubocop.yml
...
- Yes, we have yet another `.rubocop.yml` but in-line exclusions in
`<span class="display:none;">` in the Markdown seemed more ugly.
- This needed tweaks to `brew style` to make it read the new config
file when we're scanning docs.
2024-01-24 00:01:45 +00:00
Bo Anderson
3b1c171184
Further split up Gemfile into groups
2023-09-27 17:33:44 +01:00
Markus Reiter
813e639678
Add cask URL location to audit problems.
2023-05-21 16:17:16 +02:00
Douglas Eichelberger
24cf6076e8
brew style --fix
2023-04-24 20:42:39 -07:00
Issy Long
41466025cc
dev-cmd/style: Properly clean up the --display-cop-names option
...
- I remember making these changes as part of the RuboCop bump
Dependabot PR (15136), but I must have not actually pushed them. Odd.
2023-04-11 00:19:09 +01:00
Douglas Eichelberger
b8aa619f2f
brew style --fix
2023-03-15 18:21:41 -07:00
Douglas Eichelberger
827fc87cde
Enable more typing
2023-03-15 14:29:15 -07:00
Douglas Eichelberger
ed8363fd72
Consolidate some rubocop configurations
2023-02-21 16:50:29 -08:00
Sean Molenaar
f30779c6bf
Update package/scripts/postinstall
2022-12-23 19:36:13 +01:00
Mike McQuaid
a92c9eed82
style: check more shell scripts.
...
We were missing a few here so add them. Also, fix the changes in
`on-create-command.sh` that this catches.
2022-11-09 17:29:38 +00:00
Bo Anderson
e03548fc7a
style: use HOMEBREW_RUBY_EXEC_ARGS
2022-11-05 04:18:10 +00:00
Bo Anderson
a776d5f02b
Workaround macOS system Ruby issue picking incorrect native gem archs
2022-10-14 01:30:38 +01:00
Mike McQuaid
6b697470fd
brew style --fix
...
For https://github.com/Homebrew/brew/pull/13671
2022-08-10 14:19:33 +01:00
Bo Anderson
f804a22dc0
style: use new autocorrect flag
2022-06-17 19:47:57 +01:00
Mike McQuaid
bf34f21065
style: use long shfmt arguments.
...
This allows removing documentation explaining them.
2022-05-16 17:19:16 -04:00
Bryce Glover
1763beb8f6
Revert "Enable .rubocop.yml in taps"
2022-03-28 20:11:04 -04:00
danielbayley
59885d7719
Enable .rubocop.yml in taps
2022-03-24 20:28:50 +00:00
Xuehai Pan
2466353415
style: use short flags for patch command for compatibility
2022-01-03 22:13:32 +08:00
Xuehai Pan
62a63063bb
Apply suggestions from code review
...
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
Signed-off-by: XuehaiPan <XuehaiPan@pku.edu.cn>
2021-11-24 01:06:27 +08:00
XuehaiPan
9ef52080e3
utils: extract common word "for" in reason
2021-11-23 23:59:09 +08:00
XuehaiPan
d749173adc
utils: mark reason as keyword argument in ensure_formula_installed!
2021-11-23 23:31:22 +08:00
XuehaiPan
3376479e95
utils: add method ensure_formula_installed!
2021-11-23 22:48:39 +08:00
Mike McQuaid
e38e25dfd1
Merge pull request #12397 from XuehaiPan/shellcheckrc
...
.shellcheckrc: disable unneeded check SC2310-SC2312 globally
2021-11-08 16:15:21 +00:00
XuehaiPan
d78c11361a
.shellcheckrc: disable unneeded check SC2310-SC2312 globally
2021-11-08 23:50:54 +08:00
Xuehai Pan
c1d2f8a2c6
style: catch failures while applying patches
...
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2021-11-08 22:50:20 +08:00
XuehaiPan
b86fdfeb09
style: use long options for patch command
2021-11-08 22:34:49 +08:00
XuehaiPan
67c619d4f2
style: use popen_write to apply patches
2021-11-08 20:10:30 +08:00
Xuehai Pan
a56ab26e88
Merge branch 'master' into shellcheck-autofix
2021-11-08 12:02:54 +08:00
Bo Anderson
98c082ca94
style: ignore SC2310-2312 for now
2021-11-08 03:11:39 +00:00
XuehaiPan
fa85d00b95
style: implement shellcheck autofix in brew style --fix
2021-11-07 21:12:03 +08:00
Mike McQuaid
bc687314af
style: better handle HOMEBREW_REPOSITORY.
...
If you do `brew style --fix .` in `HOMEBREW_REPOSITORY` it behaves
very weirdly and uses the incorrect rules. If this is passed, assume
that people want the same behaviour as `brew style --fix`.
While we're here, do some argument naming and code cleanup.
2021-09-30 11:06:09 +01:00
XuehaiPan
966189d07d
style: add shfmt exit status to brew style
2021-09-17 00:05:37 +08:00
XuehaiPan
03017a84b4
style: move inplace flag to the front of argument list
2021-09-16 21:20:56 +08:00
XuehaiPan
2688e7e56b
style: apply suggestions from code review
2021-09-16 19:54:07 +08:00
XuehaiPan
03c7a142be
style: add keyward argument inplace to run_shfmt
2021-09-16 00:08:29 +08:00
XuehaiPan
9efde249c1
style: add shfmt implementation
2021-09-15 22:12:01 +08:00
XuehaiPan
2855ae18df
style: brew style always use latest brewed shellcheck
2021-09-15 15:00:23 +08:00
XuehaiPan
bc0663baba
style: brew style check Dockerfile as shell script
2021-09-15 15:00:23 +08:00
hyuraku
fcdeaf7eca
chnage condition for shellcheck
2021-09-07 20:47:48 +09:00
Bo Anderson
a06d136d2c
Move Sorbet gems into an optional group
2021-06-11 08:10:30 +01:00
Gautham Goli
cf733a3c4f
Enable shellcheck warnings in brew style
2021-05-18 17:10:44 +05:30
Mike McQuaid
7af68d0f8e
Fix shellcheck failures
...
A new version of `shellcheck` (I think?) brought us so new warnings and
errors.
To fix:
- pass `--source-path` so we don't need to stop `shellcheck` trying to
read sourced files every time
- disable some more warnings/errors we don't care about fixing
2021-04-22 13:18:44 +01:00
