2082 Commits

Author SHA1 Message Date
Camden Narzt
c9f4d1c35d
style 2017-08-21 19:25:37 -06:00
Camden Narzt
ab8a6f31e8
Add test 2017-08-21 19:22:17 -06:00
JCount
85fd43d4fe Merge pull request #3063 from GauthamGoli/rubocop_spec_multiline_offenses_fix
audit: In Cops and their tests convert all multiline strings to heredocs
2017-08-21 13:13:09 -04:00
Markus Reiter
4b34ca5b35 Merge pull request #3001 from reitermarkus/cask-conflicts-with
Implement `conflicts_with :cask`.
2017-08-20 17:50:54 +02:00
Markus Reiter
3b92f69869 Merge pull request #3054 from BenMusch/github-refactor
Clean-up code in GitHub module to reduce duplication & coupling w/ Github API
2017-08-18 16:26:30 +02:00
Ben Muschol
564a06dfbb Fix typo in spec 2017-08-17 13:44:18 -04:00
Ben Muschol
e096836b7b Improve rspec readability 2017-08-17 11:57:58 -04:00
Ben Muschol
7a93638105 Make test more resilient 2017-08-17 11:40:32 -04:00
Gautham Goli
db20b0c281 audit: In Cops and their tests convert all multiline strings to heredocs 2017-08-17 11:41:58 +05:30
Mike McQuaid
8518ffdee1 Merge pull request #3059 from MikeMcQuaid/why-search-take-so-long
search: explain why it takes the time it does.
2017-08-15 10:49:47 +01:00
Mike McQuaid
961d79011e search: explain why it takes the time it does.
Provide a bit of clarity that this isn't just searching a local database
but doing an GitHub API and Git history query.
2017-08-15 10:25:51 +01:00
Ben Muschol
5f8d212ccc Unify vocabulary in github module, remove unnecessary logic
Fix duplication bug
2017-08-14 14:45:24 -04:00
Ben Muschol
68cdb550f7 Spec for issues search 2017-08-14 12:06:12 -04:00
Ben Muschol
603bdd01a8 Implement PR feedback 2017-08-14 11:08:56 -04:00
Ben Muschol
24da1ecd3d Fix url encoded in expected values 2017-08-13 17:16:45 -04:00
Ben Muschol
e93ec12b32 Remove duplicate url generation logic in Github module 2017-08-13 15:03:44 -04:00
Mike McQuaid
ae8235c555 Revert "Raise an exception when double loading a formula" 2017-08-12 15:00:36 +01:00
Mike McQuaid
b93f1e3569 Merge pull request #3046 from alyssais/double_formula_load_error
Raise an exception when double loading a formula
2017-08-12 13:00:10 +01:00
Alyssa Ross
4760f4e803
Raise an exception when double loading a formula
(As proposed in #2673)
2017-08-11 22:40:08 +01:00
Ben Muschol
eb009503ed Fix test typo 2017-08-11 15:52:50 -04:00
Ben Muschol
b06fceda57 Add a test 2017-08-11 15:49:57 -04:00
Markus Reiter
2cba322200 Allow curl args to be overriden. 2017-08-08 23:06:40 +02:00
Markus Reiter
ae4bafdb36 Simplify CurlDownloadStrategy. 2017-08-08 18:10:13 +02:00
Markus Reiter
b6b8e8863f Simplify SubversionDownloadStrategy. 2017-08-08 18:10:01 +02:00
Mike McQuaid
00c8d71a23 Merge pull request #3019 from rwhogg/new-fedora-pkgsearch
cmd/search: use new Fedora package search
2017-08-08 11:00:40 +01:00
Bob W. Hogg
3b7113b304 cmd/search: use new Fedora package search
pkgdb has been put into read-only mode,
so it won't be updated for new Fedora releases
going forward. Use apps.fedoraproject.org/packages instead.

Signed-off-by: Bob W. Hogg <rwhogg@linux.com>
2017-08-07 18:22:26 -07:00
ilovezfs
986887b413 Revert "Refactor SVN and cURL download strategies." 2017-08-07 14:31:56 -07:00
Markus Reiter
dc5a2c1764 Simplify CurlDownloadStrategy. 2017-08-07 21:31:17 +02:00
Markus Reiter
fb59e79689 Simplify SubversionDownloadStrategy. 2017-08-07 21:31:17 +02:00
Gautham Goli
a3219ca09c Add node pattern methods to handle dependency audits in a better way 2017-08-07 16:02:50 +05:30
Markus Reiter
ffc47388bd Fix Pkg#uninstall not calling MacOS.undeletable? for all files. 2017-08-06 13:19:30 +02:00
Gautham Goli
781da49df8 audit: Add tests for audit rules ported from line_problems method to rubocops 2017-08-06 02:28:58 +05:30
Gautham Goli
affd9055c2 audit: Port classname and template comments audit rules from line_problems method to rubocop 2017-08-06 02:28:58 +05:30
Markus Reiter
7a17a166ec Merge pull request #3006 from reitermarkus/unfocus
Delete `:focus`.
2017-08-05 21:05:08 +02:00
Gautham Goli
66ffdb5b06 Refactor legacy_patches_cop to merge external patch audit rules in a single cop and add tests 2017-08-05 21:51:24 +05:30
Markus Reiter
f5af3fe0cd Delete :focus. 2017-08-05 18:09:09 +02:00
Markus Reiter
f89e09b785 Add spec for conflicts_with cask. 2017-08-05 16:21:14 +02:00
Markus Reiter
42cfb6d238 Merge pull request #2999 from mistydemeo/tap_each_enum
Tap.each: return an enumerable when no block given
2017-08-04 16:14:06 +02:00
Markus Reiter
12d4226bfc Remove _checkurl. 2017-08-04 15:39:32 +02:00
Misty De Meo
1c3ece12b9 Tap.each: return an enumerable when no block given 2017-08-03 17:23:16 -07:00
Mike McQuaid
f4983ab16b Merge pull request #2975 from GauthamGoli/audit_urls_rubocop_strict
audit: Port audit_urls strict rules to rubocop, add tests, autocorrect
2017-08-01 11:39:01 +01:00
Mike McQuaid
c3c3575b70 Merge pull request #2964 from GauthamGoli/audit_line_rubocop_part_1
audit: Port dependency rules from line_problems to rubocop and add tests
2017-08-01 11:29:26 +01:00
Mike McQuaid
044f4d947b Tweak preserve link status on reinstall/upgrade.
Treat a `brew install` command as normal i.e. link by default unless
keg-only and only specify whether a keg should be linked when upgrading
or reinstalling. Also, adjust the naming accordingly so it's more
obvious that this is the case.
2017-07-30 21:44:43 +01:00
Mike McQuaid
e1fd69de42 Merge pull request #2961 from MikeMcQuaid/preserve-link-on-upgrade-reinstall
Preserve link status on reinstall/upgrade.
2017-07-30 18:42:06 +01:00
Mike McQuaid
e755505c70 Merge pull request #2969 from MikeMcQuaid/default-formula-bottles
formula_installer: use default_formula for bottles
2017-07-30 18:41:10 +01:00
Mike McQuaid
a83baba8b5 formula_installer: use default_formula for bottles
This was the original, intended functionality before this was broken
in fe117bf79b244c42b7e4049d353c3c003eae4880.

Fixes https://github.com/Homebrew/homebrew-core/issues/13680.
2017-07-30 16:56:24 +01:00
Mike McQuaid
7ec0505200 Preserve link status on reinstall/upgrade.
This means if a user has manually `brew unlink` or `brew link --force`d
something then that status will be preserved after they `brew upgrade`
or `brew reinstall` that formula.

This generally should make things that are keg-only by default easier
to swallow.
2017-07-30 16:20:32 +01:00
Mike McQuaid
3821132f9e Merge pull request #2898 from MikeMcQuaid/sandbox-all-taps
sandbox: sandbox all taps by default.
2017-07-30 16:02:36 +01:00
Gautham Goli
c575f34d5f audit: Port audit_urls strict rules to rubocop, add tests and autocorrect 2017-07-30 12:59:37 +05:30
Markus Reiter
5fea557da3 Use mktmpdir. 2017-07-29 22:21:41 +02:00