11038 Commits

Author SHA1 Message Date
Markus Reiter
3540c94df6 Add define_method and define_singleton_method. 2016-09-23 15:30:06 +02:00
Markus Reiter
b97b0bac6c Update .rubocop_todo.yml. 2016-09-23 15:30:06 +02:00
Markus Reiter
23eac7ab89 Fix DoubleNegation. 2016-09-23 15:30:06 +02:00
Markus Reiter
52ff988530 Fix RuboCop CaseEquality. 2016-09-23 15:30:06 +02:00
Markus Reiter
db37920fa7 Run rubocop. 2016-09-23 15:30:06 +02:00
Markus Reiter
be22265860 Set Style/NumericLiterals MinDigits to 7. 2016-09-23 15:30:06 +02:00
Markus Reiter
129dfcac4a Remove .simplecov from cask’s RuboCop config. 2016-09-23 15:30:06 +02:00
Markus Reiter
8b921c087c Disable new Style/VariableNumber cop. 2016-09-23 15:30:06 +02:00
Markus Reiter
eec68a1e05 Disable Style/IfUnlessModifier only in Taps. 2016-09-23 15:30:06 +02:00
Markus Reiter
77bd30574b Disable Style/GuardClause only in Taps. 2016-09-23 15:30:06 +02:00
Markus Reiter
0581dda187 Auto-correct guard clauses. 2016-09-23 15:30:05 +02:00
Markus Reiter
14362a7e5f Include .simplecov in RuboCop. 2016-09-23 15:30:05 +02:00
Markus Reiter
a5f050245e Add Regex for Style/FileName cop. 2016-09-23 15:30:05 +02:00
Markus Reiter
59212445da Run rubocop —auto-correct. 2016-09-23 15:30:05 +02:00
Markus Reiter
b957a1b7e6 Enable Style/EmptyElse cop. 2016-09-23 15:30:05 +02:00
Markus Reiter
2a1788484a Remove dependency on rubocop-cask. 2016-09-23 15:30:05 +02:00
Mike McQuaid
4cbeb1e981 Merge pull request #1103 from MikeMcQuaid/update-upstream-tag-strict
update.sh: only update to semver tags.
2016-09-23 14:26:04 +01:00
Mike McQuaid
28a3cec21a test-bot: cleanup Cellar/etc/var after each build.
This has been causing issues when bottling files that are installed to
these paths due to the diff algorithm we use for figuring out whether
files installed into etc/var belong to a given bottle. Additionally,
sometimes not all formulae were uninstalled which meant `brew doctor`
would fail.
2016-09-23 14:24:41 +01:00
Mike McQuaid
8989275473 Merge pull request #1084 from penman/fast_integration_tests
tests: speed up integration tests coverage
2016-09-23 11:35:45 +01:00
Mike McQuaid
b0dfd2d435 update.sh: only update to semver tags.
Otherwise random e.g. `pr-123` tags may cause `brew update` to update
to the wrong version.
2016-09-23 11:26:24 +01:00
Zhiming Wang
19dcb2cf41
test_versions: add elasticsearch alpha test case 2016-09-23 06:23:37 -04:00
Zhiming Wang
58a2ef9b58
version: improve alpha and rc detection 2016-09-23 06:23:36 -04:00
Mike McQuaid
597a92af44 Merge pull request #1101 from MikeMcQuaid/sandbox-repository
sandbox: tweak HOMEBREW_REPOSITORY handling.
2016-09-23 11:12:08 +01:00
Alyssa Ross
5f6a8d407a tests: speed up integration tests coverage
Previously, .simplecov called `SimpleCov.result` to store the coverage
result, and ignored the return value. `SimpleCov.result`'s return can be
slow to calculate, which wastes a lot of time when it's ignored.

This commit extracts the code needed to store the SimpleCov result from
`SimpleCov.result`, and calls it directly, without doing the busywork to
compute the return value every time.

In my testing, this more than halves the time taken to run all the
integration tests.
2016-09-23 10:40:08 +01:00
Mike McQuaid
9001855d64 Merge pull request #1086 from woodruffw/macho-cosmetics
Remove old cctools references now that only ruby-macho is used.
2016-09-23 10:40:08 +01:00
Markus Reiter
759ee585d5 Merge pull request #1089 from reitermarkus/coverage
Fix coverage reporting.
2016-09-23 10:33:42 +02:00
Mike McQuaid
bc52932e5a Merge pull request #1014 from rwhogg/upstream-ant-dep-linux-fix
dependency_collector: Fix ant_dep for Linux
2016-09-23 08:41:45 +01:00
Mike McQuaid
289cd0580e Merge pull request #1085 from penman/docs-update_test
docs: more accurate update-test parameter name
2016-09-23 08:34:20 +01:00
Mike McQuaid
536c48e804 sandbox: tweak HOMEBREW_REPOSITORY handling.
If we have a HOMEBREW_REPOSITORY and HOMEBREW_PREFIX mismatch (now the
default) then we can block access to the whole of HOMEBREW_REPOSITORY
rather than just the HOMEBREW_LIBRARY and `.git`.
2016-09-23 08:29:05 +01:00
Markus Reiter
6b85593895 Fix coverage reporting. 2016-09-23 09:17:55 +02:00
Mike McQuaid
5cf3838f42 Merge pull request #1041 from penman/parallel_tests
Parallelise test suite
2016-09-23 07:57:35 +01:00
Alex
b63f024b07 Updated accessibility test for Sierra 2016-09-22 22:25:12 -07:00
Dominyk Tiller
b7e7434bdb Merge pull request #1093 from rwhogg/most-formulae-have-tests
test: most formulae have tests now
2016-09-23 04:20:12 +01:00
Dominyk Tiller
d3a2934d8b Merge pull request #1090 from MikeMcQuaid/brew-version-repository
brew.sh: fix brew --version outside HOMEBREW_REPOSITORY.
2016-09-23 03:56:13 +01:00
Bob W. Hogg
aae4dfaec0 automated rubocop fixup 2016-09-22 22:10:32 -04:00
Dominyk Tiller
f3ef9a4551
diagnostic: make using outdated dev tools fatal
A smarter form of 559cea7fa9.
Travis users can't force Travis to update 10.11 to Xcode 8, so this was murdering
builds left, right & centre.

Fixes https://github.com/Homebrew/brew/issues/1096 whilst still retaining the
point of the original commit. Also offers developers an opt-out so if we need
to test something on 10.11 with Xcode 7.x we can, etc.
2016-09-23 00:13:04 +01:00
Dominyk Tiller
559cea7fa9
Revert "diagnostic: make using outdated development tools fatal"
This reverts commit a124680b189f50ebeb550845e3c0efd34db66247.

Will need to be smarter than this, since people can't force Travis to
update. I'm losing count of the amount of times Travis has forced a change
of plans around Homebrew this year.

Closes https://github.com/Homebrew/brew/issues/1096.
2016-09-22 23:37:12 +01:00
Bob W. Hogg
1de9f3baf3 make linux behaviour the default. override only for macos 2016-09-22 17:47:50 -04:00
Bob W. Hogg
0029ad2929 add the other test back in 2016-09-22 17:36:57 -04:00
Bob W. Hogg
709a20e2a0 test: most formulae have tests now 2016-09-22 17:12:13 -04:00
Mike McQuaid
5af52410ab brew.sh: fix brew --version outside HOMEBREW_REPOSITORY. 2016-09-22 21:46:11 +01:00
Mike McQuaid
889c400be4 Merge pull request #956 from DomT4/oh_no_not_this_time_of_year_again
Xcode 8.0 changes.
2016-09-22 21:26:04 +01:00
William Woodruff
846a5b79b6
Remove old cctools references now that only ruby-macho is used. 2016-09-22 14:36:24 -04:00
Alyssa Ross
b81dcea043 update-test: more accurate variable names 2016-09-22 19:26:41 +01:00
Alyssa Ross
5ba04b0cc6 docs: more accurate update-test parameter name
`sha1` isn't a very accurate description of what this value can be
because it can be any git commit reference. For example, `brew test-bot`
uses `brew update-test --commit=HEAD`.
2016-09-22 19:26:24 +01:00
Dominyk Tiller
a124680b18
diagnostic: make using outdated development tools fatal 2016-09-22 18:15:48 +01:00
Dominyk Tiller
5575c17629
xcode: prefer Utils.popen_read 2016-09-22 18:15:47 +01:00
Dominyk Tiller
b089520682
xcode: revert expectation of 10.11 8.0 CLT 2016-09-22 18:15:47 +01:00
Dominyk Tiller
9fda6d2ec9
docs/Xcode: there is no 10.11 CLT 8.0
From the 8.1 Xcode Beta:
```
There is no Command Line Tools (OS X 10.11) for Xcode 8 package. Xcode 8 contains
SDKs that are incompatible with earlier toolchains. Developers who want to make
use of the Xcode 8 SDKs from the command line must choose the SDK with `xcode-select`.
Developers on OS X El Capitan who have installed versions of the Command Line Tools
(OS X 10.11) for Xcode 8 Beta should install Command Line Tools (OS X 10.11)
for Xcode 7.3.1.
```

Thanks Apple.
2016-09-22 18:15:40 +01:00
Dominyk Tiller
2e808ff2e3
Xcode.md: update 10.11 expectation 2016-09-22 17:30:57 +01:00