188 Commits

Author SHA1 Message Date
Mike McQuaid
d6d857c154
cmd/upgrade: fix exit logic.
Fixes #6739
2019-11-14 07:22:19 -08:00
Mike McQuaid
9d2cb8e9b3
upgrade: don't error if already installed.
I've been convinced idempotency is a good thing for this command so this
would be a good thing to get out for 2.2.0.
2019-11-12 16:18:54 -08:00
Mike McQuaid
e8c241f56c
upgrade: fix handling broken dependents.
Ensure that we use the keg for checking linkage but that the dependents
returned are still formulae.

Fixes #6715.
2019-11-11 10:08:08 +00:00
Paul
2e55eac802
'upradable' typo for 'upgradeable_dependents' 2019-11-07 22:58:02 +07:00
Mike McQuaid
81e6359aeb
upgrade: tweak dependent messaging.
Output more without requiring `--verbose` and update the messages to
make clear what we're looking for and what we found/didn't find.

This is a little more noisy but it should help explain any delays to
users and make it more obvious what's failed if something does.
2019-11-06 11:38:17 +00:00
Mike McQuaid
e12a7b0808
upgrade: simply check_dependents, remove recursion. 2019-11-06 10:21:31 +00:00
Mike McQuaid
0cf6052fcc
cmd/upgrade: comment-out broken_dependents functionality.
This is not a fix for https://github.com/Homebrew/brew/issues/6671 but
will stop people hitting this bug for now.
2019-11-05 09:51:17 +00:00
Issy Long
d0c3885f31
Merge pull request #6592 from issyl0/bump-rubocop-target-ruby-version
Bump Rubocop's `TargetRubyVersion` to 2.6 and fix all offenses
2019-10-14 09:39:21 +01:00
Issy Long
341ea60807
Auto-fix Style/RedundantBegin offenses
- This also required auto-fixes for Layout/EmptyLinesAroundBlockBody and
  Layout/InconsistentIndentation once the auto-fixer had got rid of the
  "redundant begin"s.
2019-10-13 16:04:27 +01:00
L. E. Segovia
024007f9e2
upgrade: address @MikeMcQuaid's comments 2019-10-12 22:06:08 +00:00
L. E. Segovia
f4707a8041
upgrade: reject formulae checked in earlier levels 2019-10-12 15:53:21 +00:00
Gautham Goli
393c8dfbf1 ARGV: Replace options_only and flags_only with Homebrew.args counterparts 2019-09-23 12:39:22 +05:30
Kristof Lünenschloß
3e46488ca4 Display packages to upgrade one package per line 2019-09-13 13:43:34 +02:00
Mike McQuaid
7df0292f9b
Revert "argv: move flags_only to cli/args" 2019-09-13 09:12:26 +01:00
Gautham Goli
c7681c4287 argv: move flags_only to cli/args 2019-09-09 14:51:36 +05:30
EricFromCanada
2477773259 man: include global options with customized descriptions 2019-08-25 23:59:47 -04:00
L. E. Segovia
b3a1f34b7b
upgrade: style fixes 2019-08-23 01:51:06 +00:00
L. E. Segovia
efb200e825
breadth-first search for dependents upgrade
Fixes Homebrew/brew#6386
2019-08-22 12:38:28 +00:00
EricFromCanada
8a8359cdd4 manpages: sentence rewording for readability
Use active voice when applicable, better verbs & adjectives, preposition usage, proper tense, etc.
2019-08-20 09:05:45 -04:00
EricFromCanada
ee314617f7 manpages: update command usage strings 2019-08-20 08:55:54 -04:00
EricFromCanada
6520785307 manpages: grammar fixes 2019-08-20 08:26:26 -04:00
EricFromCanada
a3e0647797 manpages: whitespace fixes 2019-08-20 08:24:20 -04:00
Mike McQuaid
1cd45a769d
Merge pull request #6330 from hogand/add-upgrade-dry-run
Add --dry-run to brew upgrade and brew cask upgrade
2019-07-28 15:18:13 +01:00
Mike McQuaid
41461b2c00
upgrade: tweak --dry-run wording. 2019-07-28 14:50:59 +01:00
Mike McQuaid
9354081323
Add HOMEBREW_DISPLAY_INSTALL_TIMES
Fixes #6300
2019-07-28 11:12:32 +01:00
Doug Hogan
7f6ef77d0e Address PR comments: remove test and use return ... if 2019-07-27 07:36:11 -07:00
Doug Hogan
9e0e012a56 cmd/upgrade: add --dry-run option. 2019-07-26 23:20:51 -07:00
Mike McQuaid
c4f72312ce
Fixup brew style failures. 2019-04-30 09:19:18 +01:00
Mike McQuaid
0b685bb890
upgrade: don't build bottles unnecessarily.
Fixes #6063.
2019-04-25 14:01:50 -07:00
Mike McQuaid
36dbad3922
Add frozen_string_literal to all files. 2019-04-20 13:27:36 +09:00
Mike McQuaid
e40b171127
Rename cli_parser to cli/parser. 2019-04-17 22:16:50 +09:00
Mike McQuaid
8d01cda922
Merge pull request #5925 from MikeMcQuaid/more-deprecations
Deprecate tap pinning (and remove `odisabled`)
2019-04-03 09:00:06 +01:00
Mike McQuaid
6987fb4d05
upgrade: make clear formula options are used (not install options). 2019-04-02 08:20:28 +01:00
Mike McQuaid
d12e39633c
Remove odisabled. 2019-04-01 15:07:50 +01:00
Mike McQuaid
45243fe449
Revert "Fix Infinite Recursion in upgradable_dependents and broken_dependents" 2019-02-26 16:49:17 +00:00
Frizlab
c27ba5c4bd Print a warning when a recursive upgradable or broken dependant has been found 2019-02-16 14:40:29 +01:00
Frizlab
b4f76db37c Fix infinite recursion in upgradable_dependents and broken_dependents 2019-02-16 00:04:12 +01:00
Gautham Goli
ba057ad239
Fixes #5663 2019-02-04 08:40:05 +01:00
Mike McQuaid
267d721988
Note HOMEBREW_NO_INSTALL_CLEANUP in the help/manual 2019-02-03 09:34:00 +01:00
Mike McQuaid
6cb7a00f2d
cmd: remove --help headers and tweak docs. 2019-01-30 21:39:28 +00:00
Mike McQuaid
867b155479
Add missing conflicts to command options. 2019-01-29 19:39:41 +00:00
Mike McQuaid
9eabcdad7d
Make install/reinstall/upgrade options more consistent. 2019-01-29 19:25:59 +00:00
Gautham Goli
22c2b06fa5
cmd/upgrade: Use CLI::Parser to parse args 2019-01-29 16:58:44 +00:00
Mike McQuaid
eed1444d61
Update deprecations and cleanup
- Move `odeprecated` to `odisabled`
- Remove `odisabled`
- Enable automatic cleanup on install/reinstall/upgrade.
2019-01-23 21:57:40 +00:00
Mike McQuaid
a24197bcc9
Fix some bottling logic
- We've never supported `devel` bottles so don't bother outputting their
  status to `brew info`
- Don't `brew upgrade` or `brew reinstall` bottles if they were
  previously built as a bottle unless there's no bottles defined at all
  (rather than there was no compatible bottles). Fixes #5532.
2019-01-14 16:47:07 +00:00
Mike McQuaid
170c5493a4
Update deprecations
- Add some `odeprecated`
- Make some `odeprecated` now `odisabled`
- Remove `odisabled` code.
- Remove old update migrations
- Remove GCC 4.0 compiler
- Remove Tiger-only code
- Remove 32-bit-only code
- Remove use of LD64
- Remove GCC 4.3 - 4.8 support.
2019-01-08 19:13:46 +00:00
Mike McQuaid
8144667a71
Cleanup periodically if HOMEBREW_INSTALL_CLEANUP is set.
This will become the default in a later version of Homebrew but has an
opt-out through HOMEBREW_NO_INSTALL_CLEANUP.

Also, always cleanup files older than 120 days and set the general
default value for "old" logs, casks etc. to 30 days.
2019-01-03 16:23:44 +00:00
Jarek Wojciechowski
51ca60d6d5 add formula cleanup to install and reinstall 2018-10-29 11:23:32 -04:00
Jarek Wojciechowski
18f8adbd5c test and add HOMEBREW_INSTALL_CLEANUP to upgrade 2018-10-23 15:46:07 -04:00
EricFromCanada
20167e5f1b Adjust comments to tidy API docs output. 2018-10-18 21:42:43 -04:00