Issy Long
cca8138a59
docs: Title-case every h1 it made sense to title-case
2019-12-18 16:09:08 +00:00
Issy Long
ed4cc753d1
docs: Make 'how to open a PR' title match filename
...
- This is a bit of a cheat to get around the titlecase lint. But I
wasn't sure whether to ignore it or not. And there've been previous
comments about making filenames match titles, so...
2019-12-18 16:09:08 +00:00
Issy Long
3771a60720
docs: Fix typo in Homebrew/linuxbrew-core repo name
2019-12-18 16:09:07 +00:00
Issy Long
dac41ba275
Scope the Vale "terms" substitution lint to paragraphs only
...
- This clears up the final four title-case "Pull Request" in titles,
which are correct.
2019-12-18 16:09:07 +00:00
Issy Long
a5ffdc6c5a
Use Title Case in h1 headings and sentence case in all others
...
- I wrote about the implications of (not) doing this in the PR
(https://github.com/Homebrew/brew/pull/6826#issuecomment-564273209 ),
but in summary:
- It looks like pretty much the only place we've ever adhered to the
sentence case rule is the Prose Guidelines itself.
- Correcting all these to sentence case would be a lot of work (and
sometimes not even make sense).
- Admittedly, some of the title case ones look a bit horrible, but
even with some allowed exceptions, but it's better than being
consistently inconsistent.
- Only lint for title case in h1 headings. H2s and H3s etc. can be
sentence case. There's not currently a lint for that.
2019-12-18 16:09:07 +00:00
Issy Long
b90e01c524
docs: Replace repo with repository everywhere it's a single word
2019-12-18 16:09:06 +00:00
Issy Long
d43aba643d
FAQ: Replace Max's pronoun with his name
...
- For some reason, the documented way of disabling a style for a
specific section of Markdown text[1] didn't work for disabling the
pronoun lint here. This is about the only place we have a legitimate
need for it. Instead, sadly, squash this linting error by using his
name.
- Also adjust the sentence for further clarity in light of this.
[1] - https://errata-ai.github.io/vale/config/#ignoring-parts-of-your-documents
2019-12-18 16:09:06 +00:00
Issy Long
6a200cb88a
docs: Fix double-spacing after full stop issues
2019-12-18 16:09:06 +00:00
Issy Long
f2c9e55d7a
Don't lint the style guide doc - it deliberately shows bad examples
2019-12-18 16:09:05 +00:00
hyuraku
f7adc88241
fix style
2019-12-19 00:09:59 +09:00
Gautham Goli
685a6b4da6
ARGV: Replace usages of ARGV.named with Homebrew.args.named
2019-12-18 20:38:21 +05:30
hyuraku
7501f3d402
check before examine_git_origin
2019-12-19 00:05:20 +09:00
Issy Long
de622a2a21
Exclude .vale.ini from .gitignore
...
- Without this, vale won't correctly detect where the styles are.
2019-12-17 21:42:54 +00:00
Issy Long
2a53448685
Add Vale linting for our docs
...
- I noticed that another open source project had taken the Homebrew
style guide and made it into [Vale linting
rules](https://github.com/testthedocs/vale-styles/tree/master/Homebrew ).
This copies them into here, so that we can make use of them. Thanks!
- What use is a style guide if our own docs don't at least try to
adhere to it? This aims to make the rules more visible to all
contributors.
- In order for these to do anything, you'll have to `brew install vale`
and run `vale` in the root of this repo. It will look for Markdown
files.
- A next step would be adding this as a pre-commit hook, or...
- The GitHub Action would have been really good, but [it doesn't support
forks](https://github.com/errata-ai/vale-action#limitations ).
2019-12-17 21:42:53 +00:00
Mike McQuaid
205a08653b
Merge pull request #6850 from Homebrew/dependabot/bundler/Library/Homebrew/thor-1.0.1
...
build: bump thor from 0.20.3 to 1.0.1 in /Library/Homebrew
2019-12-17 15:44:24 +00:00
dependabot-preview[bot]
38e5773ee8
build: bump thor from 0.20.3 to 1.0.1 in /Library/Homebrew
...
Bumps [thor](https://github.com/erikhuda/thor ) from 0.20.3 to 1.0.1.
- [Release notes](https://github.com/erikhuda/thor/releases )
- [Changelog](https://github.com/erikhuda/thor/blob/master/CHANGELOG.md )
- [Commits](https://github.com/erikhuda/thor/compare/v0.20.3...v1.0.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-17 15:14:55 +00:00
Mike McQuaid
cf98bd6c28
Merge pull request #6846 from Homebrew/dependabot/bundler/Library/Homebrew/rubocop-rspec-1.37.1
...
build: bump rubocop-rspec from 1.37.0 to 1.37.1 in /Library/Homebrew
2019-12-17 12:16:48 +00:00
Mike McQuaid
4a7a16e39b
brew vendor-gems: commit updates.
2019-12-17 11:43:08 +00:00
Issy Long
aedfbd4550
Add garden
to root execution allow list for Concourse CI containers
...
- Concourse CI uses `garden` under the hood for its containers.
- Running the Homebrew Docker container for a Concourse job was failing
with the "can't run as root" error. In the same way as
bc320ad2291f5ec652d8f4bcf3f7b7ff3c9af3bd, this adds `garden` as one of
the allowed providers.
2019-12-17 10:31:09 +00:00
dependabot-preview[bot]
53986e9b9a
build: bump rubocop-rspec from 1.37.0 to 1.37.1 in /Library/Homebrew
...
Bumps [rubocop-rspec](https://github.com/rubocop-hq/rubocop-rspec ) from 1.37.0 to 1.37.1.
- [Release notes](https://github.com/rubocop-hq/rubocop-rspec/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop-rspec/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop-rspec/compare/v1.37.0...v1.37.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-17 05:24:26 +00:00
Mike McQuaid
4973f6707b
Merge pull request #6844 from MikeMcQuaid/download_strategy_typeerror
...
download_strategy: use (more consistent) TypeError.
2019-12-16 12:07:30 +00:00
Mike McQuaid
3946a147eb
Merge pull request #6843 from MikeMcQuaid/info-json-all-installed
...
cmd/info: fix --json argument handling.
2019-12-16 11:45:40 +00:00
Mike McQuaid
dccedbf104
download_strategy: use (more consistent) TypeError.
...
Rather than a base `RuntimeError`.
Fixes https://github.com/Homebrew/brew/issues/6839
2019-12-16 11:34:31 +00:00
Mike McQuaid
4f732a0170
cmd/info: fix --json argument handling.
...
`--all` and `--installed` do not require formulae arguments.
Fixes https://github.com/Homebrew/brew/issues/6842
2019-12-16 11:23:55 +00:00
Mike McQuaid
d556d02cd4
Merge pull request #6835 from EricFromCanada/input-handling
...
cmd/dev-cmd: improve handling of invalid input
2019-12-15 15:37:21 +00:00
EricFromCanada
aea6d79d21
option parser: check for extra named args
2019-12-15 00:04:45 -05:00
EricFromCanada
0c8eae8d9c
command: handle multiple named args
2019-12-15 00:04:45 -05:00
EricFromCanada
90e830c19e
cmd: add raises for invalid input
2019-12-15 00:04:45 -05:00
EricFromCanada
2f7c3afeb8
cmd: improve wording of messages, spacing
2019-12-15 00:04:45 -05:00
Mike McQuaid
273747cee3
Merge pull request #6837 from Homebrew/dependabot/bundler/Library/Homebrew/activesupport-6.0.2
...
build: bump activesupport from 6.0.1 to 6.0.2 in /Library/Homebrew
2019-12-14 17:01:15 +00:00
Mike McQuaid
afb8fd1007
brew vendor-gems: commit updates.
2019-12-14 15:56:22 +00:00
dependabot-preview[bot]
f670f91e82
build: bump activesupport from 6.0.1 to 6.0.2 in /Library/Homebrew
...
Bumps [activesupport](https://github.com/rails/rails ) from 6.0.1 to 6.0.2.
- [Release notes](https://github.com/rails/rails/releases )
- [Changelog](https://github.com/rails/rails/blob/v6.0.2/activesupport/CHANGELOG.md )
- [Commits](https://github.com/rails/rails/compare/v6.0.1...v6.0.2 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-14 15:54:38 +00:00
Mike McQuaid
89158f5009
Merge pull request #6838 from Homebrew/dependabot/bundler/docs/activesupport-6.0.2
...
build: bump activesupport from 6.0.1 to 6.0.2 in /docs
2019-12-14 15:53:56 +00:00
EricFromCanada
c246207ba0
cmd: updates for command descriptions
2019-12-13 15:24:00 -05:00
EricFromCanada
f0270a585c
desc/audit: remove messages obviated by new arg parser
2019-12-13 15:23:38 -05:00
dependabot-preview[bot]
87e18954f9
build: bump activesupport from 6.0.1 to 6.0.2 in /docs
...
Bumps [activesupport](https://github.com/rails/rails ) from 6.0.1 to 6.0.2.
- [Release notes](https://github.com/rails/rails/releases )
- [Changelog](https://github.com/rails/rails/blob/v6.0.2/activesupport/CHANGELOG.md )
- [Commits](https://github.com/rails/rails/compare/v6.0.1...v6.0.2 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-13 18:29:09 +00:00
Mike McQuaid
aeefacc816
Merge pull request #6836 from Homebrew/dependabot/bundler/docs/html-proofer-3.15.0
...
build: bump html-proofer from 3.14.1 to 3.15.0 in /docs
2019-12-13 16:22:22 +00:00
dependabot-preview[bot]
da52731847
build: bump html-proofer from 3.14.1 to 3.15.0 in /docs
...
Bumps [html-proofer](https://github.com/gjtorikian/html-proofer ) from 3.14.1 to 3.15.0.
- [Release notes](https://github.com/gjtorikian/html-proofer/releases )
- [Commits](https://github.com/gjtorikian/html-proofer/compare/v3.14.1...v3.15.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-13 16:01:09 +00:00
Mike McQuaid
e78836fda9
Merge pull request #6832 from Homebrew/dependabot/bundler/Library/Homebrew/json-2.3.0
...
build: bump json from 2.2.0 to 2.3.0 in /Library/Homebrew
2019-12-11 17:12:02 +00:00
dependabot-preview[bot]
cc4b78214a
build: bump json from 2.2.0 to 2.3.0 in /Library/Homebrew
...
Bumps [json](https://github.com/flori/json ) from 2.2.0 to 2.3.0.
- [Release notes](https://github.com/flori/json/releases )
- [Changelog](https://github.com/flori/json/blob/master/CHANGES.md )
- [Commits](https://github.com/flori/json/commits )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-11 14:54:20 +00:00
Mike McQuaid
b1eb96dfdd
Merge pull request #6831 from MikeMcQuaid/xcode_clt_version
...
os/mac/xcode: bump Xcode/CLT versions (and cleanup)
2019-12-11 14:14:28 +00:00
Mike McQuaid
ebc764e878
os/mac/xcode: clarify latest_version comes from clang.
2019-12-11 13:50:21 +00:00
Mike McQuaid
2d5f6dd79f
os/mac/xcode: improve CLT clang version detection.
2019-12-11 13:49:56 +00:00
Mike McQuaid
8d3e7cf028
os/mac: remove CLT header package stuff.
...
We never care about it and it's not relevant anywhere except 10.14.
2019-12-11 13:49:13 +00:00
Mike McQuaid
dda80c6938
os/mac/xcode: bump Xcode/CLT versions.
2019-12-11 13:48:32 +00:00
Mike McQuaid
277a8b2220
Merge pull request #6433 from GauthamGoli/argv-cleanup-3
...
argv: move formulae to cli/args
2019-12-11 11:37:51 +00:00
Gautham Goli
2b95755afe
CLI::Args: Make processed_options read-only
2019-12-11 16:36:23 +05:30
Gautham Goli
28e62b52d1
cli_args: Remove cyclic dependency on ARGV
2019-12-11 16:36:23 +05:30
Gautham Goli
22e25dd593
argv: move formulae to cli/args
2019-12-11 16:36:23 +05:30
Mike McQuaid
bacb3d0e7e
Merge pull request #6830 from MikeMcQuaid/formula-runtime-dependencies-path
...
formula: handle missing runtime dependency formulae.
2019-12-10 17:16:36 +00:00