Mike McQuaid
a7503ec713
Revert "Enable RSpec/LeakyConstantDeclaration"
2023-01-26 09:47:20 +00:00
Mike McQuaid
a1680aebe3
Merge pull request #14419 from dduugg/enable-NoExpectationExample
...
Enable RSpec/NoExpectationExample
2023-01-26 09:35:58 +00:00
Carlo Cabrera
f576140ade
Remove Rubocop for ignore_missing_libraries
...
This is no longer needed.
2023-01-26 13:48:06 +08:00
Carlo Cabrera
4b318f738b
Remove tests for ignore_missing_libraries
...
The deprecation is causing these tests to fail.
2023-01-26 13:46:48 +08:00
Carlo Cabrera
131f5eba0f
formula: deprecate ignore_missing_libraries
...
We removed all uses of this method in Homebrew/core. See
Homebrew/homebrew-core#111297 .
2023-01-26 13:29:51 +08:00
Douglas Eichelberger
2b8b3a5cb6
Enable RSpec/NoExpectationExample
2023-01-25 14:37:39 -08:00
Mike McQuaid
e4c18be302
Merge pull request #14429 from dduugg/rm-rspec-wait
...
Refactor away rspec-wait
2023-01-25 19:21:16 +00:00
Douglas Eichelberger
f126f0d39b
Refactor away rspec/wait
2023-01-25 10:07:42 -08:00
Mike McQuaid
71fab93983
Merge pull request #14414 from Homebrew/dependabot/bundler/Library/Homebrew/concurrent-ruby-1.2.0
...
build(deps): bump concurrent-ruby from 1.1.10 to 1.2.0 in /Library/Homebrew
2023-01-25 17:04:42 +00:00
Mike McQuaid
5caf17d0a7
Merge pull request #14426 from Homebrew/shared_gcc_try
...
extend/ENV/shared: use `try`.
2023-01-25 16:48:42 +00:00
Mike McQuaid
8811a4f1bc
Merge pull request #14425 from Homebrew/codespaces_tweaks
...
Improve Codespaces behaviour
2023-01-25 16:40:30 +00:00
Mike McQuaid
612c27cd2d
extend/ENV/shared: use try
.
...
`version_suffix` exists (or doesn't) depending on the GCC formula being
available and not loaded from the API.
2023-01-25 16:07:23 +00:00
Mike McQuaid
d984ce06f2
Improve Codespaces behaviour
...
- ensure that homebrew/core is always tapped
- make RuboCop stop complaining about permissions
2023-01-25 16:05:02 +00:00
Mike McQuaid
b4510401bd
Merge pull request #14423 from MikeMcQuaid/cask_loader_api_gsubs
...
cask_loader: fixup artifacts/caveats from JSON API.
2023-01-25 15:41:56 +00:00
Mike McQuaid
ee4dc3c46e
Merge pull request #14422 from MikeMcQuaid/homebrew_install_from_api_improvements
...
HOMEBREW_INSTALL_FROM_API: various improvements.
2023-01-25 15:11:41 +00:00
Mike McQuaid
ab1fbb7fa9
cask_loader: fixup artifacts/caveats from JSON API.
...
These are mapped to generic versions in `cask/cask.rb` so we need to map
them back for them to be correct.
2023-01-25 15:07:44 +00:00
Mike McQuaid
46d727b475
HOMEBREW_INSTALL_FROM_API: various improvements.
...
- flip the messaging to refer to `HOMEBREW_NO_INSTALL_FROM_API` where relevant
- remove some duplicate checks
- better scope checks to just core tap formulae
2023-01-25 14:29:35 +00:00
Mike McQuaid
d5cf5f58b3
Merge pull request #14418 from dduugg/enable-LeakyConstantDeclaration
...
Enable RSpec/LeakyConstantDeclaration
2023-01-25 13:39:27 +00:00
Mike McQuaid
748c1b50fa
Merge pull request #14417 from dduugg/rubocop-rspec-cleanup
...
Enable RSpec cops without violations
2023-01-25 13:27:38 +00:00
hyuraku
f1eacb04f0
move check_binary_arches to extend/os
2023-01-25 22:26:49 +09:00
Mike McQuaid
daecb93d22
Merge pull request #14416 from lucaong/avoid-mutating-script-argument
...
Avoid mutating the script argument in place
2023-01-25 13:26:00 +00:00
Mike McQuaid
41765e6512
Merge pull request #14411 from hyuraku/move_default_prefix_to-extend-os
...
separate default_prefix to `extend/os` files
2023-01-25 13:16:12 +00:00
hyuraku
42960c3e74
repair if condition
2023-01-25 17:23:44 +09:00
Douglas Eichelberger
71e8135864
Enable RSpec/LeakyConstantDeclaration
2023-01-24 20:07:22 -08:00
Douglas Eichelberger
19a205b760
Enable RSpec cops without violations
2023-01-24 19:57:44 -08:00
Luca Ongaro
490679da45
Improve test
2023-01-25 00:19:37 +01:00
Luca Ongaro
1fc1c82aed
Fix code style and add tests
2023-01-25 00:08:15 +01:00
Luca Ongaro
f5765a73da
Avoid mutating the script argument in place
...
Mutating the argument in place, and in particular deleting the
`:executable` entry, leads to a bug when the same code path leading to
read_script_arguments is invoked twice, like in
https://github.com/Homebrew/homebrew-cask/pull/139749
This commit makes a shallow copy of the argument, so that it can be
safely mutated in the rest of the method.
2023-01-24 23:34:47 +01:00
BrewTestBot
d52f3cd820
Update RBI files for concurrent-ruby.
...
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml ) workflow.
2023-01-24 18:14:41 +00:00
BrewTestBot
4d822cb771
brew vendor-gems: commit updates.
2023-01-24 18:07:34 +00:00
dependabot[bot]
d09c079d58
build(deps): bump concurrent-ruby in /Library/Homebrew
...
Bumps [concurrent-ruby](https://github.com/ruby-concurrency/concurrent-ruby ) from 1.1.10 to 1.2.0.
- [Release notes](https://github.com/ruby-concurrency/concurrent-ruby/releases )
- [Changelog](https://github.com/ruby-concurrency/concurrent-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ruby-concurrency/concurrent-ruby/compare/v1.1.10...v1.2.0 )
---
updated-dependencies:
- dependency-name: concurrent-ruby
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-01-24 18:01:28 +00:00
Mike McQuaid
8f419180cf
Merge pull request #14406 from Homebrew/dependabot/bundler/Library/Homebrew/rubocop-1.44.0
...
build(deps): bump rubocop from 1.43.0 to 1.44.0 in /Library/Homebrew
2023-01-24 16:18:41 +00:00
BrewTestBot
6ee7b79b3d
Update RBI files for rubocop.
...
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml ) workflow.
2023-01-24 15:09:13 +00:00
BrewTestBot
d490ca2af1
brew vendor-gems: commit updates.
2023-01-24 15:00:42 +00:00
Mike McQuaid
aa7f7934ef
Merge pull request #14392 from Homebrew/dependabot/bundler/Library/Homebrew/regexp_parser-2.6.2
...
build(deps): bump regexp_parser from 2.6.1 to 2.6.2 in /Library/Homebrew
2023-01-24 15:00:28 +00:00
dependabot[bot]
1f632ae19e
build(deps): bump rubocop from 1.43.0 to 1.44.0 in /Library/Homebrew
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.43.0 to 1.44.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.43.0...v1.44.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-01-24 14:55:07 +00:00
BrewTestBot
4328df14f7
Update RBI files for regexp_parser.
...
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml ) workflow.
2023-01-24 14:28:11 +00:00
BrewTestBot
283f88985e
brew vendor-gems: commit updates.
2023-01-24 14:19:39 +00:00
dependabot[bot]
45178e77d8
build(deps): bump regexp_parser from 2.6.1 to 2.6.2 in /Library/Homebrew
...
Bumps [regexp_parser](https://github.com/ammar/regexp_parser ) from 2.6.1 to 2.6.2.
- [Release notes](https://github.com/ammar/regexp_parser/releases )
- [Changelog](https://github.com/ammar/regexp_parser/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ammar/regexp_parser/compare/v2.6.1...v2.6.2 )
---
updated-dependencies:
- dependency-name: regexp_parser
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-01-24 14:15:31 +00:00
Mike McQuaid
b6e8d65c40
Merge pull request #14413 from Bo98/vendor-gems-sdkroot
...
dev-cmd/vendor-gems: set SDKROOT for older macOS
2023-01-24 13:55:47 +00:00
Bo Anderson
142734aec9
dev-cmd/vendor-gems: set SDKROOT for older macOS
2023-01-24 13:24:31 +00:00
hyuraku
8289089482
add remove_const to cancel warning
2023-01-24 21:57:39 +09:00
hyuraku
97bba59e73
add require extend/os
2023-01-24 21:45:18 +09:00
hyuraku
e2f0075ee8
move default_prefix to extend/os
2023-01-24 21:02:24 +09:00
Mike McQuaid
d636f5bc0a
Merge pull request #14408 from dduugg/rspec-disable
...
Inline RSpec/InstanceVariable todos
2023-01-24 10:41:18 +00:00
Mike McQuaid
b8a9fe4d33
Merge pull request #14384 from MikeMcQuaid/homebrew_install_from_api_dev
...
brew.sh: test `HOMEBREW_INSTALL_FROM_API` on developers.
2023-01-24 10:18:43 +00:00
Mike McQuaid
daf5b276e2
Merge pull request #14407 from Rylan12/api-search
...
Fix `brew search` for `HOMEBREW_INSTALL_FROM_API`
2023-01-24 10:16:44 +00:00
Mike McQuaid
c3294f9356
test: add instance variable comments.
2023-01-24 10:15:25 +00:00
Mike McQuaid
518c961f4c
Merge pull request #14409 from carlocab/compiler-check
...
rubocops/lines: update hard-coded compiler check
2023-01-24 10:08:53 +00:00
Carlo Cabrera
86161e8c32
Fix test failures
2023-01-24 14:19:28 +08:00