58 Commits

Author SHA1 Message Date
Mike McQuaid
1bb44979ee
Disable and delete code for 3.5.0
The next planned release will be 3.5.0 so let's fix things up for there.
2022-05-30 14:59:14 +01:00
Bo Anderson
5ea092c464
formula_auditor: fix versioned alias audit
* Fix audit not being run at all due to always-false condition.
* Don't fail audit if versioned alias would clash with a versioned formula.
* Allow versioned aliases with the name of another alias.
2022-03-21 14:44:50 +00:00
Rylan Polster
12b45e85dd
Merge pull request #12854 from jsoref/audit-new-formula-should-not-define-revision
formula_auditor: new formulas should not define a revision
2022-02-11 11:09:46 -05:00
Carlo Cabrera
6c9c3c607c
formula_auditor: disallow external tap dependencies in core
Occasionally, we get PRs that attempt to add a dependency on a formula
in an external tap in homebrew/core (e.g. Homebrew/homebrew-core#94791).

We don't actually have an audit that disallows that. We should have one.
2022-02-10 06:57:46 +08:00
Josh Soref
37fd64b5a3 formula_auditor: new formulas should not define a revision
Logically new formulas should start at revision 0, but a
developer might use an existing formula as a template and
otherwise not realize they should remove this field.

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
2022-02-09 13:14:10 -05:00
Bo Anderson
8ab9465ad2
formula_auditor: fix error with formulae without taps 2021-12-13 23:05:45 +00:00
Alexander Bayandin
27a76295a4
Merge pull request #12279 from bayandin/synced-versions-formulae
formula_auditor: add audit for formulae with synced versions
2021-11-19 12:24:33 +00:00
Carlo Cabrera
f36bb3c6b0
formula_auditor: respect using: :homebrew_curl in resources too
A resource can do `using: :homebrew_curl`, but, without this change, the
audit will still use system `curl`. This fails quite predictably.

Needed for Homebrew/homebrew-core#88330.
2021-10-30 20:04:13 +08:00
Alexander Bayandin
ce2d946a7c
formula_auditor: add audit for formulae with synced versions 2021-10-25 09:40:37 +01:00
Rylan Polster
fa4bb7d74a
Refactor audit exception handling 2021-10-21 21:11:05 -04:00
Mike McQuaid
b622c36be6
Add, use uses_from_macos_names.
This strips e.g. `:build` tags.
2021-09-14 09:48:19 +01:00
Bo Anderson
8dd11e4e4c
Set uses_from_macos_elements in all cases 2021-09-14 04:06:40 +01:00
Mike McQuaid
c6aea445a3
formula_auditor: allow uses_from_macos for aliases.
This will enable https://github.com/Homebrew/homebrew-core/pull/84910 which will
enable https://github.com/Homebrew/brew/pull/12008.
2021-09-09 10:24:35 +01:00
Michka Popoff
bbfa52fcaa
formula_auditor: use brewed curl for homepage check when needed
If the download url is using brewed curl, use that too for the homepage check.
Ideally one would introduce the "using: :homebrew_curl" stanza for the homepage
line in the DSL, but it is easier to implicitely use the same logic
for homepages and url's and define the "using:" only once.
2021-08-20 10:14:50 +02:00
Michka Popoff
07df4a7e70
Use Homebrew curl for audit and fetch when specified in the formula
Introduce new :using for urls
2021-08-17 13:35:55 +02:00
Nanda H Krishna
f69f9be233
Add allowlist, make branch: mandatory 2021-08-12 12:43:22 +05:30
Mike McQuaid
bd627d86ca
Merge pull request #11709 from hyuraku/formula_auditor_repiar-audit_versioned_keg_only
formula_auditor:repiar audit_versioned_keg_only
2021-07-13 16:29:44 +01:00
hyuraku
57911f479a formula_auditor: repair audit_specs 2021-07-13 21:55:47 +09:00
hyuraku
2e80eb060e formula_auditor:repiar audit_versioned_keg_only 2021-07-13 21:20:49 +09:00
Mike McQuaid
0eb9b62c2d
formula_auditor: don't allow bottle :unneeded in core.
Now we have `all:` bottles and Bintray is going away for `mirror`s:
let's bottle everything in Homebrew/homebrew-core.
2021-06-29 12:42:30 +01:00
Alexander Bayandin
c95c2e3258
audit_conflicts: verbose variables name 2021-06-18 17:34:42 +01:00
Alexander Bayandin
43d67816ea
audit_conflicts: enable for third-party taps 2021-06-18 17:34:42 +01:00
Alexander Bayandin
1ddb6ef584
audit: do not allow aliases and renames in formula conflicts 2021-06-18 17:34:42 +01:00
Alexander Bayandin
4c14675021
audit: add more checks for conflics_with audit 2021-06-18 17:34:42 +01:00
Sam Ford
a1cf581118
ResourceAuditor: Allow only/except options 2021-06-16 10:30:52 -04:00
Nanda H Krishna
141edc8506
formula_auditor: add audit for elasticsearch and kibana
Prevent upgrading them to version 7.11 or newer, as they were
relicensed to an incompatible license.
2021-06-03 00:33:37 +05:30
Steve Peters
9b9d25d27f
audit: complain about uppercase formula names
Check for uppercase formula names in audit_formula_name method
of formula_auditor.
2021-05-27 17:55:28 -07:00
Kenneth Chew
af594739dc
audit: specify which URL has a content problem in problem message 2021-04-22 13:52:18 +01:00
Michka Popoff
3714ebd06d
formula auditor: skip uses_from_macos audit for linux-only formula 2021-04-08 23:09:08 +02:00
Shaun Jackman
d6c0bbc7f4 GHCR: Add constant OS::CI_OS_VERSION
Rename constant OS::GLIBC_CI_VERSION to OS::CI_GLIBC_VERSION.
2021-04-05 22:39:41 -07:00
Mike McQuaid
cdaeee03c4
GitHub Packages cleanup
- `download_strategy`: only request image index JSON for downloading
  the manifest for the tab
- use a shared `OS` constant for the version of `glibc` we use in CI
- fix `skoepeo` typo
- ensure that blank hash values are deleted (again) rather than just
  `nil` ones
- use a shared `Hardware::CPU` constant for oldest CPU we're
  supporting/using on Intel 64-bit
- re-add comment to `software_spec`
2021-04-05 14:58:17 +01:00
Rylan Polster
e593986763
audit: allow all minor versions in new gnome version scheme 2021-03-29 21:02:15 -04:00
Bo Anderson
8e98ce69f3
Stricter handling of CLI args 2021-03-18 16:41:57 +00:00
Bo Anderson
abb2b26a93
Add HOMEBREW_SIMULATE_MACOS_ON_LINUX 2021-03-05 12:21:45 +00:00
Bo Anderson
b3e78f31ea
Revert "dev-cmd/audit: don't do dependency checks on Linux."
This reverts commit 93362547c99d880e59d0e11f4127f01145ea5b1d.
2021-03-05 12:21:45 +00:00
Michka Popoff
6249b6b86a
audit: pin glibc version to 2.23 2021-02-25 17:44:04 +01:00
nandahkrishna
8e5451df2f
style: use parentheses for assignment in conditions 2021-02-12 18:33:37 +05:30
Sam Ford
6de5de788b
formula_auditor: skip archived audits if disabled 2021-02-03 10:12:36 -05:00
hyuraku
617ae740fe formula_auditor: repair audit_postgresql message 2021-02-01 21:26:24 +09:00
hyuraku
a1baff39d5 formula_auditor: delete adoptopenjdk condition 2021-01-28 22:57:21 +09:00
EricFromCanada
99ad3350ee use single quotes around stanza and parameter names 2021-01-26 16:19:47 -05:00
Caleb Xu
199c64d8c2 formula_auditor: prohibit patches in new core formulae only 2021-01-05 09:47:06 -05:00
Alexander Bayandin
2aaa83d398 formula_auditor: check for aliases only core formulae 2020-12-24 13:59:59 +00:00
Alexander Bayandin
1e68ce5a3f formula_auditor: do not allow depending on aliases 2020-12-23 23:29:45 +00:00
Mike McQuaid
9216d8abe6
rubocop-rails: make fixes. 2020-12-02 10:43:04 +00:00
Rylan Polster
685efd5a67 Remove hardcoded exceptions to the versioned_keg_only_allowlist 2020-11-27 11:55:53 -05:00
Rylan Polster
fe8ce9b725 Migrate GNOME_DEVEL_ALLOWLIST 2020-11-26 15:34:32 -05:00
Rylan Polster
de26310b32 Migrate UNSTABLE_DEVEL_ALLOWLIST 2020-11-26 15:26:12 -05:00
Rylan Polster
71beff367a Migrate UNSTABLE_ALLOWLIST 2020-11-26 15:18:06 -05:00
Rylan Polster
c4faac4b2f Migrate CERT_ERROR_ALLOWLIST 2020-11-26 15:01:24 -05:00