Kevin
1e4ae4ef7d
Merge pull request #14452 from dduugg/rm-undent-mp
...
remove String#undent 🐵 -patch
2023-01-30 21:28:51 -08:00
Rylan Polster
f38ac3943f
Fix tests
2023-01-28 02:39:23 -06:00
Rylan Polster
014b603b1f
Fix tests
2023-01-28 02:15:05 -06:00
Douglas Eichelberger
dc78e91edd
missed a few
2023-01-27 22:54:14 -08:00
Douglas Eichelberger
1dbeee826d
replace undent with squiggly heredoc
2023-01-27 22:52:44 -08:00
Douglas Eichelberger
dead4de3fc
Resolve Lint/EmptyBlock todos
2023-01-26 21:18:24 -08:00
Douglas Eichelberger
cd4ef92115
Use anonymous class constants instead
2023-01-26 09:42:57 -08:00
Douglas Eichelberger
259e4ae718
Enable RSpec/LeakyConstantDeclaration
2023-01-26 09:24:38 -08:00
Mike McQuaid
a7503ec713
Revert "Enable RSpec/LeakyConstantDeclaration"
2023-01-26 09:47:20 +00:00
Carlo Cabrera
4b318f738b
Remove tests for ignore_missing_libraries
...
The deprecation is causing these tests to fail.
2023-01-26 13:46:48 +08:00
Douglas Eichelberger
2b8b3a5cb6
Enable RSpec/NoExpectationExample
2023-01-25 14:37:39 -08:00
Mike McQuaid
e4c18be302
Merge pull request #14429 from dduugg/rm-rspec-wait
...
Refactor away rspec-wait
2023-01-25 19:21:16 +00:00
Douglas Eichelberger
f126f0d39b
Refactor away rspec/wait
2023-01-25 10:07:42 -08:00
Mike McQuaid
d5cf5f58b3
Merge pull request #14418 from dduugg/enable-LeakyConstantDeclaration
...
Enable RSpec/LeakyConstantDeclaration
2023-01-25 13:39:27 +00:00
Douglas Eichelberger
71e8135864
Enable RSpec/LeakyConstantDeclaration
2023-01-24 20:07:22 -08:00
Luca Ongaro
490679da45
Improve test
2023-01-25 00:19:37 +01:00
Luca Ongaro
1fc1c82aed
Fix code style and add tests
2023-01-25 00:08:15 +01:00
Mike McQuaid
d636f5bc0a
Merge pull request #14408 from dduugg/rspec-disable
...
Inline RSpec/InstanceVariable todos
2023-01-24 10:41:18 +00:00
Mike McQuaid
c3294f9356
test: add instance variable comments.
2023-01-24 10:15:25 +00:00
Carlo Cabrera
86161e8c32
Fix test failures
2023-01-24 14:19:28 +08:00
Douglas Eichelberger
8aadd14cea
Use block style instead
2023-01-23 11:56:55 -08:00
Douglas Eichelberger
49ca993074
git grep -l rubocop:todo test/ | xargs gsed -i 's|rubocop:todo|rubocop:disable|g'
2023-01-23 11:51:12 -08:00
Douglas Eichelberger
c45efc6eff
rubocop --autocorrect --disable-uncorrectable
2023-01-23 11:49:04 -08:00
Douglas Eichelberger
33905405e1
rm test/.rubocop_todo.yml
2023-01-23 11:45:36 -08:00
Mike McQuaid
f22f3eaa0b
Merge pull request #14400 from dduugg/rspec-cop-fix
...
Resolve RSpec/VerifiedDoubles todos
2023-01-23 13:36:37 +00:00
Douglas Eichelberger
f14cd8960a
Remove version_spec violation
2023-01-22 17:26:44 -08:00
Douglas Eichelberger
f365870a42
Resolve utils/analytics_spec violation
2023-01-22 17:26:44 -08:00
Douglas Eichelberger
0bfcf91a16
Resolve software_spec_spec violation
2023-01-22 17:26:44 -08:00
Douglas Eichelberger
b60eba1aa4
Resolve resource_spec violation
2023-01-22 17:26:44 -08:00
Douglas Eichelberger
a346725de2
Resolve linkage_cache_store_spec violation
2023-01-22 17:26:44 -08:00
Douglas Eichelberger
21b4251a67
Resolve language/python/virtualenv_spec violation
2023-01-22 17:26:44 -08:00
Douglas Eichelberger
06d037eadf
Resolve formula_spec violation
2023-01-22 17:26:44 -08:00
Douglas Eichelberger
b2ffa09ee9
Resolve formula_pin_spec violation
2023-01-22 17:26:44 -08:00
Douglas Eichelberger
eeac95b98a
Resolve exceptions_spec violation
2023-01-22 17:26:44 -08:00
Douglas Eichelberger
72069df68d
Resolve description_cache_store_spec violation
2023-01-22 17:26:44 -08:00
Douglas Eichelberger
94effcc64f
Resolve dependency_expansion_spec violation
2023-01-22 17:26:44 -08:00
Douglas Eichelberger
89c7117b30
Resolve dependable_spec violation
2023-01-22 17:26:44 -08:00
Douglas Eichelberger
ea832538f7
Resolve compiler_selector_spec violation
2023-01-22 17:26:44 -08:00
Douglas Eichelberger
d30ba99612
Resolve compiler_failure_spec violation
2023-01-22 17:26:44 -08:00
Douglas Eichelberger
bd62afde91
Resolve cmd/update-report_spec violation
2023-01-22 17:09:55 -08:00
Douglas Eichelberger
a83623e4cf
Resolve cask/pkg_spec violation
2023-01-22 17:09:55 -08:00
Douglas Eichelberger
585098a9b9
Resolve cask/installer_spec violation
2023-01-22 17:09:55 -08:00
Douglas Eichelberger
357807fbac
Resolve cask/artifact/pkg_spec violation
2023-01-22 17:09:55 -08:00
Douglas Eichelberger
d4c550bae7
Resolve cache_store_spec violation
2023-01-22 17:09:55 -08:00
Douglas Eichelberger
6c9d0d5424
remove RSpec/VerifiedDoubles todos
2023-01-22 17:02:29 -08:00
Alexander Regueiro
b2b7072fbe
Permit multiple uninstall stanzas in casks (temp)
...
Longer-term solution is described [here](https://github.com/Homebrew/brew/issues/14365#issuecomment-1398214354 ).
2023-01-21 18:45:58 +00:00
Mike McQuaid
d1be288418
some needs_network specs: temporarily disable.
...
These are absurdly flaky right now so let's disable them.
2023-01-20 17:41:07 +00:00
Mike McQuaid
4cf365f6c9
Merge pull request #14371 from dawidd6/os-specific-service
...
Allow defining service run command per platform
2023-01-20 15:21:47 +00:00
Mike McQuaid
200cf75233
Merge pull request #14389 from samford/add-options-to_s-method
...
Options: Add #to_s method
2023-01-20 15:21:18 +00:00
Sam Ford
dac82eb2c2
Options: Add #to_s method
...
`Options` objects are converted to a string in some circumstances but
this produces output like `#<Options:0x0000000102592c90>`.
For example, formulae.brew.sh contains analytics entries with
incomprehensible names like `adns #<Options:0x0000000102592c90>`.
This shortcoming is apparent when compared to other entries like
`adns --HEAD`.
The `Option` class has a `#to_s` method that returns the `flag`, so
this commit simply adds an `Options#to_s` method that calls `#to_s`
on each `Option` object in `@options` and joins them using spaces.
This should produce more useful output when an `Options` object is
converted to a string (e.g., `--first --second`).
2023-01-19 12:40:50 -05:00
