admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
10,755 Commits 15 Branches 471 Tags
Commit Graph

10755 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Rafael Kitover
74b18bfe12 put caveats in finish after post_install Homebrew/homebrew#42565 
When running brew -v install, long post_install output from the formula,
presumably from upstream, may hide the important instructions in the
caveats and confuse the user. For example, postgresql runs initdb which
prints its own instructions for running the database, making the caveats
scroll off screen.

Per xu-cheng's instructions in Homebrew/homebrew#42565 :

Remove the explicit call to caveats from the install, reinstall, and
upgrade commands, as well as the dependency installer code in
FormulaInstaller#install_dependency , and call caveats right before the
summary code in FormulaInstaller#finish .

Closes Homebrew/homebrew#42565.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-08-09 20:08:42 +08:00
Mike McQuaid
3518cda792 audit: allow assert !.*.include?. 
Came up on Homebrew/homebrew#34573.
 2015-08-09 09:33:33 +01:00
Dominyk Tiller
7a13f82297 echoping: to the boneyard 
Closes Homebrew/homebrew#42644.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
 2015-08-09 03:58:21 +01:00
Viet Hung Nguyen
9a40257a62 Troubleshooting.md: matching parenthesis 
Closes Homebrew/homebrew#42653.

Signed-off-by: Alex Dunn <dunn.alex@gmail.com>
 2015-08-08 08:26:40 -07:00
Xu Cheng
e60dc64828 only run post_install if it's defined 
Closes Homebrew/homebrew#42593.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-08-08 17:50:49 +08:00
Xu Cheng
8fecd4c198 help: remove obsoleted argument 2015-08-07 19:36:29 +08:00
Mike McQuaid
7a47102511 Troubleshooting: don't report the update issue plz 2015-08-07 12:20:37 +01:00
Xu Cheng
3c8a19777d update: handle more exceptions 
Closes Homebrew/homebrew#42558.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-08-07 13:42:31 +08:00
Dominyk Tiller
3369c55dc6 languages: support both luas 2015-08-06 18:46:56 +01:00
Alexis Hildebrandt
f78a63984b audit: add check for indefinite article 
at the beginning of desc.

Closes Homebrew/homebrew#42404.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
 2015-08-06 18:10:48 +01:00
Xu Cheng
09e0bcf1fc update: loading core files at the beginning 
This should help to prevent similar situation of Homebrew/homebrew#42553 happening in the
future.
 2015-08-06 22:51:36 +08:00
Xu Cheng
7c72b0c68a backport flat_map for Ruby 1.8 
Code is copied from
https://github.com/marcandre/backports/blob/master/lib/backports/1.9.2/enumerable/flat_map.rb
(MIT License by Marc-Andre Lafortune)

Closes Homebrew/homebrew#42543.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-08-06 22:33:46 +08:00
Xu Cheng
ae0e270727 favor flat_map over map...flatten 2015-08-06 22:33:46 +08:00
Xu Cheng
4e5227fd4e test_formula: add test_facotry_with_fully_qualified_name 
Closes Homebrew/homebrew#42550.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-08-06 22:28:44 +08:00
CNA-Bld
68a5b1fe46 add fully qualified name for core formulae 2015-08-06 22:28:44 +08:00
Xu Cheng
0c774cff50 hardware: temporary disable rubocop method rename rule 
Closes Homebrew/homebrew#42540.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-08-06 17:23:56 +08:00
Xu Cheng
8f20ea92b3 test_inreplace: temporary disable rubocop string replacement rule 2015-08-06 17:23:56 +08:00
Xu Cheng
b121e5fd7b more core file style updated by rubocop 2015-08-06 17:23:56 +08:00
Xu Cheng
3f8ce5f1a9 update rubocop to 0.33.0 2015-08-06 17:23:55 +08:00
Xu Cheng
2c3084a0a2 style: allow passing arbitrary file paths 2015-08-06 17:23:55 +08:00
Alexis Hildebrandt
e9180b39f5 audit: simplify command-line spelling check 
Closes Homebrew/homebrew#42403.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
 2015-08-05 20:19:40 +01:00
Ian Lancaster
65dbdccfc0 Formula-Cookbook: avoid non-with options 
Closes Homebrew/homebrew#42433.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
 2015-08-05 20:08:54 +01:00
Dominyk Tiller
150a9fe514 audit: flag plaintext mirrorservice 2015-08-05 19:45:24 +01:00
Baptiste Fontaine
1bb9c56e9c test-bot: run postinstall on dependencies 
Closes Homebrew/homebrew#36027.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
 2015-08-05 20:24:06 +02:00
Misty De Meo
176e55386c ARGV: don't downcase bottle filenames 
Fixes Homebrew/homebrew#42470.
 2015-08-05 09:51:37 -07:00
Dominyk Tiller
4f549da115 formula_support: add provided_pre_mavericks 
Closes Homebrew/homebrew#42460.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
 2015-08-04 21:26:36 +01:00
Dominyk Tiller
e1d736a0fa Formula-Cookbook: tweak conflicts_with 
Closes Homebrew/homebrew#42432.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
 2015-08-04 01:40:15 +01:00
Baptiste Fontaine
3a733cad09 shell completion of official taps added to 'brew tap' 
Closes Homebrew/homebrew#42421.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
 2015-08-03 23:37:00 +02:00
Alex Dunn
b2c0ff3985 official_taps: add emacs 
Closes Homebrew/homebrew#42418.
 2015-08-03 14:34:12 -07:00
Daniel Lee Harple
02298920d0 doc: pedantic word correction 
Closes Homebrew/homebrew#42413.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
 2015-08-03 17:09:19 +01:00
Xu Cheng
a5a1cc9865 fix ruby syntax warnings 
Closes Homebrew/homebrew#42409.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-08-03 21:27:40 +08:00
Xu Cheng
1af6ffa950 brew readall --syntax: skip vendor files 2015-08-03 21:27:40 +08:00
Mike McQuaid
ea5840ed61 keg_relocate: fix syntax error. 
Closes Homebrew/homebrew#42408.
 2015-08-03 14:25:38 +01:00
Xu Cheng
14f060621e command: fix break caused by style update 2015-08-03 20:51:16 +08:00
Xu Cheng
d62095710f More core files style updates 2015-08-03 20:38:20 +08:00
BrewTestBot
13d544e11e Core files style updates. 
Closes Homebrew/homebrew#42354.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-08-03 13:22:35 +01:00
Xu Cheng
3b68215be7 rubocop: remove conflicted rules 
Since trailing commas in method argument lists are a syntax error in
1.8, let's enforce the default rule of `TrailingComma`(i.e. `no_comma`)

Closes Homebrew/homebrew#42398.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-08-03 18:47:24 +08:00
Mike McQuaid
670ca78eaa Add Rubocop 1.8 tweaks. 2015-08-03 18:47:24 +08:00
Mike McQuaid
e4ef7f8cb7 Don't try to Rubocop vendored files. 2015-08-03 18:47:23 +08:00
Alex Dunn
b22d899d3a Add Alex Dunn as a maintainer. 
Closes Homebrew/homebrew#42347.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-08-02 13:19:55 +01:00
Xu Cheng
6eba862388 rubocop: update style rules 
Closes Homebrew/homebrew#42355.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-08-02 20:03:10 +08:00
Baptiste Fontaine
79678cb109 online audit: use GET instead of HEAD 
I also removed the `-L` flag which is already present in
`HOMEBREW_CURL_ARGS`.

Closes Homebrew/homebrew#42352.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
 2015-08-02 11:15:52 +02:00
Xu Cheng
b7732e80b4 tab: check mxcl/master synonym unconditionally 2015-08-02 16:34:45 +08:00
Xu Cheng
8f0249e9a1 handle mxcl/master synonym inside Tab#from_file_content 2015-08-02 16:12:14 +08:00
Alex Dunn
8faaba6665 check_emacs_lisp(): bail unless site-lisp exists 
Closes Homebrew/homebrew#42345.
 2015-08-01 15:52:54 -07:00
Alex Dunn
81eedecc5a Automatic caveats for emacs lisp files 
- The name of the subdirectory under site-lisp may not be exactly the
  same as the name of the package

- `(normal-top-level-add-subdirs-to-load-path)` adds every subdirectory
  of `default-directory` to the load-path, so users don't have to update
  their load-path for every package they install.

Closes Homebrew/homebrew#42309.
 2015-08-01 14:48:54 -07:00
Alex Dunn
607be5e711 formula_cellar_checks: check_site_lisp() 2015-08-01 14:48:54 -07:00
Mike McQuaid
ce5e75953a googlecl: move to homebrew/boneyard. 
Closes Homebrew/homebrew#42245.
 2015-08-01 15:17:43 +01:00
Dominique Orban
68a13b240f formula: define opt_pkgshare helper method. 
Closes Homebrew/homebrew#42023.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-08-01 15:12:46 +01:00
Xu Cheng
ac738ae2cd enumerate all formulae by files rather than names 
Before
```
$ time brew readall
brew readall  10.63s user 0.36s system 99% cpu 11.003 total
```

After
```
$ time brew readall
brew readall  5.62s user 0.24s system 99% cpu 5.859 total
```

Closes Homebrew/homebrew#42302.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-08-01 00:49:50 +08:00