16637 Commits

Author SHA1 Message Date
Markus Reiter
bcf05f1a48 Remove :cask from SystemCommand specs. 2018-07-22 21:11:47 +02:00
Markus Reiter
fd2a333b45 Use grep_v. 2018-07-22 21:11:47 +02:00
Markus Reiter
28384ba518 Rename Hbc::SystemCommand to SystemCommand. 2018-07-22 21:11:47 +02:00
Markus Reiter
4f495a967d Add verbose to extract_nestedly. 2018-07-22 20:30:28 +02:00
Markus Reiter
891be1ec64 Add verbose to FileUtils calls. 2018-07-22 20:30:28 +02:00
Markus Reiter
9bd2167257 Add quiet flags if not verbose. 2018-07-22 20:30:28 +02:00
Markus Reiter
8278e9e403 Move verbose from #initialize to #extract. 2018-07-22 20:30:28 +02:00
Mike McQuaid
c5f92bfb8b
Merge pull request #4529 from MikeMcQuaid/update-maintainer-checklist
docs/New-Maintainer-Checklist: various updates.
2018-07-22 19:28:25 +01:00
Markus Reiter
de66dad834
Merge pull request #4524 from reitermarkus/missing-super
Fix missing `super`.
2018-07-22 19:49:28 +02:00
Mike McQuaid
c1ffd17f7c docs/New-Maintainer-Checklist: various updates. 2018-07-22 18:39:25 +01:00
Mike McQuaid
3b5aabf90d
Merge pull request #4531 from claui/spec-increase-timeout
Increase spec timeout to 30 seconds
2018-07-22 16:30:11 +01:00
Markus Reiter
84e0027426
Merge pull request #4525 from reitermarkus/remove-criteria
Remove `Hbc::Container::Criteria`.
2018-07-22 16:58:42 +02:00
Claudia
8666d8fa18
Increase spec timeout to 30 seconds
I’ve noticed the deadlock test in `cask/system_command_spec.rb` appears to fail spuriously, e. g. in #4529.

Details:

https://travis-ci.org/Homebrew/brew/jobs/406827725#L297-L318

With the spec taking 2 seconds on average on my 2017 MBP, I feel it’s
entirely plausible for the aging test-bot hardware to get knocked by
the 15-second timeout.

Given that the spec will pass early anyway if it passes, I feel it’s
reasonable to bump the timeout to 30 seconds.
2018-07-22 16:27:16 +02:00
Markus Reiter
d0951bdc1d Remove Hbc::Container::Criteria. 2018-07-21 16:31:24 +02:00
Markus Reiter
17c2e2c00c Fix missing super. 2018-07-21 01:14:19 +02:00
Markus Reiter
7ad999f5f8
Merge pull request #4488 from reitermarkus/system-command
Refactor `Hbc::SystemCommand`.
2018-07-20 17:51:10 +02:00
Markus Reiter
2dbffa2907
Merge pull request #4523 from reitermarkus/jar-detection
Fix JAR detection.
2018-07-20 17:46:20 +02:00
Markus Reiter
97f693b41f
Merge pull request #4518 from commitay/rar
fix cask rar containers
2018-07-20 17:45:28 +02:00
Markus Reiter
979e6674cf Fix JAR detection. 2018-07-20 17:30:33 +02:00
Mike McQuaid
1d387f0b96
Merge pull request #4520 from MikeMcQuaid/force-bottle-prelease
Add HOMEBREW_FORCE_BOTTLE variable
2018-07-20 16:29:54 +01:00
Mike McQuaid
3e93d4c6cf Add HOMEBREW_FORCE_BOTTLE variable
This does the equivalent of always passing `--force-bottle`. This will
be enabled by default on Mojave to allow people to avoid building
everything from source until our porting and bottling is a bit further
along.
2018-07-20 14:28:14 +01:00
Mike McQuaid
333534d641
Merge pull request #4521 from MikeMcQuaid/ronn-no-output-man
man: improve messaging on no `ronn` output.
2018-07-20 14:21:19 +01:00
Mike McQuaid
b89e4c51ce man: improve messaging on no ronn output.
This can happen if your gems are messed up and it's a more helpful
error message than being unable to `gsub` on `nil`.
2018-07-20 09:47:28 +01:00
commitay
68760d7467 fix cask rar containers 2018-07-20 09:00:10 +10:00
Markus Reiter
97e549300c
Merge pull request #4515 from reitermarkus/extract-nestedly-basename
Add test for basename in `#extract_nestedly`.
2018-07-19 21:21:39 +02:00
Markus Reiter
ad7be58655 Use guard clause instead of ||. 2018-07-19 16:53:11 +02:00
Markus Reiter
fec884d8da Add tests for ErrorDuringExecution. 2018-07-19 16:53:11 +02:00
Markus Reiter
2712fcaa67 Use interleaved output for ErrorDuringExecution. 2018-07-19 16:53:11 +02:00
Markus Reiter
3ff9c5335d Canonicalize input in initialize. 2018-07-19 16:41:27 +02:00
Markus Reiter
01b2be755c Move odebug. 2018-07-19 16:41:27 +02:00
Markus Reiter
2452b27866 Refactor ErrorDuringExecution. 2018-07-19 16:41:27 +02:00
Markus Reiter
bb29150096 Refactor HashValidator. 2018-07-19 16:41:27 +02:00
Mike McQuaid
679eda3155
Merge pull request #4516 from reitermarkus/zsh-completion
Fix `zsh` completion.
2018-07-19 14:34:11 +01:00
Markus Reiter
0a7ab5c232 Fix zsh completion. 2018-07-19 13:42:40 +02:00
Markus Reiter
8dc32e5a15
Merge pull request #4513 from commitay/seven-zip
fix cask seven_zip containers
2018-07-19 13:33:29 +02:00
Markus Reiter
50855c98f0 Don't pass down basename in #extract_nested_tar. 2018-07-19 12:49:21 +02:00
Markus Reiter
c6fa3fe8b4 Add test for basename in #extract_nestedly. 2018-07-19 12:49:21 +02:00
commitay
43883a4108 fix cask seven_zip containers 2018-07-19 13:30:15 +10:00
JCount
00eca7112a
Merge pull request #4511 from reitermarkus/extract-nestedly-basename
Don't pass down basename when extracting nestedly.
2018-07-18 22:08:10 -04:00
Markus Reiter
dbcae5b499 Don't pass down basename when extracting nestedly. 2018-07-19 00:47:52 +02:00
Mike McQuaid
df45ffeac4
Merge pull request #4510 from Homebrew/dependabot/bundler/Library/Homebrew/test/parallel_tests-2.22.0
Bump parallel_tests from 2.21.3 to 2.22.0 in /Library/Homebrew/test
2018-07-18 18:26:13 +01:00
dependabot[bot]
c3ee091e40
Bump parallel_tests from 2.21.3 to 2.22.0 in /Library/Homebrew/test
Bumps [parallel_tests](https://github.com/grosser/parallel_tests) from 2.21.3 to 2.22.0.
- [Release notes](https://github.com/grosser/parallel_tests/releases)
- [Commits](https://github.com/grosser/parallel_tests/compare/v2.21.3...v2.22.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-07-18 16:40:34 +00:00
Mike McQuaid
41680cd239
Merge pull request #4508 from MikeMcQuaid/portable-ruby-remove-cache
ruby.sh: remove linkage cache on upgrade.
2018-07-18 14:58:44 +01:00
Mike McQuaid
f2d823445e ruby.sh: remove linkage cache on upgrade.
This may not be compatible between portable ruby versions and between
portable and system ruby versions.

Fixes #4485.
2018-07-18 14:09:43 +01:00
Markus Reiter
23be3cedda
Merge pull request #4507 from reitermarkus/unpack-symlink
Don't follow symlinks when unpacking a directory.
2018-07-18 13:29:07 +02:00
Markus Reiter
67c30b8372 Fix DirectoryUnpackStrategy following symlinks. 2018-07-18 13:05:34 +02:00
Markus Reiter
22ddec85b0 Add failing test. 2018-07-18 13:05:34 +02:00
ilovezfs
eb5175857c
Merge pull request #4506 from Homebrew/revert-4470-chmods-for-exec-scripts
Revert "Explicitly chmod exec script files"
2018-07-18 11:02:55 +01:00
ilovezfs
3e298bbbc8
Revert "Explicitly chmod exec script files" 2018-07-18 09:45:05 +00:00
Markus Reiter
f16bff5b95
Merge pull request #4500 from reitermarkus/load-path
Refactor `$LOAD_PATH`.
2018-07-18 00:22:17 +02:00