267 Commits

Author SHA1 Message Date
Mike McQuaid
80d75bc0d8
Homebrew/.rubocop: tweak rules.
Adjust the rules based on the current codebase. Remove various enable,
disables and default values that are unnecessary. Add more comments
explaining why. Make minor changes needed to enable a few more rules.
2018-09-02 20:15:09 +01:00
Mike McQuaid
bcb1ec5499
Improve Homebrew/brew line length.
Use 124 max line length everywhere. Also, reduce tap max line length to
189 as Homebrew/homebrew-core has that as a maximum now. In future
Homebrew/homebrew-core will also be reduced to 124 maximum line length.
2018-09-02 16:15:09 +01:00
L. E. Segovia
f7cafb50ad
Enable quarantining of Homebrew-Cask's downloads 2018-08-31 13:16:11 +00:00
Markus Reiter
55cde526a8 Deprecate brew cask cleanup. 2018-08-13 20:09:34 +02:00
Markus Reiter
921c6a33dd Refactor Cleanup. 2018-08-08 10:40:22 +02:00
Markus Reiter
9f370a3576
Merge pull request #4616 from reitermarkus/remove-cask-download-strategies
Remove cask download strategies.
2018-08-06 21:36:47 +02:00
Markus Reiter
290910d3c0 Remove cask download strategies. 2018-08-06 20:52:45 +02:00
Markus Reiter
e7bbb1f9b0 Remove unused brew cask _audit_modified_casks command. 2018-08-06 20:26:33 +02:00
Markus Reiter
7fb221ffe1 Remove unused brew cask _dump command. 2018-07-30 22:30:12 +02:00
Mike McQuaid
86df821b92
Merge pull request #4410 from alexbostock/cask-json
Cask json
2018-07-17 17:17:06 +01:00
alexbostock
49bae9b619 Rename to_hash method 2018-07-17 11:12:04 +01:00
commitay
eb1271304f cask upgrade: add message about auto_updates and :latest 2018-07-15 11:13:04 +10:00
commitay
6d1f99fa5f cask info: display auto_updates 2018-07-15 11:13:04 +10:00
Markus Reiter
7762ce32aa Use more descriptive heredoc names. 2018-07-11 18:15:30 +02:00
alexbostock
7e5addfb22 Add version number to cask JSON option
`$ brew cask info --json=v1 <formula>` instead of `$ brew cask info --json <formula>`
2018-07-04 15:03:31 +01:00
alexbostock
b548dbde97 Fix style 2018-07-02 10:46:41 +01:00
alexbostock
22b3102fbe Add version number to cask json option
Old:
$ brew cask info --json <formula>

New:
$ brew cask info --json-v1  <formula>
2018-07-02 10:32:59 +01:00
alexbostock
2d5ae645d9 Add basic JSON option to brew cask
$ brew cask info --json <cask>
2018-07-02 09:05:49 +01:00
Andrew Janke
e0a8a79921 Style fixes for Rubocop 0.57.1 2018-06-30 19:40:14 -04:00
commitay
41e27928c4
Merge pull request #4232 from commitay/cask-caveats
cask fetch and upgrade: print caveats
2018-06-21 11:51:29 +10:00
Markus Reiter
25542d7398
Merge pull request #4316 from reitermarkus/merge-search
Merge `brew cask search` into `brew search`.
2018-06-18 21:31:33 +02:00
Markus Reiter
8c620d8b97 Redirect brew cask search to brew search. 2018-06-18 16:23:35 +02:00
Luca Favatella
ece34dbe26 cask doctor: fix for non-standard installation location in ~
Symptom (relevant portions):
```
$ brew cask doctor
==> Homebrew-Cask Version
Homebrew-Cask 1.6.7-56-g9ebcef7
Homebrew/homebrew-cask (git revision fc24e; last commit 2018-06-09)
==> macOS
10.13.5
==> SIP
Enabled
...
==> Homebrew-Cask Install Location
<NONE>
==> Homebrew-Cask Staging Location
~/homebrew/Caskroom
...
==> Environment Variables
HOMEBREW_CASK_OPTS="--appdir=~/Applications"
LC_ALL="en_US.UTF-8"
PATH="/usr/bin:/bin:/usr/sbin:/sbin:~/homebrew/Library/Homebrew/shims/scm"
SHELL="/bin/bash"
Cask's Doctor Checkup: failed
 - The staging path ~/homebrew/Caskroom does not exist.
Error: There are some problems with your setup.
```

Analysis:

* The source code is
  [this](9ebcef785e/Library/Homebrew/cask/lib/hbc/cli/doctor.rb (L63-L66)).

* The issue is reproducible in `brew irb`:

```
$ ls -dl ~/homebrew/Caskroom
drwxrwxr-x  10 luca  admin  340  9 Jun 16:22 /Users/luca/homebrew/Caskroom
$ ( cd ~ && pwd; )
/Users/luca
$ ls -dl /Users/luca/homebrew/Caskroom
drwxrwxr-x  10 luca  admin  340  9 Jun 16:22 /Users/luca/homebrew/Caskroom
$ brew irb
==> Interactive Homebrew Shell
Example commands available with: brew irb --examples
irb(main):001:0> Pathname.new("~/homebrew/Caskroom").exist?
=> false
irb(main):002:0> Pathname.new("/Users/luca/homebrew/Caskroom").exist?
=> true
```
2018-06-14 23:58:03 +01:00
Luca Favatella
cac30f6186 cask doctor: delete unused render_* methods 2018-06-14 23:56:35 +01:00
commitay
7a48e04d07 internal_audit_modified_casks: remove appcast 2018-06-11 13:15:32 +10:00
commitay
0980de4cb0 _appcast_checkpoint: remove 2018-06-11 13:15:30 +10:00
Markus Reiter
1d27c5f79a Don't create Caskroom.path for tests. 2018-06-09 11:32:49 +02:00
Markus Reiter
767ebe6ab6 Fail brew cask upgrade early if Cask is not installed. 2018-06-09 11:27:44 +02:00
Markus Reiter
488149242b Remove Hbc.init. 2018-06-09 11:18:40 +02:00
Markus Reiter
b2f67c6d77 Remove the need for ensure_cache_exists. 2018-06-09 11:13:37 +02:00
Markus Reiter
12ab263784 Remove Hbc.default_tap. 2018-06-09 10:13:28 +02:00
Markus Reiter
3d423b0587 Add path method to Caskroom and Cache. 2018-06-09 09:52:48 +02:00
Markus Reiter
cb7f25ceb8 Refactor brew cask search. 2018-06-07 18:42:30 +02:00
Markus Reiter
cc93997fb7 Refactor search_taps. 2018-06-07 14:02:31 +02:00
Markus Reiter
dd8370a9fa Move shared search logic into Homebrew::Search module. 2018-06-07 13:50:10 +02:00
Markus Reiter
14b3b82fca Remove exact match from brew cask search. 2018-06-07 13:48:35 +02:00
Markus Reiter
e786bb08c9 Use search_taps in brew cask search. 2018-06-07 13:48:35 +02:00
commitay
a48e42e9dd cask fetch and upgrade: print caveats 2018-06-02 11:31:38 +10:00
Markus Reiter
de246cc528 Update Homebrew-Cask references. 2018-05-25 18:20:02 +02:00
Markus Reiter
c4222141ac Revert "Update Homebrew-Cask references."
This reverts commit 4475651b548afdcf15c4cf7a7cb57baca1885186.
2018-05-25 17:57:32 +02:00
Markus Reiter
4475651b54 Update Homebrew-Cask references. 2018-05-25 17:56:16 +02:00
Markus Reiter
b4de801a01 Support both Homebrew and caskroom for now. 2018-05-21 01:43:49 +02:00
commitay
f2feb326f9 cask upgrade: ensure cache exists 2018-05-18 08:18:39 +10:00
commitay
18cd7b7b4b zap: CaskNotInstalledError 2018-04-29 08:49:02 +10:00
Markus Reiter
19317760da Remove Hbc::Scopes. 2018-04-14 11:45:51 +02:00
Markus Reiter
8d0d5eb6d9 Remove QualifiedToken. 2018-04-14 11:44:19 +02:00
Markus Reiter
8c116f9507 Fix Cask search not showing remote matches. 2018-04-11 16:53:32 +02:00
commitay
9a25ea8ae0 cask doctor: add homebrew_cask_opts 2018-03-23 11:41:46 +10:00
commitay
8d458fa443 cask doctor: check_cached_downloads 2018-02-13 21:03:06 +10:00
Mike McQuaid
918f1b775b
Merge pull request #3631 from amyspark/doctor
Let cask doctor exit with 1
2018-02-12 08:54:47 +00:00