28250 Commits

Author SHA1 Message Date
Issy Long
10b1af8b29
formula_auditor: Appease RuboCop with another &. 2023-03-22 13:54:43 +00:00
Issy Long
21f38ca3af
formula_auditor: Correct safe navigation positioning
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2023-03-22 13:43:33 +00:00
Issy Long
13fe1bb4b4
formula_auditor: Better keg_only reason message
Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
2023-03-18 15:27:35 +00:00
Issy Long
bda88ce96e
formula_auditor: Having HOMEBREW_PREFIX in keg_only reasons is bad
- Fixes issue 14996.
- The API JSON is generated with a `/usr/local` Homebrew prefix, but
  frequently now users have `/opt/homebrew` as their prefix. Since
  formulae `keg_only` reasons are generated by the API, this can lead
  to the confusing messaging that follows:

```
socket_vmnet is keg-only, which means it was not symlinked into /opt/homebrew,
because /usr/local/bin is often writable by a non-admin user.
```

- With this change, that formula as it is now will fail `brew audit`,
  prompting to remove the prefix reference.

```
❯ HOMEBREW_NO_INSTALL_FROM_API=1 brew audit --strict socket_vmnet
socket_vmnet:
  * `keg_only` reason should not include `HOMEBREW_PREFIX` as it provides confusing output.
Error: 1 problem in 1 formula detected
```
2023-03-18 14:46:13 +00:00
Mike McQuaid
b3684e55a7
Merge pull request #14997 from ZhongRuoyu/ventura-system-settings
Update path to system settings on Ventura
2023-03-17 15:45:05 -04:00
Mike McQuaid
647d86f3e4
Merge pull request #14998 from stevenlele/locale
Fix locale parsing
2023-03-17 15:36:22 -04:00
Mike McQuaid
b8743d337b
Merge pull request #14991 from issyl0/cask-url-audit-pass-referrer
cask/audit: Pass a URL's `referer` through to cURL
2023-03-17 15:33:38 -04:00
stevenlele
c9e44a0395 Update test 2023-03-17 20:35:17 +08:00
stevenlele
ca22b67dd2 Fix locale parsing 2023-03-17 20:15:42 +08:00
Ruoyu Zhong
a0ba487a30
Fix brew tests since CI is running on Monterey
Signed-off-by: Ruoyu Zhong <zhongruoyu@outlook.com>
2023-03-17 19:53:15 +08:00
Ruoyu Zhong
e9ce4a5a4e
Update path to system settings on Ventura
"System Preferences" has been renamed to "System Settings" on Ventura.
Privacy and security settings have moved, too. This commit makes sure
these changes are reflected. (Some adjustments were already made in
#14092.)

Signed-off-by: Ruoyu Zhong <zhongruoyu@outlook.com>
2023-03-17 19:24:07 +08:00
Issy Long
0701ea42fa
cask/audit: Pass a URL's referer through to cURL
- Some casks have URL arguments like "referer" (spelled wrong, that's
  intentional in the HTTP spec).
- The audit for one such cask, `iThoughtsX`, was failing because the
  "referer" wasn't getting passed through to cURL so the access would
  404.

----

Before:

```
❯ brew audit --cask --online --appcast --signing 'ithoughtsx'
[...]
audit for ithoughtsx: failed
 - The binary URL https://cdn.toketaware.com?download=iThoughtsX.zip is not reachable (HTTP status code 404)
 - Version '9.2.0' differs from '9.3.0' retrieved by livecheck.
 - Version '9.2.0' differs from '9.3.0' retrieved by livecheck.
Error: 2 problems in 1 cask detected
```

After:

```
❯ brew audit --cask --online --appcast --signing 'ithoughtsx'
[...]
audit for ithoughtsx: failed
 - Version '9.2.0' differs from '9.3.0' retrieved by livecheck.
 - Version '9.2.0' differs from '9.3.0' retrieved by livecheck.
Error: 1 problem in 1 cask detected
```
2023-03-16 23:28:50 +00:00
Mike McQuaid
650f516c5b
Merge pull request #14992 from dduugg/enable-typing
Fix GitHub.last_commit and enable more typing
2023-03-16 17:12:48 -04:00
BrewTestBot
f2eb7d58b8
Update RBI files for rack.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
2023-03-16 19:13:12 +00:00
BrewTestBot
2681bebd4a
brew vendor-gems: commit updates. 2023-03-16 19:07:04 +00:00
dependabot[bot]
4b6d76faf8
build(deps): bump rack from 3.0.6.1 to 3.0.7 in /Library/Homebrew
Bumps [rack](https://github.com/rack/rack) from 3.0.6.1 to 3.0.7.
- [Release notes](https://github.com/rack/rack/releases)
- [Changelog](https://github.com/rack/rack/blob/main/CHANGELOG.md)
- [Commits](https://github.com/rack/rack/compare/v3.0.6.1...v3.0.7)

---
updated-dependencies:
- dependency-name: rack
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-03-16 19:02:48 +00:00
Mike McQuaid
d0c5202106
Merge pull request #14984 from alebcay/utils-gzip-not-private
utils/gzip: don't mark API as private
2023-03-16 10:23:08 -04:00
Caleb Xu
8d51f806c5
utils/gzip: don't mark API as private 2023-03-16 00:00:54 -04:00
Douglas Eichelberger
b8aa619f2f brew style --fix 2023-03-15 18:21:41 -07:00
Issy Long
1e64a658d4
Revert "Update GitHubPackages for new Tab implementation" 2023-03-15 23:12:37 +00:00
Douglas Eichelberger
96ae878808
Merge pull request #14983 from dduugg/gh-packages-compat
Update GitHubPackages for new Tab implementation
2023-03-15 15:15:27 -07:00
Mike McQuaid
ff33d34ae1
Merge pull request #14975 from issyl0/count-issues-handle-hidden-stats
dev-cmd/contributions: Don't fall over if a user's profile is private
2023-03-15 17:52:04 -04:00
Issy Long
a9e31274fc
dev-cmd/contributions: Output why we default to 0 reviews on a validation error 2023-03-15 21:31:41 +00:00
Douglas Eichelberger
827fc87cde Enable more typing 2023-03-15 14:29:15 -07:00
BrewTestBot
089f79eddb
sorbet: Update RBI files.
Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow.
2023-03-15 21:28:48 +00:00
Mike McQuaid
6fd54eba5f
Merge pull request #14985 from dduugg/no-compat
Remove compatibility layer
2023-03-15 13:48:00 -04:00
Mike McQuaid
b61bf2591b
cmd/{rb,nod}env-sync: add new commands.
Add these commands to ease use of Homebrew's bottles with `rbenv` and
`nodenv`.

I've had a lot of people request this over the years and it's worked
well for me for a long time.

I could see people extending these to support other languages or version
managers so perhaps we want a more generic name.

Co-authored-by: Rylan Polster <rslpolster@gmail.com>
2023-03-15 13:13:09 -04:00
Douglas Eichelberger
ea65b7264a Update GitHubPackages for new Tab implementation 2023-03-15 09:49:45 -07:00
Mike McQuaid
83aea49d8a
Merge pull request #14981 from dduugg/tab-no-ostruct
Remove OpenStruct use in Tab
2023-03-15 12:16:49 -04:00
Mike McQuaid
78e5bd53eb
Merge pull request #14980 from reitermarkus/spdx-test
Simplify SPDX test.
2023-03-15 12:15:08 -04:00
Mike McQuaid
65bfc6267e
Merge pull request #14978 from bevanjkay/bump-release-notes
bump-formula-pr: wrap release notes in <pre> tags
2023-03-15 12:13:09 -04:00
Markus Reiter
9d415e22da
Simplify SPDX test. 2023-03-15 14:30:47 +01:00
Markus Reiter
7591175f93
Fix env_config generator. 2023-03-15 14:28:47 +01:00
Issy Long
b6198cdd07
dev-cmd/contributions: Avoid the /users/#{user}/events API call
- This is wasteful when we can just catch the `ValidationFailedError`
  from the GitHub API from the search query.
2023-03-15 13:00:49 +00:00
Issy Long
0a804e1b38
dev-cmd/contributions: Use the correct variable name 🙄 2023-03-15 12:50:14 +00:00
Issy Long
03bd62ca0d
dev-cmd/contributions: Don't fall over if a user's profile is private
- It's possible to hide your contribution graph and not be searchable on
  GitHub. Let's make sure `brew contributions` doesn't fall over if the
  user's profile is private (determined by the `/events` user endpoint
  returning []).
2023-03-15 12:48:59 +00:00
Bevan Kay
69d03bf6ed
bump-formula-pr: wrap release notes in <pre> tags 2023-03-15 23:03:27 +11:00
Douglas Eichelberger
4d32699f61 Placate rubocop 2023-03-14 23:01:09 -07:00
Douglas Eichelberger
da3e28b026 Fix tests 2023-03-14 23:01:08 -07:00
Douglas Eichelberger
3018793f93 Remove OpenStruct use in Tab 2023-03-14 23:01:08 -07:00
Douglas Eichelberger
cc5b013cb9 Remove compatibility layer 2023-03-14 14:49:34 -07:00
Douglas Eichelberger
6238a0779d remove test 2023-03-14 11:46:38 -07:00
Douglas Eichelberger
a1748605ab Minor Kernel cleanup 2023-03-14 10:27:16 -07:00
Douglas Eichelberger
c178986235 Fix tests 2023-03-14 08:50:56 -07:00
Douglas Eichelberger
f4c9a96c70 Enable types in dev-cmd 2023-03-14 08:32:03 -07:00
Mike McQuaid
d993167fae
Merge pull request #14967 from bayandin/fix-undefined-e
debrew: fix undefined variable
2023-03-14 07:01:10 -04:00
Mike McQuaid
162d2bac33
Merge pull request #14965 from issyl0/rubocop-style-accessor-grouping
rubocop: Enable `Style/AccessorGrouping` and autofix offenses
2023-03-14 06:50:32 -04:00
Mike McQuaid
0dd41b5a57
Merge pull request #14955 from dduugg/enable-typing
Enable typing in a few more files
2023-03-14 06:49:00 -04:00
Alexander Bayandin
d907a591a9
debrew: fix undefined variable 2023-03-14 11:09:57 +01:00
Issy Long
cace5c429f
rubocop: Enable Style/AccessorGrouping and autofix offenses
- With RuboCop 1.48.1 this no longer reports offenses and applies bugged
  autocorrections for `attr`s with Sorbet `sig`s, so we can enable it.
2023-03-14 00:01:02 +00:00