13650 Commits

Author SHA1 Message Date
commitay
0ce583964e text_cop: update cargo build cop 2018-08-29 23:06:53 +10:00
Gautham Goli
32bc5535b6
style: Fix npe and add test for corrected offense results 2018-08-28 23:31:35 +05:30
Gautham Goli
b707d2a232
Merge pull request #4765 from GauthamGoli/style-results-npe-fix-2
audit: Use `fetch` with default value prevent NPE
2018-08-28 13:42:13 +05:30
Gautham Goli
5d2ca08a93
audit: Use fetch with default value prevent NPE 2018-08-28 13:16:44 +05:30
Markus Reiter
9f06b3df23 Don’t use CLI::Cleanup in Auditor. 2018-08-27 23:31:29 +02:00
Gautham Goli
23846d6ca8
audit: Add null check on style results 2018-08-27 19:50:11 +05:30
Mike McQuaid
ca6c75d229
Check version conflicts using linkage.
Instead of refusing to install software preemptively by assuming
multiple linkage to differing versions of the same library we now make
`brew linkage --test` verify that we don't have two versions of the
same library linked at the same time.

This will be considerably more permissive whilst checking the actual
problem that we're worried about.
2018-08-27 10:12:02 +01:00
Gautham Goli
3705956f53
Merge pull request #4753 from GauthamGoli/autocorrect-count
audit: Show RuboCop offense correction status and count in output
2018-08-26 23:55:17 +05:30
Gautham Goli
b82dbdcfa8
audit: Show RuboCop offense correction status in output when --fix is passed 2018-08-26 19:33:19 +05:30
Mike McQuaid
9bc17c8a82
Merge pull request #4563 from alebcay/extract
Add new extract dev command to retrieve old versions of formulae
2018-08-26 12:59:50 +01:00
Caleb Xu
b1120dd404 extract: check if DependencyCollector::Compat is defined before monkey-patch 2018-08-26 02:22:09 -04:00
Caleb Xu
ad0f9d603f extract: localize DependencyCollector monkey-patches too 2018-08-25 19:52:22 -04:00
Caleb Xu
bd352bcf35 extract: use localized monkey-patching
Instead of just blanketing over with monkey-patches like before,
set up monkey-patches as needed, and make sure to clean up after
we're done.
2018-08-25 14:52:30 -04:00
Caleb Xu
a8563afc9e extract: add progress message when searching Git history
For the impatient ones out there.
2018-08-25 13:40:57 -04:00
Caleb Xu
ff2ce2f093 extract: better success message
Fixes the empty rev string when copying file from HEAD; explicitly
set rev to HEAD in that case.
2018-08-25 13:35:08 -04:00
Caleb Xu
d4a2006f04 extract: add missing monkey-patch 2018-08-25 13:33:25 -04:00
Caleb Xu
be0cd21d0f extract: explicitly load cli_parser 2018-08-25 10:58:13 -04:00
Caleb Xu
0e080eba97 extract: simplify integration tests 2018-08-25 10:51:31 -04:00
Caleb Xu
1e4cd780c3 extract: fix style 2018-08-25 10:49:06 -04:00
Caleb Xu
9ab3ff4a41 extract: add spec/integration test 2018-08-24 11:42:11 -04:00
Caleb Xu
a232e3a791 extract: fix corner case
If the formula to be retrieved was just version-bumped in the most
recent commit (HEAD), we would've ended up grabbing the second-most
recent version.

Instead, if the file already exists in tree at the current commit,
just construct the formula from that to get the version (for naming
purposes) and copy the file outright to its new location.
2018-08-24 11:38:14 -04:00
Mike McQuaid
cc63c12247
Merge pull request #4570 from maxim-belkin/fix-linux-make-shim
Fix for Linux make shim
2018-08-24 14:24:32 +01:00
Mike McQuaid
9a84dbae71
shims/linux/make: match Linuxbrew shim. 2018-08-24 08:57:57 +01:00
Maxim Belkin
ae32922d0f
swap which and command -v 2018-08-23 20:48:12 +00:00
William Woodruff
6f7c9ae4f3
Merge pull request #4748 from woodruffw/export-homebrew-git
brew.sh: Export HOMEBREW_GIT
2018-08-23 14:37:21 -04:00
William Woodruff
d30557ace6
brew.sh: Export HOMEBREW_GIT
Should have been exported like HOMEBREW_CURL.
2018-08-23 11:50:42 -04:00
Mike McQuaid
35eb03de9f
Merge pull request #4742 from commitay/remove-undefined-bottle
audit: remove "`bottle` is not defined"
2018-08-23 16:36:05 +01:00
Maxim Belkin
4f166ce021
formula_cellar_checks: .dylib and .framework are macOS-specific 2018-08-22 21:25:00 -05:00
commitay
e0c3ea7474 audit: remove "bottle is not defined" 2018-08-23 11:06:35 +10:00
Steven Peters
26e1d17b4d dev-cmd/bottle: save local_filename to json 2018-08-22 01:30:18 -07:00
Caleb Xu
0552dcff62 extract: accept tap as a non-flagged argument 2018-08-21 10:17:23 -04:00
Caleb Xu
6018968f91 Further collapse monkeypatches 2018-08-21 10:17:23 -04:00
Caleb Xu
875885dda6 Add a starter file for spec 2018-08-21 10:17:23 -04:00
Caleb Xu
713aedb6ed Fix code review requests 2018-08-21 10:17:23 -04:00
Caleb Xu
260867627b Switch back to monkey-patching
Also gsub! some particular formula contents to work around older
formulae ("brewkit" isn't around anymore, and url is expected to
be a method, not an instance variable).
2018-08-21 10:17:23 -04:00
Caleb Xu
95abdf9662 Use refinements instead of general monkey-patching 2018-08-21 10:17:23 -04:00
Caleb Xu
ff8b5f8c5a extract: rework to search through old/deleted formulae
- Removed use of FormulaVersions - it's generally too brittle for our uses. We
  now interface directly with the Git repo via utils/git and monkeypatch the
  formula loading process where needed.

- Really old formulae (that specify fields as instance vars instead of methods)
  still need more work to be supported; they don't work here quite yet.

- Properly handles deleted/removed formulae from Homebrew/homebrew-core.
  Additional work is still needed to search through Homebrew/legacy-homebrew if
  this functionality is desired.
2018-08-21 10:17:23 -04:00
Caleb Xu
1003aa72c9 Additional fixups for extract command
- Rework command line options
- Make specifying a version optional
- Remove stdout option and require a tap to be specified
- Do not allow user to extract into homebrew/core
- Rework new class name generation to use existing Formulary tools
2018-08-21 10:17:23 -04:00
Caleb Xu
bd2ac70c0f Fix style issues in extract command 2018-08-21 10:17:23 -04:00
Caleb Xu
055460884b Fix up extract command
- Move from cmd to dev-cmd
- Add --stdout flag
- Add sanity checks for args/flags
- Minor rewording on error messages
2018-08-21 10:17:23 -04:00
Caleb Xu
2952a9bf74 Add new extract command to retrieve old versions of formulae 2018-08-21 10:17:23 -04:00
Markus Reiter
3e79e1b89e .tar.lz.tar.lzma 2018-08-21 15:46:24 +02:00
Markus Reiter
664bd9ac0f
Merge pull request #4728 from reitermarkus/languages
Ignore unparsable system languages.
2018-08-21 10:58:22 +02:00
Markus Reiter
556e76b037 Use cp instead of FileUtils.copy_entry. 2018-08-20 19:06:55 +02:00
Markus Reiter
48dcf19169 Ignore unparsable system languages. 2018-08-19 22:10:20 +02:00
Mike McQuaid
c9aa25e6d2
Merge pull request #4722 from kabel/remove-chdir-twice
Remove the chdir call that was already moved to the ancestor
2018-08-19 16:21:20 +01:00
commitay
84216f5aa8 conflicts_cop: remove node@ from whitelist 2018-08-19 17:35:23 +10:00
Mike McQuaid
b2bfa6247f
Merge pull request #4678 from sjackman/mdfind
OS::Mac.mdfind: No need to guard on OS.mac?
2018-08-18 12:06:05 +01:00
Mike McQuaid
b87f2f55c8
Merge pull request #4716 from woodruffw/curl-git-dev-paths
brew.sh: Allow developers to specify curl/git paths
2018-08-18 12:05:29 +01:00
Mike McQuaid
bab5b02293
Merge pull request #4620 from brianmorton/hbc_analytics
Add analytics to cask installs
2018-08-18 09:33:36 +01:00