31307 Commits

Author SHA1 Message Date
Michael Cho
3ddc196f11
cleanup: remove broken symlink for uninstalled migrated Casks
Signed-off-by: Michael Cho <michael@michaelcho.dev>
2024-03-21 17:52:48 -04:00
Sam Ford
b3ab410215
rubocops/livecheck: Rework LivecheckUrlProvided
The existing `LivecheckUrlProvided` RuboCop requires a `url` for all
`livecheck` blocks except those using `skip`, `formula`, or `cask`,
as those only appear in a `livecheck` block with no other DSL methods.

We now have a `throttle` method that can be used alongside other DSL
methods (e.g., `url`, `regex`, `strategy`) or by itself. `brew style`
currently fails when `throttle` is used by itself, so this reworks
the conditions to allow this usage.
2024-03-21 15:53:25 -04:00
Michael Cho
43e2e28869
dev-cmd/bump-formula-pr: clean up unused code
Signed-off-by: Michael Cho <michael@michaelcho.dev>
2024-03-21 10:11:50 -04:00
Sam Ford
0f063921c5
livecheck: Update throttle rate parameter type
Co-authored-by: Markus Reiter <me@reitermark.us>
2024-03-21 10:11:50 -04:00
Sam Ford
7681621cd4
livecheck: Reorder throttle 2024-03-21 10:11:50 -04:00
Sam Ford
25d07c3838
livecheck: Add throttle info to debug, JSON output 2024-03-21 10:11:50 -04:00
Michael Cho
bfec6eecac
livecheck: support throttle DSL
Signed-off-by: Michael Cho <michael@michaelcho.dev>
2024-03-21 10:11:49 -04:00
Mike McQuaid
a2378f29d9
Merge pull request #16929 from Homebrew/update-test-for-custom-service-require-root
rubocops/service_spec: update test for name and require root
2024-03-21 12:24:07 +00:00
Razvan Azamfirei
4129200b96
livecheck: add --extract-plist switch 2024-03-21 11:50:27 +00:00
apainintheneck
769b4f89c7 rubocops/service_spec: update test to cover custom name that requires root
This was added in recently and this just updates the test to reflect the
expected behavior for the cop.
2024-03-20 21:05:14 -07:00
Patrick Linnane
df84883f12
formula_auditor: generalize relicensed formula audit
Signed-off-by: Patrick Linnane <patrick@linnane.io>
2024-03-20 20:59:35 -07:00
Patrick Linnane
216c79cebd
formula_auditor: handle redis relicense
Signed-off-by: Patrick Linnane <patrick@linnane.io>
2024-03-20 20:49:06 -07:00
Kevin
7b2bfee363
Merge pull request #16903 from apainintheneck/prevent-unexpected-network-calls-in-tests
Prevent unexpected network calls in tests
2024-03-20 20:40:26 -07:00
BrewTestBot
8ce9ffe660
sorbet: Update RBI files.
Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow.
2024-03-21 00:20:03 +00:00
Douglas Eichelberger
b48f85f991 Fix nil repositories in dev-cmd bump 2024-03-20 13:40:35 -07:00
Douglas Eichelberger
db9c5a5da1 Fix linux test 2024-03-20 10:36:19 -07:00
Douglas Eichelberger
bf9ebccecd Handle dashed commands 2024-03-20 10:36:19 -07:00
Douglas Eichelberger
6b19bc5535 Style cleanup 2024-03-20 10:36:19 -07:00
Douglas Eichelberger
0373e0dc29 Port Homebrew::DevCmd::Contributions 2024-03-20 10:36:19 -07:00
Douglas Eichelberger
777ee12258 Port Homebrew::DevCmd::Command 2024-03-20 10:36:19 -07:00
Douglas Eichelberger
55a0991902 Port Homebrew::DevCmd::Cat 2024-03-20 10:36:19 -07:00
Douglas Eichelberger
df42e9cfb3 Port Homebrew::DevCmd::Bump 2024-03-20 10:36:10 -07:00
Douglas Eichelberger
c70dc040c6 Port Homebrew::DevCmd::BumpUnversionedCask 2024-03-20 10:25:18 -07:00
Douglas Eichelberger
1097496a06 Port Homebrew::DevCmd::BumpRevision 2024-03-20 10:25:18 -07:00
Douglas Eichelberger
d873881c47 Port Homebrew::DevCmd::BumpFormulaPr 2024-03-20 10:25:17 -07:00
Douglas Eichelberger
ebc458a7fe Port Homebrew::DevCmd::BumpCaskPr 2024-03-20 10:16:17 -07:00
Douglas Eichelberger
ee0c967ce0 Port Homebrew::DevCmd::Bottle 2024-03-20 10:16:17 -07:00
Douglas Eichelberger
0f2efd3939 Port Homebrew::DevCmd::Audit 2024-03-20 10:16:17 -07:00
Douglas Eichelberger
cae62e0175 Update Command API 2024-03-20 10:16:17 -07:00
Mike McQuaid
91d670c3fa
Merge pull request #16914 from Homebrew/service_require_root_no_run
rubocops/service: allow require_root to be used without run.
2024-03-20 08:42:34 +00:00
Mike McQuaid
f99c9c7a7b
Merge pull request #16915 from Homebrew/bump_no_tap
dev-cmd/bump: handle no formula tap case.
2024-03-20 08:27:49 +00:00
apainintheneck
74aea8e92d spec_helper: add :no_api test scope
This sets the HOMEBREW_NO_INSTALL_FROM_API environment variable
to prevent the selected tests from using the API. We will need
this as we transition to having the API be enabled by default
when running the tests but it's also nice as a sanity check
with the :needs_utils_curl scope in a few places.
2024-03-19 22:18:02 -07:00
Eric Knibbe
afbf6a1e2c
bump-formula-pr: fix type of detected version
Fixes #16917.
2024-03-19 22:44:05 -04:00
Bo Anderson
326bc3f889
Fix cask source checksum handling 2024-03-19 21:21:37 +00:00
Michael Cho
d04c5ad4f8
test/utils/github_spec: filter further to fix test failure
Signed-off-by: Michael Cho <michael@michaelcho.dev>
2024-03-19 17:01:04 -04:00
Mike McQuaid
d3ea535a9a
dev-cmd/bump: handle no formula tap case.
Fixes https://github.com/Homebrew/brew/issues/16913
2024-03-19 08:52:28 +00:00
Mike McQuaid
795642ea97
rubocops/service: allow require_root to be used without run.
Fixes https://github.com/Homebrew/brew/issues/16908
2024-03-19 08:46:47 +00:00
Patrick Linnane
e3797d39bd
Merge pull request #16912 from Homebrew/dependabot/bundler/Library/Homebrew/sorbet-runtime-and-sorbet-static-and-runtime-0.5.11295 2024-03-18 23:32:28 -07:00
BrewTestBot
9ad60e232d
brew vendor-gems: commit updates. 2024-03-19 06:04:28 +00:00
BrewTestBot
cf4527aa9c
brew vendor-gems: commit updates. 2024-03-19 06:03:42 +00:00
dependabot[bot]
05d2934e24
build(deps): bump sorbet-runtime and sorbet-static-and-runtime
Bumps [sorbet-runtime](https://github.com/sorbet/sorbet) and [sorbet-static-and-runtime](https://github.com/sorbet/sorbet). These dependencies needed to be updated together.

Updates `sorbet-runtime` from 0.5.11294 to 0.5.11295
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

Updates `sorbet-static-and-runtime` from 0.5.11294 to 0.5.11295
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

---
updated-dependencies:
- dependency-name: sorbet-runtime
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: sorbet-static-and-runtime
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-03-19 06:03:31 +00:00
dependabot[bot]
fb27ab6e17
build(deps-dev): bump rubocop-sorbet in /Library/Homebrew
Bumps [rubocop-sorbet](https://github.com/shopify/rubocop-sorbet) from 0.7.8 to 0.8.0.
- [Release notes](https://github.com/shopify/rubocop-sorbet/releases)
- [Commits](https://github.com/shopify/rubocop-sorbet/compare/v0.7.8...v0.8.0)

---
updated-dependencies:
- dependency-name: rubocop-sorbet
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-03-19 06:02:32 +00:00
apainintheneck
ad35db4b24 tests: fix tests that make unexpected network calls
These were found with the Utils::Curl check and just turning
off the network on my computer and running the entire test suite.
2024-03-18 20:57:35 -07:00
apainintheneck
b66097fa3d spec_helper: add check for unexpected network calls
Any test that is not tagged as :needs_network and that makes
a call to an unapproved method in the `Utils::Curl` module
will raise an error unless that method gets mocked somehow.

tests: add exceptions for tests that use curl to download local files

These are acceptable ways to use curl in local, non-network tests.
For those edge cases we allow you to bypass the check with :needs_utils_curl.
2024-03-18 20:57:23 -07:00
Douglas Eichelberger
0c4c4a87a2 Fix flaky Tapioca::Compilers::Args test 2024-03-18 09:24:40 -07:00
Douglas Eichelberger
2cc3ce9bb4
Merge pull request #16815 from dduugg/abstract-command
Provide interface and individual namespaces for brew CLI commands
2024-03-18 08:11:52 -07:00
Bo Anderson
6cb0fd06c4
Merge pull request #16894 from Homebrew/cask-fix-app-remove
cask/artifact/moved: fix permission handling when removing directories
2024-03-18 14:42:29 +00:00
Mike McQuaid
fbc2b7da62
Merge pull request #16904 from cho-m/bump-formula-pr-partial-versions
dev-cmd/bump-formula-pr: replace partial version in URL
2024-03-18 12:51:20 +00:00
Mike McQuaid
24dede9085
Merge pull request #16907 from Homebrew/rm-rspec-its
Remove and refactor rspec-its use
2024-03-18 12:51:06 +00:00
Mike McQuaid
af8b105388
Merge pull request #16906 from dduugg/yard-rbi
Include .rbi shims in yard docs
2024-03-18 12:50:58 +00:00