Jack Nagel
c05275e362
Update comment
2013-07-22 21:49:14 -05:00
Jack Nagel
93af660c7f
Handle optional build-time deps correctly
2013-07-22 21:36:11 -05:00
Jack Nagel
fcfc53df33
Check deps of satisfied deps
2013-07-22 21:36:11 -05:00
Jack Nagel
1fb4cd501b
Pathname#write: don't check ARGV.force?
...
Closes Homebrew/homebrew#21390 .
2013-07-22 21:26:42 -05:00
Phil Smith
9942bcc21e
typo
...
Closes Homebrew/homebrew#21385 .
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
2013-07-22 11:24:40 -07:00
Jack Nagel
6090b9b2bf
Silence warnings
2013-07-22 11:41:47 -05:00
Jack Nagel
e33cdb2f8b
Fix python dependency hash equality
...
eql? should not depend on the hash value as hash values of uneql objects
can collide, but eql values may only collide for objects that are
actually eql.
Further, python dependencies are uniquely identified by the combination
of the name and imports attributes, so there is no reason to involved
the expensive binary computation for simple equality checks.
Fixes Homebrew/homebrew#20840 .
2013-07-22 11:41:46 -05:00
Jack Nagel
b0138b9c9b
Remove redundant reader method
2013-07-22 11:41:46 -05:00
Jack Nagel
9b30fc4afa
Map pkginfo versions to actual XQuartz versions
2013-07-22 11:25:12 -05:00
Jack Nagel
34623b4ef1
Fall back on pkgutil when mdls cannot determine XQuartz version
2013-07-22 11:25:11 -05:00
Jack Nagel
d355227036
Separate version detection from accessor
2013-07-22 11:25:11 -05:00
Jack Nagel
1a54e6a449
Extract version_from_pkgutil
2013-07-22 11:25:11 -05:00
Jack Nagel
c325520316
Extract version_from_mdls
2013-07-22 11:25:11 -05:00
Jack Nagel
0b5551ee5b
Extract guess_system_version
2013-07-22 11:25:10 -05:00
Jack Nagel
df0d4aa853
Extract bundle_path from XQuartz.version
2013-07-22 11:25:10 -05:00
Jack Nagel
d6ed7fea4a
Cache pkgutil results at the source
2013-07-21 20:09:55 -05:00
Jack Nagel
a1e7d7177f
Eliminate nested conditional
2013-07-21 16:41:51 -05:00
Jack Nagel
9f2f5c81e9
Extract bundle_path method from Xcode#prefix
2013-07-21 16:41:51 -05:00
Jack Nagel
3807bd220a
Existence of directory is implied by existence of executables
2013-07-21 16:41:51 -05:00
Jack Nagel
4adf8f047a
Pull another unwieldy condition into a method
2013-07-21 16:41:50 -05:00
Jack Nagel
d9b9b77fa6
Update comment about CLT
...
This was worded in a confusing way, and made an assumption about future
OS X versions that we don't know to be true.
Also, it's probably wrong to state that the CLT location is dependent on
the OS X version; surely there will be a newer CLT for 10.8 that gets
installed in the same location as on 10.9. But we don't know any better
yet.
2013-07-21 16:41:50 -05:00
Jack Nagel
aa2554640d
Split up unreadable conditional
2013-07-21 16:41:50 -05:00
Jack Nagel
13df53166a
These should be integers
2013-07-21 07:56:30 -05:00
Jack Nagel
5acaa3374b
Remove unnecessary use of globals in compiler version methods
2013-07-20 22:40:23 -05:00
Jack Nagel
e23a3492f4
Don't report llvm-gcc if it's actually clang
2013-07-20 22:40:22 -05:00
Jack Nagel
8e0158b4d7
Add String#end_with?
...
I'm tired of not remembering if start_with?/end_with? are portable, so
just add them both if they're not defined.
2013-07-19 22:32:57 -05:00
Jack Nagel
b1e5f5ee81
Fix String#start_with? implementation
...
It is supposed to accept a variable number of prefixes, and also to
check if they are convertible to strings. This matches behavior
documented in RubySpec.
2013-07-19 22:31:07 -05:00
Misty De Meo
988316a16d
Enable superenv on Snow Leopard
...
This has been tested with several dozen formulae without any
superenv-related issues.
2013-07-19 14:13:11 -07:00
Samuel John
3fd7da0d80
SUPPORTERS.md fixed some missing http://
...
some links like example.com were not clickable
in some markdown viewers.
2013-07-19 13:38:01 +02:00
Adam Coffman
753adbb0ce
upgrade: put exit statements in both conditional branches
...
This check was only occurring in one branch of the conditional.
As a result, if you ran `brew upgrade` with no args and there were no packages to upgrade,
the nonsensical message
"==> Upgrading 0 outdated package, with result:"
would be printed.
Closes Homebrew/homebrew#21316 .
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2013-07-18 15:35:17 -05:00
Mike McQuaid
e33d3e1e5c
brew-test-bot: only install bottle if created OK.
2013-07-18 09:56:55 -07:00
Mike McQuaid
1a4bea3a55
brew-test-bot: only force fetch with --cleanup.
2013-07-18 09:56:55 -07:00
Mike McQuaid
f3821364a7
Warn more about failing bottle version detection.
...
This is needed for local bottle installation and also possible when
detecting bottle versions from URLs.
2013-07-18 09:56:55 -07:00
Mike McQuaid
4f2725cde3
Move getting formula names from bottles to method.
2013-07-18 09:56:55 -07:00
Mike McQuaid
e3a7260c1a
Formula: temporarily set PYTHONPATH.
...
Needs a less hacky fix but at least this will stop failing tests.
2013-07-18 09:56:55 -07:00
Mike McQuaid
810005156e
brew-test-bot: add devel/HEAD install options.
2013-07-18 09:56:54 -07:00
Mike McQuaid
f526bd5017
check_PATH: return early if (s)bin doesn't exist.
2013-07-17 09:36:44 -07:00
Jack Nagel
16b69317fe
Remove stray quotation mark
2013-07-17 11:27:07 -05:00
Jack Nagel
1bb7dfcafd
Escape interpolation examples
2013-07-17 11:22:00 -05:00
Adam Vandenberg
ebcf8be789
audit: skip an audit for mongodb
2013-07-17 06:58:11 -07:00
Adam Vandenberg
456621bb54
audit: ARGV.find is a warning, .value is allowed
2013-07-17 06:58:10 -07:00
Adam Vandenberg
d8d6b254f7
add ARGV.value
2013-07-17 06:58:10 -07:00
Samuel John
702b5e5ba2
doctor: Using Xcode-only is no longer experimental
...
In 10.9 we'll probably have to use that code path
anyways and by now we have adapted all formulae
to be able to build on Xcode-only.
2013-07-17 15:18:00 +02:00
Samuel John
1721cd9c08
Typo in comments
2013-07-17 09:52:30 +02:00
Jack Nagel
d9790309a6
Fix SYMROOT audit
2013-07-16 23:15:22 -05:00
Adam Vandenberg
f432a59fd0
add full lib path to audit
2013-07-16 20:50:45 -07:00
Jack Nagel
86cf6f0329
More linewise audits
2013-07-16 21:39:46 -05:00
Jack Nagel
b4bb0bf1c0
Audit text linewise
2013-07-16 21:25:02 -05:00
Jack Nagel
a632994403
Audit conditional deps that can be made declarative
2013-07-16 21:24:54 -05:00
Jack Nagel
51023ef15b
Fix some false-positive build-time dep audits
2013-07-16 15:49:11 -05:00
