Markus Reiter
2c9dc62d35
Merge pull request #4534 from reitermarkus/remove-gpg-container
...
Remove `Hbc::Container::Gpg`.
2018-07-23 20:59:11 +02:00
Mike McQuaid
ea97da9879
tab: correctly handle options request.
...
Because a `Tab` is an `OpenStruct` the existing calls to
`any_args_or_options?` would always return `false`. This means that
`Formula#declared_runtime_dependencies` would never call
`Tab#without?` to check whether a dependency has been brought in by an
option.
Fixes #4407
2018-07-23 19:58:39 +01:00
Mike McQuaid
994593505e
Merge pull request #4538 from MikeMcQuaid/audit-new-formula-issue-comment-exception-warning
...
audit: output new formula issue comment failure message.
2018-07-23 19:53:59 +01:00
Mike McQuaid
0fe1f01e41
audit: output new formula issue comment failure message.
...
This should help debug when this fails to be created.
2018-07-23 19:33:59 +01:00
Markus Reiter
b7eb7e48f0
Remove Hbc::Container::Gpg.
2018-07-23 19:35:01 +02:00
Markus Reiter
d6a245c051
Merge pull request #4536 from reitermarkus/container-system-command
...
Add `system_command` helpers.
2018-07-23 18:46:56 +02:00
Mike McQuaid
b993c7745e
Merge pull request #4537 from MikeMcQuaid/bottle-merge
...
bottle: add --json and --merge docs.
2018-07-23 15:51:41 +01:00
Mike McQuaid
44eeb59774
bottle: add --json and --merge docs.
...
Fixes #4519 .
2018-07-23 14:51:47 +01:00
Markus Reiter
1ccd1c0017
Don't use CaskError in Hbc::Container::Dmg.
2018-07-23 03:04:11 +02:00
Markus Reiter
e5e8033145
Add system_command helpers.
2018-07-22 23:24:18 +02:00
Markus Reiter
db299035ac
Merge pull request #4517 from reitermarkus/rename-system-command
...
Rename `Hbc::SystemCommand` to `SystemCommand`.
2018-07-22 22:24:00 +02:00
Markus Reiter
45f6cc5bd0
Merge pull request #4532 from reitermarkus/directory-permissions
...
Fix directory permissions when unpacking.
2018-07-22 22:23:45 +02:00
Markus Reiter
4f3df014cf
Merge pull request #4535 from reitermarkus/searchable-nil
...
Fix `Searchable` when collection contains `nil`.
2018-07-22 22:14:16 +02:00
Markus Reiter
c29ab2d707
Fix DirectoryUnpackStrategy permissions.
2018-07-22 22:03:28 +02:00
Markus Reiter
b675024ce0
Add failing test for DirectoryUnpackStrategy.
2018-07-22 22:02:09 +02:00
Markus Reiter
8f462ddb5d
Fix Searchable when collection contains nil.
2018-07-22 21:51:53 +02:00
Markus Reiter
a6dfe08c3c
Merge pull request #4526 from reitermarkus/extract-verbose
...
Move `verbose` from `#initialize` to `#extract`.
2018-07-22 21:29:04 +02:00
Markus Reiter
bcf05f1a48
Remove :cask from SystemCommand specs.
2018-07-22 21:11:47 +02:00
Markus Reiter
fd2a333b45
Use grep_v.
2018-07-22 21:11:47 +02:00
Markus Reiter
28384ba518
Rename Hbc::SystemCommand to SystemCommand.
2018-07-22 21:11:47 +02:00
Markus Reiter
4f495a967d
Add verbose to extract_nestedly.
2018-07-22 20:30:28 +02:00
Markus Reiter
891be1ec64
Add verbose to FileUtils calls.
2018-07-22 20:30:28 +02:00
Markus Reiter
9bd2167257
Add quiet flags if not verbose.
2018-07-22 20:30:28 +02:00
Markus Reiter
8278e9e403
Move verbose from #initialize to #extract.
2018-07-22 20:30:28 +02:00
Mike McQuaid
c5f92bfb8b
Merge pull request #4529 from MikeMcQuaid/update-maintainer-checklist
...
docs/New-Maintainer-Checklist: various updates.
2018-07-22 19:28:25 +01:00
Markus Reiter
de66dad834
Merge pull request #4524 from reitermarkus/missing-super
...
Fix missing `super`.
2018-07-22 19:49:28 +02:00
Mike McQuaid
c1ffd17f7c
docs/New-Maintainer-Checklist: various updates.
2018-07-22 18:39:25 +01:00
Mike McQuaid
3b5aabf90d
Merge pull request #4531 from claui/spec-increase-timeout
...
Increase spec timeout to 30 seconds
2018-07-22 16:30:11 +01:00
Markus Reiter
84e0027426
Merge pull request #4525 from reitermarkus/remove-criteria
...
Remove `Hbc::Container::Criteria`.
2018-07-22 16:58:42 +02:00
Claudia
8666d8fa18
Increase spec timeout to 30 seconds
...
I’ve noticed the deadlock test in `cask/system_command_spec.rb` appears to fail spuriously, e. g. in #4529 .
Details:
https://travis-ci.org/Homebrew/brew/jobs/406827725#L297-L318
With the spec taking 2 seconds on average on my 2017 MBP, I feel it’s
entirely plausible for the aging test-bot hardware to get knocked by
the 15-second timeout.
Given that the spec will pass early anyway if it passes, I feel it’s
reasonable to bump the timeout to 30 seconds.
2018-07-22 16:27:16 +02:00
Markus Reiter
d0951bdc1d
Remove Hbc::Container::Criteria.
2018-07-21 16:31:24 +02:00
Markus Reiter
17c2e2c00c
Fix missing super.
2018-07-21 01:14:19 +02:00
Markus Reiter
7ad999f5f8
Merge pull request #4488 from reitermarkus/system-command
...
Refactor `Hbc::SystemCommand`.
2018-07-20 17:51:10 +02:00
Markus Reiter
2dbffa2907
Merge pull request #4523 from reitermarkus/jar-detection
...
Fix JAR detection.
2018-07-20 17:46:20 +02:00
Markus Reiter
97f693b41f
Merge pull request #4518 from commitay/rar
...
fix cask rar containers
2018-07-20 17:45:28 +02:00
Markus Reiter
979e6674cf
Fix JAR detection.
2018-07-20 17:30:33 +02:00
Mike McQuaid
1d387f0b96
Merge pull request #4520 from MikeMcQuaid/force-bottle-prelease
...
Add HOMEBREW_FORCE_BOTTLE variable
2018-07-20 16:29:54 +01:00
Mike McQuaid
3e93d4c6cf
Add HOMEBREW_FORCE_BOTTLE variable
...
This does the equivalent of always passing `--force-bottle`. This will
be enabled by default on Mojave to allow people to avoid building
everything from source until our porting and bottling is a bit further
along.
2018-07-20 14:28:14 +01:00
Mike McQuaid
333534d641
Merge pull request #4521 from MikeMcQuaid/ronn-no-output-man
...
man: improve messaging on no `ronn` output.
2018-07-20 14:21:19 +01:00
Mike McQuaid
b89e4c51ce
man: improve messaging on no ronn output.
...
This can happen if your gems are messed up and it's a more helpful
error message than being unable to `gsub` on `nil`.
2018-07-20 09:47:28 +01:00
commitay
68760d7467
fix cask rar containers
2018-07-20 09:00:10 +10:00
Markus Reiter
97e549300c
Merge pull request #4515 from reitermarkus/extract-nestedly-basename
...
Add test for basename in `#extract_nestedly`.
2018-07-19 21:21:39 +02:00
Markus Reiter
ad7be58655
Use guard clause instead of ||.
2018-07-19 16:53:11 +02:00
Markus Reiter
fec884d8da
Add tests for ErrorDuringExecution.
2018-07-19 16:53:11 +02:00
Markus Reiter
2712fcaa67
Use interleaved output for ErrorDuringExecution.
2018-07-19 16:53:11 +02:00
Markus Reiter
3ff9c5335d
Canonicalize input in initialize.
2018-07-19 16:41:27 +02:00
Markus Reiter
01b2be755c
Move odebug.
2018-07-19 16:41:27 +02:00
Markus Reiter
2452b27866
Refactor ErrorDuringExecution.
2018-07-19 16:41:27 +02:00
Markus Reiter
bb29150096
Refactor HashValidator.
2018-07-19 16:41:27 +02:00
Mike McQuaid
679eda3155
Merge pull request #4516 from reitermarkus/zsh-completion
...
Fix `zsh` completion.
2018-07-19 14:34:11 +01:00
